Sometimes on re-run, this spec doesn't have vendor/date loaded properly,
and because there are dependencies on the global behavior that
file adds, they fail intermittantly depending on whether
they've been required ahead of time. Explicitly adding the requirement
seems to stabilize that failure.
Also we depend upon the require run to bind element_toggler to document.
because other places can strip off events, and the require doesn't run
everytime, I'm giving it a hook so you can explicitly bind up again
at any point with the "bind" method.
Also, I18n stubbing was in some way not getting a frame
popped, and that caused translation failures in some
cases. Adding a "clear" method to clear out
stubbing in teardown to make sure there are no
artifacts.
Change-Id: I715f4f326e6796d583501ec7df24de5fc04b24e8
Reviewed-on: https://gerrit.instructure.com/54830
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Ethan Vizitei <evizitei@instructure.com>
specifically, make file rename form go away, and actually
get rid of the wiki page onunload event handler
Change-Id: Ie323ce89e55495d2cd4e1caa4c7b17e72f2fd5fc
Reviewed-on: https://gerrit.instructure.com/54859
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Jenkins
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
fixes: CNVS-20372
* * * *
NOTE: THIS COMMIT AFFECTS NEW STYLES ONLY!
Code and QA reviewer(s): Please turn on new styles
if you pull down the changeset.
* * * *
With the New Styles flag turned ON, the speedgrader
dropdown is partially hidden behind the content in
the #main div.
http://cl.ly/image/0l2K1v061l1D
Test plan:
- Make sure the New Styles feature flag is turned
ON in your admin settings.
- Go to Speedgrader to grade something.
- Make sure the dropdown now looks like this:
http://cl.ly/image/3l3t15440r1J
Change-Id: I37386728214e1aca56fe14b3fecfeaa59db3d3d1
Reviewed-on: https://gerrit.instructure.com/53869
Tested-by: Jenkins
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
- this would make common.rb smaller
- the next step would be to put all selenium
common methods into one example group
Change-Id: I8a72fc57772d02980474ec2987ecf324706c64e1
Reviewed-on: https://gerrit.instructure.com/54719
Tested-by: Jenkins
Reviewed-by: Derek Hansen <dhansen@instructure.com>
Product-Review: Derek Hansen <dhansen@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
fixes CNVS-16978
test plan
- create a discussion topic
- cause a reply-to-able notification about the topic to be sent to
a user
- lock the topic
- change the user's email address to some non-standard capitalization
scheme (all uppercase works fine)
- reply to the notification
- ensure that the user receives a message indicating that the topic
was locked
Change-Id: I78d53ce1f9affc76fd040c0e24e99bc1d4edb9e2
Reviewed-on: https://gerrit.instructure.com/54631
Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
Had to add a requirement for discussions_common helper.
Ran 200 times in chrome and firefox to make sure it passed consistently.
Change-Id: I1ec62336b2ea1c32d7ca801ce99c8af4214e5125
Reviewed-on: https://gerrit.instructure.com/54696
Tested-by: Jenkins
QA-Review: Adam Stone <astone@instructure.com>
Reviewed-by: Robert Lamb <rlamb@instructure.com>
Product-Review: Derek Hansen <dhansen@instructure.com>
Refs CNVS-20069
Change-Id: I46cfb844ff062596af4bb3a594cb3cec381c570b
Reviewed-on: https://gerrit.instructure.com/54796
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Ryan Taylor <rtaylor@instructure.com>
Tested-by: Ryan Taylor <rtaylor@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
QA-Review: Pedro Fajardo <pfajardo@instructure.com>
Tested-by: Jenkins
refs #CNVS-20621
Change-Id: I37681cefa92235ccfc88ce6126cf4bdb08dba1bf
Reviewed-on: https://gerrit.instructure.com/54700
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
fixes CNVS-20537
Test Plan
Make sure it all passes and makes sense
Change-Id: Ic221afb3e55cd3fd63d79b16474d8e7265d68ccc
Reviewed-on: https://gerrit.instructure.com/54423
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
Product-Review: Sterling Cobb <sterling@instructure.com>
QA-Review: Sterling Cobb <sterling@instructure.com>
fixes CNVS-20515
test plan
- as a user with one communication channel, cause the channel to
be flagged as bouncing (set cc.bounce_count to 10 in the console)
- view the user settings page
- ensure that you see a bouncing channel error icon next the
channel's address on the right side bar
Change-Id: I7ccafb748d44581172829b233718ca072555dbc0
Reviewed-on: https://gerrit.instructure.com/54353
Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
fixes CNVS-20539
Test Plan
Ensure test are passing and make sense
Change-Id: I08c351842e3423903c3b296df0539e3eaf62b467
Reviewed-on: https://gerrit.instructure.com/54428
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
Product-Review: Sterling Cobb <sterling@instructure.com>
QA-Review: Sterling Cobb <sterling@instructure.com>
closes CNVS-20584
Some of the work done farther down in the index template builds a couple
new AACs for form generation, but this throws off the configs array
which
is used to decide which AACs we currently have configured. Memoizing it
grabs the active configs up front so they don't get modulated during the
display cycle and can be trusted when performing checks like
"do we have any SAML aacs" before showing saml debugging.
TEST PLAN:
1) enable SAML
2) go to the AACs configuration index as an admin
3) make sure you only see SAML Debugging section when you have an
active saml config.
Change-Id: I58f546b074552539f1751ce874f56fa17e305378
Reviewed-on: https://gerrit.instructure.com/54681
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
closes CNVS-20055
Safari doesn't like preload='none' with media-element js apparently
TEST PLAN:
1) create a media element in safari
2) click play
3) it should play
(ALSO: regression test CNVS-16057, we don't want to break that
in the process. Get lots of media players on one page,
and make sure you can click/load/play a couple in succession
wihtout them locking up).
Change-Id: I2539cc3dc53adea04d1157d19381e18e66cc995f
Reviewed-on: https://gerrit.instructure.com/54675
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes CNVS-20629
Test Plan
Ensure test pass and make sense
Change-Id: I440f529e9912998fe37744de994a09cafadb0da9
Reviewed-on: https://gerrit.instructure.com/54717
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Sterling Cobb <sterling@instructure.com>
Product-Review: Sterling Cobb <sterling@instructure.com>
test plan:
* import the package referenced in the ticket
* should not fail
closes #CNVS-20455
Change-Id: Ie9d0468724f8a409bffd9a025abfc137cd99e01a
Reviewed-on: https://gerrit.instructure.com/54673
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
refs CNVS-3194
- $.datetime.process and $.datetime.clean weren't in use at all anymore
(yay).
- $.datetime.parse pulled into its own testable util file. during move,
drops support for passing non-strings, because it wasn't called that
way anymore
- after the above, $.datetime.shortFormat and $.datetime.sortableFormat
were unused, removed
- .toString($.datetime.defaultFormat) was replaced by either
$.datetimeString or I18n.l('#date.formats.full'), as appropriate
- $.parseDateTime and $.formatDateTime not in use anymore (yay)
also, tweaks gradingPeriod.jsx to not reparse value to check validity
(already done by datepicker)
test-plan: N/A
Change-Id: I506b7991096c16f6b1e4dcfd59d696bf5d16606d
Reviewed-on: https://gerrit.instructure.com/53816
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
fixes CNVS-19515
test-plan:
- set locale to portuguese
- go to a date+time datepicker field (e.g. assignment due date)
- select a date and time
- the field value should still be in english (for now)
- but the suggest label below the field should be localized, both in
strings (e.g. month names) but also element order, 24 hour time,
etc.
- repeat for date-only and time-only datepicker fields (e.g. editing a
calendar event)
Change-Id: I8c8d0e05f56f2dd4361f65ce2cc3a46698aa01b3
Reviewed-on: https://gerrit.instructure.com/53192
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Tested-by: Jenkins
Product-Review: Jacob Fugal <jacob@instructure.com>
refs CNVS-19515
fixes it to:
(1) not use the datetime_suggest field as parseable value, using the
datetime_field's data instead
(2) use the full suggest (including separate course tz formatted
suggest, if applicable) in the accessible screen reader suggest
message
test-plan:
- regression around accessible use of the date picker involved in
calendar navigation
Change-Id: Ieaa92e2bfca1df45d275c412faf33e41f61bd050
Reviewed-on: https://gerrit.instructure.com/53191
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
fixes: CNVS-20374
* * * *
NOTE: THIS COMMIT AFFECTS NEW STYLES ONLY!
Code reviewer(s): Please turn on New Styles if you
pull down the changeset.
QA reviewer(s): Because the new styles UI is still
incomplete, please review this to see if we've broken
anything in the current UI for this feature. Once
the new styles are completely built out, we plan on
re-QAing each and every Canvas feature with the new
styles flag ON. (However, if you'd like to see the
new UI, you're more than welcome to check it out!)
* * * *
Fixes small bug in new UI with Mobile Safari not
liking padding around an inline SVG element, causing
the Canvas logo to crash into the top of the header.
https://www.dropbox.com/s/46dfw3smk8hp5xs/Screen%20Shot%202015-05-13%20at%201.09.29%20PM.png?dl=0
Test Plan:
- Make sure the New Styles feature flag is ON
- Load a page in Canvas, and make sure the Canvas
logo now looks like this, with sufficient padding
at the top:
https://www.dropbox.com/s/sae5dhv902ivyc2/Screen%20Shot%202015-05-13%20at%201.09.55%20PM.png?dl=0
Change-Id: I27ba96bf7fb551973a9156b5809f661b0b562ea3
Reviewed-on: https://gerrit.instructure.com/54184
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
refs CNVS-19515
primary motivation was to get rid of accesses to datetime_suggest in
favor of the actual data attributes. decided to clean up some stuff
while I was in there and one thing led to another...
simplifies by getting rid of the @inputs instance variable that was only
used internally. makes the validity checking a lot more readable while
maintaining the same behavior.
@blank, @validDate, @validateField, @handleInputChange, and @inputNames
were only used internally and in specs
also fixed in the refactor:
- we're not constantly rewriting the field the user just edited
(normalization in the data values and normalized formatting in the
suggest value is still done and appropriate, without replacing the
user's input)
- unfudged end at is compared to now, not fudged. e.g., if
- browser timezone is MDT
- profile timezone is EDT
- now is 2pm MDT (4pm EDT)
- endAt is 1pm MDT (3pm EDT)
- fudged endAt is 3pm MDT (5pm EDT)
the old code would have said endAt was ok (3pm MDT > 2pm MDT), when
it wasn't (1pm MDT < 2pm MDT). similarly, reversed:
- browser timezone is EDT
- profile timezone is MDT
- now is 4pm EDT (2pm MDT)
- endAt is 5pm EDT (3pm MDT)
- fudged endAt is 3pm EDT (1pm MDT)
the old code would have said endAt was bad (3pm EDT < 4pm EDT), when
it was fine (5pm EDT > 4pm EDT).
- entering valid times while the date is still blank doesn't
incorrectly claim the times are out of order, but it still treats the
set of blocks as a whole as invalid until the date is provided
test-plan:
- regression around time blocks in the scheduler
Change-Id: I85f1f588a1dfeaad40c6b5994c8f5b40fc7e270e
Reviewed-on: https://gerrit.instructure.com/53190
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
refs CNVS-19515
put the functionality in coupleTimeFields.coffee, and then use it in the
calendar event details. in the process, fix it to use the data attributes on
the fields instead of treating the related datetime_suggest fields as data
(they're not)
for the purpose of being able to set new values on the fields and have them
update their data attributes and suggest values, added setTime and setDate
methods (and setDatetime, though that's not used yet) to the
DatetimeField instance. use this instead of manually triggering change
events after direct accesses to val()
test-plan:
- regression testing around editing calendar events
Change-Id: I2f403d54b336bcfc4c118a31fb7e3b27129a45f7
Reviewed-on: https://gerrit.instructure.com/53189
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
fixes PLAT-955
test-plan:
interpolate a custom param value with a variable subsitutions,
i.e. 'my variable is buried in here ${Canvas.api.domain} can you find it?'
the interpolated variable should be expanded on lti1 & 2 launches
Change-Id: I23818756213831f1e0a52487b3d003183cc849e1
Reviewed-on: https://gerrit.instructure.com/54177
Tested-by: Jenkins
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
refs CNVS-19515
getFormData (and things that use its result, e.g. processData on formSubmit)
now returns iso8601 values for datetime_fields instead of the formatted suggest
string. this means they no longer need to be parsed and reformatted before
submission from forms, inclusion in redirect parameters, etc.
to support this, and for general use, a datetime_field now has two additional
data attributes:
iso8601: an iso8601 formatting version of the unfudged date value
invalid: a boolean indicating if the form had an invalid input (distinct from
valid but blank input; both would cause the date data attribute to
be null)
also removed a couple calls to getFormData that weren't even used
also cleans up some nearby code around the "course concludes at midnight"
warning, so that it displays if the conclude_at is set to midnight in the
context timezone (or profile timezone if no context timezone) instead
midnight in the browser timezone.
test-plan:
- regression tests, particularly around browser vs. profile timezone,
for:
* setting term start/end dates
* setting course start/conclude dates
* setting section start/end dates
* setting unlock at on new context module
* "add assignment" form from the assignment list:
- preservation of due date when clicking "more options"
- setting due date on form submission
* editing assignment due date from calendar
* editing assignment overridden due date from calendar
* create a quiz, lock it, then unlock it until a specific date
* changing attachment and folder lock/unlock dates
- set profile timezone to differ from browser timezone. set course
conclude at to midnight in profile timezone; should show "course
ends at midnight" warning
- set course conclude at to midnight in browser timezone; should not
show "course ends at midnight" warning
- set course timezone to differ from profile timezone. set course
conclude at to midnight in course timezone; should show "course ends
at midnight" warning
- set course conclude at to midnight in profile timezone; should not
show "course ends at midnight" warning
Change-Id: I55179d4416eb07cdda0e94abc79d2c9f948a5387
Reviewed-on: https://gerrit.instructure.com/53188
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
fixes CNVS-19796
Create a new modal with pure react and jsx. In order to use the modal,
you must now use the modal-content and modal-buttons component. These
components will ensure the right boilerplate classes are applied to the
each section and they are placed in the right location.
DialogAdapter was also removed. Existing places were it was being used
have been converted to use the canvas Modal.
Test Plan
Given I'm a user with new files enabled
Go to the new files page
Upload a duplicate file to the file system
Then the file rename form should pop up
And It should be styled nicely
Given I'm a user with new files enabled
Go to the new files page
Upload a zip file
Then the zip file expand form should load
And it should be styled nicely
Change-Id: I6ae76e77a7831a59739f35989fb9e68d0d4559fe
Reviewed-on: https://gerrit.instructure.com/52366
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Sterling Cobb <sterling@instructure.com>
fixes CNVS-20544
Test Plan
Test coverage makes sense and passes
Change-Id: I95bfa5ed7a2c287a831657ab234c89ab2c1740ac
Reviewed-on: https://gerrit.instructure.com/54659
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Sterling Cobb <sterling@instructure.com>
fixes CNVS-20542
Test Plan
Ensure test pass and make sense
Change-Id: Id8fb974f71a8e88abbd732e34a79c152575cc69f
Reviewed-on: https://gerrit.instructure.com/54660
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Sterling Cobb <sterling@instructure.com>
fixes: CNVS-15671
This makes our discussions in legacy canvas ui meet our
color contrast ratios.
Note: most of the contrast issues were coming from the
ugly blue background. We have gotten rid of that and
tweaked some of the text colors to use our variables.
UX has signed off on white background.
QA Plan:
- Go to a discussion
- The list in the jira ticket should now all meet contrast
ratios for both legacy ui & high contrast ui
UI Plan:
- Some of the colors were pulled from new UI css. There
were also some that were changed to be in both UIs and
cut down on either/or css
Change-Id: Idfc436ec46bcc10064342d5302a010822dd6fd49
Reviewed-on: https://gerrit.instructure.com/54030
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
fixes PLAT-1022
Test Plan
- Turn on the 'Don't move LTI query params to POST body' feature flag in the root account
- Launch a tool with a query string in the URL
- make sure the query params are not copied to the POST body
Change-Id: Ie3446086d5caa957558e0dafa1cec992934d48e8
Reviewed-on: https://gerrit.instructure.com/54399
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Fixes CNVS-20349
Test plan:
1. Go to /courses/x/pages
2. Add more than 5 pages
3. Edit the last page by clicking on edit option from cog icon
4. The menu that appears should be positioned correctly and accessible across all browsers
Change-Id: I66909c7df5dd4ef1d60a4788f9806494aaa1b0a9
Reviewed-on: https://gerrit.instructure.com/54617
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
fixes CNVS-19817
test plan
- make a custom observer role
- enroll a user to the role with an
associated_user_id
- it should work and have the associated_user
Change-Id: I4efe6c88271f0c1001eb5f6200b0c72cb133840e
Reviewed-on: https://gerrit.instructure.com/54513
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
This fixes a missing part of the pull request merged in with 54ef257
earlier. I inadvertently left out this portion because it wasn't
actually part of the pull request, but rather a fix that I had put
in manually to correct the failing spec.
Change-Id: I916c37e3afb95fb7f68d2daee45e5f8c2a2506bf
Reviewed-on: https://gerrit.instructure.com/54649
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
closes CNVS-19463, CNVS-19460, CNVS-19461
test plan:
* you know the drill by now.
* retest facebook, because that was refactored to share code
Change-Id: Iaf99b7b3c6850b1ac3690d1a5ebd1286268b5ae7
Reviewed-on: https://gerrit.instructure.com/54313
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
test plan:
* register an application on github
* configure github as an authentication source
* login with github
* it should complain about a missing user
* add that ID to your user
* login again, and it should work
* delete github authentication
* reconfigure at /plugins/github
* add authentication again; this time it shouldn't let you configure
the integration
* login with github again
Change-Id: I2be3dd482de79873ad845890827292bc4f995b7a
Reviewed-on: https://gerrit.instructure.com/54241
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fixes CNVS-19449, CNVS-19454, CNVS-19455
test plan:
* configure the facebook plugin (/plugins/facebook)
* add Facebook to your authentication configs
* try to login with valid facebook credentials - it should say it
couldn't find the user
* add a login to your user with that ID
* try to login with facebook again; it should work
* delete auth settings and plugin settings
* re-add the auth settings - it should let you configure it
directly
* log in again
Change-Id: I5aae400fe39fda6e1a864a062368e50a4c9f4ede
Reviewed-on: https://gerrit.instructure.com/54208
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fixes CNVS-18896
test plan
- run sis export report and provisioning reports through api
- set some reports to false in the parameters
- the reports set to false should not be included
Change-Id: I83d046a36db65d3c167eeb495a9c6286e0f787be
Reviewed-on: https://gerrit.instructure.com/53858
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
if you reload between sending to CAS and coming back, casclient
wouldn't get required
Change-Id: Ibe9ff74d45d8d23eaba6ec5001bb288fb4b43721
Reviewed-on: https://gerrit.instructure.com/54524
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Ethan Vizitei
