fix some N+1 queries, repeated time_zone calls,
and add a temporary cache around expensive stream item code
Change-Id: Iae5c385d6fd5917d9f35626e2d160ad71074f498
Reviewed-on: https://gerrit.instructure.com/87012
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
closes: CNVS-27220
Rubric buttons for cancel/create/update are now left aligned so they
do not overlap with right hand sidebar.
Test Plan:
- Go to an assignment
- Create a Rubric with lots of ratings (so the table will push off);
cancel and create buttons should be left aligned now; save rubric
- Edit Rubric
- Cancel and Update buttons are left aligned
Note:
- Added a modifier class for ic-Action-header to put half margin on top
and bottom, vs the default bottom margin
Change-Id: Iadbe6eebefc6ca5cff829f688a49ac8431adce7a
Reviewed-on: https://gerrit.instructure.com/83419
Reviewed-by: Chris Hart <chart@instructure.com>
QA-Review: Nick Peterson <npeterson@instructure.com>
Tested-by: Jenkins
Product-Review: Colleen Palmer <colleen@instructure.com>
Fixes: CNVS-29575
test plan:
- as a student with items in the to do list... the icon should
now have some breathing room between it and the text
- as a moderated grader - the above should be true as well
- ensure the admin to do still renders as it did
old view: http://screencast.com/t/YXzzGVaOr3WC
new view: http://screencast.com/t/M1JQhYzD
Change-Id: I59153f8b7471bd0795089c82279accdf00dc12e3
Reviewed-on: https://gerrit.instructure.com/84672
Reviewed-by: Chris Hart <chart@instructure.com>
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
fixes CNVS-30491
Test plan:
* you should be able to change the color of the global nav icons using
the theme editor both with and without the k12 features enabled.
Change-Id: I081b1609d76970d4a5adf69a9a3994845914786a
Reviewed-on: https://gerrit.instructure.com/85677
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
There are no automated tests present with this commit because
it is only a wording change.
closes CNVS-30378
Test Plan:
- Go to the dashboard
- Toggle to recent activity view (because you should be in the
new UI because that's a thing)
- Expand one of the notification categories
- Use a SR to navigate to the X
- It should read as "Ignore" not "Close"
Change-Id: If7000897f7ea19e2ce29067b2d0018e65e70b495
Reviewed-on: https://gerrit.instructure.com/84846
Tested-by: Jenkins
Reviewed-by: Matthew Sessions <msessions@instructure.com>
Product-Review: Matthew Sessions <msessions@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Fixes CNVS-30304
Test Plan:
- In account settings check Enable Profiles feature
- Ensure that Users may edit their name is disabled
- go to a students user profile page
- Using a SR click the edit button
- Notice that focus goes to the bio text area and
this information is told to the SR user
Change-Id: Ib592e3e0d8434cdd1ab180cc74960d4593cdc5da
Reviewed-on: https://gerrit.instructure.com/84378
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Tested-by: Jenkins
Product-Review: Matthew Sessions <msessions@instructure.com>
due to a bug fix for JAWS that involved removing and reapplying
attributes to the screenreader alert container, text for alerts
were being shown in the page as plain html in Internet Explorer
and Edge. in addition to fixing this issue, the flash
notifications code was refactored and tests were written for it.
fixes CNVS-29411
test plan:
- create a course if necessary
- navigate to the Settings page
- click the Update Course Details button
- ensure an alert appears that reads "Course was successfully updated"
- wait 15 seconds
- click the Update Course Details button again
- ensure an alert appears that reads "Course was successfully updated"
- ensure that plain html does not appear at the upper left corner
of the page
- navigate to the Announcements page
- click the Add External Feed button
- submit the form with an invalid character in the url (; works)
- ensure that an alert shows above the form field and at the top
of the page
- wait 15 seconds
- submit the form with the same invalid data
- ensure that an alert shows above the form field and at the top
of the page
- ensure that plain html does not appear at the upper left corner
of the page
Safari/VoiceOver test plan:
- open the Settings page in Safari and VoiceOver
- click the Update Course Details button
- ensure that "Course was successfully updated, Close" is read
- click multiple times and ensure that the alert is read every time
- open the Announcements page in Safari and VoiceOver
- click the Add External Feed button
- submit the form with an invalid character in the url (; works)
- ensure that "div is not a valid url slash div" then "Oops! The last
request didn't work out. Development Only. Details. Close" is read
- click multiple times and ensure the alert is read every time
Firefox/NVDA test plan:
- open the Settings page in Firefox and NVDA
- click the Update Course Details button
- ensure that "Alert! Course was successfully updated, Close" is read
- click multiple times and ensure that the alert is read every time
- open the Announcements page in Firefox and NVDA
- click the Add External Feed button
- submit the form with an invalid character in the url (; works)
- ensure that "Alert! div is not a valid url slash div" then "Oops!
The last request didn't work out. Development Only. Details.
Close" is read
- click multiple times and ensure the alert is read every time
- note that on multiple clicks, reads of previous alerts is acceptable
- also note that being interrupted by an "Alert!" is acceptable
Internet Explorer/JAWS test plan:
- open the Settings page in Internet Explorer and JAWS
- click the Update Course Details button
- ensure that "Alert! Course was successfully updated, Close" is read
- click multiple times and ensure that the alert is read every time
- open the Announcements page in Internet Explorer and JAWS
- click the Add External Feed button
- submit the form with an invalid character in the url (; works)
- ensure that "Alert! div is not a valid url slash div" then "Oops!
The last request didn't work out, Development Only, Details,
Close" is read
- click multiple times and ensure the alert is read every time
- note that on multiple clicks, reads of previous alerts is acceptable
- also note that being interrupted by an "Alert!" is acceptable
Change-Id: Ia38ddff903691e09414e80a7a27b6e3ff3b35e8b
Reviewed-on: https://gerrit.instructure.com/80475
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Pierce Arner <pierce@instructure.com>
for the grading standard partial view, three places had
different patterns for checking whether the object passed to
the partial was nil despite the partial checking for nil itself.
this commit removes the redundant checking and relies on the
checking in the partial. also, the nil checking and use
of variables in the partial were cleaned up. this cleanup also
fixed an issue where the name of the default grading scheme was
not being shown despite the data being shown. this was seen
in the Edit Discussion Topic and Course Settings pages.
closes CNVS-29329
test plan:
- create a course if necessary
- navigate to the "Course Details" tab of the "Settings" page
- set the "Enable course grading scheme" checkbox
- click the "view grading scheme" link that appears
- ensure that "Default Grading Scheme" is the title of the table
- create a discussion if necessary
- edit the discussion
- set the "Graded" checkbox in the "Options" section
- select "GPA Scale" from the "Display Grade as" dropdown
- click the "view grading scheme" link that appears
- ensure that "Default Grading Scheme" is the title of the table
- create an assignment if necessary
- edit the assignment
- click the "More Options" button
- select "GPA Scale" from the "Display Grade as" dropdown
- click the "view grading scheme" link that appears
- ensure that "Default Grading Scheme" is the title of the table
Change-Id: Iae0b317ec2bc95e0a94eba1c2182022732ea898b
Reviewed-on: https://gerrit.instructure.com/79422
Tested-by: Jenkins
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
test plan:
* enable profiles
* view the profile page for another user in a course
* it should show the message icon link to message
the user under the "Contact" section even if the user
has no registered services
closes #CNVS-29650
Change-Id: I0dba928695960723bd435cf3786496dc1d40b84d
Reviewed-on: https://gerrit.instructure.com/82343
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
- Install a tool with an svg path specified via the icon_svg_path_64
in XML config with a global placement
- The logo svg path should be drawn as the logo for global navigation
in the new UI
Change-Id: I50785da33494cb776c7765e3b46512c628174e65
Reviewed-on: https://gerrit.instructure.com/82250
Reviewed-by: Andy VanWagoner <andy@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins
Reviewed-by: Chandu Tennety <ctennety@instructure.com>
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Product-Review: Brad Humphrey <brad@instructure.com>
fixes CNVS-30081
test plan:
- go to create a rubric
- screenreaders should read "Add Criterion" on the button
Change-Id: Id7858182db6f08ba8c07f9fe1f8838f9353e2718
Reviewed-on: https://gerrit.instructure.com/82925
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
closes CNVS-28052
refs CNVS-28050
refs CNVS-28051
refs CNVS-28053
test plan:
- go to edit a rubric
- check the following, the 'cancel' button should be
listed first
'view longer description'
edit criteria name
edit rating
- go to the outcomes page
- the order for both outcomes and outcome groups
should be from left to right, visually and tab order
Move -> Edit -> Delete
Change-Id: I5d1bdd49152a758dd4cc74366b3a78bd35fceac8
Reviewed-on: https://gerrit.instructure.com/79594
Reviewed-by: Davis McClellan <dmcclellan@instructure.com>
Reviewed-by: Chris Wang <cwang@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Tested-by: Jenkins
Product-Review: Dana Danger <dana@instructure.com>
fixes CNVS-29878
Test plan:
- Visit any page on Canvas with a header
- Verify that all the buttons read as expected when tabbed to with a
screen reader.
- Verify that the landmark regions don't repeat the word "navigation".
- Verify that the screen reader does not enter forms/application mode
when pressing enter on a link inside any of the nav regions.
Change-Id: I16f32fc4fad919223dc436b8a85c077ace3262b8
Reviewed-on: https://gerrit.instructure.com/82351
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
refs CNVS-28024
refs CNVS-28025
Test plan:
Verify that there is no change to Help links across the app by default.
In the rails console run:
`Setting.set('show_feedback_link', 'true')`
Enable new ui.
Go to the settings page for the root account.
There should a section called 'Customize Help Link'.
Change the link name and select a new icon.
Click 'Update Settings'
The help icon and label in the global navigation should update.
Note that the link name should be updated on login pages and in
speed grader as well.
The settings should not appear when new ui is disabled.
Change-Id: Ic36a8f396989182446c440cd6c7d80d1fdf11b1b
Reviewed-on: https://gerrit.instructure.com/81078
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
fixes CNVS-29616
test plan
- navigate to an error page that has the "Click here to tell us
what you were looking for" form. the 404 page you get when you
set an id in the url to something that doesn't exist works great.
- submit the error form
- ensure the error form was submitted
- use the "Inspect Element" feature of your browser to find the
hidden input field with the id "error_username"
- set the value of the hidden input field to anything
- submit the error form
- ensure that form does not submit and an error is thrown instead
Change-Id: I3c19682fff1414c595bacb1d2d5746fb5d41cb11
Reviewed-on: https://gerrit.instructure.com/80724
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
closes: CNVS-29206
This enables the entire long course title to be seen when you hover over
and view the tooltip.
Test Plan:
- Make sure to have a course with a long name
- Go to All Courses page
- Long course name should truncate, hover over and view tooltip
- Entire course name should appear on tooltip
Should work in all browsers now
Change-Id: If63c2765a781dd70d695e491466ec96451552542
Reviewed-on: https://gerrit.instructure.com/80113
Reviewed-by: Pam Hiett <phiett@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
fixes CNVS-28203
Test plan:
* use the "message student who" feature in srgb
* when focusing the "out of" field (this is available when using the
"scored more/less than" criteria), the field description should
include the points possible in its description
Change-Id: I795a150876ca75151be634534f708a2ecb61e4bb
Reviewed-on: https://gerrit.instructure.com/79920
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Gentry Beckmann <gbeckmann@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Tested-by: Jenkins
Fixes: CNVS-29488
test plan:
- as an admin navigate to a course
- create an assignment and once saved - the + Rubric block
will be available (updates on this view + Rubric button
has been updated = http://screencast.com/t/t9K8MTcQo)
- after clicking the + Rubric button the + Criterion
has been updated = http://screencast.com/t/A6YTVR68W
- lastly, click the "Find a Rubric" link from the modal
click the "Manage Rubrics" link
- the + Rubric button has been updated to match
http://screencast.com/t/dPU6NtNwj
Change-Id: I1d3c6aff5e2f12b959afcf9cde60d26b59bb6e63
Reviewed-on: https://gerrit.instructure.com/80369
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Blake Simkins <bsimkins@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
Refs: CNVS-28334
Mockup from UX (ignore colors for this commit):
http://cl.ly/2f2P0u3n433r
Test plan:
- This change affects both new and legacy UIs
- Go to /styleguide#highlights/alerts
- Note that the flash notifications are restyled per
the mockup above: http://cl.ly/2x2o3m0i0i29
(The light-background Bootstrap .alerts will be
restyled in a separate commit.)
- Log in to Canvas and perform actions that trigger
flash alerts. All the alerts you see should now be
updated in terms of their style.
- Log in as your admin to see this notification,
for example: http://cl.ly/1m0n261N401M
- If you are running Canvas locally, stop the
server, and you should see this notification:
http://cl.ly/3K1v1r2R2b0w
Change-Id: Iee2304dd38c38bb62c67927d06104c7092d11518
Reviewed-on: https://gerrit.instructure.com/79192
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
closes: CNVS-28351
- Clever logo for the sso icons on login
- Clever logo for login listings
- Canvas logo for login listings
- Ran other logos through svgo for smaller file sizes
Test Plan:
- Enable Clever login
- See that clever logo now appears on the login screen
- View your login listings, but Clever and Canvas should be there
Change-Id: If1d4bc1b7e2c87fd6aaf47c6927b794be9742cf3
Reviewed-on: https://gerrit.instructure.com/79750
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
this commit is the result of squashing a bunch of
others together. this is everything that was
already on the dev/save_a_theme branch as well as
the "Add specs" commit.
I left the test plans from some of the squashed
commits in case they are helpful for QA
Test plan:
- Recompile assets, restart Canvas and clear browser
cache
- Go to Admin > [Your school name]
- Click on Themes in the context menu
- You should now see a collections page with
a theme card for all the themes you have in
Theme Editor: http://screencast.com/t/lb5vozF7
- Note: it might be my database, but on my end,
I don't see a theme card for my Canvas default
theme. There are also some brand colors missing
for my theme cards. I'll be interested to see
if you hit the same thing. These are issues that
we can resolve with Ryan when he is back.
- You should be able to click on the Apply and Delete
buttons and see the confirm-overlays. We still need
final copy for these.
Test plan:
- Go to your institution's Settings page and click
Themes on the context menu.
- You should now see a page listing all the default
and user-created themes in your Canvas installation.
- Clicking on each theme will open it inside theme
editor.
- The current/active theme will be correctly styled
with a green outline
change redirect targets and messages in theme editor
test plan:
exiting theme editor
should redirect you back to the /accounts/x/themes page
instead of /acounts/x
make room for footer in theme editor
test plan:
in theme editor, scroll the preview to the bottom
you should be able to scroll all the way, without
having the bottom cut off by the footer
remove "theme editor" button from account user/course search
this is not needed since "Themes" now shows up
in the left nav.
test plan:
turn on the 'Course and User Search' feature flag
go to accounts/x
you should not see a "theme editor" button on the right
aka, not like this: http://cl.ly/2G2C3p3s3n0C
fix "Exit" button in theme editor
we were warning "you will lose unsaved changes"
even when you hand not made any changes
add specs to "Save A theme" stuff
closes: CNVS-27961
test plan:
do a whole regression test on the theme editor
don't show both "k12 theme" and "canvas default" as options
fixes: CNVS-25495
description (and test plan):
if you are a k12 school, rather than seeing both
"Canvas Default" and "K12 Theme"
as options on the tiles of system themes to start from,
you should now just see "Canvas Default".
if you pick that, it should show the k12 theme.
Change-Id: I5c2512e576dcb2aedaa899e17080d9c106e159ca
Reviewed-on: https://gerrit.instructure.com/78163
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
fixes CNVS-29210
Test Plan:
- While using a Screenreader, go to the user Profile section (Account >
Profile)
- Navigate to the Edit Profile button > Enter
- Notice that there is an indication that you are editing the profile
Change-Id: I4472d56881738063cfde43b785d0b05231e329b4
Reviewed-on: https://gerrit.instructure.com/79440
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Burnett <sburnett@instructure.com>
in the grading standard partial view, the table caption for
screenreader now reads "grading scheme" as it should instead of
"grading standard". this change is accessible from the Edit
Discussion Topic, Edit Assignment, and Course Settings pages.
closes CNVS-29291
test plan:
- start VoiceOver
- open Canvas with screenreader-supported browser
- create a course if necessary
- navigate to the "Course Details" tab of the "Settings" page
- set the "Enable course grading scheme" checkbox
- click the "view grading scheme" link that appears
- using VoiceOver, navigate the page and ensure the table
caption is "Current grading scheme for this assignment"
- create a discussion if necessary
- edit the discussion
- set the "Graded" checkbox in the "Options" section
- select "GPA Scale" from the "Display Grade as" dropdown menu
- click the "view grading scheme" link that appears
- using VoiceOver, navigate the page and ensure the table
caption is "Current grading scheme for this assignment"
- create an assignment if necessary
- edit the assignment
- click the "More Options" button
- select "GPA Scale" from the "Display Grade as" dropdown menu
- click the "view grading scheme" link that appears
- using VoiceOver, navigate the page and ensure the table
caption is "Current grading scheme for this assignment"
Change-Id: I381ccc51aea3215d050b648da1bf28c835160973
Reviewed-on: https://gerrit.instructure.com/79265
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
Tested-by: Jenkins
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Christi Wruck
Fixes: CNVS-28853
test plan:
- as a user with the new UI
- ensure the account has "Enable Profiles" selected from the
Features section of the account settings
- now whether you are logged in as a teacher or a student
select "Account" from the left-hand nav - from the sub-nav
select "Profile"
- the view has been cleaned up to match the product design
comp that is attached to the jira ticket
example work flows: http://screencast.com/t/aKDKcjLu
notes: the next hurdle would be to tackle the user settings
page (there is quite a bit more of complexity surrounding
that page/old code)
Change-Id: I9b4aac75f39cfe545fd56f34c97eef8b6c7ed7bc
Reviewed-on: https://gerrit.instructure.com/76565
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
refs: CNVS-28781
instead of loading this css on every page
I moved it out into its own bundle so it can be
only loaded in the few places that use it
test plan:
* go to these places where you can get an
"unauthorized, you need to log in" message
* make sure that message is styled like it was before
Change-Id: Id8462f92e4abbf308957a58374b902c32a0657ae
Reviewed-on: https://gerrit.instructure.com/77313
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
refs: CNVS-28781
instead of loading this css on every page in common.css,
I moved it out into it's own bundle so it can be only
loaded in the couple of places that use it
test plan:
* go to these three places that use this css
* make sure the stuff on the right side of the page
looks like it did
Change-Id: Ibefbada279f51dbfb7b61ac4b0aa5135340955e1
Reviewed-on: https://gerrit.instructure.com/77310
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
refs: CNVS-28781
instead of loading this css on every page in common.css,
I moved it out into it's own bundle so it can be only
loaded in the one place that uses it
test plan:
* go to the page in your course where you import new
users via a comma separated list of email addresses
* go through the process and make sure everything
is styled as it was before
Change-Id: I2505d97ec14eb29d08324ff50c06e1f11c8a4409
Reviewed-on: https://gerrit.instructure.com/77309
Tested-by: Jenkins
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
used to turn 1.0.to_s to "1"
closes #CNVS-28310
Change-Id: I79106a4c0b42fe9b6d96097aaf9dd28a43024373
Reviewed-on: https://gerrit.instructure.com/75194
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
not a comprehensive list by any means, but these were
the ones that stood out
refs #CNVS-27773
Change-Id: I209d983155e740fe1990b8fc4b1a10167eb149d6
Reviewed-on: https://gerrit.instructure.com/75134
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
fixes CNVS-25676
test plan:
** Help dialog:
- Navigate to the help menu.
- Select the 'Report a Problem' menu item.
- The text block beginning with the text: "For an instant answer" should
receive screenreader priority / focus.
** No Outcomes Warning
- I cannot get this to render via the UI; I may actually just remove it.
** Outcomes template
- Navigate to the Oucomes tab for a course with an outcome (or create one).
- Click on the name of the outcome in the left hand tab so that the
information is displayed in the content view on the right side.
- Observe that there is a screenreader only element 'displaying' the
title. (I opted not to update this to be a role="alert", as it didn't
seem like the correct usage of this attribute. Happy to be told
otherwise.
** Select content dialog
- Be logged in as an instructor.
- Navigate to the assignments page, then click on the `+` to create a
new assignment.
- On the new assignment page, go the `Submission Type` select box, and
select `External Tool`.
- Click on the `Find` button. This will open the `Configure External
Tool` dialog.
- Observe that the follow text receives focus: `Select a tool from the
list below, or enter a URL for an external tool you already know is
configured with Basic LTI to add a link to it to this module.`
Change-Id: If4868654778b6933ff4aeb55de20190f2d909ecd
Reviewed-on: https://gerrit.instructure.com/76707
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
Fixes: CNVS-28706
Fixes: CNVS-28681
test plan:
- as a user with new UI using IE10|Win8|Chrome
- navigate to "courses" in left-hand nav > select "all courses"
- the course colors should now be showing as a solid color vs an
outlined box
- as a user with new UI using FF
- repeat above steps (course color should align properly)
Change-Id: If3baa7604a0af57776c41b85a88d9eaf0128bd14
Reviewed-on: https://gerrit.instructure.com/77057
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
fixes CNVS-28203
Test plan:
in srgb, check the message students who feature:
* the "out of" field (scored more than/less than) should include
the points possible in its description
* when buttons are disabled, they should still be focusable (and read
by the screenreader)
Change-Id: Ibd06f9ef2286c5993673f2f07e1b24cda8c4f166
Reviewed-on: https://gerrit.instructure.com/75373
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Christi Wruck
Fixes: CNVS-28372
test plan:
- as a user with the new UI
- navigate to the dashboard (at this point if you do *not* have
items in the todo list... create a few)... the todo list can
also be viewed on a course home page
- the right side "To Do" has been cleaned up so the notification
badge aligns better with the text and the "Ignore X" is no
longer overlapping the text
- old new UI view: http://screencast.com/t/jyzBe8sD
- new new UI view: http://screencast.com/t/bsQxefuINp
- switch to old ui and repeat above steps
- old old UI view: http://screencast.com/t/LNQi0XBp
- new old UI view: http://screencast.com/t/sYVuCuWewT
Change-Id: Ib0aeebffaa1b3d3a4b9fcaacc0f5178e75a61cb8
Reviewed-on: https://gerrit.instructure.com/76018
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
nobody has used this since last year
deprecated by ContentMigration
refs #CNVS-27773
Change-Id: Ie3db513a0e347401005fd0f535674e539d53073b
Reviewed-on: https://gerrit.instructure.com/75100
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
refs PFS-3588
TEST PLAN
* verify Global Announcements can be made from sub account settings page
* admins and users should see on notification what account its from
(bottom of each notification)
* verify that users receive the correct announcements based on account
and role
- sub account notifications should only go to users with an enrollment
or admin role somewhere within the sub account hierarchy
- if the sub account notification has specified roles, only users
with those roles within the sub account hierarchy should see them
* verify Global Announcement permission can be made for sub accounts
* on sub accounts the Add/Edit forms should not display 'Unenrolled
users' checkbox
Change-Id: I087acba0504a04595244062b8dfc41f340fc2f1a
Reviewed-on: https://gerrit.instructure.com/72343
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Allison Weiss <allison@instructure.com>
SCIM was never implemented, and FB is an incorrect alias of facebook
Change-Id: I07fcbae975b1418aedc5396b7ca4e8b2b41a3612
Reviewed-on: https://gerrit.instructure.com/75778
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
test plan:
* enable user avatars on account
* create a course with two students
* add an avatar for one of them
* as the other student, visit their profile page and
report their avatar, keeping the browser window open
* it should not show their avatar on their profile page
* in another browser/incognito, log in as an account admin
and visit the avatars page for the account
("/accounts/:id/avatars")
* approve the avatar
* in the reporting student's browser window, refresh the
offending student's profile page
* it should show the avatar now
closes #CNVS-24959
Change-Id: I867266344260e23704948ad0efe94a0ab0839be7
Reviewed-on: https://gerrit.instructure.com/75049
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes: CNVS-27871
test plan:
- as a user with the old and/or new ui
- navigate to the course listing page /courses ("all courses")
- there should now be an outlined version of the star and once
clicked it will fill to a solid golden
- example: http://screencast.com/t/g1vpLc78NSbZ
note:
- product design asked that the dashcard cog icon be swapped
out for the paper/pencil icon so that was addressed on
this ticket as well (http://screencast.com/t/hKw3AHLi)
Change-Id: Iab9048db7bfd8a8ec3672cc00a5c50dafd729992
Reviewed-on: https://gerrit.instructure.com/74220
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Pierce Arner <pierce@instructure.com>
Tested-by: Jenkins
Commit from Siimpl
Fixes OI-3, OI-4
test plan:
* register an application with Microsoft
* configure microsoft as an authentication source
* login with microsoft
* it should complain about a missing user for an ID
* add that ID to your user
* login again, it should work
* delete microsoft authentication
* reconfigure at /plugins/microsoft
* add authentication again; this time it shouldn't let you configure the integration
* login with microsoft again
* change to email attribute
* login and it should show your e-mail, instead of an opaque ID
* change tenant to "organizations"
* login with a regular Microsoft account
* it should give an error about not being able to log in
* login with an organization account (@instructure.com works)
* it should show your email
* change tenant to "consumers"
* login with your regular Microsoft account; it should work
* login with an organization account; it should give an error
NOTE: Microsoft requires https. so if you're testing locally, and don't have
https, you'll need to change oauth2_controller.rb and add (protocol: 'https')
to both oauth2_login_callback_url calls; during the login flow it will
redirect you back to the app over https; edit the url and connect to
http and it will work
Change-Id: I578df7c2865b8775752ead28a1153918cd24aaa6
Reviewed-on: https://gerrit.instructure.com/72971
Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Andrew Butterfield <abutterfield@instructure.com>
it doesn't seem to be doing anything
Change-Id: Ie8f0b0e87676669b4df2c14849f1ec9b8a71c8f7
Reviewed-on: https://gerrit.instructure.com/74967
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Fixes: CNVS-27932
test plan:
- as a user with the new ui
- verify the dashcard color matches the color being displayed
on /courses ("all courses") page for each course
- lastly, ensure old ui does not show course color
Change-Id: I2c5a563cb5cfa813c845e0f9565efcd63388e747
Reviewed-on: https://gerrit.instructure.com/74809
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
Fixes: CNVS-27934
test plan:
- as a teacher or student using the new ui
- ensure you have a course that you have changed the
name using the nickname option from the user
dashcard
- now click the courses link from the left nav
- click the "all courses" link
- the table should now show a nickname that
corresponds to it's course (it will be blank
if there is not a nickname)
Change-Id: I0fe0a801cb8746d311d245d4e48d2c4e1be6fd91
Reviewed-on: https://gerrit.instructure.com/74452
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
test plan:
- ensure the sub-accounts at each level of the Department
dropdown in Course Settings are sorted by name
fixes CNVS-27998
Change-Id: Ibb77479b1c46e1e8e9129a7ce0d8a61080586e67
Reviewed-on: https://gerrit.instructure.com/74698
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Fixes: CNVS-27591
note: this drastically changes the new ui view and
subtly changes old ui
test plan:
- as a user that is enrolled in multiple courses
- within new ui: navigate to courses link and within sub-nav
click "all courses" updated view should be similar
to product design comp http://screencast.com/t/h4Z10zuLgWG
- ensure old ui still looks good
Change-Id: I54b943bf6184e0399b5f1e2d76e1418b29d5f2d4
Reviewed-on: https://gerrit.instructure.com/73641
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
it was relying on an ivar to exist that wasn't always set. because of
caching, whichever environment it rendered in first for a given user
(with or with @wiki) would persist across the course.
fixes CNVS-27726
test plan:
- clear your redis cache
- visit the a page with the wiki sidebar
- it should correctly show "Link to a new page" based on whether you
have permission or not
Change-Id: I52ea02075f8d159e0ca159eb0852a140cdfc5172
Reviewed-on: https://gerrit.instructure.com/73765
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Also adds basic test coverage around Api.paginate
Fixes PLAT-1357
Test Plan:
1) Create a test course and add 100 LTI tools to it:
course = Course.find(15)
(1..100).each do |n|
cet = ContextExternalTool.new(
url: "https://www.example.com",
name: "Tool ##{n}",
shared_secret:"foo",
consumer_key:"bar")
cet.context = course
cet.save!
end
2) Try to add an LTI tool to a module or as an
assignment, see that you can see all 100 tools.
Change-Id: I9c59d2286f928ad726917e9e794967dcf6ffca9d
Reviewed-on: https://gerrit.instructure.com/73680
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
iow, don't let image_tag generate alt text badly
test plan: (T＿T)
fixes CNVS-27489
fixes CNVS-27043
Change-Id: I52dfe7703f57074df61358262f195161cd34c32f
Reviewed-on: https://gerrit.instructure.com/73334
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes CNVS-27508
- An `assessing` local var is passed in to the `shared/rubric` partial;
the way this had been getting set was insufficient. It had been `if
@current_user != @submission.user`, then we're assessing. This is
obvviously not true for observing users, who are not assessing, nor are
they the submission user. The logic is now, `if user has the right to
grade or is currently assessing.
- Added view test cases to cover all three of these use-cases.
- Update submissions js to not mess with style of rubric form.
test plan:
- Have a course with a teacher, two students and one observer.
- Add an assignment.
- Add a rubric to the assignment.
- Complete the assignment as each student.
- Assign peer reviews to students.
- Sign in as the teacher and grade the submissions.
- Click the `show rubric` link and observe that the rubric criteria
points are editable forms, and that a grade can be provided.
- Sign in as the respective students.
- Complete the assigned peer reviews.
- Click the `show rubric` link and observe that the rubric criteria
points are editable forms, and that a grade can be provided.
- Sign in as the observer.
- View the grades for the student the observer observes.
- Click the `show rubric` link and observe that the rubric criteria is
plain text and not editable.
- Sign in as the students and view their own grades.
- Click the `show rubric` link and observe that the rubric criteria is
plain text and not editable.
Change-Id: I77bb4e6a979860559248f75e610239c894b08123
Reviewed-on: https://gerrit.instructure.com/71709
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Tested-by: Jenkins
Product-Review: McCall Smith <mcsmith@instructure.com>
fixes CNVS-26923
test plan:
- enable screenreader
- attempt to submit a validated form with errors,
such as an assignment with no title
- after the alerts have been automatically read,
navigate to an errored field
- the field should include the error in its readout
- regression tests on other validated forms in Canvas
notes:
once added, error descriptions are not removed
until form is submitted. this behavior is
expected
on Safari, you must wait approximately 5
seconds for the error description to read
out after navigating to an errored field
Change-Id: If7607c1744b3dd4b1d75711beb9b8104b97a4489
Reviewed-on: https://gerrit.instructure.com/71612
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
Product-Review: Aaron Cannon <acannon@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
also do some minor refactoring around this coffeescript to make it safer
and easier to test.
fixes CNVS-26490
test plan:
- basic regression test around user profile editing
(you need to enable profiles in account settings)
- specifically, when you delete links while editing the profile, focus
should go to the previous delete link button or the bio textarea (if
you delete the top one)
Change-Id: I15b5e552485c447d51cdccedf9990456de10b13d
Reviewed-on: https://gerrit.instructure.com/71298
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Fixes: CNVS-25379
Code review note: I realized that adding dimensions
to this image via CSS would also affect any user-
uploaded images that live inside this container. The
least-harmful way in the end was to specify the width
and height within our default logo SVG file (this does
not prevent the SVG from scaling down).
I also changed the dimensions of the image container to
better match the dimensions of the area at the top of
the main nav where the image will be placed.
Test plan:
- Recompile assets and clear browser cache
- Open Theme Editor. If you have any custom
theming going, please reset Canvas to its
default branding :(
- Expand the Global Navigation section
- You should now be able to see the default Canvas
logomark in all supported browsers:*
http://screencast.com/t/lMAhb5l8q5Wg
* Note: MS Edge had a bug with scaling images via
max-width (which we do here to keep the image inside
our image container):
https://connect.microsoft.com/IE/feedback/details/
1494666/
scaling-an-svg-using-max-width-vs-width-in-microsoft-edge
It is fixed now, but if you have an older build of
Edge, you might find the default Canvas logo looks
a little small.
Change-Id: Ia4eeec799c8aa7a00d0e2c32c89bf53856e87fa3
Reviewed-on: https://gerrit.instructure.com/71306
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Fixes: CNVS-26579
note:
- the font-size: 4px was specific to screen-reader-text class
which has been replaced with screenreader-only
sample test plan:
- ensure the css compiles without errors
- as an admin using the old or new UI in safari
- navigate to a course and click on settings
- click into the "sections" tab ensure everything displays correctly
- turn on VO navigate down to the edit/delete icons and through VO
you should hear the alert that shows as a popover for sighted
users (example: http://www.screencast.com/t/bpNg0n1hFFX)
Change-Id: I0003b6fbd0a360cfe0c7e1faf4e038fc9b94bb8b
Reviewed-on: https://gerrit.instructure.com/70886
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
fixes CNVS-26072, CNVS-26075
refs CNVS-13110, CNVS-13130
Test plan:
1. Visit account rubrics page
2. Select an existing rubric
3. Tab through page to verify that non-interactive cells
are not focused
4. Click "Edit Rubric"
5. Tab through page to verify that non-interactive cells
are not focused
Using screenreader (esp. NVDA),
6. Verify that individual ratings are read by screenreaders
in show and edit pages.
Change-Id: Ie10338b8e51c21391c53997632a0d30886070f74
Reviewed-on: https://gerrit.instructure.com/70770
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
Fixes CNVS-25877
Test plan:
- Create a user with:
- an assignment that needs to be submitted
- an assignment that needs to be graded
- an assignment whose grades the user needs to moderate
- an assignment that they need to peer review
- a calendar event that they can see
- Go to the user's home page
- Ensure all of the assignments show up in the to-do list
- Ensure they show up in Coming Up as well
- Ensure that the calendar event shows up under Coming Up
- Go to the courses where you created the assignments
- Ensure that each assignment shows up on its respective course to-do
list
- Submit an assignment
- As a teacher, ensure that the assignment shows up as needing
grading, and that the number in the badge to the left is 1
- Ensure that screenreaders read the badge as "1 submission
needs grading"
- Make another submission as a different user
- Clear the cache by running `Rails.cache.clear` at a Rails console
- As the teacher, ensure that the badge is now 2
- Ensure that screenreaders read the badge as "2 submissions
need grading"
- Repeat 8 more times as different users, so that there are now
10 submissions
- Clear the cache again
- Ensure that the badge now says "9+"
- Ensure that screenreaders read the badge as "More than 9
submissions need grading"
- As the user who submitted the assignment, ensure that the grade
shows up on the To-Do list, Coming Up, and Recent Feedback
- As a teacher, leave a submission comment
- As the user who submitted the assignment, ensure that the comment
shows up under Recent Feedback
- Create a public course
- You can make a course public by going to its settings page
and checking "Make this course publicly visible"
- Log out
- Visit /courses/<id>, where <id> is the id of the course
- Ensure that the course shows as expected, and that nothing
shows up on the to-do list
- Automated tests should cover everything else
Change-Id: I18673995db94d896bf2c39515258e61065b48319
Reviewed-on: https://gerrit.instructure.com/69474
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Tested-by: Jenkins
Product-Review: Allison Weiss <allison@instructure.com>
fixes CNVS-25741
When an instructor "Messages students who…" and selects an
option for which a cutoff score is appropriate, we set
focus on the new 'cutoff' score field. Additionally, a
label has been added to make the field more accessible.
Test plan:
0. In gradebook, using keyboard only navigation and
screenreader software…
1. Tab to the column of an assignment.
2. Press [esc] to get out of edit mode.
3. Press [m] to open the assignment menu.
4. Select "Message students who…"
5. Select either "Scored less than" or "Scored more than"
from the menu.
6. Verify that focus is set on the cutoff score input.
Change-Id: Ide0663ef21002866e1f683390b07316f316ec42a
Reviewed-on: https://gerrit.instructure.com/68820
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Dana Danger <dana@instructure.com>
test plan:
* create a course with a future term/start date
* check the box "Restrict students from viewing before start date"
in the course settings
* invite a student
* the course should be shown in the list of future enrollments
(but not with a link, since the course is not accessible)
closes #CNVS-26313
Change-Id: Ica49536a09c65f3df9d4e0f62e885e8455bced40
Reviewed-on: https://gerrit.instructure.com/70045
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
Fixes CNVS-25343
Test plan:
- Verify that every visible iframe in Canvas has a non-empty title attribute
- Verify that every title attribute on an iframe has meaningful content ,
which correctly indicates the content the iframe contains.
Change-Id: Iac3a2031a81836b11e1e4bfdc2d242777a493172
Reviewed-on: https://gerrit.instructure.com/68027
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
QA-Review: Simon Williams <simon@instructure.com>
This only affects the New UI.
This makes it so that the sequence footer will always be
at the bottom of the screen rather than at the bottom of the
content. This makes a much better user experience for people
navigating through module items.
closes CNVS-24793
Test Plan:
- Make sure you are using New UI
- Go to a course's module page
- Make sure there are several different module items added
to a module, ideally one of each type.
- Go to one of the module items
- When the page finishes loading there should be a next/previous
bar at the bottom.
- Scrolling on the pages should keep the bar at the bottom
- The bar should not obscure the footer.
Change-Id: I0134624bbe976277dbf5ec071bb2f35abac60b23
Reviewed-on: https://gerrit.instructure.com/68729
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
either with Relation#all or Association#scope
refs #CNVS-26056
Change-Id: Ie370a3c47c575007ce3b0ba75a122d854e6f8fbc
Reviewed-on: https://gerrit.instructure.com/69497
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Fixes: CNVS-25974
Dashcard width and alignment updates requested by
Blake. See JIRA for changes and acceptance criteria.
Also added subtle animation on the placeholder
image that appears for each dashcard while the
content is loading.
Test plan:
- New UI only. Please clear browser cache.
- Open the dashboard and resize the screen.
- The dashcards should now resize like this:
http://screencast.com/t/q6rQiQaxSV
(stretching to the full width of the
container until the 1200px breakpoint, then
becoming fixed-width and stacking up to the
left as the screen is widened)
Change-Id: I04a1c33b4792befa6175fa7e9be37da3a969d646
Reviewed-on: https://gerrit.instructure.com/69144
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
refs CNVS-25916
TEST PLAN:
1) discussion_show_page_specific_user_spec should pass
under webpack selenium
WARNING: This has possible regression impact on all places where we use
the little "Add Rubric" button (quizzes in the 'view rubric' link from
the gear dropdown, assignments when given the option to add a rubric
while editing an assignment, and discussions where you can mess with the
rubric on a "graded" discussion), so each rubric adding workflow should
be checked.
Change-Id: I84af8b58e4143e79bff96bd638bd2149d8e73c2e
Reviewed-on: https://gerrit.instructure.com/68988
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes: CNVS-24787
fixes: CNVS-23964
fixes: CNVS-23957 - Handle parent account custom css/js for new_styles
test plan:
* set up a root account, child account, and grandchild account
* use theme editor to set a custom css/js file for each
(eg: for css `* {color:red}` and for js 'console.log("from grandchild")`
* make a course & a group in the grandchild account
* load a page in that course and group and make sure
you see grandchild account's branding, and root's,
child's, and then grandchild's css loaded on the page
(grandchild should be loaded last so you see it's css
effects override root or child's and you should see
the console.log from root then child then grandchild)
* view a page in "child". it should have root and child's
css/js but not grandchild
* as a user that only has enrollments (account associations)
in "child", go to the dashboard. you should see
css/js for both root and child but not grandchild
fixes: CNVS-25051 Opening Theme Editor for
sub-accounts shows incorrect theme preview
test plan:
* Go to a sub-account in theme editor and change
settings so the Branding is different and save.
* the preview on the right should reflect your
changes both after you "apply" and "save"
(and not just show the preview of the root
account's branding)
fixes: CNVS-23406 - global JS and CSS files are being
included when Global CSS/JavaScript includes is false
test plan:
* go to /accounts/self/, and go to theme editor and
upload a css_override
* see that that css is loaded on pages
* back in root account settings disable Global
CSS/JavaScript includes
* check that the css is no longer loaded.
* do the same thing checking a subaccount's custom css
fixes: CNVS-25558 - load whole chain of custom css/js
in native app api requests
test plan:
* make api request for a wiki page in course in a
subaccount that has custom css/js within a root
account that also has custom css/js
* you should see both the root account's css/js and
the child account's returned in the response
to test grandchild js issue jeremyp found:
* go to theme editor for a grandchild account
* choose a js override file (like: `console.log('first')`)
* preview & apply
* you should see "first" in console
* go back to theme editor, pick a new file (like: `console.log('second')`)
* preview & apply
* you should only see "second" in console. not "first"
Change-Id: I8d9047948f5da94be41e0205844629a170f980af
Reviewed-on: https://gerrit.instructure.com/68249
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
Fixes: CNVS-25440
Test plan:
- New UI only
- The dashcards on the user dashboard should now
look like this:
http://cl.ly/image/0a311i3a1g25
- The dashcards should function exactly the same
as they did before. The only non-style-related
change is that now, when the page is loading,
the number of "empty dashcard" placeholder
images should now match the number of dashcards
that will appear when the dashboard loads.
Change-Id: I92d0a9dc866718e79921c33390965471135fde21
Reviewed-on: https://gerrit.instructure.com/68356
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
Fixes: CNVS-25499
test plan:
- as an admin using the new ui
- navigate to your canvas instance
- the admin link should now display directly above the dashboard
link in the left-hand navigation
- ensure that this link does not show for a student/non-admin
Change-Id: Ie9a206228b4fdc53c5cfe70841c3afd40793e1e9
Reviewed-on: https://gerrit.instructure.com/68440
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
test plan:
- go to /accounts/X
- use Course Filtering / Find a Course / Find A User
and ensure after the search completes, the area where you
started regains keyboard focus
fixes CNVS-25660
Change-Id: Ia736b3e9144fa0d65d30a710066d4d17f5e368db
Reviewed-on: https://gerrit.instructure.com/68567
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Ryan Allen <rallen@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
test plan:
* edit an assignment, selecting "Display Grade as" to
"Letter Grade"
* click "View Grading Scheme" to see the default grading scheme
* click on the edit icon to edit it
* save the grading scheme
* it should work
closes #CNVS-25096
Change-Id: I49b08bc50e7b2fc57fd70c2d9afc2031419e4294
Reviewed-on: https://gerrit.instructure.com/68437
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes: CNVS-25498
test plan:
- as a user using the new UI
- navigate to your dashboard
- the account link should now be located directly under the upper
-left-hand logo (was previously located last)
Change-Id: Id6b4880e28ccf88eff352fc7a5f68095d3e2cbc7
Reviewed-on: https://gerrit.instructure.com/67983
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Add the ability to remove students from the list of recipients
in gradebook's "Message students who..." feature
test plan:
- have some students enrolled in a course
- have some kind of gradeable assignment or something,
and submit to it as some of the students
- as a teacher, go to the gradebook, and grade
some of the submissions
- hover over the assignment header, and select
"Message Students Who..." from the dropdown menu
- notice how when you select criteria, a list of students
whose submission (or lack thereof) matches the criteria
appears
- click the X next to a student to remove them from the list
- ensure only the selected students receive the message
when you click "Send Message" (not students manually
removed from the recipients)
- ensure the X buttons can be operated by the keyboard
and contain a prompt readable by screenreaders
- ensure the Send Message button is disabled if you
remove all the students from the recipients
(and you can change criteria and get the students
back)
closes CNVS-25005
Change-Id: I375d017f4bdd1d22ba6f8bb6ae6c83dbc76d3a9d
Reviewed-on: https://gerrit.instructure.com/68180
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Christi Wruck
test plan:
* create a new user with a login
* try to login as the user
* at the terms of use form, try to submit
without checking the "I agree" box
* it should pop up with an error
closes #CNVS-25286
Change-Id: Icab93ec1aac091368cb9e58d3533b995707885a5
Reviewed-on: https://gerrit.instructure.com/67769
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes: CNVS-24653
test plan:
- as a user with the new UI turned on - navigate to user
settings and select "use high contrast styles"
- click courses on the left-hand navigation - the upper left-hand
logo should no longer be vivible (nav now starts with dashboard)
- ensure nothing has changed with the old UI
Change-Id: Ic488735091aef53ddbc6ee622180fd6a7701c334
Reviewed-on: https://gerrit.instructure.com/66674
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
fixes CNVS-22822
Test plan:
* (in a very large course)
* use "message students who" in the gradebook to message everyone in
the course
* the messages should be delivered
* there should be no errors
* test other "message student who" features (just make sure they
still work)
Change-Id: I776f151e8a4b521727c4b759f50a27c602e3c557
Reviewed-on: https://gerrit.instructure.com/62928
Tested-by: Jenkins
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
refs #CNVS-11466
Users who aren't logged in should submit
an email, otherwise we can't get back to them.
This adds some front-end validation to require
an email address if the user isn't logged in.
If they are, we leave it alone, we can identify
them from their session.
This also removes the 404.html page, I can't find
anywhere where we actually use it (and it is
exactly duplicated in the error_form and such)
Change-Id: I0aaa322aa25f4c3f316cb2ce15573c2ac288035c
Reviewed-on: https://gerrit.instructure.com/63715
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes CNVS-24126
test plan:
- search the app and make sure there are no external references to this
partial
Change-Id: Ief7f62586c54eb66e58846fcdd0de0dab6ddc551
Reviewed-on: https://gerrit.instructure.com/65416
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Jenkins
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Add grading period dropdowns on the 'grades' page,
and add a "Display Totals for 'All Grading Periods'"
feature flag. By default, the feature will be turned
'off'.
When the feature is 'off':
- Totals will not display in the gradebook
or the 'student grades' page when the 'All
Grading Periods' option is selected.
- The grading period dropdowns on the 'grades'
page will not have an 'All Grading Periods'
option.
When the feature is 'on':
- Totals will display in the gradebook and the
'student grades' page when the 'All Grading
Periods' option is selected.
- The grading period dropdowns on the 'grades'
page will have an 'All Grading Periods' option.
closes CNVS-23995
test plan:
1) as a teacher, enable the 'multiple grading
periods' feature (do not enable the 'display
totals for all grading periods' feature yet).
a) verify the gradebook does not show totals
when the 'All Grading Periods' option is
selected.
b) verify the 'student grades page'
(courses/4/grades/9#tab-assignments) does
not show totals, and the calculation of
'what-if' grades is disabled when the
'All Grading Periods' option is selected.
c) turn on the 'display totals for all
grading periods' feature. repeat steps
a & b and verify that the totals now
show up (and you can calculate what-if
grades on the student grades page when
'All Grading Periods is selected')
2) sign in as a student that is enrolled in
3 courses: 1 course with MGP disabled, 1
course with MGP enabled and 'display all
grading periods totals' (DAGPT) disabled,
and 1 course with MGP enabled and DAGPT
enabled. go the the 'grades' page (/grades).
a) verify there is a grading period dropdown
next to the totals for courses that have
MGP enabled. verify there is not a grading
period dropdown next to the total for the
course with MGP disabled.
b) verify that the current grading period is
selected by default, if one exists. if a
current grading period does not exist, then:
- the dropdown next to the total for the
course with DAGPT disabled should show
'Select a grading period' and the total
grade should show as '--'.
- the dropdown next to the total for the
course with DAGPT enabled should show
'All Grading Periods' and the total grade
should be displayed.
c) verify clicking a grading period in the
dropdown changes the total, and shows
the correct total for that grading period.
3) repeat steps 2a-c, but sign in as an observer that
is observing at least 3 students in 3 different
courses(1 course with MGP disabled, 1 with MGP
enabled and DAGPT disabled, and 1 course with
MGP enabled + DAGPT enabled).
4) verify that the grading period dropdowns that were
added are accessible.
Note: The 'grades' page (/grades) will _always_
display the total for 'All Grading Periods' when
signed in as a teacher. We are aware of this
existing bug and we're working on a solution.
Change-Id: If501b47aa57121d17d4e6629d1dcdbc8676971a2
Reviewed-on: https://gerrit.instructure.com/65847
Tested-by: Jenkins
Reviewed-by: Strand McCutchen <smccutchen@instructure.com>
Reviewed-by: Dylan Ross <dross@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
fixes CNVS-24128
test plan:
- with users that both can and cannot publish sis grades, visit the
course settings page.
- the appropriate controls should be present/absent and work correctly.
Change-Id: I45ded2726a64b3a7457e76e67e681e3d3274b000
Reviewed-on: https://gerrit.instructure.com/65454
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
test plan:
0. enable New Styles
1. go to the dashboard with the rectangle card things
2. click the gear icon on a course card
3. edit the course name in the box above the colors and
click Apply
4. notice the course name in the dashboard card has changed
and the original name is visible if you hover over
the nickname
5. click the card to go to the course and notice your
course nickname is used:
- on the course home page (with 'recent activity'
or 'syllabus' selected)
- in the Courses menu
- in "All Courses" under the Courses menu
- in the UI navigation (breadcrumbs)
- on the calendar (right side list)
- in the Inbox (course dropdown)
6. go back to the dashboard, click the gear menu on
a course card, clear out the nickname, and click Apply.
- the original course name should be restored
and shown in the locations listed in step 5
7. repeat steps 2-6 with a different student in the same
course; ensure the first student's course nickname
doesn't leak through to a second student
8. regression test course color choosing functionality
on both the dashboard and the calendar
closes CNVS-23201
Change-Id: I8dd714cad83dca5e17e65c6c463cdadc655db83c
Reviewed-on: https://gerrit.instructure.com/65052
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
test plan:
* create a moderated assignment
* make a provisional grade
* the assignment should show up in the
todo list for the moderator
to "Moderate X" and take them to the
assignment moderation page
* the todo item should be ignoreable
(either permanently or until a mark is created/changes)
closes #CNVS-23307
Change-Id: I7007ba948e688ca5864a0d851c153a288bef4233
Reviewed-on: https://gerrit.instructure.com/64734
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
also add a read-only view for course settings
test plan:
* create an account role with permissions to do everything
except "Manage Courses" and
log in as an account admin with that role:
* they should be able to view unpublished items
(modules, assignments, etc)
* they should be able to get to the course settings page
but they should not be able to edit the settings
(or try to, unsuccessfully)
* they should not be shown options on the course home
they don't have the rights to edit, such as
"Choose Home Page"
* also to be safe, make sure all the course settings are
editable for a full admin
closes #CNVS-22594
Change-Id: I57a7fe9dd04b6ec35fd6e2b311e02b9e43d82929
Reviewed-on: https://gerrit.instructure.com/63064
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
fixes CNVS-22052
Test plan:
* As the dashboard card view loads, you should see ghost images of the cards.
* When you toggle to the recent activity view, it should load immediately.
* If you reload the page, the recent activity view should load.
* If you toggle back to the cards view, it should load immediately.
* If you reload the page, the cards view should load.
Note: this change could result in a slight negative performance impact.
I think that it's worth it for the improved UX when switching views, but
it's something we should look at when testing.
Change-Id: Ib83234a3d955e42cbd1133e8d8634f23184277f4
Reviewed-on: https://gerrit.instructure.com/64040
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
Tested-by: Jenkins
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
fixes CNVS-22876
Test plan:
This refactors the logic to determine whether a nav item should be
highlighted, so we should test all of the nav items.
Change-Id: I4b60d662b498ae0ee31663b123465e602643d690
Reviewed-on: https://gerrit.instructure.com/64372
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
stopgap measure to keep someone from calling the search page
over and over again
test plan:
* account user and course search (e.g. the "Find a User"/
"Find a Course" searchboxes on the right hand side of
account pages) should be disabled and show an indication
that they're loading a new page when submitted
refs #CNVS-23230
Change-Id: I41d765bd4a033885abd305093920fe7e0223a79b
Reviewed-on: https://gerrit.instructure.com/64336
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
fixes CNVS-23167
Note: https://gerrit.instructure.com/#/c/61285 caused a bug where
navigating anywhere other than the main theme editor page during
preview results in a blank page
(ArgumentError Exception: wrong number of arguments (1 for 2).
Meanwhile, https://gerrit.instructure.com/#/c/61890/ made it so
that the offending code was never run, but also prevented the flash
notices from appearing in preview mode. This fixes both of these issues.
When navigating to any page (other than the theme editor page) while in theme
preview mode, you should see the following flash notice and the
'Theme Editor' link should take you to the theme editor view for the
current account:
* Within the theme editor: http://cl.ly/image/072l0M3z3R3g
* Outside the theme editor: http://cl.ly/image/1X281e2i3O2W
The theme editor page should display this notice in preview mode:
http://cl.ly/image/3Y3p0b0i091h
Change-Id: I124d722c2b4257c80cf08b20700147799c304f8e
Reviewed-on: https://gerrit.instructure.com/62982
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Closes: CNVS-21895
This commit allows a user to preview changes
made to the login screen from within Theme
Editor as can be seen here
http://www.screencast.com/t/RGzK7dvNuTr
Test Plan:
- In the NUI, open Theme Editor
- The preview page should appear similar to
this http://www.screencast.com/t/isstjV9eC
- Selecting 'Login Screen' from the left
side navigation should cause the screen
to scroll down to the login preview.
- With the 'Login Screen' option selected,
selecting any other options should scroll
the screen back to the top of the Theme
Editor preview page
- As a user updates different values, the
Login preview should update to reflect
those changes.
From within the login preview:
- The user can interact with the form text
fields and input dummy values
http://www.screencast.com/t/nlJx4ajq3AR0
- Pressing the 'Log In' button should NOT
log the user into Canvas from the preview
iframe. The button can be clicked, but
the form should not be submitted
- Selecting the 'Forgot Password' link
should allow the user to preview the
password request page.
- The user can interact with the text
field on the Forgot Password login
page. http://www.screencast.com/t/M6HuDrPYv
- The 'Request Password' button can be
clicked, but it should not be functional
and the form should not be submitted.
Note: the 'Request Password' form can be
submitted by hitting the ENTER key. This is
a known issue and is acceptable as it is an
edge case.
Change-Id: I2314db188c9ce561c21c745455ad17c61697968b
Reviewed-on: https://gerrit.instructure.com/61890
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
Tested-by: Jenkins
QA-Review: Michael Hargiss <mhargiss@instructure.com>
refs CNVS-21426
test plan:
- make an account (parent) with a child and
a grand child
- on the parent go to settings and
enable subaccount branding
(check "Let sub-accounts customize themes
and add additional includes")
- go to the grand childs account and they
are able to open the theme editor
- make a theme
- it works
- disable subaccount branding on the parent
- both the child and grandchild cannot open
the theme editor and lose their specific
custom css (they have the root css tho)
- turning it from the parent makes it all work again
Change-Id: I0b4c043de891c9201a4f58b867c3a9430b9c6b75
Reviewed-on: https://gerrit.instructure.com/61603
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins
Product-Review: Rob Orton <rob@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
Fixes: CNVS-22752
Adds new UI markup and CSS classes to the
Updated Terms of Use page in Canvas.
Test Plan:
To view this page in the browser:
- As an admin, manually create a user within
Canvas, and assign him/her a login/password
- Log out of your admin acct, and try to log
in as the user you created, using the new
password.
- You should be challenged to accept the
terms of use.
- The screen should now look as follows:
New UI: http://screencast.com/t/hTgWoiwM
Legacy UI: http://screencast.com/t/V9wFUXZpkL3
- The screen should work exactly the same as before
Change-Id: I0b31f30f9610eb2b3fdbbb25745df12fa24e11b4
Reviewed-on: https://gerrit.instructure.com/62546
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
fixes CNVS-21426
changes theme_editor routes to nest under accounts
show correct brand_config for subaccount
be able to theme subaccounts
parent account changes trickle down to subs
theme editor default values are that of parent account
add not in preview text that subaccounts dont show
test plan:
simple creation
- create a sub-account
- brand it differently from parent
- if you go to courses belonging to
this subaccount, it gets their css
- if you go to courses belonging to
the parent you get the parent css
- if you go to a user dashboard
you get the parent branding
(maybe we can add smarts to this
later in case you only are in
the subaccount?)
trickle down
- rebrand two values on the parent
- one that the subaccount explicitly sets
- and one that doesnt
- apply this config on the parent
- wait a little and go to the child account
- its theme inherits values for the parent,
but... if it explicitly sets those values
itself then it doesnt inherit it
- go to the editor for the subaccount
- the placeholder values are those
of the parent account (or the canvas
default if the parent hasnt set it)
- test trickle down with a sub-account and
a sub-sub-account
still to do on different patch sets:
- account settings to allow subaccount branding
- show the progress of all the child compilation
Change-Id: Iaddba7036f564965427807c2fd8b0a6a5d524366
Reviewed-on: https://gerrit.instructure.com/61285
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
fixes CNVS-22900
Test plan:
Verify that groups icon in global nav when new ui is enabled is not the courses icon.
Change-Id: Ie8855c61b64d708c307085995e2efdbfc9a08441
Reviewed-on: https://gerrit.instructure.com/62374
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
fixes CNVS-21915
Note: I refactored the help_link helper so we should do regression testing
around the help link in the following areas:
* Login footer
* Global nav for new UI
* Footer with legacy UI
* Speed grader
Change-Id: I7f71bb0050cab4c69546329f20cd0fa9cd30d442
Reviewed-on: https://gerrit.instructure.com/61607
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
fixes CNVS-22527
test-plan:
- when "Updated Terms of Use" page displays, should not include any
custom account CSS
Change-Id: I98bcc48e1bf4f281ee34db8ee50ed204defc437d
Reviewed-on: https://gerrit.instructure.com/61659
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
fixes CNVS-21986
test plan:
- navigate to a created assignemnt
- click add rubric
- inspect the table rows to find scope
Change-Id: Ib7090ebfb78e6e39316c5f6ffe221c127bcaa77c
Reviewed-on: https://gerrit.instructure.com/60150
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Davis McClellan <dmcclellan@instructure.com>
fixes CNVS-21569
Test plan:
1. Log into a course
2. Navigate to course settings (in the left column)
3. Select the Course Details tab
4. Scroll down to the Grading Scheme section and select set
grading scheme.
5. Confirm the grading schemes and the done button are
fully visible.
Change-Id: I72aa23056a4875f7d5a1aa1123d6f7315352f01d
Reviewed-on: https://gerrit.instructure.com/60461
Tested-by: Jenkins
Reviewed-by: Derek Bender <dbender@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Christi Wruck
should not be able to interfere with assessments that
belong to submissions or assignments
closes #CNVS-22007
Change-Id: I9aee919ba3c3b7568127927b1da5d898e94bbbb2
Reviewed-on: https://gerrit.instructure.com/60832
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
closes: CNVS-22368
When a student only has enrollments in unpublished
courses, they do not see a courses global nav link.
The link is needed to get to "all courses" and see
their enrollments.
this changes things so the "courses" menu is always
shown. that way those users will be able to get
to that "all courses" link
Product / UX/UI review question:
This is just one possible way of fixing this problem.
the other thing we could do is to leave it how it was
but do a second, more expensive DB query to see if
there are any of those unpublished or archived courses that
I can see on the /courses page but not in the course
menu. in standup, we agreed to do it like this but
if any of you feel strongly that we should do it
the other way, that's fine too.
test plan:
Add a new user
Enroll them in an unpublished course
Masquerade as the new user,
click the courses global nav option
you should see the "all courses" link in the tray popup
Change-Id: I140dbc4f4d2852c386cc57cac3f2afec6ef62979
Reviewed-on: https://gerrit.instructure.com/60233
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Fixes: CNVS-20428
Test Plan:
- This change affects both the legacy and new UI
- Go through the JIRA ticket and test each type
of notification listed.
- Here is what the new notifications should look
like in your browser:
Course invitation:
http://screencast.com/t/nH8lerGRzg0b
Global account notifications (5 types, each
with a different icon. Warning and error should
be orange and red, respectively):
http://screencast.com/t/vJ03xNjYf
Scheduled web conferences:
http://screencast.com/t/Ozts1TFQpp
Welcome to Canvas!
http://screencast.com/t/F9netv3X
Configure communication preferences:
http://screencast.com/t/gUSWOOyK
Change-Id: I68d78852d455125a26eb7e2f8fd01997ab3f65c4
Reviewed-on: https://gerrit.instructure.com/59601
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Fixes: CNVS-21513
Test Plan:
- In Firefox with NVDA enabled, turn on the new UI
- Move through the global nav with NVDA
- Previously, Account and Inbox options had an extra
link announced (http://screencast.com/t/mAp9jc5tMtjO)
- Now, the Account and Inbox options should be
consistent with the ones before them (no extra
'link' is announced)
Change-Id: Ie7267a4a93680c5ea8f066b505148c1b0e42fa31
Reviewed-on: https://gerrit.instructure.com/59669
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
fixes: CNVS-22211
test plan:
* make changes in theme editor,
* the banner at the top of the page should say this
new message
Change-Id: Ib1b15540446b6df01fe7987f9f5e8bd955b208b0
Reviewed-on: https://gerrit.instructure.com/59451
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Fixes CNVS-22039
Test plan:
- Enable the new UI
- Log in
- Ensure that 'login_success=1' is in the URL
- Ensure that the dashboard tab appears selected with a white
background
Change-Id: I4744dd4064e00146de774b10e1b86a9147025db0
Reviewed-on: https://gerrit.instructure.com/58886
Tested-by: Jenkins
Product-Review: Colleen Palmer <colleen@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Adrian Russell <arussell@instructure.com>
fixes: CNVS-21376
This adds the styles and markup we need to customize the
new ui navigation logo.
Test Plan:
- Turn on new UI
- Go to Theme Editor
- Find the navigation logo and upload a new one
- Preview new logo
- Apply new logo, navigate to canvas and make sure it's still there
- Repeat a couple of times
Change-Id: Idd221a61c7806c71ca15a5d1e82cce0e39101ba8
Reviewed-on: https://gerrit.instructure.com/56393
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
Tested-by: Jenkins
QA-Review: Pedro Fajardo <pfajardo@instructure.com>
Essentially there were some issues with JS failing for some reason
and that caused the redirect to not work appropriately. This was
happening somewhat frequently especially for OSS users.
This change converts the terms_required view to use rails helper
methods and moves the redirect on success logic to the users
controller.
fixes CNVS-21496
fixes CNVS-21658
fixes gh-654
Test Plan:
- Ensure that terms of service are required for the account
This can be done with `Setting.set('terms_required', 'false')`
- Login with a new user that hasn't already accepted terms
- The agree to terms box should show up.
- Checking the checkbox to accept terms and submitting should
save that acknowledgement and move you along to the dashboard
or whatever particular page you were needing to go to.
Change-Id: I016e7e21acda67ce26b5d782d37d1477f134a065
Reviewed-on: https://gerrit.instructure.com/58475
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
fixes: CNVS-21745
This removes all the logic we had around html and styles specifically for k12
so we can return it to the legacy look/feel.
Primarily this is for legacy UI. See note below on new UI.
Test Plan:
- In legacy UI, turn on the k12 flag
- Nothing should change
Note: In k12 theme we primarily touched the navigation and account nav
(aka, course nav) area. So long as those look the same as
Canvas Legacy UI, it's good.
New UI: We will be making another commit that will allow new ui styles to
compile with k12 flag on. Right now turning new UI on will break it (since we
are not including these assets).
Change-Id: I71699ca3f77c508dc704e232c1e06ddf737f7e42
Reviewed-on: https://gerrit.instructure.com/57975
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Adrian Foong <afoong@instructure.com>
refs: CNVS-21746
This makes it so when the k12 flag is on, we show a few different icons
in the global navigation for:
- Dashboard
- Courses
- Grades
- Inbox
- Calendar
Note: focus is on icons - background color may change based on your settings
Test Plan:
- Turn on New UI and you should see these icons:
http://cl.ly/image/0K1D031M0Y43
- Turn on k12 flag and you should see these:
http://cl.ly/image/1l232g0K2O1I
Change-Id: Ic79cdecb3b8dc83066e58fcd1c45f12422c56f17
Reviewed-on: https://gerrit.instructure.com/58135
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Tested-by: Jenkins
rails4 removed the automatic initialization of a local variable
matching the name of a partial view
(e.g. setting `course` to nil in _course.html.erb)
also helper methods are protected so they cannot simply be
delegated to the spec controller anymore
refs #CNVS-21596
Change-Id: I7ce8b8a0084602a93f8ac571ee5c98740cb861d1
Reviewed-on: https://gerrit.instructure.com/58718
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
test plan:
- you should be able to create, edit, and view wiki pages named
"new", or whose names start with "new"
- when editing a wiki page, the "Link to a New Page" link in the
wiki sidebar should function properly
- if you go to /courses/35/pages/nonexistent-page-id, you should
see a message indicating the page doesn't exist but you can
create it, and sent to an editor for the page
fixes CNVS-1428
Change-Id: I306441e1f686a993885beeb066409c30f9e2528b
Reviewed-on: https://gerrit.instructure.com/58649
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes CNVS-21826
test plan
- as an account admin you should be able to use
brand configs
Change-Id: I907e856a9b675681c5d1bc099cec6b7c3cab7b34
Reviewed-on: https://gerrit.instructure.com/58521
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Refs: CNVS-19258
This updates the masquerading and student view
fixed-bottom alerts to match Blake's mockup for
the New UI (Blake has approved screenshots of
this ticket).
NOTE: Because this involved a lot of shifting
markup around to get to the new mockup, I had
to make this change affect BOTH the new and
old UIs.
For masquerading:
- Go to Admin > Site Admin > Users
- Choose a user, and click the tiny "Become" link
- For the new UI, masquerading should now look like
this:
http://screencast.com/t/7iG8rMjwh00P (tablet - desktop)
http://screencast.com/t/jxrp5yxL (wide screens)
- For the old UI, masquerading should now look like
this:
http://screencast.com/t/uw8agxcf (all screen sizes)
For student view:
- Go to any course > Settings
- Click the Student View button on the right-hand menu
- For the new UI, student view should look like this:
http://screencast.com/t/SBT6IOnjAgN (tablet - desktop)
http://screencast.com/t/zLZS7cRtpkt (wide screens)
- For the old UI, student view should look like this:
http://screencast.com/t/SBT6IOnjAgN (all screens)
Change-Id: I0730a3225eed6b5d42fbb65e8c715ecdfa591d6c
Reviewed-on: https://gerrit.instructure.com/57212
Product-Review: Colleen Palmer <colleen@instructure.com>
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Pedro Fajardo <pfajardo@instructure.com>
fixes: CNVS-20551
This adds the final UX polish to bring it up to par with what UX wants
theme editor to look like. This fixes the ui for the theme editor ui
when you upload an image. It also tweaks the Windows logo upload and
the tile color helper text.
Please take a look at this screen for comparison:
http://cl.ly/image/2q1g1Q0R3C3t
Test Plan:
- In new UI go to theme editor
(Account Settings > Open Editor)
- The theme editor UI should now resemble the above screenshot
Change-Id: I986504edcddd84f6954916a71f1618c28ed94699
Reviewed-on: https://gerrit.instructure.com/56392
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
with the new css stuff, we don't actually use
jammit so jammit_css has been renamed to css_bundle.
we left an aliased jammit_css and marked it deprecated
so these all still worked but spit out a deprecation warning.
Change-Id: Ib74037711f559f64851d9379644479587c1f83f2
Reviewed-on: https://gerrit.instructure.com/55888
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
should improve performance for all pages
test plan:
* regression test dashboard cards
refs #CNVS-21317
Change-Id: Id6506c2f31ecb45b9d32a01c8e0a3534be76851e
Reviewed-on: https://gerrit.instructure.com/57642
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
what this does:
* Changes the way we generate css so we are able to generate custom
css for people that use the theme editor.
* Sets everything up so we can push all of our static assets
(js, fonts, css, images, etc) to s3 pre-deploy and serve them
from cloudfront. Yay! faster canvas for everyone!
* as part of that, this enables the rails asset pipeline just so we
can use it to put md5s in our urls. we don't use it for any of the
coffeescript/sass/sprockets transformer stuff.
* adds a new "Theme editor" functionality (only for people that have
have the use-new-styles feature flag turned on) where an admin for
an account can pick their own colors/images for all the users
at their account/school.
* when the user is done saving things in theme editor, it will,
in a delayed job, generate all the css with against the variables
that user specified and push it to s3 so it will be available to
anyone else that requests it. (the delayed job will shell
out to a node.js executable called `brandable_css`).
* ability to pick an existing shared theme and to reset to
blank theme. closes: CNVS-19685
* gets rid of jammit.
test plan:
(this is exaustive, so not every person has to do every step
but we should make sure at least someone does each of these things.
maybe as part of the review add a comment if you have done one of these
bulletpoints)
* before you check this out, compile all css and copy the
public/stylsheets_compiled directory somewhere. after you check out
this code and regenerate all the css. make sure there are no
significant changes to the css output. (we updated the versions of
node-sass and autoprefixer that we use so we want to make sure they
don't change things in a way we weren't expecting)
* make sure the way we load css for handlebars templates still works.
eg: if there is a handlebars template at
app/views/jst/some/template.handlebars
if there is also a scss file at
app/stylesheets/jst/some/template.scss
then that stylesheet should get loaded when that template is rendered
* check out the code and run migrations. browse around canvas,
make sure css and js files load correctly as before.
* cody, jacob, or someone on queso: look at the db migrations and
make sure everything looks good and that I am handling sharding
correctly.
* verify that both rake canvas:compile_assets and guard, works as well
as `node_modules/.bin/brandable_css` (note: if you have
"node_modules/.bin" in your PATH (which you should), it will also
work with just `brandable_css`)
* verify that passing the --watch option to
`.bin/node_modules/brandable_css` works and picks up changes to
sass files, images, fonts, or any other resource that goes into
a css file. and that it only recompiles the css files that actually
depend on that file.
* go to https://github.com/ryankshaw/brandable_css and check out the
code there. that is what is actually doing the sass compiling
* create a config/canvas_cdn.yml file and add aws access creds and
an s3 bucket and cdn hostname (for testing, you can use the credentials
for instructure_uploads_engineering from
https://gollum.instructure.com/OtherServiceTestAccounts ). for a test
cdn hostname you can use https://diu0rq5m1weh1.cloudfront.net. that
is a cloudfront bucket I set up on my personal account that points to
instructure_uploads_engineering
* run rake canvas:compile_assets again, this time, at the end, you
should see it run the assets:precompile task that puts md5s in filenames
and, gzipps them, and copys them to public/assets.
then you should see it run canvas:cdn:upload_to_s3
(look at log/development.log for progress),
which pushes everything to s3.
closes: CNVS-17333 CNVS-17430 CNVS-17337
* try out the theme editor: turn on new styles, go to accounts/x
(where x is the @domain root acount you are testing from) and click
the "theme editor" button on the right side of the page.
that should take you to a page that has the ability to pick colors/images
on the left side and preview your changes in an iframe on the right
closes: CNVS-19360 CNVS-20551
* test the "preview", "save", "reset", and "choose existing" functionality
closes: CNVS-17339 CNVS-17338 CNVS-19685
* make sure that the themeeditor works both if you have
config/canvas_cdn.yml set up and enabled as well as if you don't.
if it is enabled, you should see it push the css for just that new
brand config to s3 when you hit preview, and the css
should be accessible from the cdn you configured.
Change-Id: Ie0a812d04f5eeb40e7df7e71941ff63ea51a4d22
Reviewed-on: https://gerrit.instructure.com/53873
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Small wording tweaks requested by UI team to
primary navigation in new UI.
Fixes: CNVS-21363
Test Plan:
- Make sure that the Use New Styles flag is
turned ON.
- On the main navigation, underneath the profile
pic, it should now read "Account" (not Profile).
- The title of the tray that slides out when you
click on Account should now be "Account"
- On the main navigation, the Accounts link has
been renamed "Admin"
- The title of the tray that slides out when you
click on Admin should now be "Admin"
- Click on the Courses link on the main navigation.
The "All courses" link on the tray should now
have a gray border on top of it.
Change-Id: I6693f507ca6d75608aeed8c454ed008e3d24d187
Reviewed-on: https://gerrit.instructure.com/56944
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
test plan:
* hide the files navigation tab for a course
* as a student, the files tab in the wiki sidebar should not be
shown
closes #CNVS-20096
Change-Id: Id7b7dd6f501e1e2941714fe743113c0ae8dc5766
Reviewed-on: https://gerrit.instructure.com/56931
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
fixes CNVS-21039
This adds the dashboard icon to the global navigation.
Test Plan:
- Turn on new UI
- In the global nav there should be a dashboard icon that brings you to your
dashboard
- If you navigate away from dashboard it will no longer have an active state
- Turn off new UI
- There should not be a dashboard link anywhere in the global navigaition
- Turn on k12
- There should not be a dashboard link anywhere in the global navigation
(because it's based off legacy ui)
Change-Id: I07083bf656b345e4889769e61cc829588d4c3455
Reviewed-on: https://gerrit.instructure.com/56200
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Robert Lamb <rlamb@instructure.com>
closes CNVS-21027
TEST PLAN:
1) add google as an authentication provider
2) get a pseudonym for your user affiliated
3) on the login page for canvas (/login/canvas) there should be a
google icon (no "+") next to the "Login with google" text
4) on the pseudonyms page, your google pseudonym should have a google
icon (no "+")
Change-Id: I95450a969d74fa0cb687fc1e9d5003c53a28f69a
Reviewed-on: https://gerrit.instructure.com/56862
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
Essentially links everything up with jQuery events so that the
awesomeness of the tray still occurs, but it doesn't reload everything
with React causing a flash, and we don't end up having to maintain
the same stuff in two places.
closes CNVS-21015
Test Plan:
- Enable new styles
- Global nav should function as expected meaning:
- Courses/Accounts/Groups only show if the user has those
- Clicking one of those pops out a tray listing them
- The Profile tray pops out as expected
- On public facing pages logged out users should see a
Login button rather than a Profile button.
- This commit does not get global LTI links such as Commons
working, that happens in another commit.
Change-Id: I66f925d46e78e79be4a25546a8d2967aa5eeb8e2
Reviewed-on: https://gerrit.instructure.com/56046
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
closes CNVS-19331
refs CNVS-15543
The plan was to make date pickers in shared/_add_assignment accessible,
but when I tried to use the partial in the one place it still
gets included (context module inline assignment creation), it
doesn't even get used anymore. Removing
this code entirely.
TEST PLAN:
1) context module editing and assignment adding should not break
2) tests should all pass
Change-Id: Ib1c88a963aecbbe4f15f3b6824ffb6a9e9eea4e9
Reviewed-on: https://gerrit.instructure.com/56673
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes CNVS-21028
Test Plan:
- Make sure you are in an environment where the help link
normally shows up. I know it does in beta/prod, but not
sure about portals. Locally there is a setting that has
to be set from the console.
- Load up Canvas with 'Use New Styles' enabled. (any page should work)
- The footer area should look similar (you may have more links)
to this: https://goo.gl/zkVzKd
- It should not look like this: https://goo.gl/Pv1Eiz (note the extra
white space)
- It should also definitely not have any sort of hovering thing on it
that looks like this: https://goo.gl/zRmPxt (note that when hovering
it looks like the New UI help button) Yeah, 🤦 on that one.
Change-Id: I27063c79bba10f1b07f9790b471f9593ac234f9e
Reviewed-on: https://gerrit.instructure.com/55979
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
QA-Review: Adrian Foong <afoong@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
fixes CNVS-20119; fixes CNVS-20139; fixes CNVS-20140;
fixes CNVS-20424; fixes CNVS-20426
This adds a new Dashboard view when using New UI.
Note: This is for New UI only. Legacy UI should only show Recent Activity on
dashboard (as it always has).
Test Plan:
- Login and make sure new UI is on
- Go to / and see the new Dashcard view.
It should look similar to: http://cl.ly/image/2R2K28183h2G
- Switch to "Recent Activity" by using the toggle
It should look similar to: http://cl.ly/image/2l1V1h421b0d
- Dashboard Cards have quick links on the bottom to quickly let you
navigate to within a course. These include:
- Discussions (if available)
- Announcements (if available)
- Files (if available)
- Assignments (if available)
If activity has happened in Announcements, Assignments or Discussions, an
active state is given to the quick link that makes it look like this:
http://cl.ly/image/1d3Y0T3w1Q01
Change-Id: Ia07f7f2711d6e0625d26d7ea5d050ccb51dc0128
Reviewed-on: https://gerrit.instructure.com/53043
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
Tested-by: Jenkins
QA-Review: Adam Stone <astone@instructure.com>
closes CNVS-20970
Adds SVG that you can see (previously was white on transparent)
to make pseudonyms easy to identify on /users/self
TEST PLAN:
1) configure canvas for a couple oauth providers authentication
(facebook, twitter, linked in)
2) get your user setup with a pseudonym for each.
3) go to /users/self
4) you should see pretty icons
Change-Id: Ice0e664a16ba7a1ebda53df36639ebb6b49f9deb
Reviewed-on: https://gerrit.instructure.com/55931
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins
Product-Review: Ethan Vizitei <evizitei@instructure.com>
This fixes a few places so that requests aren't sent off from the
login screen. This also gives the navigation header a login button
to use when certain pages are open for public access.
Test Plan:
- The login screen of canvas should work without throwing
any JavaScript errors (warnings are just fine)
- When going to a page with public access allowed, you should see
a "Login" menu item
Change-Id: I68729c7241babab47cde9a57fb67f94ec9cf0c99
Reviewed-on: https://gerrit.instructure.com/55852
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
CNVS-20987
fixes 2 places where svgs are included as partials without an
extension specification, which rails doesn't like.
Change-Id: I4b52ee61618d63e216dc94bccef0604d6d3cd276
Reviewed-on: https://gerrit.instructure.com/55881
Reviewed-by: Brian Palmer <brianp@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Ethan Vizitei <evizitei@instructure.com>
closes CNVS-19458
closes CNVS-19542
closes CNVS-19543
closes CNVS-19462
closes CNVS-20954
Add a "login with X" buttons that only displays
if the account has configured OAuth. The button
just goes straight to the login flow. Also tries to do it
in an abstract enough way that other OAuth providers will be easy
to add buttons.
Also add icons to pseudonyms so that you can tell which is which
from "/users/self"
TEST PLAN:
1) configure a facebook AAC (and probably do these for each oauth
provider)
2) visit /login/canvas
3) click the AAC-specific vendor login button
4) complete the AAC-specific vendor login flow
5) go look at "/users/self" and make sure you can identify your
oauth pseudonym
Change-Id: Ie5e085cd65512286858cf5be5caffd4e7431a6c7
Reviewed-on: https://gerrit.instructure.com/55172
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins
Product-Review: Ethan Vizitei <evizitei@instructure.com>
Makes it so that the global nav is rendered in a 'static' form by
the server via application.html.erb but is then replaced by the React
component once JavaScript has come onto the page.
It also makes it so the API calls don't take place until the
relevant button on the sidebar is hovered over.
closes CNVS-19257
closes CNVS-19199
closes CNVS-18822
closes CNVS-17911
closes CNVS-18489
closes CNVS-18351
closes CNVS-20214
closes CNVS-20507
Test Plan:
- You should see a server rendered version of the bar on the page
- It should be rendered by React once JS loads
- Hovering over the courses/groups/accounts should cause an API
call the first time.
- Courses/Groups/Accounts should only show if the user you are using
has access to those things.
- Make sure the help link opens up the normal help modal.
- When on the courses page make sure at smaller resolutions that the
hamburger menu successfully opens and closes.
- If Commons is enabled, that link should show in the global nav.
- The active link should show as being highlighted white.
* Please also test this with multiple screen sizes (tablets/desktop).
It should be responsive
Change-Id: If27c9f07e6eea662909790fb09d6ada254b8009c
Reviewed-on: https://gerrit.instructure.com/54703
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
fixes: CNVS-20375
* * * *
NOTE: THIS COMMIT AFFECTS NEW STYLES ONLY!
Code reviewer(s): Please turn on New Styles if you
pull down the changeset.
* * * *
Fixes small layout bug in New Styles on the
/courses page: The table that lists the courses
does not scale down very well to tablet-portrait
size: the star icon/link smushes into the text.
(See JIRA story for screenshot of bug.)
Test Plan:
- Make sure the New Styles feature flag is
turned ON.
- Click on the Courses link in the main
navigation on the left-side.
- When you are on the /courses page, scale
your screen down to tablet-portrait size.
- Confirm the courses table now looks like
this: http://screencast.com/t/L6VqQPmku
- Note: I also changed the star icon colors
to conform to color contrast requirements.
Change-Id: Id52b5b9f5a8d75bea69cfd103bc2037871866ebe
Reviewed-on: https://gerrit.instructure.com/54194
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
fixes CNVS-20394
split it into appropriate concerns. main points are:
* /login never renders a login form - it redirects forward to the
default auth controller based on the first account
authorization config (or discovery url on the account)
* /login/canvas is the new home of the old login form. this form is
never rendered in-situ anymore - other places that used to render
it now redirect to /login (and then forward to here), reducing
their knowledge of SSO
* /login/ldap ends up at the same place (cause LDAP auth is handled
transparently)
* /login/cas and /login/saml redirect forward to the first SSO
configuration of the appropriate type. /login/:auth_type/:id can
be used to select a specific one
* if an SSO fails, it redirects back to /login with flash[:error]
set. this can forward to the discovery url appropriately, or
render an error page appropriately (the old no_auto=1, but now
it's not layered on top of the login partial that didn't show a
login form)
* ?canvas_login=1 is deprecated. just go directly to /login/canvas
* /saml_consume, /saml_logout are deprecated. they are processed
directly by /login/saml and /login/saml/logout
* /login/:id is deprecated - it forwards to /login/:auth_type/:id
as appropriate (presumably only saml, since that was the only
one that previously should have been using these links)
* OTP has been split into its own controller, and separated into
multiple actions instead of one all-in-one action
* /logout has been vastly simplified. the login controller should
set session[:login_aac], and on logout it will check with that
AAC for a url to redirect to after logout, instead of /login.
SSO logout is handled by each controller if they support it
test plan:
* regression test the following functionality -
* login with canvas auth
* login with LDAP auth
* login with SAML auth - and multiple SAMLs
* login with CAS auth
* MFA (configure, using, auto-setup)
* Canvas as OAuth Provider flow
* redirects to the login page when you're not
logged in
* failure of SAML/CAS (i.e. can't find user)
show a decent error page and allows retry
* "sticky" site admin auth (site admin is CAS/SAML,
going directly to another domain logs you in with
site admin)
Change-Id: I1bb9d81a101939f812cbd5020e20749e883fdc0f
Reviewed-on: https://gerrit.instructure.com/53220
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
closes CNVS-20076
First, pull a presenter out of the AAC index
This thing needs more flexibility before introducing
multiple OAuth connectors. This commit adds a couple characterization
specs for the AAC controller, then drives out a presenter to pull
as much logic and config out of the nested views as possible.
Then, this commit refactors the
previously-somewhat-bespoke-and-presumptive sac
configuration into a workflow that shows each aac
in turn according to it's type, creating forms for
each type at the bottom, and
showing the relevant form for a new one based on
selection on the right.
Have regression tested in the browser to the level
of CRUD functionality, but also deserves solid QA
for SSO functionality post-configuration.
DONE:
-successful CAS creation/editing/deletion
-successful LDAP creation/editing/deletion
-proper differentiation between LDAP primary and secondary
-proper SAML creation/editing
-move away from "update_all" deprecated endpoint
-Selenium Spec fixes
-ensure discovery URL and debugging workflows for saml
-remove duplication from views
-tear down old JS workflow
-apply appropriate tests for new behavior
-remove presenter methods that are no longer valuable
-Moved change_password_url and login_handle_name
-up to account settings, removed them from AACs, and built
-migrations to manage the transition.
-Found and fixed all references to change_password_url on AACs
-Found and fixes all references to login_handle_name on AACs
-add datafixup for migrating AAC data to account settings
-unify repetative individual files into single form delcarations \o/
-remove old SAML editing js
-Make sure SAML still works
-Make LDAP partial flow just like SAML/CAS
-Unify position information across all types
-update "acts_as_list" to support STI classes
-move discovery URL into account auth form
-remove discover URL js management
-Unify form generation between new/existing aacs
-deprecate discovery url API endpoints
-update docs for authorization settings to deprecate their usage in AAC
api and redirect their values to current settings for now
-make delete links non-js-y to stop this silly page refresh on api
completion
-make form submissions actually submit the form rather than do this silly
page refresh on api completion
-See if anything needs “Edit Details” button, remove if not
-Wire up removing account settings by blanking out form
-Removed "cancel" button from form because fields are always open
-placate gergich
-Test removing config info
-Test population fixup on real data
-write docs for authorization settings
-fix existing specs
-fix routing and docs to not break doc generation
-fix stupid jenkins task that thinks it can’t see controls
-re-fix selenium
-fix saml debugging workflow
-write tests for acts_as_list behavior
-write tests for authorization settings
-remove auth_info types of things
-clean up and unify styles where possible
TEST PLAN:
Regression test creating/deleting/editing and logging
in with SSO solutions for CAS, LDAP, and SAML.
Should be no functional behavior modification, though
workflow will be a little more unified between the
3 currently supported types (each one will
require using the menu in the right sidebar
to add a new AAC).
Also test setting and deleting account settings through
the form underneath the configs when there are AACs in existence.
Finally, make sure that the SAML Debugging workflow still works.
Change-Id: I448db10185512d1b9469c2a425be0a3bcf9e6ebf
Reviewed-on: https://gerrit.instructure.com/53448
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
In module based courses, to make it easier for students to keep
track of their progress. This commit adds support for 'mark as
done' requirements to the module progressions. This to better
cater to students who needs multiple reading sessions before they
feel they are done with a module item (i.e wiki pages).
This requirement can also be used on assignments that are purely
for self studying.
Test plan:
- In a course with modules
- Make sure there is one wiki page and one assignment associated with a module
- Add 'mark as done' as module completion requirements to both module items
- As a student of the course, go to the modules page
- Oberve that both module items are labeled as "must mark as done"
- Visit the module items each in turn and click the "mark as done" button.
- On the modules page, oberve that both module items are now labeled as "marked done".
This just chagnes the label on our new nav ui to say
Profile instead of Settings.
Test Plan
- No changes to legacy ui
Change-Id: I546e6510bcbb9400f1368c479d4c29b3b38e2d5d
Reviewed-on: https://gerrit.instructure.com/53496
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Chris Hart <chart@instructure.com>
Tested-by: Jenkins
fixes:
CNVS-17905
CNVS-19188
CNVS-19185
CNVS-19191
CNVS-19197
CNVS-19187
CNVS-19189
This commit adds HTML/CSS that will serve as the
foundation for the new Canvas navigation and the foundation for
a responsive Canvas UI. It is this base structure we need to
continue to add the rest of the new UI features which include:
- Subnavigation panel
- Avatar in navigation (user sub-navigation)
- Sub-page revisions to bring in new ui
to them (there's a list of these)
ALL these changes are hidden behind the use_new_styles
flag, which no customers have turned on. In order to see them you
will need to turn on the feature flag.
THIS commit should NOT impact either the legacy or
k-12 UIs.
QA Test Plan:
Because this is a large feature to build out,
we are planning to merge it in manageable chunks.
As the feature is not finished yet, this
commit needs only to be tested to make sure it
hasn't broken the current Canvas navigation.
- Make sure the Use New Styles feature flag is off
in the admin settings.
- Click every link in the current Canvas primary
and secondary navigation and make sure everything
still works and looks the same as it does on master.
Change-Id: I082aa0f4db6de143b4d9d4f193ca925de9716589
Reviewed-on: https://gerrit.instructure.com/52131
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Jenkins
Product-Review: Colleen Palmer <colleen@instructure.com>
Reviewed-by: Chris Hart <chart@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
fixes CNVS-12764
test plan
- ensure that the todo list does not promise to ignore things
forever
Change-Id: I8cf4cfe3494e82e208a59170ace25e36768d99cd
Reviewed-on: https://gerrit.instructure.com/51391
Tested-by: Jenkins
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
hides the edit and delete links on the rubrics page showing on an
imported outcome that cannot be edited
fixes CNVS-16829
test plan:
- make a course level outcome
- make a course level rubric
- click "find a outcome" on the rubric page
- import outcome into rubric
- notice no edit/delete links on the outcome section
of the rubric
- save the rubric
- the links should still be hidden
Change-Id: I76859b664c224aaf13958a4a2529b3da48750398
Reviewed-on: https://gerrit.instructure.com/49722
Tested-by: Jenkins
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-19809
test plan:
- go to root account recent activity page
- navigate to one of the course links under the recent activity streams
- link should read out "(activity stream type) for (course)"
Change-Id: I5141aaeaf0c7867ec8201a35d2ab7ae3b7084861
Reviewed-on: https://gerrit.instructure.com/52147
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Matt Berns <mberns@instructure.com>
test plan:
* create a wiki page with a name with several
capital letters together (e.g. "FAQs")
* when editing/creating future html content,
the link to the previous page in the wiki sidebar
should match the title (e.g. "FAQs" and not "Fa Qs")
closes #CNVS-1593
Change-Id: I37a93c0a0f3f89608796de85f2ea1e1f88e2319e
Reviewed-on: https://gerrit.instructure.com/51204
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Exchanges ::before labeling for <label> labeling for an input element in
the rubric editing dialog on quiz editing.
Closes CNVS-19226
Test-Plan:
- Confirm presence of "Title:" label
- Confirm "Title:" is in bold.
- Confirm that SR picks up label tag for "Some Rubric" input element
Change-Id: Ibcec54484f948f10c04c57864113190fa59da5c9
Reviewed-on: https://gerrit.instructure.com/50781
Tested-by: Jenkins
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
Closes CNVS-19227
Test Plan:
- Confirm that "Description of criterion" in "add criterion" option in
Quiz Edit Show Rubric modal is read properly by SR.
Change-Id: Ib8fb08a42a14bedef7b8892337704db2ade935b6
Reviewed-on: https://gerrit.instructure.com/50788
Tested-by: Jenkins
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
Fixes CNVS-19267
Test plan:
- Visit /accounts/N as an admin.
- Using a screen reader verify that Find a Course and Find A User both have
labels associated.
Change-Id: I9439321ed903e9f1a8aa2b68c9c25fc1c6c1b802
Reviewed-on: https://gerrit.instructure.com/50330
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
fixes CNVS-19205
Test Plan:
- Add a submission to a course that needs grading.
- As a teacher of the course go to your dashboard
- In the to do list, use a SR to access the menu that
pops up with the Ignore "X".
- You should be able to navigate it without problem
- The same behavior should occur from the course
home page.
- For keyboard only, focus should go to the previous
ignore "X" if it is there.
- If a previous ignore "X" isn't available, it should
go to the view calendar link.
Change-Id: I8e8297dc41ac8af69131ef748f25f169541c2958
Reviewed-on: https://gerrit.instructure.com/50278
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
test plan:
* as a teacher, start a long-running web conference
* visit the course dashboard
* should be able to close the conference from the dashboard
without being sent to a json page
closes #CNVS-1634
Change-Id: I9253880599b3c1da7eee32ea1776fa36d4b9bbc8
Reviewed-on: https://gerrit.instructure.com/49706
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Converts the "Add File" portion of the "Add Module Item" dialog
into a React component. It also sets up a Folder and File store
for interacting with the API. It also modifies the behavior
so that folders that do not contain any files are not shown in
the select box.
fixes CNVS-13036
closes CNVS-18302
Test Plan:
- Go to the modules page in a course that has some files.
- Add a file to a module via the file menu.
- Create 200+ folders with at least one file in each.
You can import and expand this zip to make this a lot easier:
http://goo.gl/lNtfx5
- All files should be visible.
- Create another folder, with no files within it.
- That folder should not be visible.
Change-Id: I93e520135acb66bd821b3d19cc387eec59b347c7
Reviewed-on: https://gerrit.instructure.com/49028
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
test plan:
* enable avatars on the root account,
* create a course with multiple students
* a student should be able to look at the
course profile of another user in the course
and report their avatar
* when reported, should be able to be seen by
account admins at "/accounts/X/avatars"
* should work with profiles enabled or disabled
closes #CNVS-13849 #CNVS-4781
Change-Id: I97f62ca709321233c8a57cd6f1bd9870dc50d215
Reviewed-on: https://gerrit.instructure.com/49781
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
test plan:
* create a course
* create a page, allowing "Teachers and students"
to edit the page
* as a student, should be able to edit the page,
but should not be able to link to new pages in
the wiki sidebar
* edit the settings to allow "Teachers and Students"
to "create, rename and edit course wiki pages"
* as a student, should be able to link to new pages
* should also be able to follow the links and
create the new pages there
closes #CNVS-18825
Change-Id: If272218522e36310edf95fe77fe3b8af03456725
Reviewed-on: https://gerrit.instructure.com/49678
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Fixes CNVS-16148
Test plan:
Setup:
1. As a teacher, Create & publish 5 assignments, due within the next week, submission type “Online” and “Text Entry”
2. As a student, submit all 5 assignments.
3. As the teacher, give feedback on all 5 assignments
Places to test:
1. Visit the dashboard as the teacher, see that it says “2 more in the next week” in the Coming Up section
2. Visit the course homepage as the student, and verify it says “2 more in the next week” under “Coming Up” and “2 more in the past two weeks” under “Recent Feedback”
3. Verify you see the same on the student’s dashboard
Change-Id: I46c62c4f705c05d6bddd2c4a81dcdc7fee40b9cf
Reviewed-on: https://gerrit.instructure.com/48559
Reviewed-by: Joel Hough <joel@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
replace Bootstrap styles with non-broken Canvas Style Guide
test plan:
- in Account Settings, confirm the "Find a Course" and
"Find a User" boxes (comprising the edit field and the
"Go" button) operate, and are the correct width
(look on Setting, Sub-Accounts, Courses, and Users tabs)
fixes CNVS-18377
Change-Id: I348180e196d5bcdb4d9fd5758efacaf8ae807650
Reviewed-on: https://gerrit.instructure.com/48592
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes: CNVS-18444
this just put whether they are k12 as part of the
cache key so we don't have to wait 15 minutes for
cache to clear.
test plan:
turn on k12 in account settings
reload
it should have blue k12 header
turn k12 off
reload
you should not have to wait 15 minutes to go
back to looking "normal" (not k12)
Change-Id: Ie7030d6df3c4cbab1d08c74d5883f54d90461e28
Reviewed-on: https://gerrit.instructure.com/48492
Reviewed-by: Chris Hart <chart@instructure.com>
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
remove the account model methods, since these don't have
access to the request IP address, which is needed for
international terms of service.
test plan:
0. enable self-enrollment in account settings
1. enable self-enrollment in a course in the account
2. register a new user using the course's self-enrollment URL
3. terms of use and privacy policy links that appear on the
"require acceptance of terms" dialog should function
(and should not take the user to another "require
acceptance of terms" dialog)
4. create a new user via the Accounts page, then click the
link in the email sent to the user to complete the registration.
the terms of use/privacy policy links that appear in the dialog
should work (as in 3). (note that you can go to
/users/<id>/messages as an admin to see this email even if
outbound email is not configured in your portal.)
closes CNVS-18025
Change-Id: Ibf19d2892c587f9e251917f70448212aac0709ad
Reviewed-on: https://gerrit.instructure.com/47607
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes: CNVS-18040
Changes what fragments are being cached so the form for logout is not
being cached.
Test Plan:
- Login to Canvas
- Click the logout link in the navigation.
- Login to Canvas again.
- Click the logout link in the navigation again.
- Should not see a page asking if you are sure you want to logout.
Change-Id: I9e1a91a11fb074525b3b0227f87c1a0a1bc53663
Reviewed-on: https://gerrit.instructure.com/47491
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Nick Cloward <ncloward@instructure.com>
James Williams