The focus indicator is implemented by having a margin to create spacing
around a 2px border that is the visual indicator. The border is
transparent until the item receives focus, when it changes to the active
font color, which adjusts for high-contrast.
fixes ADMIN-833
test plan:
- load canvas and start tabbing
> expect it to look like the designs attached to the ticket
- change to high contrast
- repeat
Change-Id: I3cd9adf5e041692dbdf2568591894ad1ee5e86b8
Reviewed-on: https://gerrit.instructure.com/143118
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
fixes COMMS-329
Test Plan
- Assign a student to a group in a course
- In that course, check the box that says
"Restrict students from viewing course after end date"
- Conclude the student or the course
- As the student, notice that "Groups" tab does not appear
in the global navigation, and navigating to "view all groups"
is for not showing groups is not a complaint anymore
- Make sure to check other edge cases where a student
may or may not have groups and have the navigation not
showing or even showing
Change-Id: I9ba4a41cd1cf74cae7b6a39cbe157f6d7dbff4fe
Reviewed-on: https://gerrit.instructure.com/139532
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Venk Natarajan <vnatarajan@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
fixes ADMIN-307
Test Plan:
- Navigate to the main navigation
- Notice it now says global
Change-Id: Idc49a5ddd33414b8ac9296138f010ea726a252cd
Reviewed-on: https://gerrit.instructure.com/130805
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
we already show all groups in the menu, just not
the menu
fixes CNVS-39650
test plan
- have a cross shard group
- you should be able to get to it from global nav
Change-Id: I2806cd78ec7079abb8967c09fe33a2eb82efd5df
Reviewed-on: https://gerrit.instructure.com/128467
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
fixes CNVS-38231
test plan
- delete an admin
- admin should be gone from every where
- admin should not have permissions to do stuff
Change-Id: I56c90a12b2be879c5d646c1ab6980693ff161673
Reviewed-on: https://gerrit.instructure.com/119220
Reviewed-by: Tyler Pickett <tpickett@instructure.com>
Tested-by: Rob Orton <rob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Fixes: CNVS-35473
Test plan:
- The global nav expand/collapse button should
no longer have the markup mentioned in the
JIRA ticket
- The button should work as it did before
Change-Id: Ibc9a22e946d7ae1a644452ab7cad2caa7b4cc092
Reviewed-on: https://gerrit.instructure.com/105041
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
QA-Review: Dan Sasaki
Product-Review: Chris Hart <chart@instructure.com>
Fixes: CNVS-32625
Test plan:
- Clear cache
- Log into Canvas as any kind of user
- The primary nav should look and function
exactly as it did before
- Reload the page, and quickly open the Courses,
Accounts, or Groups trays (pages that load
content via the API). You should now see
the Instructure-UI spinner instead of
the panda-riding-a-bicycle GIF
Change-Id: I3edc34c3af1a26f1e86ca12d67cfb6b288c6f6ee
Reviewed-on: https://gerrit.instructure.com/92687
Tested-by: Jenkins
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
QA-Review: Pierce Arner <pierce@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
Fixes: CNVS-32624
Test plan:
- Log into Canvas as both an admin and student
- Make sure in both cases that the help link is
always positioned at the bottom of the primary
nav in the global navigation, like so:
http://screencast.com/t/tpkRgsfjC
Change-Id: I3608f8aa3a31f5ec086932aa384dbddada10c476
Reviewed-on: https://gerrit.instructure.com/92641
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Pierce Arner <pierce@instructure.com>
Fixes: CNVS-30698
Test plan:
- Clear cookies and browser cache
- Log into Canvas as any kind of user
- The primary navigation on the left of the
screen should be expanded (i.e., look just like
it usually does)
- Click the new Expand/Collapse button at the bottom
of the navigation, and the nav should contract
- If you hover or focus on the nav links, you should
now see the text appear as popovers on the right:
http://screencast.com/t/QOx3noAw24
- Once you have set the nav to expand or collapse, it
should remain that way in all pages in Canvas until
you change your preference
- The toggle button text should change based on the state of
the global navigation
- Your user preferences should persist, even if you
log out of Canvas or switch browsers
- The nav should function exactly as it did before
Change-Id: I2a5c8bb55e2c9fc6bd499266ec971676f6556105
Reviewed-on: https://gerrit.instructure.com/89358
Tested-by: Jenkins
QA-Review: Pierce Arner <pierce@instructure.com>
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
fixes CNVS-30931
The help tray should come up whenever the show_feedback_link setting is set
even if the default account has a support_url setting.
Test plan:
- Set the support_url account setting for the domain root account or the
default account.
- Set the show_feedback_link setting
- Verify that the help tray appears in the global nav
Change-Id: Id27ea4b1630afbf30ff71fbfd0854c1289915fb5
Reviewed-on: https://gerrit.instructure.com/87528
Tested-by: Jenkins
QA-Review: Pierce Arner <pierce@instructure.com>
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
closes: CNVS-30609
This moves the help link to be underneath the other links in the global
navigation, but not fixed to the bottom.
Test Plan:
- Login to Canvas
- Make sure help link is enabled
- Help should now be at the bottom of the global navigation link list
Change-Id: Id17287441f1d52b66cf22a2a871c8a6719cf391a
Reviewed-on: https://gerrit.instructure.com/86222
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Pierce Arner <pierce@instructure.com>
Refs: CNVS-28038
Test Plan:
- enable the help link in the rails console:
`Setting.set('show_feedback_link', 'true')`
- enable new ui
- verify that when you clik on the 'help' link in the global nav, the links
display in a navigation tray.
- verify that the create ticket and teacher feedback forms work fine
(within the tray).
- verify that there is no change to the 'help' dialog when launched from
the login page or the speedgrader.
- verify that there is no change to the 'help' dialog when launched with
old ui.
Change-Id: If455bc198fca89a2bf242a8230b30dc8ddfc234d
Reviewed-on: https://gerrit.instructure.com/84116
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Pierce Arner <pierce@instructure.com>
fixes CNVS-29878
Test plan:
- Visit any page on Canvas with a header
- Verify that all the buttons read as expected when tabbed to with a
screen reader.
- Verify that the landmark regions don't repeat the word "navigation".
- Verify that the screen reader does not enter forms/application mode
when pressing enter on a link inside any of the nav regions.
Change-Id: I16f32fc4fad919223dc436b8a85c077ace3262b8
Reviewed-on: https://gerrit.instructure.com/82351
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
refs CNVS-28024
refs CNVS-28025
Test plan:
Verify that there is no change to Help links across the app by default.
In the rails console run:
`Setting.set('show_feedback_link', 'true')`
Enable new ui.
Go to the settings page for the root account.
There should a section called 'Customize Help Link'.
Change the link name and select a new icon.
Click 'Update Settings'
The help icon and label in the global navigation should update.
Note that the link name should be updated on login pages and in
speed grader as well.
The settings should not appear when new ui is disabled.
Change-Id: Ic36a8f396989182446c440cd6c7d80d1fdf11b1b
Reviewed-on: https://gerrit.instructure.com/81078
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
it doesn't seem to be doing anything
Change-Id: Ie8f0b0e87676669b4df2c14849f1ec9b8a71c8f7
Reviewed-on: https://gerrit.instructure.com/74967
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Fixes: CNVS-25499
test plan:
- as an admin using the new ui
- navigate to your canvas instance
- the admin link should now display directly above the dashboard
link in the left-hand navigation
- ensure that this link does not show for a student/non-admin
Change-Id: Ie9a206228b4fdc53c5cfe70841c3afd40793e1e9
Reviewed-on: https://gerrit.instructure.com/68440
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Fixes: CNVS-25498
test plan:
- as a user using the new UI
- navigate to your dashboard
- the account link should now be located directly under the upper
-left-hand logo (was previously located last)
Change-Id: Id6b4880e28ccf88eff352fc7a5f68095d3e2cbc7
Reviewed-on: https://gerrit.instructure.com/67983
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Fixes: CNVS-24653
test plan:
- as a user with the new UI turned on - navigate to user
settings and select "use high contrast styles"
- click courses on the left-hand navigation - the upper left-hand
logo should no longer be vivible (nav now starts with dashboard)
- ensure nothing has changed with the old UI
Change-Id: Ic488735091aef53ddbc6ee622180fd6a7701c334
Reviewed-on: https://gerrit.instructure.com/66674
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
fixes CNVS-22876
Test plan:
This refactors the logic to determine whether a nav item should be
highlighted, so we should test all of the nav items.
Change-Id: I4b60d662b498ae0ee31663b123465e602643d690
Reviewed-on: https://gerrit.instructure.com/64372
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
fixes CNVS-22900
Test plan:
Verify that groups icon in global nav when new ui is enabled is not the courses icon.
Change-Id: Ie8855c61b64d708c307085995e2efdbfc9a08441
Reviewed-on: https://gerrit.instructure.com/62374
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
fixes CNVS-21915
Note: I refactored the help_link helper so we should do regression testing
around the help link in the following areas:
* Login footer
* Global nav for new UI
* Footer with legacy UI
* Speed grader
Change-Id: I7f71bb0050cab4c69546329f20cd0fa9cd30d442
Reviewed-on: https://gerrit.instructure.com/61607
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
closes: CNVS-22368
When a student only has enrollments in unpublished
courses, they do not see a courses global nav link.
The link is needed to get to "all courses" and see
their enrollments.
this changes things so the "courses" menu is always
shown. that way those users will be able to get
to that "all courses" link
Product / UX/UI review question:
This is just one possible way of fixing this problem.
the other thing we could do is to leave it how it was
but do a second, more expensive DB query to see if
there are any of those unpublished or archived courses that
I can see on the /courses page but not in the course
menu. in standup, we agreed to do it like this but
if any of you feel strongly that we should do it
the other way, that's fine too.
test plan:
Add a new user
Enroll them in an unpublished course
Masquerade as the new user,
click the courses global nav option
you should see the "all courses" link in the tray popup
Change-Id: I140dbc4f4d2852c386cc57cac3f2afec6ef62979
Reviewed-on: https://gerrit.instructure.com/60233
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Fixes: CNVS-21513
Test Plan:
- In Firefox with NVDA enabled, turn on the new UI
- Move through the global nav with NVDA
- Previously, Account and Inbox options had an extra
link announced (http://screencast.com/t/mAp9jc5tMtjO)
- Now, the Account and Inbox options should be
consistent with the ones before them (no extra
'link' is announced)
Change-Id: Ie7267a4a93680c5ea8f066b505148c1b0e42fa31
Reviewed-on: https://gerrit.instructure.com/59669
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Fixes CNVS-22039
Test plan:
- Enable the new UI
- Log in
- Ensure that 'login_success=1' is in the URL
- Ensure that the dashboard tab appears selected with a white
background
Change-Id: I4744dd4064e00146de774b10e1b86a9147025db0
Reviewed-on: https://gerrit.instructure.com/58886
Tested-by: Jenkins
Product-Review: Colleen Palmer <colleen@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Adrian Russell <arussell@instructure.com>
fixes: CNVS-21376
This adds the styles and markup we need to customize the
new ui navigation logo.
Test Plan:
- Turn on new UI
- Go to Theme Editor
- Find the navigation logo and upload a new one
- Preview new logo
- Apply new logo, navigate to canvas and make sure it's still there
- Repeat a couple of times
Change-Id: Idd221a61c7806c71ca15a5d1e82cce0e39101ba8
Reviewed-on: https://gerrit.instructure.com/56393
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
Tested-by: Jenkins
QA-Review: Pedro Fajardo <pfajardo@instructure.com>
refs: CNVS-21746
This makes it so when the k12 flag is on, we show a few different icons
in the global navigation for:
- Dashboard
- Courses
- Grades
- Inbox
- Calendar
Note: focus is on icons - background color may change based on your settings
Test Plan:
- Turn on New UI and you should see these icons:
http://cl.ly/image/0K1D031M0Y43
- Turn on k12 flag and you should see these:
http://cl.ly/image/1l232g0K2O1I
Change-Id: Ic79cdecb3b8dc83066e58fcd1c45f12422c56f17
Reviewed-on: https://gerrit.instructure.com/58135
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Tested-by: Jenkins
Refs: CNVS-19258
This updates the masquerading and student view
fixed-bottom alerts to match Blake's mockup for
the New UI (Blake has approved screenshots of
this ticket).
NOTE: Because this involved a lot of shifting
markup around to get to the new mockup, I had
to make this change affect BOTH the new and
old UIs.
For masquerading:
- Go to Admin > Site Admin > Users
- Choose a user, and click the tiny "Become" link
- For the new UI, masquerading should now look like
this:
http://screencast.com/t/7iG8rMjwh00P (tablet - desktop)
http://screencast.com/t/jxrp5yxL (wide screens)
- For the old UI, masquerading should now look like
this:
http://screencast.com/t/uw8agxcf (all screen sizes)
For student view:
- Go to any course > Settings
- Click the Student View button on the right-hand menu
- For the new UI, student view should look like this:
http://screencast.com/t/SBT6IOnjAgN (tablet - desktop)
http://screencast.com/t/zLZS7cRtpkt (wide screens)
- For the old UI, student view should look like this:
http://screencast.com/t/SBT6IOnjAgN (all screens)
Change-Id: I0730a3225eed6b5d42fbb65e8c715ecdfa591d6c
Reviewed-on: https://gerrit.instructure.com/57212
Product-Review: Colleen Palmer <colleen@instructure.com>
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Pedro Fajardo <pfajardo@instructure.com>
fixes: CNVS-20551
This adds the final UX polish to bring it up to par with what UX wants
theme editor to look like. This fixes the ui for the theme editor ui
when you upload an image. It also tweaks the Windows logo upload and
the tile color helper text.
Please take a look at this screen for comparison:
http://cl.ly/image/2q1g1Q0R3C3t
Test Plan:
- In new UI go to theme editor
(Account Settings > Open Editor)
- The theme editor UI should now resemble the above screenshot
Change-Id: I986504edcddd84f6954916a71f1618c28ed94699
Reviewed-on: https://gerrit.instructure.com/56392
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Small wording tweaks requested by UI team to
primary navigation in new UI.
Fixes: CNVS-21363
Test Plan:
- Make sure that the Use New Styles flag is
turned ON.
- On the main navigation, underneath the profile
pic, it should now read "Account" (not Profile).
- The title of the tray that slides out when you
click on Account should now be "Account"
- On the main navigation, the Accounts link has
been renamed "Admin"
- The title of the tray that slides out when you
click on Admin should now be "Admin"
- Click on the Courses link on the main navigation.
The "All courses" link on the tray should now
have a gray border on top of it.
Change-Id: I6693f507ca6d75608aeed8c454ed008e3d24d187
Reviewed-on: https://gerrit.instructure.com/56944
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
fixes CNVS-21039
This adds the dashboard icon to the global navigation.
Test Plan:
- Turn on new UI
- In the global nav there should be a dashboard icon that brings you to your
dashboard
- If you navigate away from dashboard it will no longer have an active state
- Turn off new UI
- There should not be a dashboard link anywhere in the global navigaition
- Turn on k12
- There should not be a dashboard link anywhere in the global navigation
(because it's based off legacy ui)
Change-Id: I07083bf656b345e4889769e61cc829588d4c3455
Reviewed-on: https://gerrit.instructure.com/56200
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Robert Lamb <rlamb@instructure.com>
Essentially links everything up with jQuery events so that the
awesomeness of the tray still occurs, but it doesn't reload everything
with React causing a flash, and we don't end up having to maintain
the same stuff in two places.
closes CNVS-21015
Test Plan:
- Enable new styles
- Global nav should function as expected meaning:
- Courses/Accounts/Groups only show if the user has those
- Clicking one of those pops out a tray listing them
- The Profile tray pops out as expected
- On public facing pages logged out users should see a
Login button rather than a Profile button.
- This commit does not get global LTI links such as Commons
working, that happens in another commit.
Change-Id: I66f925d46e78e79be4a25546a8d2967aa5eeb8e2
Reviewed-on: https://gerrit.instructure.com/56046
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
This fixes a few places so that requests aren't sent off from the
login screen. This also gives the navigation header a login button
to use when certain pages are open for public access.
Test Plan:
- The login screen of canvas should work without throwing
any JavaScript errors (warnings are just fine)
- When going to a page with public access allowed, you should see
a "Login" menu item
Change-Id: I68729c7241babab47cde9a57fb67f94ec9cf0c99
Reviewed-on: https://gerrit.instructure.com/55852
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Makes it so that the global nav is rendered in a 'static' form by
the server via application.html.erb but is then replaced by the React
component once JavaScript has come onto the page.
It also makes it so the API calls don't take place until the
relevant button on the sidebar is hovered over.
closes CNVS-19257
closes CNVS-19199
closes CNVS-18822
closes CNVS-17911
closes CNVS-18489
closes CNVS-18351
closes CNVS-20214
closes CNVS-20507
Test Plan:
- You should see a server rendered version of the bar on the page
- It should be rendered by React once JS loads
- Hovering over the courses/groups/accounts should cause an API
call the first time.
- Courses/Groups/Accounts should only show if the user you are using
has access to those things.
- Make sure the help link opens up the normal help modal.
- When on the courses page make sure at smaller resolutions that the
hamburger menu successfully opens and closes.
- If Commons is enabled, that link should show in the global nav.
- The active link should show as being highlighted white.
* Please also test this with multiple screen sizes (tablets/desktop).
It should be responsive
Change-Id: If27c9f07e6eea662909790fb09d6ada254b8009c
Reviewed-on: https://gerrit.instructure.com/54703
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Ed Schiebel