closes OUT-2244
Test plan
- enable "Rubric Criterion Range" and "Non-scoring Rubrics"
at the account level.
- from the assignments page, add a rubric and set a criterion
to use range ratings
- click "Remove scores from rubric"
- verify that range option is hidden and points are hidden
- save rubric
- verify that range points are still hidden
- reload rubric
- verify display and editing again
- uncheck "Remove scores from rubric" to verify that original
status of range ratings unchanged.
Change-Id: I67f434d9ebcf8ef8c19abc4fc48f0effd9c31769
Reviewed-on: https://gerrit.instructure.com/150706
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Reviewed-by: Matt Berns <mberns@instructure.com>
Tested-by: Jenkins
QA-Review: Andrew Porter <hporter-c@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
feature flagged as development-only
adds "Don't show Outcomes results" checkbox
closes OUT-2132
Test plan:
On the assignments show page
and discussions edit page:
- Ensure the non-scoring rubrics feature flag is
off
- Spot check that no non-scoring behavior is apparent
and that rubrics are edited and saved as normal
- Enable the non-scoring rubrics feature flag
(note that due to caching you may need to wait
for the feature to be truly enabled)
- Verify that choosing "Remove points from rubric"
removes all references to points -- existing ratings,
outcome thresholds, creating new ratings, point totals,
points column, etc.
- Choose update rubric, verify that no points are shown
in the view of the rubric
- Reload page, verify that no points are shown in the view
of the rubric
- Edit rubric and uncheck "Remove points...". Verify that
points are returned in all locations
- Verify that edit and view modes for a rubric do not show
points when using a screenreader and "Remove points..."
is set
- Verify that "Don't show outcome results" is persistent
but otherwise has no effect
On manage rubrics page:
- Spot check that no non-scoring behavior is apparent
Change-Id: Ifa72e127f26936221304afcd6530c1d8f1a6ac3b
Reviewed-on: https://gerrit.instructure.com/149622
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Tested-by: Jenkins
QA-Review: Andrew Porter <hporter-c@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
fixes OUT-2183
fixes OUT-2187
test plan:
- create two rubrics - on one rubric, create 3 or more criteria,
with at least two criteria utlizing rubric ranges (if you do not
see option for range, you'll need to enable "Rubric Criterion
Range" feature on the account).
- on the other rubric, utlize 5 criteria with the following setup:
3 criteria with a scale of 20/15/10/5/0
2 criteria with a scale of 20/10/5
- attach the rubrics to two different assignments
- as a student, submit to the assignments
- as a teacher, provide scores on the rubrics. On the first one
with the range, ensure that the 2 (or more) range criteria have
different point totals given to them
- on the second rubric, provide a range of points (20, 15, 10, 5, 0)
- as the student, view the grades
- first visit the submission show page. Both rubrics should have their
proper areas highlighted per the scores on the criteria
- visit the student's grades page and expand the rubrics - they both
should have their proper levels highlighted there as well. All
highlights on this page should match the highlights shown on
the submission's show page
Change-Id: I902f5d80285a3c4ef9d55e5d247c4b9f596ca04a
Reviewed-on: https://gerrit.instructure.com/148640
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Tested-by: Jenkins
QA-Review: Dariusz Dzien <ddzien@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
fixes a bug where a nil assessment rating points would cause
the page to error
closes OUT-2174
Test Plan:
1. Create an assignment with a rubric and grade a student with
a nil assessment rating.
2. Go to the student grades page for that student and verify it
loads.
Change-Id: I750b37fc50b7b9db89e9348194910ffd7193b4e3
Reviewed-on: https://gerrit.instructure.com/147737
Reviewed-by: Gentry Beckmann <gbeckmann@instructure.com>
QA-Review: Gentry Beckmann <gbeckmann@instructure.com>
Tested-by: Jenkins
Product-Review: Keith T. Garner <kgarner@instructure.com>
fixes OUT-2051
test plan:
- go to account settings and ensure the "Allow Outcome Extra
Credit" flag is set to "off"
- have at least two outcomes in a course
- create a rubric, align two outcomes, and create a regular
non-outcome criterion
- attach the rubric to an assignment
- as a student, submit to the assignment
- enable voiceover
- as a teacher, go to speedgrader and attempt to give more than
the maximum possible score on one outcome - a flash warning
should appear notifying the user that the outcome's score
has changed, and the alert should be audible to voiceover
- attempt to give all three criterion scores over their maximum
- both outcomes should have alerts that are read out, the normal
criterion should not be altered
- go to the submission show page
- repeat the above steps and ensure proper alerts are presented,
and that they're audible to voiceover
Change-Id: I1c8bb5c4a9d097ef5825fb5a27d515175cd64a39
Reviewed-on: https://gerrit.instructure.com/146036
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Tested-by: Jenkins
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
QA-Review: Dariusz Dzien <ddzien@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
Closes: CORE-1243
These are all the places that we are using in line styles that w
ould be affected in right to left. This change does absolutely nothing
to our existing left to right CSS it just flips it in right to left.
Test plan:
Because this change does not change anything for our left-to-right users
We can safely merge it without having to manually check these pages
Just likewe did With the other automated CSS changes
Change-Id: I62841f4b47925b4d9594c3ca914fa3e5d53fd7b0
Reviewed-on: https://gerrit.instructure.com/145447
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
fixes OUT-1657
test plan:
- create two assignments
- attach a rubric to each assignment, make one rubric standard
and the other rubric use a range (if you do not see option for
range, you'll need to enable "Rubric Criterion Range" feature
on the account). Use multiple criteria for each rubric
- as a student, submit to the assignments
- as a teacher, provide scores on the rubric. for the ranged
rubric, provide a score that falls between ranges
- as the student, go to the submission show pages and click
'show rubric' - the proper rating should be highlighted
for each criterion
- as a student, go to the grades page
- next to the assignments, click on the icon to show the rubric
- the proper rating should be highlighted for each criterion
Change-Id: I035d1853a11ac01cd972a76ea2c41cbb332000c5
Reviewed-on: https://gerrit.instructure.com/144859
Tested-by: Jenkins
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
QA-Review: Dariusz Dzien <ddzien@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
Closes ADMIN-634
Test Plan:
* As an admin
* With the student planner feature flag disabled
* Set the account's Default Dashboard View setting to 'activity'
* Masquerade as a newly created user in that account
* View their dashboard
* It should match the account's setting
* Repeat the process above, but enable the student planner feature
flag and make sure the new user for testing the
dashboard is a student
* It should still work as above
Change-Id: Ic9a99c5710ac0eeca22afaf4a5c76f3c542ce65f
Reviewed-on: https://gerrit.instructure.com/138160
Reviewed-by: Mysti Sadler <mysti@instructure.com>
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Christi Wruck
UIDEV-179
test plan:
- ensure the icon + view calendar text is showing on the
right side bar of dashboard
- example view: https://screencast.com/t/6nWQDLikx6YZ
Change-Id: I5f7f9594f2d1a4c74aef3dee216610605162df31
Reviewed-on: https://gerrit.instructure.com/144851
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
(So it flips in RTL)
Test plan:
* these pages should still look exactly as they did before for LTR users
* they should look right for RTL users too though now
Change-Id: I3c9698a29bfc247f8a74da34df6eb835c73286e7
Reviewed-on: https://gerrit.instructure.com/144092
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes: CORE-1171
I split all the changes to do RTL into 2 commits. This one
contains all of the things that actually change css or javascript.
That way, the test plan on the other, with much more changes to source
code, can be to simply verify that the generated css output is exactly
the same as it was before for all of our existing CSS files, and that
it only changes things for the RTL set of stylesheets.
test plan:
* absolutely nothing should change for anyone that doesn't have
the RTL feature flag(s) turned on.
* turn on the RTL feature flag.
* these changes should make it so stuff looks better in RTL,
(you'll need to also checkout the following commit to see *all* of the
RTL changes)
Change-Id: Ic24ec8dae454709d40f27c2aec80a40ff81c8ef0
Reviewed-on: https://gerrit.instructure.com/143971
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
The focus indicator is implemented by having a margin to create spacing
around a 2px border that is the visual indicator. The border is
transparent until the item receives focus, when it changes to the active
font color, which adjusts for high-contrast.
fixes ADMIN-833
test plan:
- load canvas and start tabbing
> expect it to look like the designs attached to the ticket
- change to high contrast
- repeat
Change-Id: I3cd9adf5e041692dbdf2568591894ad1ee5e86b8
Reviewed-on: https://gerrit.instructure.com/143118
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
For letter grade assignments and discussion topics, the default grading
scheme is now 1. the course grading scheme, if it is using one, or 2.
the Canvas default grading scheme. Previously, the default grading
scheme for letter grade assignments and discussion topics was always
the Canvas default grading scheme.
closes GRADE-914
refs CNVS-15228
Test Plan 1: Assignments
1. Set up a course that is NOT using a grading scheme.
2. Create a new assignment, and verify the default Grading Scheme when
choosing 'Letter Grade' is the Canvas Default (A -> F).
3. Go to the New Gradebook and verify you can enter grades in the
submission cells and Grade Details Tray input according to the
Canvas default Grading Scheme rules (i.e. you can enter 'A' or 'B' or
'C', etc.)
4. Go to edit the assignment, and verify when you click 'Letter Grade'
the Canvas Default Grading Scheme is shown.
5. Create a new custom grading scheme at courses/:id/grading_standards.
I'll create one that looks like 'Hi' -> 100 to 94%, 'Bye' -> < 94 to
0%.
6. At the course settings page, check the box next to 'Enable course
grading scheme' and select the custom scheme created in step 5.
Click 'Update Course Details' at the bottom of the page.
7. Create a new assignment, and verify the default Grading Scheme when
choosing 'Letter Grade' is the custom scheme.
8. Go to the New Gradebook and verify you can enter grades in the
submission cells and Grade Details Tray input according to the
custom grading scheme rules (i.e. you can enter 'Hi' or 'Bye', but
entering 'A' or 'B' shows an invalid input error).
9. Go to edit the assignment, and verify when you click 'Letter Grade'
the custom grading scheme is shown.
Test Plan 2: Graded Discussion Topics
1. Set up a course that is NOT using a grading scheme.
2. Create a new graded discussion topic, and verify the default Grading
Scheme when choosing 'Letter Grade' is the Canvas Default (A -> F).
3. Go to the New Gradebook and verify you can enter grades in the
submission cells and Grade Details Tray input according to the
Canvas default Grading Scheme rules (i.e. you can enter 'A' or 'B' or
'C', etc.)
4. Go to edit the discussion topic, and verify when you click
'Letter Grade' the Canvas Default Grading Scheme is shown.
5. Create a new custom grading scheme at courses/:id/grading_standards.
I'll create one that looks like 'Hi' -> 100 to 94%, 'Bye' -> < 94 to
0%.
6. At the course settings page, check the box next to 'Enable course
grading scheme' and select the custom scheme created in step 5.
Click 'Update Course Details' at the bottom of the page.
7. Create a new graded discussion topic, and verify the default Grading
Scheme when choosing 'Letter Grade' is the custom scheme.
8. Go to the New Gradebook and verify you can enter grades in the
submission cells and Grade Details Tray input according to the
custom grading scheme rules (i.e. you can enter 'Hi' or 'Bye', but
entering 'A' or 'B' shows an invalid input error).
9. Go to edit the discussion topic, and verify when you click
'Letter Grade' the custom grading scheme is shown.
Change-Id: I0b7a7bd1f18a506be83a923a421a45e96d129c96
Reviewed-on: https://gerrit.instructure.com/142105
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
Tested-by: Jenkins
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
Fixes: UIDEV-163
test plan:
- navigate to the dashboard
- within the right side bar ... next to the "Coming Up" text
the calendar link has been removed (compare to screenshots
on the ticket for comparison)
Change-Id: Ica6f50a956bb0a4a763129859f5bec685343235f
Reviewed-on: https://gerrit.instructure.com/140970
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Mary Jane Anderson <manderson@instructure.com>
fixes ADMIN-574
Test plan
- Ensure only the API calls for the current
dashboard are called on page load
- Ensure each dashboard can properly load
when you select a new one
- Ensure that if you turn off the to do feature
that after the setting has saved properly (it
takes a few seconds) that the option disappears
from the drop down and the view changes to card
view if list view was selected
- Load up the planner dashboard and then switch to
another dashboard and ensure API calls are NOT made
to load future or past items for the planner when
scrolling
Change-Id: Ibb5f640440179a667a128993a6effd3f898e8465
Reviewed-on: https://gerrit.instructure.com/138566
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
(it is already blocked in User#avatar_image= but the UI appears
to let you change it anyhow, only for your change to disappear
upon reloading the page)
test plan:
- as a student, set an avatar image
- as an admin, lock the student's avatar image
- the student should no longer be able to click on their
avatar image on their profile page to try to change it
(/profile or /profile/settings)
- the non-clickable profile link should no longer
contain a screenreader-only span saying
"click to change profile picture for X"
and should not be read as clickable by a SR
- when viewing a student's profile in /courses/X/users/Y,
and there is a flag icon on the profile, the
screenreader text should say "click to report"
instead of "click to edit"
closes ADMIN-697
Change-Id: I8cfe4ee45cc467dd76df633eee9d1202837da2fb
Reviewed-on: https://gerrit.instructure.com/139598
Tested-by: Jenkins
Reviewed-by: Mysti Sadler <mysti@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
test plan:
- associate a rubric with an assignment
- check the "hide score total..." option in the rubric
association
- submit the assignment as a student
- assess the submission on the rubric as a teacher
- view the submission as a student, and click "View Rubric"
- the score total should not be shown at the bottom
fixes OUT-1925
Change-Id: I0b357bbc37ccf7eae410930811a44832db03527a
Reviewed-on: https://gerrit.instructure.com/139760
Reviewed-by: Mysti Sadler <mysti@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
QA-Review: Andrew Porter <hporter-c@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Changes 'Updated Terms of Service' to 'Acceptable Use Policy'.
Fixes COMMS-837
Test Plan:
- Create a new user
- Login as new user
- On the first login, notice the modal says 'Acceptable Use Policy'
instead of 'Updated Terms of Service'
Change-Id: I35bd5ed261f987784812fc0ff2f204382b6eea2b
Reviewed-on: https://gerrit.instructure.com/140038
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
QA-Review: Venk Natarajan <vnatarajan@instructure.com>
Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
fixes COMMS-329
Test Plan
- Assign a student to a group in a course
- In that course, check the box that says
"Restrict students from viewing course after end date"
- Conclude the student or the course
- As the student, notice that "Groups" tab does not appear
in the global navigation, and navigating to "view all groups"
is for not showing groups is not a complaint anymore
- Make sure to check other edge cases where a student
may or may not have groups and have the navigation not
showing or even showing
Change-Id: I9ba4a41cd1cf74cae7b6a39cbe157f6d7dbff4fe
Reviewed-on: https://gerrit.instructure.com/139532
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Venk Natarajan <vnatarajan@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
fixes OUT-1874
test plan:
- as a teacher, create an assignment and outcome. ensure
to include a description for the outcome
- create a rubric for the assignment, adding a regular
criterion and the outcome criterion
- add a long description for the regular criterion
- when viewing the rubric on the assignment show page,
the regular criterion should show the full text of
the long description, the outcome should show a link
to view longer description
- as a student, submit to the assignment
- as the teacher, go into speedgrader
- click on 'View Rubric'
- both the regular criterion and the outcome should show
the 'view longer description' link, rather than the full
long description text
Change-Id: Ia8580db202934f65706a90a4ab1ed8cf9c4546e2
Reviewed-on: https://gerrit.instructure.com/138680
Tested-by: Jenkins
Reviewed-by: Frank Murphy <fmurphy@instructure.com>
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
QA-Review: Leo Abner <rabner@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
fixes: UIDEV-154
Test plan:
- Go to a Module in Canvas and add a file to it
- The modal window where you select a resource type to
add to the Module should now show a paperclip icon
when you select `File`
- The attached file should now be represented by
a paperclip icon on the left side of the Module's
item group
Change-Id: I32c9d0b29742fec078ab3cb0b3ca58b2d1a2c8fc
Reviewed-on: https://gerrit.instructure.com/137157
Tested-by: Jenkins
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
fixes OUT-1724
test plan:
- have an assignment with a rubric that has free-form
comments enabled
- go into speedgrader
- leave a comment with '%' symbol on a criterion and
check off the 'save this comment for future use'
box, then save the rubric
- re-open the rubric, leave another comment with no
'%' check off the 'save this comment...' box and
save
- re-open the rubric and select your original
comment with the '%', it should load into the
comment box as expected
- save and ensure it persists
- switch back to the other comment and save again
- reload the page
- re-select your comment with the '%', it should
still work as expected
- attempt to save various other comments using the
above process, passing various special characters,
such as RTF apostrophes and urls
- all should work as expected
Change-Id: Iad3e66d02f827db1286247910d5b4a658b82347a
Reviewed-on: https://gerrit.instructure.com/135890
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Tested-by: Jenkins
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
QA-Review: Leo Abner <rabner@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
fixes COMMS-547 COMMS-505
Test with this commit
https://gerrit.instructure.com/135165
Test Plan
* Setup Betterchat as an LTI tool using the README in chew-the-fat
* Go to chat screen and make sure regular chat launches correctly
* Got to a page where embedded chat is visible like discussions
* Notice that betterchat will reliably launch in the bottom right
Change-Id: Iaead3695345e21c33e20e7486422a5764f586696
Reviewed-on: https://gerrit.instructure.com/135164
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
Tested-by: Jenkins
QA-Review: Venk Natarajan <vnatarajan@instructure.com>
Product-Review: Aaron Kc Hsu <ahsu@instructure.com>
Fixes: UIDEV-137
test plan:
- as a user turn on recent activty for dashboard view
- using vo, jaws, nvda... ensure the "ignore x" reads properly
so there is context as to what is being ignored
Change-Id: Ia1699ea657425b40f72176a714091475bfd3eddc
Reviewed-on: https://gerrit.instructure.com/134702
Tested-by: Jenkins
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
Fixes: UIDEV-123
Test plan:
- As a student, make an assignment submission by
submitting a file, etc.
- On the subsequent page, confirm that the header
looks as follows:
https://www.screencast.com/t/Qs1dD2VrLO
- Also check this view as a teacher/admin
Change-Id: I6f96495c4812ce6cd7f249dc883182ab258c2d90
Reviewed-on: https://gerrit.instructure.com/133971
Tested-by: Jenkins
Reviewed-by: Pam Hiett <phiett@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
Fixes: UIDEV-126
test plan:
- as a user, navigate to the dashboard
- from the cog dropdwon select "recent activity"
- click the "show more" and the line items should have an "X" at
the end of each row (this is now using "icon-x" vs a typed "x")
example: https://screencast.com/t/vJAilWeWdwpY
Change-Id: I2b24a154e6544de3a9bf9d672d98d582f6eba9db
Reviewed-on: https://gerrit.instructure.com/133835
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
test plan:
- attach a rubric to an assignment
- on the assignment page, edit the rubric and uncheck
"Hide score total". the score total should disappear.
- click "Update rubric" and then reload the page
- edit the rubric again
- the point total should still be hidden, but the
"+ Criterion" and "Find Outcome" buttons should still
be visible
fixes OUT-1683
Change-Id: Ia9168c27f1298c88953653ecaca78eb87d916dc6
Reviewed-on: https://gerrit.instructure.com/133263
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Leo Abner <rabner@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes OUT-1581
this refers to the SR only text that notifies blind users
that a criterion is aligned to a learning outcome
test plan:
- create or have some outcomes in a class
- go to an assignment edit page and add a rubric
- using a SR, confirm the default criterion does not
contain SR only text stating it's aligned to an outcome
(it should be located near the description element when
scrolling through w/ right/left arrows
- import an outcome to the rubric - before saving, confirm
that the SR only text is present in this criterion row
- save the rubric
- confirm again that the outcome readout only happens in the
proper criterion
- reload the page and confirm once more
- go to speedgrader and provide a grade to the assignment.
- when using a SR to move through the rubric summary, confirm
that the SR only text reads out on the proper criterion
Change-Id: I3e4af7961ca3f634738b61d8f216c5664b3a503f
Reviewed-on: https://gerrit.instructure.com/130043
Tested-by: Jenkins
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Andrew Porter <hporter-c@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
fixes COMMS-251
Test Plan:
- Jenkins passes
- change custom terms
- with passive terms turned off
relogin.
- notice the links are aligned and the wording
changed
Change-Id: Ibcecc33213c62f5c2d2a1d2f95594b7b05771559
Reviewed-on: https://gerrit.instructure.com/131817
Tested-by: Jenkins
Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Closes: CORE-370
See this for why:
https://mathiasbynens.github.io/rel-noopener/
Test plan:
* click on these links.
* in the dev console for the newly created tab, type:
opener.location = 'https://mathiasbynens.github.io/rel-noopener/#hax'
* go back to the opening tab
* it should not show a message that you’ve been hacked and should
Still be on the same page that was there before
Change-Id: I35972ed79a4be1c9f30dd76e2cb6712b2fbc6163
Reviewed-on: https://gerrit.instructure.com/130847
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Fixes: PFS-8619, PFS-8993
Test Plan:
Verify:
1. When adding a new criterion - Edit Criterion
dialog opens on the new criterion.
2. When adding a new rubric, an initial criterion
is created with the default, 'Description of
Criterion' description.
3. When clicking to edit a criterion, dialog
opens with two editable textareas -
description, and long description.
4. In dialog, "description" and "long
"description" are appropriately labeled
for a11y.
5. On dialog submission control should return
to "edit criterion" link.
6. When canceling a new criterion (clicking
cancel in dialog after clicking add
criterion), control should return to
"add criterion" control for a11y.
7. Criterion edit should be styled similarly
to rating edit dialog, with a 5px gap between
the label and the textbox components.
View should be verified in both rubrics page
(account/rubrics or course/rubrics)
and in assignment page (add rubric to assignment)
Change-Id: Id2133513c6ea7aa1b9b0f1312088f2409a1d3321
Reviewed-on: https://gerrit.instructure.com/127984
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Aiona Hernandez <ahernandez@instructure.com>
QA-Review: Andrew Porter <hporter-c@instructure.com>
Tested-by: Jenkins
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
fixes ADMIN-307
Test Plan:
- Navigate to the main navigation
- Notice it now says global
Change-Id: Idc49a5ddd33414b8ac9296138f010ea726a252cd
Reviewed-on: https://gerrit.instructure.com/130805
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
Fixes: PFS-8611
Test Plan:
For new rubrics and existing rubrics,
verify:
1. Clicking "Find Outcome" should function
as before.
2. Clicking "+ Criterion" should bring up a
popover menu.
a) Clicking "New Criterion"
should function as before.
b) The duplicate sub-menu should be
populated with all criterions in
menu.
c) Clicking on a criterion to duplicate
should add that criterion again to the
bottom of the rubric. Learning outcomes
should not be editable, but should be
deletable.
3. Add a criterion to the rubric. The new
criterion should appear in the pop-over
menu when you click "+ criterion".
4. Delete a criterion. The deleted criterion
should no longer be available to duplicate.
5. Edit a criterion description. The edited
description should now appear as the name
of the criterion in the duplicate menu.
6. Try a really long description. The description
should be truncated before it causes the
popover menu items to misalign or push to
a second row.
Change-Id: Id47b6ec218096a9f158a70e9a5a3c8eefc577614
Reviewed-on: https://gerrit.instructure.com/126509
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Aiona Hernandez <ahernandez@instructure.com>
QA-Review: Andrew Porter <hporter-c@instructure.com>
Tested-by: Jenkins
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
refs COMMS-166 COMMS-173 COMMS-168
Test Plan
* Invite a brand new User
* Use register link to go the page
* Notice only active accounts have to check terms of service
Change-Id: Id82d143dbdb41ba9648cdcf125874e59c35bb86a
Reviewed-on: https://gerrit.instructure.com/128882
Tested-by: Jenkins
Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
QA-Review: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
fixes ADMIN-289
Test Plan:
- Go to create an assignment
- Look on the right hand side at the
wiki bar.
- Notice the names match the desired names in the ticket
Change-Id: I4ab297692b4ac8e04b729a26cdac82d3f5e4ac37
Reviewed-on: https://gerrit.instructure.com/129556
Tested-by: Jenkins
Reviewed-by: Mysti Sadler <mysti@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
we already show all groups in the menu, just not
the menu
fixes CNVS-39650
test plan
- have a cross shard group
- you should be able to get to it from global nav
Change-Id: I2806cd78ec7079abb8967c09fe33a2eb82efd5df
Reviewed-on: https://gerrit.instructure.com/128467
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Fixes PFS-8549
Test Plan:
Verify that a description is now able to be added for
rubric ratings. Description should adhere to requirements
outlined in JIRA.
Specifically:
1. Add a rating description, and save the rubric. Verify
that description is still present after saving. Reload
page. Verify description is still present.
2. Verify rating description is displayed on the following
pages:
a) Assignment submission view.
b) SpeedGrader / PeerReview view.
c) Student Grades view.
d) Account/Course rubric view.
e) Assignment rubric view.
3. Verify that course copy will also copy rating descriptions
from rubrics.
Change-Id: I544a0564fd3df6b8928a44d13464693621f96533
Reviewed-on: https://gerrit.instructure.com/126139
QA-Review: Aiona Hernandez <ahernandez@instructure.com>
Tested-by: Jenkins
QA-Review: Andrew Porter <hporter-c@instructure.com>
Reviewed-by: Matt Berns <mberns@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
fixes CNVS-39058, CNVS-39061
Canvas doesn't need to store any additional metadata about instfs
thumbnails; the only metadata it uses about its legacy generated
thumbnails is the url (whether local or s3). we can just generate
thumbnail urls direct to instfs and forgo the thumbnail model
altogether.
test-plan:
- enable instfs
- upload an image to Canvas
- the uploaded image should have a thumbnail in the UI same as a
non-instfs file before this commit, but the thumbnail should be being
read from instfs as well
- regression test thumbnails with instfs disabled
Change-Id: I03c21be89469238de7efa317753763834d41c86c
Reviewed-on: https://gerrit.instructure.com/128180
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
Tested-by: Jenkins
QA-Review: Collin Parrish <cparrish@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
R13: QA fixes - move labels closer
to inputs. Default focus dialog
on close button.
R18: Use aria-label for min and max
inputs.
R21-R26: additional screenreader alerts
for "rating update" and "rating
creation canceled". a11y fixes.
Fixes: PFS-8468
Test Plan:
Change should replace the in place edit
form with a pop-up dialog.
In an editable rubric; hover over a rating
cell to trigger edit pencil to appear.
Click pencil to edit rating. Verify
following for both range and non-range
type criterions.
Verify:
1. Modal dialog appears, and in place,
editable form no longer exists.
2. Changing values in the dialog and
clicking "Update Rating" will
update the values in the rubric.
3. Changing values in the dialog and
clicking "Cancel" will not
update the values in the rubric.
4. Adding a new rating will automatically
open up the edit rating dialog with
the default values pre-populated.
Closing a new rating by clicking
"cancel" or "x" to close should
delete the rating.
A11y:
1. Verify that on cancelling a new rating
focus should be reset to the "add rating"
link.
2. Verify that on updating a new rating the
focus is on the "edit rating" link of the
new rating.
Change-Id: Ib7fe388014c1ef6608ee6549faae9707911934a7
Reviewed-on: https://gerrit.instructure.com/125934
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
QA-Review: Aiona Hernandez <ahernandez@instructure.com>
Tested-by: Jenkins
QA-Review: Andrew Porter <hporter-c@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
R12: put "+" after edit links for a11y.
R13: show delete for outcomes after
rubric update.
R14: put "+" after description / pts
for a11y.
R15: text for screenreader for "+"
R16: switch to aria label rather than
screenreader span, due to safari
issue. Fixed existing issue that
incorrectly allowed user to delete
last cell after update rubric.
R17: bug fixed in R16 was also
impacting the first cell after
rubric update. Fixed that too.
Fixes: PFS-8517
Test Plan:
Verify that rubric is functionality is intact and
that ui adheres to prototype in all supported
browsers.
Explicitly -
1) Adding a new rating is accomplished by clicking
"plus" buttons between ratings, not by hovering
over cell boundary.
2) edit/delete buttons are constant while in edit
mode, no hover logic needed.
3) delete column has been removed, and delete icon
is now in criterion description. Verify that
learning outcome criterions function right in
this regard (they should have delete option,
but not edit).
4) minor css stuff like dashed border.
Change-Id: Ie8abd4b45f9f2e660f8ce18104d6ec006d2a969f
Reviewed-on: https://gerrit.instructure.com/124636
Reviewed-by: Chris Hart <chart@instructure.com>
QA-Review: Aiona Hernandez <ahernandez@instructure.com>
Tested-by: Jenkins
QA-Review: Andrew Porter <hporter-c@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
Fixes: PFS-8712
Test Plan:
In environment with page caching -
1. View rubric page (account or course
shouldn't matter)
2. Turn on "rubric criterion range" in
account features.
3. Wait 5 minutes and View rubric page
- range option should be available.
4. Turn off "rubric criterion range".
5. Wait 5 minutes and Reload rubric page
- range option should not be available.
To enable caching on a local dev environment:
In config/environments/development.rb:
1) config.cache_classes = true
2) config.action_controller.perform_caching = true
Change-Id: I43114086c1df903cc4ee103c0e63ce4f0018d8e5
Reviewed-on: https://gerrit.instructure.com/127456
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Aiona Hernandez <ahernandez@instructure.com>
QA-Review: Andrew Porter <hporter-c@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
Fixes: CNVS-39393
Test plan:
- Confirm Canvas CSS compiles with no errors.
- Go to Gradebook as an instructor or admin, and
make the "comment" link appear by hovering or
focusing over/on a Gradebook cell. Confirm that
the link text is still hidden with the .hide-text
CSS class: https://www.screencast.com/t/g0Ku662U5Wyi
- This one was hard to test (I had to comment out the
logic in Rails to make one of these links appear).
You need a user with a social media account
registered with Canvas as a contact method. Go to
your user's Profile page and inspect the social-
icon link that appears on the page:
https://www.screencast.com/t/1ExfoJPt
Confirm that the link text is hidden via the
hide-text CSS class.
Change-Id: Ifb736d485099b744a4c26df31856b6a2b479b9c0
Reviewed-on: https://gerrit.instructure.com/127219
Tested-by: Jenkins
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
- feature flag for rubric range
Fixes: PFS-8283
test plan:
Enable feature: Rubric Criterion Range
Access rubric in account, course, and assignment.
1. Verify that 'range' option is available when editing
a non-outcome criterion.
2. Verify range option is not available for imported
outcomes.
3. Verify range option is not available when using
custom comments (assignment rubrics only)
For range enabled criterions:
1. Verify that increasing the total points assigned
to a criterion will appropriately scale all
range values.
2. Verify that increasing the max of highest score
cell increases total points available for
criterion.
3. Verify that increasing the max of a middle-cell
will increase the min of cell to left.
4. Verify that min of cell farthest to right is locked
at 0.
5. Verify that adjusting the min of a middle-cell
will adjust the max of cell to the right.
In Speedgrader:
1. Verify that selecting values anywhere within a rating
range will highlight the whole rating cell in green.
Feature Flag:
1. Verify that when feature flag is disabled app functions
as if range has been disabled for all criteria. (Leave
a criterion using range, and verify that is no longer
uses range when the feature is disabled).
In Submission Page:
We should also check the submission show page, since Rubrics
are displayed there as well. It can be a little hard to find
since it doesn't follow typical REST patterns for some reason.
When someone submits to the assignment, the url will be the
assignment's id and the user's id.
e.g, for a user id of 9 and an assignment id of 7 on course 1,
the url would be:
/courses/1/assignments/7/submissions/9
Accessibility:
Verify the new fields are a11y compliant by testing keyboard only
and voiceover navigation, so we don't introduce any new
accessibility issues.
Internationalization:
Test range ratings with different numbering system (i.e. Polish)
Verify that rounding works correctly.
Course Copy:
Verify that course copy preserves rubric ranges.
Change-Id: Ia1e9d3cc1d544aecc21c3628bd3dbec70831da2f
Reviewed-on: https://gerrit.instructure.com/121870
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Aiona Hernandez <ahernandez@instructure.com>
QA-Review: Andrew Porter <hporter-c@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
test plan:
* create an assignment with "Display Grade as" set
to "Not Graded"
* on the assignment page, click "+ Rubric"
* there shouldn't be a checkbox to
"Use this rubric for assignment grading"
closes #OUT-1396
Change-Id: Id485e75ff96f03cc87bd29e6768c18abfefa7d34
Reviewed-on: https://gerrit.instructure.com/125326
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Andrew Porter <hporter-c@instructure.com>
Product-Review: Pert Eilers <peilers@instructure.com>
Closes PLAT-2738
Test Plan:
- Install two lti tools that use the new
'com.instructure.PostMessageToken' variable expansion.
- Visit a page with two LTI tools launched (this happens when
launching a tool in a course that has chat enabled).
- Have one tool send a resize post message and verify the correct
tool is resized. The post message should include the token
for the value of 'token':
<script type="text/javascript">
parent.postMessage({
subject: 'lti.frameResize',
height: 12000,
token: '<%= @wrapper_id %>'
}, '*');
</script>
- Verify the proper tool is resized.
Change-Id: Ie7e976c5cd53ef5c61cd86c471ba416045a0fb68
Reviewed-on: https://gerrit.instructure.com/119858
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
Tested-by: Jenkins
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Change-Id: Ibdbca9847de64e79f472df8d3ff886e3b9c4a4ba
Reviewed-on: https://gerrit.instructure.com/122503
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Change-Id: I60ec3b519219fcb5256a132c05f63538600df73f
Reviewed-on: https://gerrit.instructure.com/121760
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
closes QUIZ-394
test plan:
- create a QUIZ2 quiz
- edit the quiz
- at the bottom of editing page, a user can append rubric
- this rubrics editing should not be available for traditional quiz
Change-Id: I28d18a5bae1a91a25f04df3e970b07aaaf109dfc
Reviewed-on: https://gerrit.instructure.com/120033
Tested-by: Jenkins
Reviewed-by: Omar Khan <okhan@instructure.com>
QA-Review: Omar Khan <okhan@instructure.com>
Product-Review: Kevin Dougherty <jdougherty@instructure.com>
Fixes GRADE-120
Test plan:
* Create a course
* Edit its grading schemes
The grading scheme inputs should be wide enough to see more than 3
characters at once.
Change-Id: I126e5c41e9eb7d3ae1208f99cf9e005592bb20d3
Reviewed-on: https://gerrit.instructure.com/120944
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Neil Gupta <ngupta@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
fixes CNVS-38231
test plan
- delete an admin
- admin should be gone from every where
- admin should not have permissions to do stuff
Change-Id: I56c90a12b2be879c5d646c1ab6980693ff161673
Reviewed-on: https://gerrit.instructure.com/119220
Reviewed-by: Tyler Pickett <tpickett@instructure.com>
Tested-by: Rob Orton <rob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Michael Brewer-Davis