Commit Graph

14 Commits

Author SHA1 Message Date
Matthew Berns 8a71527884 fix ePortfolio page performance / page timeouts
fixes OUT-2961

test plan:
- have at least 2 student in a course
- submit to several of the assignments in the course
- go to the students ePortfolio and confirm their submissions
  appear on the "Welcome to Your ePortfolio" page
- make the ePortfolio public under 'ePortfolio' settings
- view the ePortfolio as another student, confirm that no
  "Recent Submissions" list appears for the public portfolio
   (only should appear when logged in as the user who owns the
   portfolio)

Change-Id: I651db17382e151b44fd2b2d59a2ac5f26f28451f
Reviewed-on: https://gerrit.instructure.com/179302
Tested-by: Jenkins
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Neil Gupta <ngupta@instructure.com>
2019-01-30 00:09:48 +00:00
Jeremy Stanley e9945743b8 fix eportfolio file uploads harder
test plan: ensure you can upload a file to:
 1. the root of a new eportfolio
    (example url: /eportfolios/123?view=preview)
 2. a section added to an eportfolio
    (example url: /eportfolios/123/SectionName)
 3. a page added to an eportfolio section
    (example url: /eportfolios/123/SectionName/PageName)

fixes ADMIN-924

Change-Id: I62db3a0f49438c21e9b56cff8201fc86d530011a
Reviewed-on: https://gerrit.instructure.com/145748
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Mysti Sadler <mysti@instructure.com>
QA-Review: Mysti Sadler <mysti@instructure.com>
2018-04-06 00:09:37 +00:00
Landon Wilkins 79215618d4 da licença part 29
add consistent license headers to all source files
(ruby, coffeescript, javascript)

except for vendor files

Change-Id: I49a8930917a609d3f118da1b20b51dedfd5d5903
Reviewed-on: https://gerrit.instructure.com/110053
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
2017-04-27 21:59:53 +00:00
Simon Williams 86ca2adb3e don't try to render url for eportfolio category with blank slug
this was fixed for blank eportfolio entries, but categories can also
occasionally have blank slugs, if their name contains no characters
which are "slugable"

fixes CNVS-25592

test plan:
- create a eportfolio category without any letters or numbers (like
  "+++")
- links to this category won't work, but you should still be able to
  navigate other parts of the eportfolio normally

Change-Id: I2f3a0169f22b3fbc2e868fefb70de0bf92b04a73
Reviewed-on: https://gerrit.instructure.com/68422
Reviewed-by: Spencer Olson <solson@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
2015-12-08 19:50:19 +00:00
Cody Cutrer 0f54b991a4 quick fix to avoid trying to generate a url we can't generate
test plan:
 * running Rails 4
 * create an eportfolio and add an entry to it
 * in the database, set name and slug to ''
 * verify that you don't get a page error viewing
   the eportfolio

Change-Id: I20f6855001ea4e0d7a3deb5b1eee610f0a67cd57
Reviewed-on: https://gerrit.instructure.com/68413
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
2015-12-08 02:31:42 +00:00
Cody Cutrer 9bf7304917 use preload instead of include on associations
refs CNVS-21901

also got rid of some useless associations

Change-Id: I13e012e0ec755443fbed12ca0629c53a9c693f43
Reviewed-on: https://gerrit.instructure.com/62217
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-09-08 20:32:41 +00:00
James Williams 600165e7b2 rails4: deprecate Relation#all in favor of Relation#to_a
refs #CNVS-21596

Change-Id: I5dedaab90a2abe6bf288ff30401c9b31629b45b2
Reviewed-on: https://gerrit.instructure.com/59220
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
2015-07-24 21:28:14 +00:00
Simon Williams 24d3ddd01f ensure there is a default eportfolio page
fixes CNVS-14580

test plan:
1. create an eportfolio
2. click organize/manage pages
3. create a second page
4. open the eportfolio in a new tab
5. in one tab, delete the welcome page
6. in the second tab, delete the new page
7. refresh the eportfolio
8. it should still load the welcome page (having recreated it)

Change-Id: I400b2d4689773a8f48d8b3bfa577982492a4bfb4
Reviewed-on: https://gerrit.instructure.com/38847
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
2014-08-14 23:15:09 +00:00
Nick Cloward e9595976c1 clean up permission calls for grants_rights?
refs: CNVS-11425

Change-Id: Ia0145e4b4d1da9e0f83a1845647ce203b3586057
Reviewed-on: https://gerrit.instructure.com/34280
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2014-06-19 18:10:30 +00:00
Cody Cutrer 5ffbcbeb05 arel-ify lib
excluding api_find, which needs more work

refs CNVS-4706

Change-Id: I013d0660ff2b8dbe2abf6a5c973bd1203f432f99
Reviewed-on: https://gerrit.instructure.com/18921
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Clare Hetherington <clare@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2013-04-01 19:12:22 +00:00
Zach Wily 1de2a2108d 1.9 - fix eportfolios
String#map and String#[] are no longer defined in 1.9.

Change-Id: I9deedd7ad12b7dbd93f73447e43f7809bb891c1d
Reviewed-on: https://gerrit.instructure.com/10798
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
2012-05-17 23:10:51 -06:00
tom metge 3c3633c4e6 Find ePortfolio page attachments by ID. Fixes #6380.
EportfolioEntry.content_sections returns the database ID of any
attachments. EportfolioPage was expecting a UUID. This commit
teaches EportfolioPage to expect the correct value and, just
because the author is so awesome, remove that terrible, blanket
rescue statement. That was done out of the kindness of the author's
heart.

Change-Id: I5c8fb3cc16f38a66d76a233f951e410ffc536317
Reviewed-on: https://gerrit.instructure.com/7696
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
2011-12-28 13:10:16 -07:00
Jon Jensen 58a25bd462 preliminary i18n setup, closes #4124
* i18n key scoping for controller/model/js/etc.
 * inline English translation support
 * rdiscount gem for markdown'ed translations
 * html_safe interpolation tweaks
 * label helpers
 * crummy tweak to translate symbol keys
 * internationalized most of lib, and some plugins/messages
 * conference i18n (view/model/controller/js)

Change-Id: I42772b9e19a110efbe855dc83a681be49ec98df2
Reviewed-on: https://gerrit.instructure.com/4080
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
2011-06-06 14:19:03 -06:00
Brian Whitmer 8b8173dcc9 Initial commit.
closes #6988138
2011-01-31 18:57:29 -07:00