fixes CNVS-22173
test plan:
- if local, run 'rake db:load_notifications'
- create a new user via the API
- with user[skip_registration] true
& communication_channel[skip_confirmation] true
& communication_channel info
- masquerade as the user and go to
/profile/settings
- there IS NOT a message telling you that
you must verify your email address
- with user[skip_registration] true
& pseudonym[send_confirmation] true
& communication_channel info
- the user gets an email telling them
they have been registered
- there IS NOT a message telling you that
you must verify your email address
- with user[skip_registration] false
& communication_channel[skip_confirmation] true
& communication_channel info
- masquerade as the user and go to
/profile/settings
- there IS a message telling you that
you must verify your email address
- create a new user via the API, but associate
this user with an already made pseudonym
(use enable_sis_reactivation and sis_user_id
to do so)
and set pseudonym[send_confirmation] to true
- they DO get an email saying that they have
been registered
Change-Id: I60d0fe013cef1648abd838fd53d9992facf0e106
Reviewed-on: https://gerrit.instructure.com/59726
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
closes CNVS-19046
Marketing is moving to take over the FFT form, which means
the user creation will occur via API, but they'll still need
to get the self-registration style emails to get passwords right
and such.
This provides a parameter to do so. It also pulls out a handful
of lines from the users_controller all related to how and which
notifications get sent, and moves them into a policy object, which
has some predicate methods for the controller to make decisions off
of, and also does the notification dispatching.
Change-Id: I0513062aedf4258b7d9f51a46b1d8e42b2a2582a
Reviewed-on: https://gerrit.instructure.com/51608
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
Michael Nomitch