fixes CNVS-6624
test plan:
- general regression test on rubrics, including rubrics in assignment and
discussion pages, on the rubrics page, in the student submission page, and in
speedgrader
- go to an assignment page, add a rubric, and read it with the screenreader.
It should not read the title and/or "find a rubric" with each cell
- try using 'update' and 'cancel' buttons when editing a rubric. they should
manage focus properly
- there are a lot of things that aren't accessible yet (like editing). Those
are coming.
Change-Id: I8e4296243d32f089fc2216c5e25ca925d16acc50
Reviewed-on: https://gerrit.instructure.com/25104
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
FIXES CNVS-4923
Per ryanf, override header styles to classes that
represent headers as divs, so that we can keep
the styles but change some things that aren't actually
headers to become headers.
Then I went through the reported pages on the ticket
and made sure NFB recommendations were followed:
no more or less than 1 h1 tag
no out-of-order headers
no skipped levels of headers (h1 to h3)
TEST PLAN:
1) nothing should look different on any of the
modified pages.
2) JAWS should use the new h1 tags to give context
to the overall page by reading them off (visit
the pages mentioned in the ticket to try it out)
Change-Id: I20d6b026aea21f770c2d5900ddc7aa20931ec571
Reviewed-on: https://gerrit.instructure.com/20069
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
Product-Review: Ethan Vizitei <ethan@12spokes.com>
this commit does the following:
* upgrade bootstrap-sass gem to most recent version
* switches to using bootstrap's normalize.css and forms.css
which fixes a whole bunch of misformatting of how bootstrap
stuff is supposed to look, but changing those 2 affects
a lot of our old stylesheets.
* gets rid of unified_buttons.sass and just uses bootstraps buttons.
.ui-button @extends these because we still have to support .ui-button
for modals & buttonsets. but .button is no longer supported.
* a lot of css file reorganization (there's no more 'blue' and
'normal canvas', there's just canvas)
* a bunch of files had to be tweaked to look good with these changes.
test plan:
This change touches every page in canvas so, no kidding, we need to make
sure every page looks OK. In order to do that:
1. each sprint team needs to give a +1 after they make sure all the
pages in the features they are over look good.
2. the QA person on each team needs to look at the pages for their
teams features for a QA +1
things to look for specifically when testing:
* buttons: this gets rid of all those red 'cancel' links
that are actually buttons, make sure all the buttons you see
look right. if you see 2 plain gray buttons next to each other
like [Save] [Cancel], we should make the primary one blue (by
adding the .btn-primary class)
* Forms: a lot of this change has to do with how form elements look,
especially <select>s, <input>s and <label>s. look at the diffs
for the ones that have the most changes and make sure those look
good, but also check for the ones I missed and make sure those
look good too.
* and just random style changes, if something looks ugly or broken
(and it didn't before), we should fix that.
Also:
just use a link instead of a drop-menu for adding event from sidebar
we used to have a drop down menu for adding events
to cal2 from the sidebar where you'd hit a cog
and it'd ask you if you wanted to add an event or
an assignment. this just simplifies it to an add
icon.
this: http://cl.ly/image/133a2A3q3q1M
instead of: http://cl.ly/image/46463o2s3W0g
Change-Id: I384fe273934bca96bf28423afb1402c7792d8766
Reviewed-on: https://gerrit.instructure.com/15422
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
QA-Review: Ryan Florence <ryanf@instructure.com>
clicking the edit rubric button multiple times no longer
causes the edit rubric form to appear multiple times on
the page.
also update edit/cancel buttons on edit rubric form to
match new canvas styles.
test plan:
* create and view a new rubric;
* click the 'edit rubric' button in the right sidebar
and verify that 1) the button appears disabled, and
2) the edit rubric form appears;
* click the edit button again and verify that the form
does not appear twice; also verify that the edit/cancel
buttons are right-aligned and match the new canvas
styles.
Change-Id: I595e776af624b1b5c524194ccfff03835e31ae75
Reviewed-on: https://gerrit.instructure.com/13139
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mark Ericksen <marke@instructure.com>
older versions of sass would silently ignore the invalid & here. this is
actually how we want it to behave, since the li is inside the
.view_switcher
for the rubrics one, there is no hover element, so the generated sass is
equivalent
test plan:
1. run bundle update
2. it should work
3. go to a discussion topic
4. the icons in the view switcher ("Expand Unread", etc.) should be
correctly aligned
Change-Id: I418d902f124f754f000f4dd19df8875ea60b3d77
Reviewed-on: https://gerrit.instructure.com/12877
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
test plan:
1. create an assignment with a rubric attached
2. make sure the free form comments setting is checked
3. go to speedgrader for that assignment
4. click on view rubric on right side
5. add a really long assessment comment
6. save the rubric
7. click on the assessment comment to view full comment
8. notice text is not truncated in the popup
Change-Id: I9db3c9f9255d7505292352d41795153443dbe867
Reviewed-on: https://gerrit.instructure.com/10248
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
when you add a learning outcome to a rubric, you can optionally choose to
ignore it when grading. this commit ensures that point totals acutally ignore
the line consistently across the varios places they are displayed, including
when creating the rubric, when grading from the speed grader, and when grading
from the assignment submission page.
test plan:
- create a learning outcome
- create an assignment with a rubric for grading
- make sure the rubric has at least one normal criterion for grading
- include the learning outcome, and choose ignore for grading
- make sure point totals are consistent in the rubric form
- grade the assignment with the speed_grader, make sure point totals are
consistent.
- modify the grade at /courses/c.id/assignments/a.id/submissions/user.id and
make sure point totals are still constistant.
Change-Id: I454d73897ee5d4e6413b7c653ffafa1c4ac98e2e
Reviewed-on: https://gerrit.instructure.com/8263
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
comments were supposed to display when you clicked
a green bubble in the grade summary page, but they
didn't
this commit changes the behavior to display the
comments in the table instead of hidden in a popup
test plan:
1. create a new assignment
2. add a rubric to the assignment
3. click 'user this rubric for assignment grading'
4. ensure that 'free-form' comments is unchecked
5. turn in the assignment as a student
6. open the assignment in speed grader
7. click "view rubric"
8. click the green comment bubble and add a comment
9. go to /courses/:course_id/grades/:student_id
10. click 'show all details'
11. view the "instructor comments" under the
description of the criterion
Change-Id: I80008fb1ea8b17db045edc067595d7430978bb78
Reviewed-on: https://gerrit.instructure.com/8067
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Simon Williams