0bb6789501
allow ruby 3.0
...
Change-Id: I4d9dc50c44fecc218884f60605bc971df95ebaf6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251288
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2020-12-07 18:53:03 +00:00
d6e044ff76
add # frozen_string_literal: true for embedded gems
...
Change-Id: Ib49bc8939cf1706e758429e531a87c57d0231a37
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251156
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
2020-10-28 22:08:40 +00:00
e6d6577e74
Add dependency resolution to autoextend
...
flag=none
refs QUIZ-7242
test plan:
- Specs pass
Change-Id: I5029cd059ef62c4df91ae62cf039e3908739bfb3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/220913
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2019-12-16 21:38:14 +00:00
0f383e71ef
spec: use rspec for autoextend tests rather than minitest
...
Change-Id: I1c58754aa0864254377581176cac9ba81f09ea92
Reviewed-on: https://gerrit.instructure.com/208071
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
2019-09-04 16:21:26 +00:00
7423e4fb94
rails 5.2
...
closes #CORE-1301 #CORE-1302
Change-Id: I687132b066d12cf35e3c7a593dff9b2a91337f33
Reviewed-on: https://gerrit.instructure.com/147220
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
2018-04-25 19:15:20 +00:00
68f5e6065c
prep for Rails 5.1
...
several gem bumps for versions compatible with rails 5.1, and loosening
requirements on in-repo gems.
Change-Id: I4849b053690527e812bb1042fde8142520452123
Reviewed-on: https://gerrit.instructure.com/115650
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2017-06-16 02:54:20 +00:00
c5b5cc786d
da licença part 53
...
add consistent license headers to all source files
Change-Id: I405d2def01ad68c76533b9254983497485cd7073
Reviewed-on: https://gerrit.instructure.com/110160
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
2017-05-01 21:06:11 +00:00
4afb90a86b
ensure all Autoextend extensions get used
...
to avoid bugs creating new ones
Change-Id: Ie5e9444ac7445d388de7e3b466c53be9ef17c0ab
Reviewed-on: https://gerrit.instructure.com/101946
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Tyler Pickett <tpickett@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2017-02-13 23:06:36 +00:00
1339e44130
fix autoextend detecting nested modules from autoloading
...
fixes CNVS-34248
Change-Id: I8b4c899568f06886354d66f1a1462141a557d3da
Reviewed-on: https://gerrit.instructure.com/99225
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2017-01-10 20:52:15 +00:00
adf329b5f0
improve autoextend to hook into ActiveSupport
...
refs CNVS-33695
this allows immediate detection of modules that came from autoloading,
and also allows delaying calling your extension until the class
is fully loaded if desired (to call a method on the base class, for
example)
Change-Id: I2ddd2055e3cf184d3ee149f114da7ec93bd0ead8
Reviewed-on: https://gerrit.instructure.com/97928
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2016-12-20 20:23:26 +00:00
1063e97d2d
clarify autoextend documentation slightly
...
Change-Id: Ic9ebcd36d9d13cd1522cc4e6ba22f8af9167c80e
Reviewed-on: https://gerrit.instructure.com/89089
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
2016-08-31 14:44:09 +00:00
f552f4fc00
simplify gem test harnesses
...
rely on test_all_gems.sh to output header and trailer,
and use `set -e` in each test.sh to simplify passing
through errors
Change-Id: I3ba724ad2539ddfe31195394c43f646acfc73920
Reviewed-on: https://gerrit.instructure.com/70469
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2016-01-19 17:52:58 +00:00
02ced44cc7
some vendored gem test fixes
...
* explicitly depend on syck/iconv when used
* fix cassandra spec config checking
Change-Id: Id9b706943c6b46190cf753fd302cbca0f7bf2a2b
Reviewed-on: https://gerrit.instructure.com/69779
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2016-01-07 05:33:25 +00:00
011f78b53a
remove old autoextend API
...
including autoextension of methods - use prepend!
Change-Id: I073dcf4324a92e6cf14360d77fa59b1a6a4a1588
Reviewed-on: https://gerrit.instructure.com/56479
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-06-17 19:48:45 +00:00
772105314f
allow autoextend target to be an actual module
...
sometimes there's no point in delay loading the extension
Change-Id: I0b758789f5d9985381cd6b293946312e4d3a04ac
Reviewed-on: https://gerrit.instructure.com/56347
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-06-15 16:11:19 +00:00
387a0f05c1
fix an order-of-inclusion problem with Autoextend on modules
...
Change-Id: I84a2a5bda44cd38236bed907200ba7b42a51bc5b
Reviewed-on: https://gerrit.instructure.com/56253
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-06-12 18:27:02 +00:00
9db90e3f32
improve Autoextend
...
use prepend, and do a best effort hook of modules
Change-Id: I7c636d3bfaf332cf7d2faebf62abeffed1659335
Reviewed-on: https://gerrit.instructure.com/56042
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-06-11 15:52:08 +00:00
9d5157b15d
fix Style/EmptyLiteral issue
...
Change-Id: I8417d2abf3e2d3e01b691df553c79026801f6bce
fixes: CNVS-20009
Reviewed-on: https://gerrit.instructure.com/52920
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Strand McCutchen <smccutchen@instructure.com>
QA-Review: Strand McCutchen <smccutchen@instructure.com>
2015-04-27 19:47:30 +00:00
84f1082b6a
don't autoextend methods from modules
...
we can't detect when a method is added from a module, so make immediate
detection work the same way
Change-Id: I8558e1fccf14a62d21efcc3108a1fca34f0c2ac4
Reviewed-on: https://gerrit.instructure.com/51799
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-04-14 18:41:01 +00:00
bd52b0a491
fix autoextend for ruby 1.9
...
const_get in 1.9 doesn't support nested constants
Change-Id: I1f511697b44846f7b8c9714f8bf84adaf42591bf
Reviewed-on: https://gerrit.instructure.com/52054
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-04-13 21:11:08 +00:00
a424a91f97
add autoextend gem for plugins to easily add functionality to canvas
...
closes CNVS-14263
Change-Id: If2fb80e776662cae1fe56dd9e5e550c50f6accd8
Reviewed-on: https://gerrit.instructure.com/51654
Tested-by: Jenkins
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-04-13 18:25:50 +00:00
Cody Cutrer