refs VICE-574
flag=trophy_case
test plan:
** WITHOUT enabling trophy_case flag **
- open the user profile tab
- there should be no link to the trophy case page
** WITH enabling trophy_case flag **
- open the user profile tab
- there should be a link to the trophy case page
- clicking the link should take you to /trophy_case
qa risk: low
Change-Id: I3b3ade661b509a2fc42f6ccf532cd4dcff7ceb3d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/240870
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Matthew Lemon <mlemon@instructure.com>
QA-Review: Matthew Lemon <mlemon@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Test plan
- Pull down change for testing
- Open a course with announcement or discussions
- Open an announcement or discussion
- Tab through page to see Shortcut announcement with Alt + F8 shortcut
- Alt + F8 should open shortcut modal
Expect
- Shortcut text to state Alt + F8
- Alt + F8 should open Keyboard shortcut modal
- Shift + ? should no longer open Keyboard shortcut modal
Change-Id: I04773894cb596d4c5dc66a0d972de2dbb6e1df2a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/240661
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
This allows reporting of sis_source_id/sis_user_id as sisId on various
objects in graphql: account, assignmentGroup, assignment, course,
groupSet, group, section, term, and user. For top level searchable
objects (account, assignment, assignmentGroup, course, term) you can
search by either the _id or the sisId. If both are supplied to a query,
an error is returned.
closes PLAT-5272
test plan:
- Seed your canvas instances with at least one of each type above that
has a source_source_id (or in the case of user,
user.pseudonym.sis_user_id)
- As a user with either read_sis or manage_sis permissions:
- Perform queries in graphql using those sisIds that were set for
account, assignment, assignmentGroup, course, term.
- Note that the queries return the correct objects
- Perform searches that return the list of objects in the commit
description and return the sisId
- Note that the quieries return the correct sisIds
- As a user without read_sis nor manage_sis permissions:
- Perform searches that return the list of objects in the commit
description and return the sisId
- Note that the sisIds are returned as null
Change-Id: Id549ea93ff770cd29b227607973835266196a704
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/236718
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Karl Lloyd <karl@instructure.com>
Change-Id: I686fe02bf60aac4835b11fe1e6096b398b4962ab
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/240901
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
flag=trophy_case
also updates team file to new name
test plan:
- n/a
qa risk: low
Change-Id: I463f27792aa8ec6912bbd280d8070125f23a48a9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/240850
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Matthew Lemon <mlemon@instructure.com>
QA-Review: Matthew Lemon <mlemon@instructure.com>
Product-Review: Matthew Lemon <mlemon@instructure.com>
fixes VICE-575
flag=none
/ ---- ---- \
| Test Plan |
\ ---- ---- /
- specs pass
- create a conversation
- add some additional root account ids to it
- verify that the root_account_ids are sorted
Change-Id: I3b603ae6a9b390cb22b8acb6517db8fefa69c812
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/240965
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs CNVS-48876
flag = none
TEST PLAN:
1) run auditors repairing
2) no course job errors out with failed FK check
Change-Id: I7bf569c810e48939fca4a54d7a93860d4129b183
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/240939
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
closes PLAT-5765
flag=none
Test plan
- When you create a plagiarism tool
(tool that has the similarity detection
placement) it should create and save
a live events subscription id on the
tool
- The subscription should have an associated
integration id created with it
Change-Id: Ia6d29c61f25fddaea46478469bdd668e7aa39509
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/239210
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
Fix the root issue behind the flakey spec, but it still fails FSC due to the spec taking too long. Skipping test and leaving this to LS-849 to fix.
refs CCI-375, LS-849
flag = none
Change-Id: Ie7b20483bfafa2a84f22da78988d6879c9691833
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/240689
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ryan Norton <rnorton@instructure.com>
QA-Review: Ryan Norton <rnorton@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
fixes USERS-364
so that branded icons are properly shown
test plan:
* use the theme editor and upload a custom icon for Mobile
Homescreen Icon
* on an Android device, bookmark the canvas website to your homescreen
* you should see your custom icon
NOTE: because this uses the existing brand config variable, apple and
android will now share an icon, whereas they have differed in the past
Change-Id: Ibb1e6da5a42dae630a04651071618b2504a7f3ce
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/229636
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Jonathan Fenton <jfenton@instructure.com>
allow a list of regions, as well as negating the option
Change-Id: Ic306c1999854f94bdfd8a9257735eb16525ed6f3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/240535
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
Without this change we were calling the same config functions
over and over and that was muddying up the logs and didn't
seem especially fast either due to the load() in the
underlying function.
Change-Id: Ia37869ca84604ec2723212d1be46a446f57a1a6e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/240190
Reviewed-by: James Butters <jbutters@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Derek Bender <djbender@instructure.com>
refs CNVS-48876
flag = none
TEST PLAN:
1) run auditors repairing
2) no job errors out with failed FK check
Change-Id: I6ca783a0966325bee82d91e0b5bf1190f017fa40
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/240805
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes VICE-338
flag=none
/ ---- ---- \
| Test Plan |
\ ---- ---- /
- specs pass
- Create a pseudonym for a user and a communication channel
- Open your rails console and grab the communication channel
- cc = CommunicationChannel.last
- Verify that the root_account_id is set on the communication channel
and that it matches the pseudonym account
- cc.root_account_id
Change-Id: I7bf7979779577b9fa0372ce6c8b00913ad41809c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/239316
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
fixes VICE-341
flag=none
/ ---- ---- \
| Test Plan |
\ ---- ---- /
- Create a conversation
- Grab that conversation and add another root account id to it
- c = Conversation.last
- c.root_account_ids = [1,2] # assumes normal account and site admin
- c.save!
- Check that the conversation participants root_account_ids now includes
the added root_account_id
- c.conversation_participants.first.root_account_ids
- Check that the conversation messages root_account_ids now includes the
added root_account_id
- c.conversation_messages.first.root_account_ids
- Check that the conversation message participants root_account_ids now
includes the added root_account_id
- c.conversation_message_participants.first.root_account_ids
Change-Id: I949bd25001d18303d6e79bd07dc7d3494166b84c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/240730
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Davis Hyer