ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
46,318 Commits 324 Branches 20,019 Tags 1.7 GiB
Commit Graph

8 Commits

Author SHA1 Message Date
Cody Cutrer f299f76b75 add # frozen_string_literal: true for models 
Change-Id: I70825be7ec7e24458afe0c63dc48c5a76158f520
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251150
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
 2020-10-28 22:08:12 +00:00
Cody Cutrer c5227d3f1b shackles was renamed to guardrail 
closes FOO-989, FOO-990

Change-Id: I49dfa130cb74c34dd0eb25952790176ae4951058
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/249365
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2020-10-06 19:23:08 +00:00
Rob Orton 3fe8c877fc report runner improvements 
this doesn't really change anything with how report runners are run, but
how they might fail.
we don't want to abort the runner that may have failed, so we can get
data on which report had an error with state of error or running.

Also we don't want to write rows on a failed or aborted report runner
because then we can manually run that runner and any aborted to finish
the report in a console for troubleshooting.

test plan 
 - specs should pass

Change-Id: I5cfc3d975899f85aff64a6e20c7673b1f2cd1b88
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/244625
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
 2020-08-10 15:36:29 +00:00
Cody Cutrer a81944a73a rails 6: s/update_attributes/update/g 
Change-Id: Ie137c1040260b363979160e1f0558883577ebebd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/222510
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
 2020-01-09 20:56:35 +00:00
Rob Orton adf3104684 make report runners work with zip file reports 
this also converts mgp_report to use report runners

test plan
 - mgp report should work

refs CORE-3207

Change-Id: I62d02683c0bc3c96ec2ba54461ab5980435e2938
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/213456
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Cameron Matheson <cameron@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
Tested-by: Jenkins
 2019-10-23 21:13:39 +00:00
Rob Orton 47a4974528 make report runners write to db more efficient 
refs CORE-2742

test plan
 - report specs should pass

Change-Id: If11a71145b8ce21be6c91bfcf09f27792a095f68
Reviewed-on: https://gerrit.instructure.com/188692
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
 2019-04-09 16:56:53 +00:00
Rob Orton f91d236e38 improve account report cleanup process 
refs CORE-2309

test plan
 - cleanup should work

Change-Id: If24f2079589d4e2b9c5c151fb21ebdf76199286b
Reviewed-on: https://gerrit.instructure.com/176854
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
 2019-01-04 20:45:49 +00:00
Rob Orton e1b9a42062 create parallel report runners 
fixes CORE-1240

test plan
 - run account report using parallel runner
 - it should work

Change-Id: Ib0e8480e53d65b7e5b7f4d3c3f2f36c7d283fb52
Reviewed-on: https://gerrit.instructure.com/145605
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
 2018-04-04 19:16:44 +00:00