hardcoding the dir /usr/src/app for git safe.directory doesn't
still leaves plugins broken. Change to use $DOCKER_WORKDIR.
flag: none
Test Plan:
- plugin jenkins build generates crystalball prediction
- standard jenkins build generates crystalball prediction
Change-Id: I06b3be6884685377fca3653f18db6a0a0157800d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/319114
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
Build-Review: James Butters <jbutters@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
toptal/crystalball has been stale for a couple years and we
are in need of updates with Psych 4 that aren't getting
merged. Switch to using wrapbook/crystalball since it has the
Psych 4 update amoung other improvements.
[force-crystalball]
Change-Id: Iee3565f69a6af83b018459c39326e1b475648bd1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/319020
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
Build-Review: James Butters <jbutters@instructure.com>
[change-merged]
[build-registry-path=jenkins/canvas-lms/de-1572]
refs DE-1572
test-plan:
- simulate change-merged build
- expect the docker image to be available for both amd64 and arm64
Change-Id: I6b17ba42e2eb0eac8ab22630f2f88ab6f0c1a9fd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/313972
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Build-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
refs DE-1421
flag=none
TEST PLAN:
Build
Change-Id: I4816755153decf199415b889b16cba3b930d786e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/303043
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: Bobby Buten <bobby.buten@instructure.com>
Product-Review: Bobby Buten <bobby.buten@instructure.com>
Build-Review: Bobby Buten <bobby.buten@instructure.com>
refs DE-1351
flag=none
TEST PLAN:
Build
Change-Id: I1c90fa22f7f64e875157bd3e589b16f7079e6274
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/302044
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: Bobby Buten <bobby.buten@instructure.com>
Product-Review: Bobby Buten <bobby.buten@instructure.com>
Build-Review: Bobby Buten <bobby.buten@instructure.com>
refs DE-1379
Test Plan
1. JS Impact Analysis works
2. Tarball hashes are reproducible crossbuild
[build-registry-path=jenkins/canvas-lms/de-1379-3]
[change-merged]
Change-Id: I69631a80dd2cbdc03467b1ae690c0eeeaeda555c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/301748
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Bobby Buten <bobby.buten@instructure.com>
Build-Review: Bobby Buten <bobby.buten@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Rover was originally added as a devDependency so that Apollo Studio
schema checks could be performed. However, Rover does not build under
linux/arm64, so developers with newer M1 Macs were unable to get Canvas
running. Instead, the schema checks will be run inside of a separate
rover specific container, removing the dependency.
[canvas-builds-refspec=1b94202e657e6899de6629afd85b628a1e27b66c]
[force-graphql-schema-check]
closes INTEROP-7174
flag=none
test-plan:
- the simulated post-merge build succeeds
- M1 users can run yarn install without issue
- devx is happy :P
Change-Id: I92f8862b580b4300b14ee98bc9e9826c8d649e96
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/298396
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Ryan Hawkins <ryan.hawkins@instructure.com>
why:
- Schema checks ensure that any change to the Canvas GraphQL Schema
don't impact existing queries as well as ensuring we don't break
supergraph composition.
- We're starting with a post-merge build to see how common of an issue
this is for now. We'll move it into the deploy and pre-merge steps
once we're sure we like it.
flag=none
[canvas-builds-refspec=0e2b75ca09d79fe85fdb749b9288dabbbfc86012]
[change-merged]
[build-registry-path=jenkins/canvas-lms/interop-7174]
closes INTEROP-7174
test-plan:
- the simulated post-merge build reports to the appropriate Slack
channel and we *don't* get a message about a schema check failure.
- we'll get eyes from devx and our SET to make sure everything looks
A-OK.
Change-Id: Ibdb55c1f50d0ab71d809bb06a5f0d01a5b7fbc02
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/296771
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Ryan Hawkins <ryan.hawkins@instructure.com>
Product-Review: Ryan Hawkins <ryan.hawkins@instructure.com>
Creates a generic Slack failure for Jenkins. This is useful for newer
processes that need to customize where an error message might be sent
and whether or not the author of the failing patchset should be alerted.
refs INTEROP-7174
flag=none
test-plan:
- The current alerting methodology still works
Change-Id: I952548c2c3954028f63c2bfc9a23a8c4a3efd40b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/296974
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Ryan Hawkins <ryan.hawkins@instructure.com>
Product-Review: Ryan Hawkins <ryan.hawkins@instructure.com>
refs FOO-2801
flag = none
this patch renames the rake task i18n:generate to i18n:extract to better
reflect what it does and to be consistent with the rest of the codebase
this might not be significant for 99% of users, but for maintainers who
deal with i18n code - i18nliner on ruby, i18nliner on js, i18n_tasks -
this particular Rake API is disorienting because everywhere in the code
the routine is referred to as "extraction" except for the api --
"i18n:generate", it's also compounded by the other api
"i18n:generate_js" which is significantly different in terms of logic,
so you always had to keep that in mind
now we have:
- i18n:extract - extract translations from all source code; Ruby, JS,
Handlebars into a single YAML file with a tree structure
- i18n:generate_js - generate translation files for the JS *runtime*
~ test plan ~
you can still run i18n:extract and i18n:generate_js, and Jenkins runs
them too
Change-Id: I0216206b46c225e101dcd2112d9f84b773a84d04
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/294207
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Ahmad Amireh <ahmad@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
flag = none
Change-Id: I33bc4af82d2e7db4cf067b86d941981cefefaba8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/291464
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
refs DE-938
flag=none
TEST PLAN:
Confirm all builds still run successfully
Confirm all webpack linter jobs still run
Comfirm bundle sizes are appropriately reported
This task removes the webpack linter stage from premerge builds,
spreads the previous tasks around,
and adds a step to postmerge builds to track and report
webpack bundle sizes
Change-Id: I017876726ac0db6f099367b1ecfd086cfb726cf8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289680
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Bobby Buten <bobby.buten@instructure.com>
Product-Review: Bobby Buten <bobby.buten@instructure.com>
Change-Id: I44decd04cc35a179a69cc2951c106019b06bff15
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289673
Reviewed-by: Bobby Buten <bobby.buten@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
James Butters