Commit Graph

4 Commits

Author SHA1 Message Date
Simon Williams f9d0cb4e7e optimize scheduler notifications
don't need to serialize a whole user AR object just for a name

closes CNVS-38377

test plan: make sure all scheduler notifications from appointment groups
still work

Change-Id: Ie2343b90ec189ca30ce9ae2f9dd35a529e57d9ff
Reviewed-on: https://gerrit.instructure.com/120519
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
2017-08-11 17:41:54 +00:00
Cameron Matheson ff4e9d293a fix appointment group signup/cancellation notifications
fixes #7771

Notifications were broken for signups/cancellations on appointments
because the messages dependend on some transient instance vars on the
CalendarEvent.

Test plan:
  - run canvas in production
  - create an appointment group
  - signup as a student
  - cancel the appointment
  - ensure notifications were sent

Change-Id: Ie1bb9f0d7c17546fa1dc1d681e20df97836a64d6
Reviewed-on: https://gerrit.instructure.com/9721
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mark Ericksen <marke@instructure.com>
2012-05-31 13:00:43 -06:00
Cameron Matheson a2a6579c10 multiple contexts per appointment group
closes #7561

Test plan:
  - create some appointment groups:
    - make one with multiple courses
    - make one with a course, and then add more courses after saving
    - make one restricted to some (not all) sections in a course [1]
    - make one that has students sign up in groups [1]
  - make sure that only students that match the above criteria are able
    to see/reserve those appointment groups

  [1] you can only choose the group-signup option or restrict
      appointment groups to certain sections on creation (these options
      won't be availabe when editing later)

Change-Id: I1cff5fb4ed233882c2061f8fd8a7ba6f2d4959b0
Reviewed-on: https://gerrit.instructure.com/9407
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
2012-04-30 15:30:03 -06:00
Jon Jensen 80c90587d6 calendar and scheduler apis; refs #3395
Change-Id: I0bafb21630086ff2a99b8b881568bff51afabedc
Reviewed-on: https://gerrit.instructure.com/7823
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
2012-01-06 12:35:27 -07:00