fixes COMMS-236
Test Plan:
- Generate all notifications you can reply too
(for help look at the names of the files I changed)
- Notice wording has changed and is correct
Change-Id: Ic6d5acc15c9164343c5899e7fdeb1b13c6560c09
Reviewed-on: https://gerrit.instructure.com/131173
Tested-by: Jenkins
Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
QA-Review: Aaron Kc Hsu <ahsu@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
fixes CNVS-38989
Test Plan:
- Send yourself an email (one which you can reply too
aka conversation messages/discussions)
- notice you see the text:
"You can reply to this message in Canvas by replying directly
to this email, or by clicking this link: %{link}."
- stop your server and modify config/outgoing_mail.yml
under development(or whatever env you are in) add
`reply_to_disabled: true`
after ` default_name: "Instructure Canvas"` key
- resend yourself an email like above
- notice that text above no longer states you can reply to the email.
Change-Id: I2707b77d3aa296dce5f04359c8e016d805e7ecd3
Reviewed-on: https://gerrit.instructure.com/124813
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Christi Wruck
fixes CNVS-22766
test plan
- cause a discussion reply notification to be sent (by replying to
a discussion)
- follow the link in the notification
- ensure that the specific reply is scrolled into view
- do the same for announcements
Change-Id: I6a6f9fee7c9acd1e637486d607f71471f4664d6b
Reviewed-on: https://gerrit.instructure.com/69166
Tested-by: Jenkins
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
prefer wording like "clicking this link: %{link}" over "clicking the
link below" or "clicking the following link"
fixes CNVS-24646
test plan:
- verify that the following notifications work when delivered as plain
text (not html) email:
added_to_conversation
announcement_reply
conversation_created
conversation_message
group_membership_accepted
group_membership_rejected
new_context_group_membership
new_context_group_membership_invitation
new_discussion_entry
new_student_organized_group
peer_review_invitation
submission_comment
submission_comment_for_teacher
- also verify that peer_review_invivataion works when delivered as an
sms or in a summary email (again plain text)
Change-Id: I6d36f797de3a3162fa27a4ce3f7cc423a85e3ff7
Reviewed-on: https://gerrit.instructure.com/66079
Tested-by: Jenkins
QA-Review: Adrian Russell <arussell@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Product-Review: Allison Weiss <allison@instructure.com>
fixes CNVS-11838
and then choose the host more intelligently to use one the user
can actually log in to
test plan
- have accounts on two shards, referred to as "account 1" and
"account 2" from now on
- have account domains that are resolvable for the accounts,
referred to as account1.canvas.dev and account2.canvas.dev from
now on
- have account 2 trust account 1 by POSTing to
account2.canvas.dev/api/v1/accounts/<account 2 id>/trust_links
with a site admin's auth token and setting
trust_link[managing_account_id] to account 1's global id.
you can now use users from account 1 on account 2
- regression test notifications, especially considering
notifications generated by account 2 that are sent to account 1
users.
- account 1 users should have links that use account1.canvas.dev
and have global ids for referenced objects that live on
account 2's shard,
e.g. account1.canvas.dev/courses/2~1/discussion_topics/2~30
- avatars should use the avatar owner's account domain
- account 2 users should have links that use account2.canvas.dev
and have local ids,
e.g. account2.canvas.dev/courses/1/discussion_topics/30
- following the links when the user receiving the notification is
logged in should take the user to the linked object
- following the links when not logged in should take the user to
a login page that they are able to log in to
- be sure to at least check:
context file downloads links (e.g. discussion topic attachments)
file downloads links (e.g. conversation message attachments)
avatars links
conversation notifications
discussion notifications
peer review notifications
Change-Id: Idebd247fee99a2b973d3fa6f4f2fca0e723d99a5
Reviewed-on: https://gerrit.instructure.com/31867
Tested-by: Jenkins
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
Creates a new notification preference for announcements created by
you. Now you can see what you've sent, and how it looks in specific
communication channels. This new notification preference will also
send notifications when someone responds to the announcement.
Fixes CNVS-13745
Fixes CNVS-2135
Test Plan:
- Set "Announcement Created By You" preference
- Create an Announcement
- Check /users/[:user_id]/messages for "Announcement Created By You"
- As another user comment on the announcement
- Check /users/[:user_id]/messages for "Announcement Reply"
Change-Id: Ibb16f0dc3ba34d98f749c40d1df1eb12430aecca
Reviewed-on: https://gerrit.instructure.com/40636
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
Steven Burnett