Fixes: CNVS-23963
Test Plan:
- as a teacher using the new UI navigate to a course
- click the "Pages" link from the left-hand sub-nav
- if you do not have any pages created - create a couple so you can
see the new table in action
- ensure the old table styles display when the new UI is turned off
- lastly ensure the view looks good for both old and new UI when you
activate "Student View"
Notes:
- in order to get the new styles working for the new UI, table headings
needed to added for the publish and manage settings icons (as for screen
reader, not sure what is the best verbage so am open for feedback)
Change-Id: I5fa45e2c5d46e58dc37e8d25ccd5ebef7f9a96ca
Reviewed-on: https://gerrit.instructure.com/65059
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Fixes: CNVS-22000
test plan:
- as a user with the old AND then new UI using HIGH CONTRAST
- navigate to a course and click into the discussions link from the
left-hand sub-nav
- hover over the various buttons on the page and the hover state
should now be black with white text
- hop around in various areas to ensure the buttons have this new
hover state
- ensure the buttons and hover are not affected when high contrast
is turned off
Change-Id: Id2016f7f9b0e6b25bf0657d0ad9767e4f6f93dbb
Reviewed-on: https://gerrit.instructure.com/65740
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
refs #CNVS-11466
Users who aren't logged in should submit
an email, otherwise we can't get back to them.
This adds some front-end validation to require
an email address if the user isn't logged in.
If they are, we leave it alone, we can identify
them from their session.
This also removes the 404.html page, I can't find
anywhere where we actually use it (and it is
exactly duplicated in the error_form and such)
Change-Id: I0aaa322aa25f4c3f316cb2ce15573c2ac288035c
Reviewed-on: https://gerrit.instructure.com/63715
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
This essentially reverts the behavior in e8eefad3.
fixes CNVS-23838
Test Plan:
- Got to the files page with at least one folder
- The toolbar preview button should be disabled
when you have the folder selected
- When you have a file preview open, it should
navigate to all the files and not show folders
at all
Change-Id: I2dc411d5c81970cba1986abae7b5f0c73af6cfc6
Reviewed-on: https://gerrit.instructure.com/66138
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
fixes CNVS-23326
test plan
- see repro steps on the jira ticket
Change-Id: Idf175a9afed061e7cb367ffc1a2357aca26bb881
Reviewed-on: https://gerrit.instructure.com/66229
Tested-by: Jenkins
QA-Review: Adrian Russell <arussell@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
fixes CNVS-24662
This should be an edge case, but we should not try to add files that do
not exist to either the ePub book or the unsupported files directory.
test plan:
- Have a course with assignments (or another canvas object) that
reference files that do not exist as part of the course.
- Export the course as an ePub.
- Observe that the ePub export completes.
- Observe that the messaging in the ePub is similar to when the file is
not supported.
Change-Id: Ic24e91e99fe53ddcf8389ba0d58243aad1ef7dea
Reviewed-on: https://gerrit.instructure.com/66233
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: John Corrigan <jcorrigan@instructure.com>
Fixes CNVS-22398
CNVS-22398 was previously fixed with c428f832, however,
that commit created issues in Continious Integration, with
failures which only happened when the tests were run in
parallel. c428f832 was reverted in f566717b.
This commit differs from the c428f832 by avoiding
using fakeENV to manage creating an ENV for testing
purposes. The function isInPastGradingPeriodAndNotAdmin
is not as well tested as it was in c428f832, but this is
preferable to having intermittent spec failures in CI.
Test Plan:
1. As an admin, create an account-level grading period
which ends in the past.
2. Create an assignment that is due within that grading
period.
3. As a teacher, go to Gradebook, click on the grades for
that assignment.
4. Observe that they are not editable.
5. Navigate to Individual View. Select the past grading
period.
6. Select the assignment and a student in the Content
Selection section.
7. Verify that you are unable to edit this grade.
8. Click "Submission Details."
9. Verify that you are unable to edit this grade.
Change-Id: I381c3d3c78f00eabc7a685ef3a0e8fea0f886ac2
Reviewed-on: https://gerrit.instructure.com/65417
Tested-by: Jenkins
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Christi Wruck
fixes CNVS-23104
test plan
- as an account admin (not site admin), ensure that you can send
a conversation message without specifying a context
- disable the "See the list of users" permission for the Account
Admin role on the user's root account
- as the account admin, ensure that you now cannot send a
conversation message without specifying a context
Change-Id: I25d6bacae1b213d6fa5caf7813de6d979282411b
Reviewed-on: https://gerrit.instructure.com/66155
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Tested-by: Jenkins
QA-Review: Adrian Russell <arussell@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
Test Plan:
- pass Jenkins
- check for syntax errors
- make sure new test_ids match up to an existing test case in TestRails
Change-Id: Id0477279c50cb9a5b32283ac0b564849cf2848f3
Reviewed-on: https://gerrit.instructure.com/65934
Tested-by: Jenkins
Reviewed-by: Adam Phillipps <adam@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
Reviewed-by: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Michael Hargiss <mhargiss@instructure.com>
refs CNVS-24234
This needs a lot of QA There are not automated test written for the
file so everything its manual.
Test Plan
- go to new files
- start using all of the search features
- nothing should be broken
Change-Id: I359100463352175b8c684d9e58117ee78d2ad60f
Reviewed-on: https://gerrit.instructure.com/61558
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Sterling Cobb <sterling@instructure.com>
closes CNVS-24685
test plan:
- ensure ePub Exporting is no longer a user level setting
- ePub Exporting should default to 'off' on account level in beta
- when off on account, option should not apepar on course level
- toggle ePub exporting to 'allowed' on account
- should now be able to set setting in course
- toggle ePub exporting to 'on' on account
- should now be locked to 'on' in course
Change-Id: I6a51bd47766edb73f9fa227d89953cea14a9c806
Reviewed-on: https://gerrit.instructure.com/66190
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
Tested-by: Jenkins
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
test plan:
* send a conversation message to another user with a media
comment, either uploaded or recorded
* on the receiving end, the media link should have a name
closes #CNVS-20036
Change-Id: I8fbc1b377883de5d8b83f30e53990e79cfd87414
Reviewed-on: https://gerrit.instructure.com/66172
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Ryan Allen <rallen@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
closes CNVS-24686
Test Plan:
- Go to files
- The tooltip in the toolbar for restricted access should say
manage access instead
Change-Id: Ie6d304a08dfd83c1d911319d4822a3ea79abfef8
Reviewed-on: https://gerrit.instructure.com/66197
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
closes CNVS-24124
makes working with web pack possible in canvas
instead of require-js. See doc/working_with_webpack.md
for instructions.
TEST PLAN:
Nothing should change in non-webpack'd behavior
Things should mostly work when you use the
USE_WEBPACK environment variable, but make sure to document
and ticket things that don't
Change-Id: I493a259a609e9e183950bc57aa5876df70108547
Reviewed-on: https://gerrit.instructure.com/64386
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Fixes: CNVS-23959
Notes:
- includes assignment dates as well as the quiz attempts tables
Test Plan:
- as a teacher using the old or new UI
- navigate to a course with an assignment or create a new assignment
- upon saving if new or below an existing course is a table that
contains "Due" "For" "Available For" and "Until" - - upon inspection
the table class should now be "ic-Table" (which is the new styleguide
version)
- there is a quiz attempt history that will display a table under the
assignment dates
Notes:
- a new component has also been created in order to allow action items (in
this case the + Rubric button) to fall directly under the table giving
them breathing room top and bottom
Change-Id: Ice3db093f36dd13d00382c549a6f5215ed67e855
Reviewed-on: https://gerrit.instructure.com/65040
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
fixes SKYW-3
Test plan:
* Ensure that the dialog is now accessible via screenreaders and
keyboard
Change-Id: I3ef04c9492a33c4b8301f999aa4da5543a965393
Reviewed-on: https://gerrit.instructure.com/65914
Tested-by: Jenkins
Reviewed-by: Mark Severson <markse@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Andrew Butterfield <abutterfield@instructure.com>
test plan:
* try to click on the logout link a whole buncha times
* should not receive any errors (should only try to
log out once)
closes #CNVS-24226
Change-Id: I4944f8660fc4ff8b9f338cdb16fada63c00222e4
Reviewed-on: https://gerrit.instructure.com/66224
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Ryan Allen <rallen@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
closes CNVS-24707
TEST PLAN:
1) go to a course as a student with pages nav enabled and with a wiki
with a "front_page"
2) go to the wiki front-page
3) you should see the "View All Pages" button
Change-Id: I289d959befb187ffa56f86ff3f5101ad1164bb3d
Reviewed-on: https://gerrit.instructure.com/66256
Reviewed-by: Jon Willesen <jonw@instructure.com>
QA-Review: Pedro Fajardo <pfajardo@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Ethan Vizitei <evizitei@instructure.com>
fixes CNVS-24706
when not an option property, the value doesn't actually
get set.
TEST PLAN:
1) go to course with pages as a student and pages enabled
2) view a page
3) you should see "View All Pages"
Change-Id: I6a0dc50b750c10d553030c71d25ae19b3cac4350
Reviewed-on: https://gerrit.instructure.com/66255
QA-Review: Pedro Fajardo <pfajardo@instructure.com>
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Ethan Vizitei <evizitei@instructure.com>
closes CNVS-24284
json-jwt has encryption built into the library.
Also replace all bare uses of JWT library
with Canvas::Security so we use a consistent
interface throughout the app.
TEST PLAN:
1) no behavior changes
2) regression test Oauth logins
3) regression test LTI tool launches
Change-Id: If1a98cc9fbaf9f77631b730a5afe0951347743ab
Reviewed-on: https://gerrit.instructure.com/65774
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Jenkins
refs CNVS-21803
test plan:
- generate an ePub using module type sorting and content type sorting
- all quizzes should show up in the syllabus for content type sorting
- only quizzes for their respective modules should show up on module sorting
Change-Id: I359594b1ce3c565741acde9bbd2b1e87c2ee74b0
Reviewed-on: https://gerrit.instructure.com/66209
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Tested-by: Jenkins
Product-Review: Matt Berns <mberns@instructure.com>
fixes CNVS-24674
test plan:
- Attempt to create an ePub export that you know will fail.
- Observe that the status is marked as failed, the progress bar
disappears & the Regenerate button is present.
Change-Id: I6a8a8d165285e09d6bbd6e812b3048eb1dcc06d6
Reviewed-on: https://gerrit.instructure.com/66142
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
the count on the new ui "Inbox" dashboard for new messages
should work as before (just refresh slower)
closes #CNVS-24652
Change-Id: Ida979fb7e8730eaa71837df7699fde35dea7fa08
Reviewed-on: https://gerrit.instructure.com/66085
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Ryan Allen <rallen@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
fixes CNVS-9378
Some on-time submissions displayed the message,
"Note: This submission was LATE" while other late
submissions did not.
The error was caused by submissions being given a
value attribute of 1, 2, …, an off-by-one-error
which led to this message never being applied to
the last submission, and always being applied to
the last on-time submission when an assignment
had late submissions.
test plan:
1. Create a quiz with a due date and allow multiple
attempts.
2. As a student take the quiz before the due date.
3. After the due date as the student, take the quiz again.
4. Check speedgrader and confirm that no message is
displayed below the submission to view dropdown.
5. Confirm in speedgrader that the last submission displays
the message "Note: This submission was LATE".
Change-Id: I470c20fc7bb161457faa6ddfb92071eacf83ec66
Reviewed-on: https://gerrit.instructure.com/65607
Tested-by: Jenkins
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Strand McCutchen <smccutchen@instructure.com>
refs CNVS-23798
test plan:
- ensure that links still work properly for module and content sorting
- there should be no other visual changes for end users
Change-Id: I7400fff729aecf3739d073544c66c090b7120dd9
Reviewed-on: https://gerrit.instructure.com/66121
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Matt Berns <mberns@instructure.com>
test plan:
* install a post grades lti 2 tool
* the post grades placement should be shown for the tool
* the tool should be shown on the gradebook page for posting grades
fixes SKYW-106
Change-Id: I25f26c09017d8967799b3692a2aeb15986a4c322
Reviewed-on: https://gerrit.instructure.com/57576
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Mark Severson <markse@instructure.com>
This commit also does a little refactor of the tests for the
column header to avoid missing prop warnings.
fixes CNVS-24640
Test Plan:
- Go to the moderation screen
- Click the select all checkbox
- It should select all the students
- Click it again, all the students should be unchecked
- Other than the ones that were previously added to the
moderation set, because those boxes are disabled.
Change-Id: I19c0832087eae1d279586a4aa9da10a62002affb
Reviewed-on: https://gerrit.instructure.com/66077
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Ryan Allen <rallen@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
closes #CNVS-24658
Change-Id: I9317fc30990af17d5580827e36108668f0bf394a
Reviewed-on: https://gerrit.instructure.com/66166
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Fixes CNVS-22956
Test plan:
- Amazon's documentation is ambiguous about whether
ooto@simulator.amazonses.com will actually generate a
transient failure, so this may not actually work.
- Set up outgoing email through the Amazon SES test account
- Set up bounce_notifications.yml with the SQS test creds
- Set a user's email address to ooto@simulator.amazonses.com
- Cause a message to be sent to that user
- Wait for the bounce notification processor to run (~5 minutes)
- At a Rails console, check the CommunicationChannel's
last_transient_bounce_at and verify that it roughly corresponds
to when the initial message was sent
- Check the CommunicationChannel's last_transient_bounce_details and
ensure that they have been filled in
Change-Id: Ic3a4110319673d6ec6f0789885c760faec4775b3
Reviewed-on: https://gerrit.instructure.com/62562
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Alex Boyd <aboyd@instructure.com>
Fixes CNVS-24109
Test plan:
- Enable the International SMS feature flag
- Go to your settings page
- Click the button to add a new other form of contact
- Ensure that a disclaimer saying that "international text messaging
rates may apply" does NOT show up
- Select a non-U.S. country from the list
- Ensure that the above disclaimer now shows up
- Select the U.S. from the country list
- Ensure that the disclaimer no longer shows up
- Select a non-U.S. country and ensure that it shows up again
- Select the "[Select Country]" option
- Ensur that the disclaimer no longer shows up
- Disable the International SMS feature flag
- Go to your settings page, and refresh if necessary
- Click the button to add a new other form of contact
- Ensure that the disclaimer does not show up
Change-Id: I04493410be37fe3e1602c71ce1fc0618ed60a36d
Reviewed-on: https://gerrit.instructure.com/65789
Tested-by: Jenkins
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Alex Boyd <aboyd@instructure.com>
refs CNVS-22335
There are no automated test around this conversion so needs a well done
QA.
Test Plan
- Go to files section
- Ensure everything to do with showing folder and file previewws is
working
Change-Id: If10fcaf992dcb80ded031dcaddf41a347a6acceb
Reviewed-on: https://gerrit.instructure.com/61762
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Sterling Cobb <sterling@instructure.com>
and some other things too
test plan:
* regression test around the dashboard sidebar
closes #CNVS-22776
Change-Id: I46f1bd4476ca9aba27d41a4ce725c7dc2ee00dc5
Reviewed-on: https://gerrit.instructure.com/66056
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Ryan Allen <rallen@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
don't render on add until the collection is loaded
test plan:
* create a course with over 10 assignment groups
* it should work (and also load much better)
closes #CNVS-24118
Change-Id: I7c12e43042a2e0b0587e2a86fd4a9813c6cade28
Reviewed-on: https://gerrit.instructure.com/66096
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
Refs CNVS-10866
Decrease formating precision to remove floating point noise
Test plan:
- Create and take calculated questions with lots of big and small
numbers with varying significant digits
- Formating should be better, but any question that could be answered
before should still be able to be answered now.
- At least the following
123456789 * 10^-5
123456789123456789 * 10^-5
123456789 * 10^25
123456789123456789 * 10^25
123456789123456789123456789123456789 * 10^25
1 * 10^100
and the examples in CNVS-10866
Change-Id: I601633740665ad90a9b8e4086a6439ea8457a4ab
Reviewed-on: https://gerrit.instructure.com/63258
Reviewed-by: Davis McClellan <dmcclellan@instructure.com>
Tested-by: Jenkins
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
fixes CNVS-24183
test plan:
- create some text in tinymce and mark it as preformatted
- it should look visually distinct in the edit view
Change-Id: I3de45392657971e7f47f99414ee63419fb8628cd
Reviewed-on: https://gerrit.instructure.com/65708
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes CNVS-24178
- Updates FilesConverter so that it returns both files that will be
displayed in the ePub and the files that are unsupported.
- Adds CC::Exporters::Epub::FilesDirectory class, which accepts a
collection of file objects and adds them to a zip file.
- Updates UI so that a separate download link is present for the zip of
unsupported files.
- Adds support to MIME::Types library to be able identify ePubs.
- Updates EpubExport to have many attachments; one epub & one zip.
- Updates process of creating attachments related to EpubExports so that
the content_type value is properly set.
test plan:
- Have a course that contains files that are not supported by ePub, such
as pdf, doc or xls.
- Navigate to `/epub_exports`.
- Click the button to generate an ePub for the given course.
- Observe that, after the successful generation of the course, two
download links appear: one for the ePub, one for additional files.
Change-Id: I2f321362bc5ed23f8b28334395f8969c9d90a5de
Reviewed-on: https://gerrit.instructure.com/65753
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
Test Plan:
_ Tests should pass
_ Code review
* note this is a slow running spec and can be a P2
Change-Id: I9186089c94860c4d2402c9f12b6eec20f6cc7925
Reviewed-on: https://gerrit.instructure.com/66090
Reviewed-by: Derek Hansen <dhansen@instructure.com>
Tested-by: Jenkins
Product-Review: Derek Hansen <dhansen@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Add a spec to test that assignment due dates appear correctly
for different sections in the calendar agenda view.
Spec for test case C138848
Test Plan:
Run specs
Change-Id: Ib47890d4c92417da451aa6a1f8a94e44a480c523
Reviewed-on: https://gerrit.instructure.com/65949
Tested-by: Jenkins
Reviewed-by: Adam Phillipps <adam@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
Product-Review: Gentry Beckmann <gbeckmann@instructure.com>
QA-Review: Gentry Beckmann <gbeckmann@instructure.com>
includes n-strand improvements to perform load balancing
at runtime instead of queue time
(e.g. should prevent one strand from getting blocked when
queueing many imports at a time)
test plan:
* regression test delayed jobs
Change-Id: I2f616d380c841d7231af5159c09c24cbcc8d235d
Reviewed-on: https://gerrit.instructure.com/65976
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Change-Id: I3eb761f5ca80e1f59520ba63747e17189109d0e2
Reviewed-on: https://gerrit.instructure.com/66034
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
test plan:
- create a course with an assignment group containing a graded
discussion topic and a quiz (but no assignments as such)
- export the course to a common cartridge file
- selectively import the course:
* you should see the quiz and the discussion topic listed
under "Assignments" and your assignment group in the
select-content dialog
* checking the assignment should check the associated
quiz or topic and vice versa
* if the (entire) assignment group is selected, it should be
imported in a selected import
* if individual items (but not the entire assignment group)
are selected, they should be imported into an
"Imported Assignments" group
fixes CNVS-23017
Change-Id: I2553cbf87209ea89b01325da855f3bfd12aa31aa
Reviewed-on: https://gerrit.instructure.com/66023
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Pam Hiett