closes: CNVS-31787
the only things left in bower are things that
are just not avalable on npm because they are so old.
we'll have to continue using the bower versions of them,
but it's ok since they are mostly old ember stuff
that will be ripped out when we finish our react screenreader gradebook
also:
remove some ember stuff that wasn't being used anymore.
nothing was using this stuff
test plan:
this really does touch a lot of stuff. some things
to check out specifically in the prod/optimized requireJS build:
(load the page, click around to make sure things work)
the screenreader gradebook
client_apps:
quiz statistics
quiz event logging
creating a new student group
calendar, try all the views (month/agenda/etc)
gradebook 2
turn on the new course/user search feature for your account
and go to accounts/x and search for a user/course
the new react gradebook
use tinymce on a page, make sure that both the service
and local version of it work
Change-Id: I4322a154d289760ab51b92e34dd7fac808b41ba8
Reviewed-on: https://gerrit.instructure.com/93102
Tested-by: Jenkins
QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-32934
see
https://developers.google.com/web/updates/2015/03/increasing-engagement-with-app-install-banners-in-chrome-for-android#native
for how these work.
test plan:
* you have to be serving canvas over https://
* on android, install Chrome, or another browser that
supports Service Workers and manifest
* Visit the site over two separate days.
* Or, more usefully, enable chrome://flags/#bypass-app-banner-engagement-checks
* it should ask you to install the native canvas android app
Change-Id: I7c5cf8e9ecffd4dc52058bed865f82eaf3a7ea97
Reviewed-on: https://gerrit.instructure.com/93760
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
refs CYOE-310
Implement Noop AssignmentOverride set_type to persist a setless "tag"
Add MasteryPaths noop override to assignment, discussion, quiz edit
Add only_visible_to_overrides to Assignment copied attributes
Test Plan
1. Edit an assignment. From the "Assign to" dropdown select "Mastery
Paths."
2. Ensure "Everyone Else" override is removed from Assign to.
3. After saving, ensure the assignment is no longer visible to students.
4. Ensure adding other overrides (section, student) alongside MP allow
visibility as expected.
5. Ensure MP override is available and works as expected for other
"assignment types" including quiz and discussion.
6. Ensure when an assignment with the MP override is copied or imported,
its MP designation remains intact. (But any individual or section
overrides do not)
6. With the Mastery Paths feature flag disabled, the option should not
appear in the dropdown. If the flag is turned off, the MP override
should disappear but the assignment should stay invisible to students
until "Everyone" is added back again. If the flag is turned back on,
MP should reappear.
Change-Id: I17ac8345f872c111d073886c23bd7a3dd9b5dbce
Reviewed-on: https://gerrit.instructure.com/91833
Tested-by: Jenkins
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
closes CNVS-24092
closes CNVS-30394
closes CNVS-30342
Test Plan:
- Make sure the tray is accessible
- It should maintain focus within the tray when it is open
- Screenreaders should announce things properly
Change-Id: I743c663a9dcda369faee8986d63d549a96423b07
Reviewed-on: https://gerrit.instructure.com/84736
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
This includes a bump to the react-tray library so that it is
more compatible.
closes CNVS-26225
Test Plan:
- Make sure New UI works as intended
Change-Id: I43fd744db83fe5455a2e8e4347de624ddc344818
Reviewed-on: https://gerrit.instructure.com/78771
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
This commit is a squashed version of commits that were
merged to the dev/react-0.14.8 branch in gerrit.
The original commits are all listed below with the
JIRA tag modified and moved here
closes CNVS-24170
closes CNVS-26233
closes CNVS-28995
closes CNVS-26230
closes CNVS-26237
closes CNVS-26223
Test Plan:
- Regression test all parts of the app using
React.
This includes but is not limited to:
- Files
- External Apps
- Account Course User Search
- Theme Editor
- React Gradebook
- Moderated Grading
- Course Link Validator
- Epub Exports
- New UI Navigation
- New UI Dashboard
- Course Wizard
- Groups
Make Theme Editor selenium specs pass with React 0.14.8
CNVS-26306
Test Plan:
- automated specs pass
Reviewed-on: https://gerrit.instructure.com/78578
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com> (+7 squashed commits)
Squashed commits:
[bda75e1] Make React Gradebook selenium specs pass under React 0.14.8
CNVS-26233
Reviewed-on: https://gerrit.instructure.com/78540
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Clay Diffrient <cdiffrient@instructure.com>
[4f83c59] [spec] Fix account_course_user_search JS specs for React 0.14.8
CNVS-28995
Reviewed-on: https://gerrit.instructure.com/78164
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Tested-by: Clay Diffrient <cdiffrient@instructure.com>
[811ced9] [spec] Fix due_dates JS specs for React 0.14.8
CNVS-26230
Reviewed-on: https://gerrit.instructure.com/78269
Reviewed-by: Matt Berns <mberns@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Tested-by: Clay Diffrient <cdiffrient@instructure.com>
[d253b5b] [spec] Make gradebook JS specs pass with React 0.14.8
CNVS-26233
Reviewed-on: https://gerrit.instructure.com/78265
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Tested-by: Clay Diffrient <cdiffrient@instructure.com>
[4b8173c] [spec] Make moderated grading JS specs pass with React 0.14.8
CNVS-26237
Reviewed-on: https://gerrit.instructure.com/78264
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Tested-by: Clay Diffrient <cdiffrient@instructure.com>
[f4f074f] Bump react-modal to 1.2.0 for react 0.14.8 support
CNVS-26223
Test Plan:
- Make sure usages of modals in Canvas works
Reviewed-on: https://gerrit.instructure.com/77663
Product-Review: Ryan Shaw <ryan@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Clay Diffrient <cdiffrient@instructure.com>
[59de625] Bump React version to 0.14.8
This adds the ReactDOM dependency as well. The
dependency itself is accessible via react-dom or
ReactDOM to provide availability in some libraries
that expect "react-dom" and others that expect
"ReactDOM". Please prefer the "react-dom" syntax
when requiring it in your code.
CNVS-24170
Test Plan:
- Make sure all react sections of Canvas work
Change-Id: Ib10b7de33eb96a78a483d78b7b8d51eb224b81bf
Reviewed-on: https://gerrit.instructure.com/78262
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Clay Diffrient <cdiffrient@instructure.com>
Reviewed-on: https://gerrit.instructure.com/78662
Tested-by: Jenkins
QA-Review: Pedro Fajardo <pfajardo@instructure.com>
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
The library is no longer used anywhere in Canvas. This commit
strips the library and any remaining artifacts of its use
from the codebase.
closes CNVS-28551
Test Plan:
- Automated tests pass
- Files/External Apps still work
Change-Id: I2917d4d36e1fbbb4f94fff34b4344ecb47e81593
Reviewed-on: https://gerrit.instructure.com/76658
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Tested-by: Jenkins
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
This keeps our routing layer independent from our view
layer, thus shielding us from changes in the view layer
affecting the routing layer and vice versa.
closes CNVS-26296
Test Plan:
- Regression test everything in files, because this
seriously touches every aspect of files
Change-Id: I127623569cb3a63be0b29ab7ecd0e9051a960558
Reviewed-on: https://gerrit.instructure.com/76267
Tested-by: Jenkins
Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
the only thing that was using this were some specs
for moderatedGrading. since we only run our qUnit
tests in modern browsers that have native `Promise`
support, we don't need to polyfill it there
whenJS(someVal) is exactly the same as Promise.resolve(someVal)
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/resolve
test plan:
moderatedActionsSpec should pass
Change-Id: Ia0f8d24f8452bf0aafce8b11e4e36dad9e472797
Reviewed-on: https://gerrit.instructure.com/73243
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
skip-ci
This commit includes upgrading react-modal to v0.5.0
Test Plan:
- Tests should pass
- Anywhere react-modal is used (Files, Color Picker, etc.)
should work as expected
- There should be no warnings/errors in the console.
Change-Id: I25e585fe992001cb1a225b8f76c688854c072de6
Reviewed-on: https://gerrit.instructure.com/65971
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Tested-by: Clay Diffrient <cdiffrient@instructure.com>
This commit also upgrades React Router to version 0.13.4
skip-ci
closes CNVS-24259
Test Plan:
- Everything at /accounts/XX/settings/ on the Apps tab should
work as expected
- There should be no React related errors/warnings in the console
Change-Id: If36dfb32ad79ad164bd2d122ca72d42d2f3222bf
Reviewed-on: https://gerrit.instructure.com/65810
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Clay Diffrient <cdiffrient@instructure.com>
skip-ci
closes CNVS-24203
Test Plan:
- Make sure all tests pass
- Make sure all react areas in canvas work properly
Change-Id: If989f091ae6e45f0c47081464c739344822d2e4a
Reviewed-on: https://gerrit.instructure.com/59913
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Clay Diffrient <cdiffrient@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
also lay foundation for new account user search
test plan:
* in development mode, enable the
"Course and User Search" feature flag
* should be able to view the "Search" tab on the
sidebar (may need to resave the account to
clear the sidebar cache)
(replaces the "Courses" and "Users" tabs)
* searching for courses on the account page
should work pretty good
(the people tab is still forthcoming)
closes #CNVS-24750
Change-Id: Id44d1b3c7c36e407339858d2c1657579d1128abc
Reviewed-on: https://gerrit.instructure.com/65268
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
fixes CNVS-23816
fixes CNVS-23718
closes CNVS-23721
closes CNVS-23717
refs CNVS-23719
refs CNVS-19514
fixes CNVS-23719
note: feathj, cpalmer, and mnomitch
all worked on this jointly
test plan:
- general regression of calendar
- all 4 views
- with events, assignments, overrides
and scheduler
- with personal timezone and course
timezones different
CSS plan:
- stylistic regression of the calendar
- confirm that orange border around current day should show completely
hover:
- Create an event for the calendar
- Hover over the event, it should be pulling in the custom
color (it's not working if, on hover, it changes white)
big cal borders:
- The current date should have an orange background and now
is pulling in the border along the title at the top
Change-Id: I92df1271545db7a00fcd9695e018822279ba56d5
Reviewed-on: https://gerrit.instructure.com/65007
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
This is an initial stab at the conversion. It gets most of the
boilerplate stuff in and working.
It also handles converting over the publish button.
closes CNVS-23313
closes CNVS-23037
closes CNVS-22746
Test Plan:
- Set up your environment to function with moderated grading stuff
- Go to a moderated grading assingment as a teacher
- You should see the list of students that can be moderated
- Test Plan from CNVS-22746:
- Activate Moderated Grading feature flag
- Create an assignment that is moderated
- Submit a few assignments as students
- Go to speedgrader on those assignments and give
an initial grade
- Go to the assignment page as the teacher and
click the "Moderate" button
- Click the "Publish" button
- A confirmation box should appear
- Cancelling should do nothing
- Confirming should then flash a green success flash message
- The grades should now be published to the gradebook.
- The publish button should be disabled after doing the previous steps.
- Refreshing the page should still have the button disabled.
Change-Id: I15f4bc5d71f7bd3120c4c2ba2d4d239e8ad22db7
Reviewed-on: https://gerrit.instructure.com/63547
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
merge the dev/react-gradebook dev branch into
master, and put it behind a feature flag.
closes CNVS-23056
test plan:
go to account settings, and verify the
gradebook performance feature is turned
off. verify no bugs have been introduced
on the current, non-react-gradebook.
Change-Id: Ia1723d14df8bb77f91ffd832b446b0df842ac56e
Reviewed-on: https://gerrit.instructure.com/62978
Tested-by: Jenkins
Reviewed-by: Dylan Ross <dross@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
fixes CNVS-22400
test plan:
- run followin in JS console
m = require('moment')
m()
- a Moment object is returned
Change-Id: I424001d75d54c53fbf46a820875a10802e8a3902
Reviewed-on: https://gerrit.instructure.com/60308
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
Product-Review: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
fixes CNVS-21570
test-plan:
- visit a page in canvas
- open the javascript console
- run `require("moment")().format()`
- get a string representation of the current time
Change-Id: I3f5dc6978855574e13bcaa0100db792a726b8167
Reviewed-on: https://gerrit.instructure.com/57606
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
this change does a few things:
* removes 'smartbanner' from the 'common' css and
js bundles into it's own that is only loaded on
android devices. (this is a win since we only
use it for android anyway so we won't be sending
that needless css/js on every page load now)
* uses bower to load 'smartbanner'. this is good
since it makes upgrading easier and makes it clear
where the separation of our code and vendor code is.
* now, there are no files in our repo that are just
copy-pasted from 'smartbanner'
test plan:
* load canvas on a web browser on an android device,
it should show the "install the canvas native app"
just like it used to.
* load canvas on a normal browser, the banner should
not appear.
* aka, there is no observable change to users.
Change-Id: Ifed35a255d774a9148a90b1daf7b4c8e09af91ce
Reviewed-on: https://gerrit.instructure.com/54806
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes CNVS-21177
Turns the auth type selector into a react component
and makes sure it responds correctly in a couple
corner cases (with specs!)
TEST PLAN:
1) go to the authentication providers config page
2) add several authentication providers
3) you should always be scrolled down to your new
form when you add a new one
Change-Id: Ia520ee358dbc8a469e29e13fcd653cf11f9259b3
Reviewed-on: https://gerrit.instructure.com/56377
Tested-by: Jenkins
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes CNVS-20119; fixes CNVS-20139; fixes CNVS-20140;
fixes CNVS-20424; fixes CNVS-20426
This adds a new Dashboard view when using New UI.
Note: This is for New UI only. Legacy UI should only show Recent Activity on
dashboard (as it always has).
Test Plan:
- Login and make sure new UI is on
- Go to / and see the new Dashcard view.
It should look similar to: http://cl.ly/image/2R2K28183h2G
- Switch to "Recent Activity" by using the toggle
It should look similar to: http://cl.ly/image/2l1V1h421b0d
- Dashboard Cards have quick links on the bottom to quickly let you
navigate to within a course. These include:
- Discussions (if available)
- Announcements (if available)
- Files (if available)
- Assignments (if available)
If activity has happened in Announcements, Assignments or Discussions, an
active state is given to the quick link that makes it look like this:
http://cl.ly/image/1d3Y0T3w1Q01
Change-Id: Ia07f7f2711d6e0625d26d7ea5d050ccb51dc0128
Reviewed-on: https://gerrit.instructure.com/53043
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
Tested-by: Jenkins
QA-Review: Adam Stone <astone@instructure.com>
This is a squashed commit of g/54335 and g/54489
Because Internet Explorer is crazy and has SVGs as focusable by
default, we add the focusable="false" attribute to all the SVGs
so that they don't recieve focus in IE.
refs CNVS-18489
Test Plan:
- Turn on new styles (Settings > Feature Options > Use New Styles)
- Navigation should now appear as left panel
* Please note that sometimes because of caching it may take a bit for you
to see new styles, restarting the server makes this much quicker :)
- Verify inbox unread count should show if there are unread items.
- Verify links work, the inbox and calendar should take you where you want to
go.
- Verify the avatar image is shown on the Profile item.
- Verify Courses tray
* Clicking, or pressing Space/Enter on Courses should open tray
* Clicking away, or pressing Esc should close tray
* Focus should be returned to Courses when tray is closed
* The same behaviors should also work with any of the
- If you have admin (account) access, you should have an "accounts"
option. Clicking it should cause a list of accounts to fly out.
- If you have groups, you should have a "groups" option. Clicking
it should show the flyout list with groups in it.
- The Profile nav item should cause a profile flyout to open.
Change-Id: Id73bca9470d2fd422e56f6de317db5518b393923 (+1 squashed commit)
Squashed commits:
[3f96364]
refs CNVS-18489
test plan:
1.
2.
3.
4.
6. Verify Courses tray
- Clicking, or pressing Space/Enter on Courses should open tray
- Clicking away, or pressing Esc should close tray
- Focus should be returned to Courses when tray is closed
Change-Id: I904a344cfc5ae75e1e4757aab30796f98779e4f6
Reviewed-on: https://gerrit.instructure.com/54335
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
fixes CNVS-20652
test plan:
- go to SelRel student picker
- add a student and then re-click
the input with your mouse
- the input opens when you do this
- try this again a few times to make
sure behavior is consistent
Change-Id: I51524afec98708a24ccc534cd2b3967da6c51990
Reviewed-on: https://gerrit.instructure.com/54815
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
fixes CNVS-18413
test plan:
- on assignments, quizzes & discussions pages
- with DA on and off
- assign various due dates/(un)lock dates
to source sections, individuals, and everybody
- these should create overrides that properly take
students/sections and dates
- validations should work for all dates as normal
and not let empty overrides get created (with no
students or sections)
- the names of overrides should properly update as
students change
- as more overrides get created, saving assignments
should not slow down significantly
- the student/section selector should be intuitive
Change-Id: I1d4fafa8e4f52096ce88731cdb4bdf442eeb0f80
Reviewed-on: https://gerrit.instructure.com/51628
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
fixes PLAT-944
Test Plan:
- Go to external apps
- Add an app
- The modal should appear
- Press shift+tab
- Focus should not leave the modal
* Make sure the modal isn't borked in other places such as the
course wizard and new files preview.
Change-Id: Ibeec9d6182086e4e542996e1c646bb49bef8fad0
Reviewed-on: https://gerrit.instructure.com/51312
Tested-by: Jenkins
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
fixes CNVS-19468
no test plan
Change-Id: Id10b6d4885d9b920098930227da03edb9f6b0bed
Reviewed-on: https://gerrit.instructure.com/50868
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Mike Nomitch <mnomitch@instructure.com>
closes CNVS-19496
Minor upgrade from 4.1.7 to 4.1.9
TEST PLAN:
- Use the tinymce editor in various contexts
- there should be no significant behavior difference from 4.1.7
- Styles should still look good
Change-Id: I5470efd61ab3bdc8cdece017ab5e0fce827d62d3
Reviewed-on: https://gerrit.instructure.com/50856
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
refs CNVS-11523
this doesn't make use of 4.1.7, just gets it into the
repo so we have a stable installed version
Change-Id: Id5dd09574d1f74ec33ad373998510181deac7f28
Reviewed-on: https://gerrit.instructure.com/49996
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
closes: CNVS-18177
this commit just changes our bower version of react
and react-router to the latest and copies the
current versions we are using to
old_unsupported_dot_use_react.js ant
old_unsupported_dot_use_react-router.js
...and then points everyone's existing code to those
old versions, so that nothing actually changes.
but if you require 'react' or 'react-router' you will
now get the new version.
each team can now take the time to update their own code
to the new versions and when no one is using either
of these 2 old libraries we can delete them.
test plan:
poke around in newfiles, the course wizard,
the external_apps app, quiz-statistics and make
sure they still work. nothing should actually change
Change-Id: I99a3526a740ac82f350bb6dd1fd4f25e4fd92483
Reviewed-on: https://gerrit.instructure.com/47625
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
QA-Review: August Thornton <august@instructure.com>
fixes PLAT-731
fixes PLAT-774
fixes PLAT-679
Test steps:
- Add, remove, navigate and show apps
- Ensure that when the App Center is disabled,
you are only able to access the configurations
Patchset notes:
33: removed ability to destroy cache via api, removed reviews
37: rebased
37: fixed js map bug
Change-Id: I397aeab58ff50a5a930b39228571a7088e5784ce
Reviewed-on: https://gerrit.instructure.com/43818
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Reviewed-by: Brad Humphrey <brad@instructure.com>
Product-Review: Eric Berry <ericb@instructure.com>
react-router wasn't correctly firing the
route handler in IE10, resulting in a blank
page. This fixes that by updating react-router
to the newest version. Note that some of the
functionality is currently broken in IE,
such as styles and the FolderTree. Let's
do a run through of IE now that it's rendering
and make tickets of whatever is left to be fixed.
fixes CNVS-15930
test plan:
* Enable "Better File Browsing" feature flag
* Navigate to any course's Files tab in IE10
* The FilesApp should render and be semi-functional
Change-Id: I52e4ca73ace6ca0dec6b26a76c1a3cfa51e5d128
Reviewed-on: https://gerrit.instructure.com/42453
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Test Plan:
- Nothing really testable, since it just adds a library
Change-Id: Ib5977abeffdc759a57c5373e193a9b113af54a49
Reviewed-on: https://gerrit.instructure.com/41835
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
Product-Review: Jason Madsen <jmadsen@instructure.com>
QA-Review: Jason Madsen <jmadsen@instructure.com>
test plan:
* disable high-contrast stylesheet
* load calendar
* add events for multiple contexts
* verify that the colors used are bright
* enable high-contrast stylesheet
* load calendar
* verify that the colors used are dull
Change-Id: Id8b39aa1c683994411e9111e14667aab1f157fd1
Reviewed-on: https://gerrit.instructure.com/41072
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Braden Anderson <braden@instructure.com>
closes: CNVS-12642
closes: CNVS-11221
test plan:
nothing should have changed for courses/accounts that
have the feature flag 'better_file_browsing' turned off
but I guess make sure.
with it turned on, you should be able to browse the
files in your course, search for things, and re-sort.
it should paginate, download files you click on,
show thumbnails of files (where it has one) and you
and see the files usage in the bottom left.
things that I know dont work:
* the folder tree thing on the left is still
just static html, not the actual files in your course.
* it does full page reloads when you go from
looking at one folder to another or when you
search for something. I am going to fix that.
I know there is still work to be done here to consider
the entire files section complete, but this is a solid
foundation so that sterling and I can collaborate and
work forward.
Change-Id: Ia79ddba4318b7d6e52b38a87e91f615552da250b
Reviewed-on: https://gerrit.instructure.com/37491
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Sterling Cobb <sterling@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
we aren’t using jsx (yet, anyway) bring it into a
module like anything else:
define ['react'], (React) ->
There’s also a helper module to make building
your UI simpler at `compiled/withReactDOM`. It
safely moves everything from `React.DOM` to window
during a function call for convenience.
Change-Id: Ibf64f0b207411c31b92f30dddc6ce188d9462e11
Reviewed-on: https://gerrit.instructure.com/37376
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Ryan Florence <ryanf@instructure.com>
QA-Review: Ryan Florence <ryanf@instructure.com>
to get case insensitive file extension fix
fixes NTRS-608
Change-Id: I7a4f3fa4fb80c24b32e211c197dde844a7117c7d
Reviewed-on: https://gerrit.instructure.com/37047
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
QA-Review: David Josse <david@instructure.com>
Product-Review: Paul Hinze <paulh@instructure.com>
this commit is meant to be a way to commit some of
the progress I have been making on this. everything
new is behind a hidden feature flag so it should
not do anything any different for any existing users
if you want to test it out, open a console
and do:
Course.find(<your course id>).enable_feature! :better_file_browsing
then browse to the 'files' part of your course.
the main thing to QA right now is that we did not
break anything for people that don't have that
feature flag turned on. I know there are a ton of
things that are either broken or still need to be
implemented on the new app.
this is a few commits squashed into one and
closes multiple tickets:
create rails routes for new files UI
closes: CNVS-12140
for the new files UI we are going to use pushState
urls so we had to find a url namespace that we
could completely take over. the thing we chose was
/(courses|groups)/<course_id>/files/folder/foo/bar/baz
(assuming you were looking at the foo/bar/baz folder)
example urls:
/course/1/files/folder/foo/bar/baz
/groups/2/files/folder/lectures/1 Cell Mitosis/handouts/takehome work/
/files
/course/1/files
acceptance criteria:
the following NEW urls SHOULD be routed to new
ember files page:
/(courses|groups|accounts|users)/:id/files/folder*full_path
/dashboard/files/folder*full_path
/files/folder*full_path
the following urls already exist and if the
:new_files feature is enabled SHOULD be routed
also to the new ember files page instead of where
they go now (but if the :new_files feature is not
enabled, they should still go where they go now):
/files
/(courses|groups|accounts|users)/:id/files
/dashboard/files
style mockups for the new files page
fixes CNVS-11216
Enable feature flag for new files page, closes #CNVS-11215
closes: CNVS-12730
closes: CNVS-12659
closes: CNVS-12663
Change-Id: I3868fcf8efd6b517f38f56e88c7bb1e56cf564e8
Reviewed-on: https://gerrit.instructure.com/36005
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
this release of ic-menu has fix for conditional items being ordered
correctly and adds ability to have a disabled menu item
closes CNVS-13355
test plan:
- enable ember quizzes
- navigate to an existing quiz overview / show
- click the admin cog in the top right
- lock, or unlock the quiz
- click the cog again
- using up and down keyboard arrows navigate through menu
- verify that the key navigation order syncs with the visual order
in the list
Change-Id: Ica4809c1454fcc0204155d60a429852f1af1bbc3
Reviewed-on: https://gerrit.instructure.com/35803
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Jason Madsen <jmadsen@instructure.com>
closes CNVS-11294
test plan:
- enable ember quizzes
- ensure that existing ember quizzes continue to work
- all existing ember tests should continue to pass
Change-Id: I4f56b1267504533be8332520ea5f77d2fa566263
Reviewed-on: https://gerrit.instructure.com/33105
Reviewed-by: Derek DeVries <ddevries@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Jason Madsen <jmadsen@instructure.com>
fixes CNVS-12227
test plan:
* create at least 20 courses
* enable and open calendar 2
* verify that all neighboring courses have visually
distinctive colors
Change-Id: I2d3f9fb0e669cbc4fcda55a432cba07c18dbdfb5
Reviewed-on: https://gerrit.instructure.com/32931
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Braden Anderson <banderson@instructure.com>
Change-Id: Ib1a4175ab7284a7598acb9d8b973876364cad7b6
Reviewed-on: https://gerrit.instructure.com/30364
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Stanley Stuart <stanley@instructure.com>
Product-Review: Stanley Stuart <stanley@instructure.com>
QA-Review: Stanley Stuart <stanley@instructure.com>
closes CNVS-6506
test plan:
- enable kaltura plugin as site admin
- enable js_kaltura_uploader on Account.default.settings
- go to assignment that has kaltura record / upload enabled as student
- upload a file via the RCE
- experience should mimic existing flash uploader
- verify that audio and video recording continue working as before
- disable js_kaltura_uploader on Account.default.settings
- as student attempt to upload to assignment
- verify that it continues to work as before
Change-Id: I1f4ba5ac5df5e023f74046f33d7c623cac924ee3
Reviewed-on: https://gerrit.instructure.com/30340
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Product-Review: Jason Madsen <jmadsen@instructure.com>
Ryan Shaw