The modifier while/until construction should not be preferred.
The style guide has been updated to reflect this:
https://gollum.instructure.com/Ruby-style-guidelines#While/Until
Change-Id: Ib1b8b3cf29d52729ba9d3f9066554fc421d47111
Reviewed-on: https://gerrit.instructure.com/52997
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: Strand McCutchen <smccutchen@instructure.com>
QA-Review: Strand McCutchen <smccutchen@instructure.com>
The cop wants to see stabbies used for single-line
lambdas, and the lambda method for mutli-line lambdas.
This is dumb cause stabby lambdas should be used everywhere!
Change-Id: I6e9c948688b7192a34a0cff37fe1d1cadcbd047f
Reviewed-on: https://gerrit.instructure.com/52877
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Benjamin Porter <bporter@instructure.com>
QA-Review: Benjamin Porter <bporter@instructure.com>
Change-Id: I13490195e05df00d58c190761711fe6002b7d6cd
Reviewed-on: https://gerrit.instructure.com/52310
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
This commit removes the ostentatious AbcSize metric from rubocop,
and changes the following severities:
- Style/RescueModifier from convention to warning
- Lint/AmbiguousRegexpLiteral from warning to convention
- Performance/Detect from convention to warning
Change-Id: I6737b4feafaab2d4f94a44cf5f750e8c1779ca38
Reviewed-on: https://gerrit.instructure.com/52220
Reviewed-by: Cameron Matheson <cameron@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Ethan Vizitei <evizitei@instructure.com>
closes CNVS-19816
make sure we have a spec to check rendering of the plugins
setting view from now on, and explicitly require 'dynamic_form'
in the plugins controller
also removes a linter that shouldn't be on for
describing classes (or views in this case)
TEST PLAN:
1) go configure any plugin
2) it should not explode
Change-Id: I32e58a524ddb18b922ba79e20e9e7b9c1f2a8f07
Reviewed-on: https://gerrit.instructure.com/52216
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
Change-Id: I5e1cea86576ae1787b3c837d4594d0a7c3e687d8
Reviewed-on: https://gerrit.instructure.com/51991
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Dana Danger <dana@instructure.com>
add migration lint as rubocop cops
create frozen constant linter
find_ids datafixup lint
send_later lint
lint send_later in predeploys
add freeze_constant cop to default config
don't forget to include rubocop when running
get the rubocop runner into the script
lint for wrong algorithm name
lint primary key
lint remove_column in predeploys
get rubocop output as parsed json
diff munging for gergich
disable a few style cops
tweak rubocop setup to allow IDE plugins to work
get gergich comment format right
shell out to gergich if we're in jenkins-land
Change-Id: I6eecc8d8ede17a755c9d9a86121c3658776de9cd
Reviewed-on: https://gerrit.instructure.com/51755
Tested-by: Jenkins
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Rob Orton