refs VICE-1507
flag=deprecate_sms
test plan:
**BEFORE running migration**
- set a custom override on your root account
> account.settings[:allowed_sms_notification_categories] = 'foobar'
> account.save!
**AFTER setup**
- run migrations
- confirm that your previous setting has been removed
qa risk: low
Change-Id: Idba401d78f474e441f379c7ad173a6a65a5e119b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/272556
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs QUIZ-8355
refs QUIZ-8354
test plan:
- run the migrations
- access the rails console
- there should be 2 new placements (ContextExternalToolPlacement records)
for each Quiz LTI tool, with the placement_type values
'account_navigation' and 'course_navigation'
- each Quiz LTI tool (ContextExternalTool records where
tool_id = 'Quizzes 2') should have a new 'account_navigation' hash added
to its settings field with the following value:
{
"custom_fields"=>{"item_banks"=>"account"},
"default"=>"enabled",
"text"=>"Item Banks"
}
- each Quiz LTI tool should have a new
'course_navigation' hash added to its setting field with
the following value:
{
"custom_fields"=>{"item_banks"=>"course"},
"default"=>"enabled",
"text"=>"Item Banks"
}
- re-running the migrations should not re-create placements
- the migrations should not create placements for deleted
Quiz LTI tools
- the migrations should not update the settings fields of
deleted Quiz LTI tools
Change-Id: Ib430bdf18e97d76393475e243d3efc3ea1c51dcd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264152
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Han Yan <hyan@instructure.com>
QA-Review: Mark McDermott <mmcdermott@instructure.com>
Product-Review: Jorge Arteaga <jorge.arteaga@instructure.com>
closes LS-1182
flag = submission_type_tool_placement
Test Plan:
- spec runs ok
Change-Id: I36eb9050e9dc4114cad87ebf4101413d69d7b93e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/242136
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Clint Furse <cfurse@instructure.com>
turns out putting unique in the name of an index is not enough to
actually make it unique.
test plan
- migrations should run
fixes KNO-410
Change-Id: I889d436f24cc8a3ec1d914589d26c1e68bfc2594
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/234406
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Test plan:
-migrations run
Fixes KNO-476
flag=account_pronouns
Change-Id: I95fcb90b891cc20be6f3de1e88a138ee2007a3bd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/236947
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
such as gradebook column settings stored for every
course, etc
test plan:
* all user preferences should behave as before, such as
gradebook column sizes, course nicknames,
dashboard card color settings, etc
closes #LA-571
Change-Id: I6896e0d97d577c554d450f377137cb4d6e78e2ef
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/226119
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
This reverts commit ec90fe1357.
the validation check might fail, because it uses a cassandra commit
Change-Id: Ia8be0df1d7de5716f6ec376589af1532b9d84a18
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/227042
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
Tested-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes COMMS-1971
Test Plan:
** DO THESE BEFORE CHECKING OUT THE PS
- With notorious running create a bunch of videos with
the rce or submission contents
- while watching the video click on the cc button
on the video
- add a bunch of closed captions of SRT type (or media tracks
as they are stored in the db)
- notice that the cc play on the video
CHECK OUT THE PS
- migrate your db
- notice the column on MediaTracks that you added called
webvtt_content is now populated
- upload another srt file to a video
- notice it still plays
Change-Id: Iba0004ace0a248d8ed28ffe3015dbf5c5d3ddeee
Reviewed-on: https://gerrit.instructure.com/188126
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Landon Gilbert-Bland <lbland@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Burnett <sburnett@instructure.com>
currently works for enrollments created after the link but
this will fix it so it looks across the trust for existing
enrollments when creating the link
also remove enrollments across trust when link is deleted
and require root account because why not
closes #CORE-2486
Change-Id: I861690eee819d14f9520084aa55cfa051a32aca1
Reviewed-on: https://gerrit.instructure.com/181448
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
need to move it after the url before the quote
closes #CORE-2289
Change-Id: Ia1e13d79ceab35b4d31e1c87e03c313fd8797575
Reviewed-on: https://gerrit.instructure.com/176026
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
woo
Change-Id: I1c3045f001626bee41ee669e8bbe86ea708b8080
Reviewed-on: https://gerrit.instructure.com/160230
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
this cleans up some assignment override issues that periodically
cause support week issues:
- AssignmentOverrideStudents that are not associated with an
AssignmentOverride, or are associated with a deleted one
- AssignmentOverrides that are not associated with a quiz or
assignment, and the AssignmentOverrideStudents associated
with them
closes ADMIN-1060
Change-Id: I7c23cae3127776ec9b2166ed735428efcf687e7f
Reviewed-on: https://gerrit.instructure.com/153392
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Mysti Sadler <mysti@instructure.com>
Tested-by: Jenkins
QA-Review: Mysti Sadler <mysti@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
I couldn't take it anymore. it was driving me crazy
Change-Id: Ib40addff56e98a6e0a6d80f246c208e0ce0cb762
Reviewed-on: https://gerrit.instructure.com/148026
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Change-Id: Id3e1d88c0ed376713eb106b65cc4b7ecbe2878d1
Reviewed-on: https://gerrit.instructure.com/146427
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
rails uses callbacks internally to manage dirty state tracking. in
a recent update, skipping these callbacks when saving a new object
breaks any future updates to that object (because id_from_database is
not populated, which is then used as `nil` when trying to do
a subsequent update). see:
6932998fc7 (diff-1a091d0f7eb7b0b2ca95c82f5ba0e1fb)
Because of that I feel like saving without any callbacks is somewhat
dangerous. I think if you have to do it, use one of the built in active
record methods that skips callbacks:
http://guides.rubyonrails.org/active_record_callbacks.html#skipping-callbacks
Or use our active_record-suspension gem to skip specific app-level
callbacks.
test plan: tests pass
Change-Id: I7bfb87e328317430fb2a77edca56cace2cd372b5
Reviewed-on: https://gerrit.instructure.com/146139
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
test plan:
* use the User Observees API to link and unlink
students and observers - noting the additional
optional 'root_account_id' argument
and the returned 'observation_link_root_account_ids'
value
* user observation links (user_observers) should
behave similar to before (especially in the majority
of cases where users and observers are associated
with a single account), with the exception that
only courses in linked root accounts will
automatically add the observer
closes #CORE-1065 #CORE-1066
Change-Id: I056596c022b373cd93519ae2773f9bb1023613eb
Reviewed-on: https://gerrit.instructure.com/143124
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
for my sanity because it's too confusing to actually refactor
closes #CORE-1140
Change-Id: I445e0edeb3fde76ffd02a467180ee7a83d916067
Reviewed-on: https://gerrit.instructure.com/143538
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Closes: GRADE-861
Test Plan
- Verify there are no N+1 queries when loading speedgrader
caused by originality reports
- Verify there are no N+1 queries when loading gradebook
caused by originality reports
- Verify originality reports are copied to all submissions
in a group when they are created or updated in a group
assignment.
- Verify online upload originality reports are displayed
correctly in speedgrader, gradebook, student grade page,
and submission details page.
- Verify originality reports display properly in gradebook
and speed grader when there are multiple submissions
and each has a different originality report.
- Verify the "resubmit to plagiarism tool" button still
appears in speedgrader.
- Verify originality reports for group assignments are displayed
correctly.
- Verify text entry originality reports are displayed correctly.
- Verify originality report launches work correctly from speedgrader
and gradebook.
Change-Id: I459bbf0a165bb131d58fc153feb0dce3d0bf07af
Reviewed-on: https://gerrit.instructure.com/141321
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
all of them should be migrated over now
Change-Id: I4663d44ccafd913087ecef3cf89809473e5be202
Reviewed-on: https://gerrit.instructure.com/129707
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
closes #CNVS-38965
Change-Id: I3ae429608b323da9ed95ec0ee8da9e3c5a67c394
Reviewed-on: https://gerrit.instructure.com/125186
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Cody Cutrer