- Change the table to be a set of flexbox divs.
- Maintain the standard layout on screen sizes > 900px;
- At 900px, it converts to labels being above form elements,
as opposed to labels being beside form elements.
- Also update the license help modal to use
flexbox divs instead of tables for layout.
- Bolds the labels to make them stand out a bit more.
See what it looks like in this video. https://instructure.slack.com/files/UJFBF3Z37/F0108AS2W1M/scale.mov
Test plan:
Navigate to a course settings page.
Change the viewport to 320px wide.
Navigate and see the checkboxes are
not overlaid on top of the label text.
Navigate the page with a screenreader
- controls still have appropriate labels and roles.
Refs LA-558
Change-Id: Id17ca65c69fef4e02690943d22df6568538ecd79
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230163
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
and translate it
refs #CORE-2757
Change-Id: I809d9938a22bb6a91b9fc10c89e1b328e869f319
Reviewed-on: https://gerrit.instructure.com/188846
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
fixes: PFS-4864
Test Plan:
- Setting the Course level select will set the public flag, or public to
auth flag
- When selecting the Customize checkbox the options for Syllabus will
display
- When setting Course level to a more public option, the customize
select will remove more restrictive options
- Syllabus public flag or authorized flag will be set with select.
- Users with out edit permissions do not see the selection options.
Change-Id: I58bb0b0df7f1ded524b9ec896836d1e6527a01b5
Reviewed-on: https://gerrit.instructure.com/86096
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Christi Wruck
this file was being loaded directly via html and rendered in the page,
which bypassed the possibility of properly translating the strings in
the file.
fixes CNVS-7053
test plan:
- enable the kaltura plugin (with and without the html5 uploader)
- go to conversations, compose a message, click the media upload button
- content in the dialog should be translated (other than the actual
"use the camera" warning message)
- spot check other places that use the media upload button (like
speedgrader comments)
Change-Id: I3d38e923f840567a571b8aa607684b78599f7dbf
Reviewed-on: https://gerrit.instructure.com/62422
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Adrian Russell <arussell@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-6505
test plan:
* enable kaltura;
* in conversations, click the "Compose a new message"
button and then, in the new message dialog, click the
media record button;
* using a screen reader, verify that the webcam and audio
buttons in the record media tab read as, "record with
webcam" and "record with microphone only" respectively.
Change-Id: If98ebb62efbc13d1b272d08ea51847ad6cbae27a
Reviewed-on: https://gerrit.instructure.com/24231
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <banderson@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
test plan:
- record a video or audio comment, and enter a long title.
it should prevent you from entering more than 255 chars
(rather than failing to save the media comment)
fixes CNVS-4446
Change-Id: Iec4d022bba3b33f5bf678ed7ca37c366a337b3f1
Reviewed-on: https://gerrit.instructure.com/20944
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
test plan:
* in the editor, open the record/upload media tab
* note style changes
fixes #CNVS-4440
Change-Id: I8d5620fe5a137029c9581e8668bec77021728cf6
Reviewed-on: https://gerrit.instructure.com/18527
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
This fixes a few formatting items in tiny mce. In
particular, it fixes the recording tabs (when
uploading and making a video recording) As well
as when adding a link, the field and buttons are
now fixed.
Change-Id: Ibd91959cbd4e285b2979c8f86571111d7c906b89
fixes: CNVS-4303
Reviewed-on: https://gerrit.instructure.com/18207
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
in order to not have to support buttons with .ui-button AND
.button AND .btn classes this simplifies and and makes our
codebase more consistent by deprecating the .button class
with .btn
Change-Id: I4802d785a47b36aa477f302e6ac8c87715db8a62
Reviewed-on: https://gerrit.instructure.com/15194
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
does a few things: consolidate the help
and support links at the bottom of the page
into 1 and calls them "help"
allows a school to set their own custom
help links to show in the help dialog so
they can link to their campus LMS support
in addition to our help options.
also cleans up the flow for teacher feedback and
submitting a ticket.
test plan:
* go to the account settings page of a root account
* you should see an option there to set up "custom
help links", create a couple
* click the help link in the footer and the top left,
a dialog should appear with the old options as well
as the ones you set up.
* as a student, click the help link, click the teacher
feedback option, fill out the form, the teacher AND TA's
in that class should have got a canvasation.
* click the file a ticket option, fill out the form,
zendesk should have a new issue with the
* and of course the specs in helpDialogSpec.coffee and
help_dialog_spec.rb should pass
Change-Id: If2d841c00b28ece55eb118085ee8728b0de96c08
Reviewed-on: https://gerrit.instructure.com/7153
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Changed the "feedback" link to say "help" instead, and put a
dialog in front of the original feedback dialog which helps
point users to additional useful resources.
Also added account#custom_feedback_links so that plugins can
optionally add other useful links to this help dialog.
fixes#177
Change-Id: I31e855cbf83475006dd530cd027aff123a75d56a
Reviewed-on: https://gerrit.instructure.com/5310
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
changed the buttons to be actual <a>s with role=button
and use aria-checked="true/false" to reflect state.
Change-Id: I083f6db51bc5b2c4900fb9b41ac2f870247aa01d
Reviewed-on: https://gerrit.instructure.com/4920
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
We've made modifications to Kaltura's swf recorder that will
allow it to record either just audio or audio and video, with
both options now available from the same swf file. I've also
made some additional tweaks to the UI to help clean things up
in this interface.
Also included a fix for enabling storing to Kaltura over SSL.
Change-Id: Ia30b407ea1f0b049f7553d11195fceee75f23e7a
Reviewed-on: https://gerrit.instructure.com/3404
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
Also bumped up the limit to 100MB, and started making it configurable via the
plugin.
Change-Id: Iee000afa2d6b68b48357931dfcd72ab3fde9ddf7
Reviewed-on: https://gerrit.instructure.com/3235
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Alex Anderson