also fix a bug dismissing the feature flag dialog with
the keyboard.
this feature is a one-way gate. once it's enabled, it can't
be turned off.
test plan:
- ensure you're given a warning before enabling the feature.
* ensure that closing the dialog with Esc or clicking the
Cancel button work as expected.
- ensure you can't turn it off again afterward.
* make sure the state of the switch doesn't make it
appear that you _did_ turn it off if you dismiss
the dialog with Esc instead of Cancel
closes CNVS-28143
Change-Id: I68480cbd1b6877c2c05ba79cf230c92ebc8be3b1
Reviewed-on: https://gerrit.instructure.com/77771
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Allison Weiss <allison@instructure.com>
refs #CNVS-27549
Change-Id: Ia6091a7e3b6a9858c4ee01681aef90c145269e8c
Reviewed-on: https://gerrit.instructure.com/73897
Tested-by: Jenkins
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
closes #CNVS-27699
Change-Id: I5af3d9915fef4189204283ca87cafc540ed3eed4
Reviewed-on: https://gerrit.instructure.com/73566
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
fixes CNVS-21995
Change-Id: I0e30cbf1508fdbe2a06e3b75f52146ea22c4234a
Reviewed-on: https://gerrit.instructure.com/61058
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Dana Danger <dana@instructure.com>
closes CNVS-21601
test plan:
- Differentiated Assignments should be on for all courses in all accounts
Change-Id: I24142a2e8e20186c62de5ef8db909e13b87f44e6
Reviewed-on: https://gerrit.instructure.com/57502
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>
Closes CNVS-19694
Test Plan:
- Confirm no dates appear on feature flag.
Change-Id: I4935fcec4e2d6f0a5b5ffa769f9aa87da6e6294b
Reviewed-on: https://gerrit.instructure.com/52148
Tested-by: Jenkins
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>
Closes CNVS-17903
Test Plan:
- Confirm that Quiz Statistics are active on all courses
Change-Id: I08b37869a6c25405aa380d8ff7da8b6409dc9dc2
Reviewed-on: https://gerrit.instructure.com/47021
Tested-by: Jenkins
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
Closes CNVS-17020
Adds a small app for browsing quiz submission events for a student's
submission. Re-architectures the previous canvas_quiz_statistics client
app to now host more than 1 app. Common code between the two apps is
factored out into /apps/common/{css,js,test}.
Also:
- a feature flag for quiz log auditing
- renamed previous QuizSubmissionEventsController to an Api one
- an API endpoint + controller action for retrieving/viewing events
- "canvas_quiz_statistics" merged with the new client app
"canvas_quizzes"
TEST PLAN
---- ----
Make sure you build the assets by running `bundle exec rake
canvas:compile_assets` before doing any of this.
Now:
- take a quiz as a student
- as a teacher, view the student's attempt
- click on the big "View Log" link
+ verify the page loads and you can browse around in it
We also need to test stats, because the commit affects it:
- turn on the new stats feature flag
- go to stats:
+ verify the page loads and looks OK
Try both pages another time with the ?optimized_js=1 parameter added to
the URL to make sure nothing went wrong when they were optimized.
Change-Id: I5a30cb0db05e80084d1ddd595b53f9aa3cf336eb
Reviewed-on: https://gerrit.instructure.com/44576
Reviewed-by: Derek DeVries <ddevries@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
fixes CNVS-17452
test plan:
as account admin that is not a non-siteadmin,
make sure you can enable DA for your root account
Change-Id: I6c904c50f89d78a757f709cb2bd16a6d7c2218ff
Reviewed-on: https://gerrit.instructure.com/45656
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-16920
Change-Id: Ibca09a92a7d77782f33d0d766f6a2f7f3923c179
Reviewed-on: https://gerrit.instructure.com/45419
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
test plan:
* basic regression test on assignments, discussion topics
gradebook, and modules (mostly make sure the basic
index/show/edit views aren't broken)
closes #CNVS-15563
Change-Id: I3411bfb7645b3c4bf8a4663e3e052b4402f899ba
Reviewed-on: https://gerrit.instructure.com/43609
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
- The "New Quiz Statistics" feature flag now converts the regular
statistics page into the new one that uses the React/CQS client app
- All Ember quizzes code gone
- canvas_ember_urls gem gone
- quiz_moderate feature flag gone
- quiz_stats feature flag is now allowed in prod
- statistics_cqs explicit/hidden route gone, but the statistics_cqs ERB
and coffee bundle are still there to help ease the transition later
Closes CNVS-16330
TEST PLAN
---- ----
- go to /courses/:course_id/quizzes/:quiz_id/statistics
+ verify you get the old/regular stats page
- enable the "New Quiz Statistics" feature flag
+ refresh that page, verify you see the new app
Now turn the flag on and off and play around the quizzes pages, verify
everything looks OK.
Change-Id: I01fc5da80fd206df08338823ffb446a1e3a06ed0
Reviewed-on: https://gerrit.instructure.com/42965
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Reviewed-by: Derek DeVries <ddevries@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
fixes CNVS-15750
test plan:
- DA on
- make a module and visit the modules page as a student
- as the teacher unenroll the student from a section
- there should be no error when you unenroll the student
- DA off
- same thing
Change-Id: I9c2356cdb034b25e63b9693a610849072513e49b
Reviewed-on: https://gerrit.instructure.com/41744
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
also remove the 'development' tag on existing features, other
than those that manually made themselves invisible in prod.
we'll let 'beta' suffice for the purpose of informing the user
that a feature is not fully baked.
test plan:
- Deploy normally to your QA portal. The 'quiz stats'
feature flag should be available and operational.
- Remove the testcluster.yml file from your config/
directory (or move / back it up to a safe place)
- Restart your QA portal.
- The quiz stats feature flag should not be available
or visible.
fixes CNVS-15724
Change-Id: I9e4e46f8cc4f54ac62f5226dbca09ae4885c93a9
Reviewed-on: https://gerrit.instructure.com/41551
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
fixes CNVS-14095
fixes CNVS-15157
test plan:
- with DA on and off
- go to modules page
- only the right assignments show
- completion requirements ignore
assignments that cant be seen by a user
- modules page works with changing sections
- complete/incomplete updates properly
- as does locked/unlocked
- modules page shows correct content when
a students grade is deleted and this makes
them lose assignment visibility
- modules api doesnt return any content that
a student cannot see
Change-Id: Ia1acfd919214823cdfc3b45e974876b4529bb14d
Reviewed-on: https://gerrit.instructure.com/38970
Product-Review: Hilary Scharton <hilary@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Mike Nomitch <mnomitch@instructure.com>
closes CNVS-14678
This commit allows the quiz stats feature flag to be registered only when
within the beta environment (or development or test). It should not be available in production.
Test plan
- Deploy normally to your QA portal. The 'quiz stats' feature flag should
be available and operational.
- Remove the testcluster.yml file from your config/ directory (or move
/ back it up to a safe place)
- Restart your QA portal.
- The quiz stats feature flag should not be available or visible.
Change-Id: If51af6bae18b31fed8f7b2d666f59562ad0fb18e
Reviewed-on: https://gerrit.instructure.com/39330
Reviewed-by: Derek DeVries <ddevries@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Josh Simpson <jsimpson@instructure.com>
this hard-codes draft state to on in the code, but still allows tests to run
against non-draft state code (as if it was still set to allowed). this allows
us to then go clean up tests on a component by component basis as we rip out
old non draft state code
closes CNVS-13582
test plan:
- basic canvas regression test
- make sure draft state is on for all courses
- make sure it cannot be turned off at the course or account level
Change-Id: Ia22e6b8a7e40a64b42021846f2fe85aaf3005504
Reviewed-on: https://gerrit.instructure.com/37260
Reviewed-by: Bryan Madsen <bryan@instructure.com>
Product-Review: Bryan Madsen <bryan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
test plan:
* as an account admin (but not site admin), verify
that you can see the draft state feature in your
account;
* as a teacher, verify that you cannot see the draft
state feature in your courses until the account admin
has set the feature to 'allow.'
Change-Id: I5d2f54d9ee0b50742b8011b1d9b777c9825030a1
Reviewed-on: https://gerrit.instructure.com/32255
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Clare Strong <clare@instructure.com>
the DraftState::Publisher needs to be in the Features module
in order for the jobs daemon to find it
test plan:
- allow draft state in an account
- enable draft state for a course in the account
- have unpublished items in the course:
- assignment
- module
- module item
- discussion topic
- turn draft state off in the course
- the unpublished items listed above should be published
fixes CNVS-10967
fixes CNVS-10156
Change-Id: Id3764cc9e7a758820337d4950d81db59271f913f
x
Reviewed-on: https://gerrit.instructure.com/29902
Reviewed-by: Mark Severson <markse@instructure.com>
Product-Review: Mark Severson <markse@instructure.com>
QA-Review: Mark Severson <markse@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
test plan (non-draft-state):
- as a teacher
* create each of the following:
- assignment
- discussion
- page (hidden from students)
- page (not hidden from students)
- quiz (leaving it unpublished)
* add each of the above items to a module
* refresh the modules page
- each of the above items should be listed
- as a student
* navigate to the modules page
- the hidden page and quiz should not be listed
- all other items should be listed
* click on the first item in the module
* click through each of the 'Next' buttons
- only items listed in the module should be presented
test plan (draft-state):
- as a teacher
* create each of the following:
- assignment
- discussion
- page
- quiz
* add each of the above items to a module
* refresh the modules page
- each of the above items should be listed
- as a student
* navigate to the modules page
- only published items should be visible
* click on the first item in the module
* click through each of the 'Next' buttons
- only published items should be presented
* publishing items (as a teacher) should make them available to the
student in the module progression as well as the modules page
closes CNVS-10831
Change-Id: Ia84e56f42438ff531a4e15784eefaec2ead8ecdd
Reviewed-on: https://gerrit.instructure.com/30312
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
fixes CNVS-9352
test plan
- as an admin
- go to the account settings page
- go to the "Feature options" tab
- the wording for "Draft State" should be updated to reflect that
disabling the feature may delete newly created/edited content from view
Change-Id: Iac2cb54f0fe4382af2ab0dfe7c3c21bd1e46d46e
Reviewed-on: https://gerrit.instructure.com/29097
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Stanley Stuart <stanley@instructure.com>
Product-Review: Derek DeVries <ddevries@instructure.com>
test plan:
1. have an account with draft state allowed
2. have a course in the account with draft state enabled
3. have unpublished things in the course:
- quizzes
- wiki pages
- assignments
- discussion topics
- modules
- module items for each of the above
4. turn off draft state in the course
(not in a parent account)
5. verify the unpublished quizzes are still unpublished
6. verify the unpublished wiki pages are now "hide from students"
7. verify the unpublished assignments, discussion topics, modules,
and module items are now visible to students
8. re-enable draft state and the things that were published by
step 4 should still appear published (green cloud icon, etc.)
fixes CNVS-10358
Change-Id: I3945b21f7e700d427cbaf98289b5db658b61f73f
Reviewed-on: https://gerrit.instructure.com/28650
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
test plan:
0. render and consult the API documentation on feature flags,
specifically looking at the 'transitions' member that
was added to FeatureFlag
1. enable draft state in a course
2. use the API to show the draft state feature flag for the
course (GET /courses/X/features/flags/draft_state)
- verify that transitions['off'] contains a warning
message about what happens to unpublished data
3. allow draft state in an account
4. as a non-site-admin user, use the API to show the
draft state feature flag for the account
(GET /accounts/X/features/flags/draft_state)
- verify that transitions['on']['locked'] is false
- verify that transitions['off']['locked'] is true
and is accompanied by an explanatory message
5. attempt to turn the feature off via the API
(still as a non-site-admin user)
- you should get a 403 Forbidden error
6. repeat step 4 as a site-admin user
- neither transition should be 'locked', but the
message should still accompany 'off'
7. repeat step 5 as a site-admin user
- it should succeed
fixes CNVS-10355
fixes CNVS-10356
Change-Id: I36b0d387ad09f98cdf3d4de9e4e351bfd6aa8c58
Reviewed-on: https://gerrit.instructure.com/28541
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Jeremy Stanley