test plan:
* basic regression test of assignment overrides
closes #CNVS-27549
Change-Id: Ie463848b3831087efb3f9ec762dca6264055ee76
Reviewed-on: https://gerrit.instructure.com/73139
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
refs #CNVS-21317
Change-Id: Id9bbb04a92abd835af69ba5ec0c21ef758a8a324
Reviewed-on: https://gerrit.instructure.com/61146
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
fixes CNVS-19165
test plan:
- turn DA on
- go to the group discussion index page
- go to a group discussion
- nothing errors out
Change-Id: I87fbec441f9348285af372d7b9413e727841e9e0
Reviewed-on: https://gerrit.instructure.com/50140
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-18595
test plan:
- make a course with DA on and some assignments
only visible to certain sections
- make it public to all
- when logged out you can see all the
assignments on the index page
- when logged in as a user, DA filters assignments
out of the index page by section (like normal)
- make it public to authenticated users
- when logged in as a user enrolled in the course,
DA filters assignments out of the index page
- when logged in as a user who is NOT enrolled,
you see all the assignments on the index page
- when logged out you cant access this page
- make it a private course
- when logged out or logged in as a student NOT in
the course you cant see the assignment index
- when logged in & enrolled DA filters like normal
Change-Id: Id9b19883baab20b4aa871d61ecf29620a5212d05
Reviewed-on: https://gerrit.instructure.com/49176
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-16367
test plan:
- go to modules page and change stuff and save
- things dont break
- DA'd discussions/assignments/quizzes filter out
of the modules page for students
- the page for all student progressions works
as it should
Change-Id: I8403e4c508169e7f3750f3ddc7494f4a4ed3f371
Reviewed-on: https://gerrit.instructure.com/43113
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-15925
test plan:
- quick regression test of DA
- focus on assignments/quiz/discussion/modules index pages
Change-Id: I0c6fe67f14e0692d54727839ece993037fc4f6ca
Reviewed-on: https://gerrit.instructure.com/41958
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
- cleans up assignment model
- eliminates unnecessary feature flag checks
- eliminates unnecessary teacher permission checks
- moves duplicated methods from assignment and quiz
to new module
Change-Id: I8d1e8f99bf5c8f6a63bd670b432aeef7e8f0e86b
Reviewed-on: https://gerrit.instructure.com/41654
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
James Williams