ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
5,584 Commits 324 Branches 20,019 Tags 1.7 GiB
Commit Graph

2 Commits

Author SHA1 Message Date
Jon Jensen 5639ccacf7 fix ES5 shim 
require.js runs later, so define doesn't exist here. also we don't need it

test plan
1. use canvas in IE
2. you should not get a javascript error on every page

Change-Id: I350e991d54962765612cb984aaf72604c5348ee5
Reviewed-on: https://gerrit.instructure.com/13317
Reviewed-by: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
 2012-08-30 13:45:50 -06:00
Ryan Shaw 4bc93e7e85 shim String::trim and Function::bind and make always available 
all environments we support besides ie8 do these
natively, these are accurate and safe since they
will not mess with any for … in loops.  better than
having to do $.trim and _.bind everywhere.

Change-Id: I2292a2303884a2fcf68ee055945c29fbbd2b1b88
Reviewed-on: https://gerrit.instructure.com/12997
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Reviewed-by: Mark Ericksen <marke@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
 2012-08-24 16:40:46 -06:00