ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
46,445 Commits 324 Branches 20,019 Tags 1.7 GiB
Commit Graph

2 Commits

Author SHA1 Message Date
Evan Battaglia 145b68cfef Fix bug in LTI2 app registration 
Test plan:
- comment out the event.origin check I added in LTI2Iframe.js & compile
  assets
- run the repro steps detailed in the ticket.
- it should not repro, as the HTML should be escaped.
- uncomment the event.origin check & recompile assets
- run the repro steps again. Now, it shouldn't even show a flashError.
- make sure LTI 2 registration still works (?)

refs INTEROP-6755

Change-Id: I0df2b92cddf7e94befe51a3a0f117f3a03c40b6d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/264361
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
 2021-05-10 17:32:18 +00:00
Ahmad Amireh 4243097b21 rename some things 
fixes FOO-1265

[skip-eslint=true]
[pin-commit-analytics=7e49eefd7f59cbf43fd03bf8957bbbfa76f8d9d5]
[pin-commit-demo_site=adade2e38e46a358a4643cd3db2fe5ccffe39ec5]
[pin-commit-instructure_misc_plugin=47a3161102b0611af56d134fbd0c828ddc1b8abf]
[pin-commit-migration_tool=0dbac2f5b421d894395605ce4b583ef0f7d60b22]
[pin-commit-multiple_root_accounts=cc96d28c0d59bbe47acc64de4fdd8e1d2b029805]

Change-Id: I14c07f20bd260cf0de1f48ceb70b3c2313edf2d2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258807
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Ziwisky <mziwisky@instructure.com>
QA-Review: Michael Ziwisky <mziwisky@instructure.com>
Product-Review: Michael Ziwisky <mziwisky@instructure.com>
 2021-04-06 01:12:49 +00:00