Commit Graph

18 Commits

Author SHA1 Message Date
Aaron Ogata fccfab478e emsure private defaults are used everywhere
Change-Id: Ie43bdced918987670bd186cbb5eb9f63ff13c52b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/314067
Reviewed-by: James Butters <jbutters@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
2023-03-23 13:52:42 +00:00
Aaron Ogata 9f1ca5f895 remove usage of configuration.getInteger
refs DE-1359

Change-Id: I500acf9fefd0a5d4f247da80c08ed7093d7dd7f3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/313393
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
2023-03-16 15:10:08 +00:00
James Butters 29f3f7dadf add require statements
add require statement that were previously removed
add pull images before rspecq reporter

Test Plan:
- crystal-ball build passes

Change-Id: I30a6e72247cfdfbe51c2b662620b44d5f46cb2f2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/308695
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
2023-01-12 18:46:09 +00:00
Aaron Ogata f135d25758 rename webpack-cache image to webpack-assets
refs DE-1379

Change-Id: I50d9482c465daa410d693ef46ddf0942a6ee4343
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/301424
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Build-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2022-09-20 16:57:47 +00:00
Aaron Ogata c81178caf7 remove karma-builder image since local Chrome is no longer needed
refs DE-1334

Change-Id: I3fb5de6c396dc627813953b7cc31c7f40665b713
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/298395
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
2022-08-15 14:19:35 +00:00
James Butters 7429163d3f run buildDockerImageStage.&patchsetImage without async steps
flag = none

Change-Id: Id1f642b0cc92120c6675cc671f364d7d0eaa7b71
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/294942
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
2022-06-28 15:34:02 +00:00
Aaron Ogata c78a877f1d remove mostly useless copy files script
refs DE-1221

Change-Id: Ic1719c364ea2bf9561de2b5d8e0a091c77a880cb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/293438
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
2022-06-09 15:16:39 +00:00
James Butters cc0125eb18 crystalball map build with rspecq
refactor Jenkinsfile.crystalball more like
Jenkinsfile.rspecq to use fewer nodes.

Change-Id: Ia1cc7d70a2fc7efa38f21ef9659bb67e211a8e43
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289027
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
2022-04-08 20:14:10 +00:00
Brian Watson a87301eaf7 Add file check to crystalball smoke test and move to rspecq
flag=none

[skip-stages=Flakey Spec Catcher]

Test-plan:
- verify that minimal files are displayed for missing in the map
- ensure that Test Plan junit displays ~45,000 specs run

Change-Id: I516103e3d3348b4f7deaf4124044e8276dfc707e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/288539
Reviewed-by: James Butters <jbutters@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Brian Watson <bwatson@instructure.com>
2022-04-07 15:09:29 +00:00
Brian Watson 1aa3d4a151 Add Crystalball Map Smoke Test
flag=none

Test-plan:
- run map build, verify that it posts an updated map message
- run map build and abort it, verify it doesn't push to s3

Change-Id: I2f31aaad2f21a2d4befa8d2bea80b02d4800b7af
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287943
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Brian Watson <bwatson@instructure.com>
2022-03-29 17:48:12 +00:00
Brian Watson b9cbe6e772 Enable all rspec tests to generate crystalball map coverage
flag=none

Test-plan:
- unit tests have entries in the crystalball map

Change-Id: I9a05fd5c050f0b4142dfc19fb3b960fdb00f3584
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283875
Reviewed-by: James Butters <jbutters@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Brian Watson <bwatson@instructure.com>
2022-02-01 17:23:26 +00:00
Brian Watson 0412324fc7 Sort crystalball ruby + js items
flag=none
Test-plan:
- new map should have ruby coverage items sorted first
  and then js items sorted and added after

Change-Id: I8053fb7be7a77ff82ab7e12b73ebd4eb2f4c551f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283786
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Kyle Rosenbaum <krosenbaum@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Brian Watson <bwatson@instructure.com>
2022-01-28 18:25:41 +00:00
Brian Watson 79b1ede72d Start Coverage gathering earlier to prevent coverage holes
flag=none

Test-plan:
- generate new map, make sure more things are present without
  losing things

Change-Id: I135673942b1fd6353e2a22d2c0441449bab531b2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/280525
Reviewed-by: James Butters <jbutters@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Brian Watson <bwatson@instructure.com>
2022-01-27 00:20:26 +00:00
Brian Watson 4a49800443 Add istanbul-instrumenter-loader for crystalball map
Note: Ensure that istanbul is only enabled for crystalball before
this is merged

closes OUT-4918
flag=none

Test-plan:
- crystalball map should include JS files
- ensure that CRYSTALBALL_MAP isn't set to 1 in standard pre-merge

Change-Id: I5ae2f32177640e3caeb77871918644890eb4ae30
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/280813
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Brian Watson <bwatson@instructure.com>
2022-01-12 18:57:00 +00:00
Brian Watson 37b2bf1bd5 Push crystalball map to s3 in crystalball-map job
closes OUT-4895
flag=none

Test-plan:
- after job builds, new map should be visible in instructure-canvas-ci
  bucket

Change-Id: I3fa98f1da7e4b75f6b24dedff5a9cb35c3e08eb6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/280200
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Brian Watson <bwatson@instructure.com>
2021-12-06 16:52:41 +00:00
Brian Watson 96fbbf87c9 Revert "Revert "Crystalball post-merge map generation""
Also moves config/initializer/crystalball.rb to spec/support
to prevent it from running in prod

This reverts commit 9a9c68be6e.

Test-plan:
- passes cd to edge without failure
- generates map successfully in PoC build

Change-Id: I67c02ebaea06e11b3a3721aa49217da16e75bd32
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279848
Reviewed-by: Michael Hargiss <mhargiss@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Brian Watson <bwatson@instructure.com>
2021-12-01 17:35:52 +00:00
Brian Watson 9a9c68be6e Revert "Crystalball post-merge map generation"
This reverts commit bd847c2d14.

Reason for revert: breaking cd

Change-Id: I85ed1dc69045d2cd984778da12c2e0b402b842ad
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279637
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Brian Watson <bwatson@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
2021-11-30 17:36:13 +00:00
Brian Watson bd847c2d14 Crystalball post-merge map generation
flag=none

Test-plan:
- #crystalball-noisy should link to the latest build AND the
  latest map should be linked (stored as a build artifact)
- job should run nightly
- nightly alerts should promopt #crystalball-noisy posts
  (but not gerrit manual triggers)

Change-Id: Ibbd45dfd8a9b3ed8f4c662b322214cbbc3dc99b4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277205
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Hargiss <mhargiss@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Brian Watson <bwatson@instructure.com>
2021-11-30 16:18:07 +00:00