after the merge of 357959 we missed a couple of spots
to update the container names using hyphens.
[skip-crystalball]
[change-merged]
[build-registry-path=jenkins/canvas-lms/dockercomposehyphen]
Change-Id: I64a717a1ace4bdb9bb28d4242a6e658a93c0f994
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/361085
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
Build-Review: James Butters <jbutters@instructure.com>
Reviewed-by: James Belleau <james.belleau@instructure.com>
When Discussion Checkpoints is enabled, any assignment feedback
that is not a discussion checkpoint is not displayed in Course
Recent Feedback. This PS ensures that all assignment feedback is
displayed.
closes VICE-4768
flag=discussion_checkpoints
Test plan:
- Specs are sufficient
- Prereq:
- A course with an assignment and a student enrolled
- Disable the Discussion Checkpoints feature flag in the account
settings
- As the student submit to the assignment
- Add a submission comment on the student's submission in
SpeedGrader
- As the student go to the dashboard and note that the submission
comment shows under Recent Feedback in the dashboard sidebar
- Enable the Discussion Checkpoints feature flag and clear the
user cache for the student
- Go to the dashboard as the student and assert the assignment
comment shows under Recent Feedback
- As an instructor, create a checkpoint discussion.
- As a student reply to topic and entry to fulfill the checkpoint
requirements
- As an instructor, grade the reply to topic and required replies
checkpoints and leave a comment
- As a student assert that the Recent Feedback section displays
the assignment comment, two graded checkpoints but does not
display the parent assignment to graded checkpoints
Change-Id: Id18177a64868b8744ef1883a146c5052ab40ecf3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360998
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Wilmer Corrales <wilmer.corrales@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Chrystal Langston <chrystal.langston@instructure.com>
closes EGG-78
flag=none
test plan:
- Create an unpublished course and enroll students and observers
- Click on the 3 dots next to one of the observers name and hit
the “Link to students” button
- Start adding student names in the box and then hit the update button
- Leave the people page
- Go back to the people page and try to do the process again
- Validate that the names you previously added to the box remain
and you can add someone new
Change-Id: Ic274ebf8414d32fea41c4c8ce604db9ca888160e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360830
Reviewed-by: Jason Gillett <jason.gillett@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Sam Garza <sam.garza@instructure.com>
closes RCX-2589
flag=block_editor
test plan:
- add a divider block
> expect a divider line
Change-Id: I33cac6d34709dd765281695ffdec2e6e36902afb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360975
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Luis Oliveira <luis.oliveira@instructure.com>
QA-Review: Luis Oliveira <luis.oliveira@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Description: Adjust the position for the See all button on
smaller mobile view and remove the scrollbars in the
search input in mobile view
test plan: Go to Discover page adjust the screen size down to 320px
flag=lti_registrations_page
refs LRN-8726
Change-Id: I6b291c9ab9bf6f3371e8bb0b9e5b01044aee0da2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/359936
Reviewed-by: Westin Humble <westin.humble@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Panna Kristóf <panna.kristof@instructure.com>
Product-Review: Panna Kristóf <panna.kristof@instructure.com>
fixes VICE-4633
flag=react_discussions_post
test plan:
- go to a discussion create/edit page
- append "?embed=true" to the URL
- try to add some sections, save
- it shouldn't crash the page
Change-Id: I76845f102c2a6acc7ef382e2f2804c17f9466f2d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360379
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Tamás Balogh <tamas.balogh@instructure.com>
Reviewed-by: Daniel Matyas Vincze <daniel.vincze@instructure.com>
Reviewed-by: Janos Csizmas <janos.csizmas@instructure.com>
QA-Review: Mario Hegyi <mario.hegyi@instructure.com>
refs VICE-4745
flag = instui_nav
Testplan:
- Go to groups
- Check the situation when buttons are in one line with header and check
if they dont overlap and small space between them exist
Change-Id: If52e9ea140c85a32b89bd1aebd5656a735428381
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360703
Reviewed-by: Roland Beres <roland.beres@instructure.com>
QA-Review: Dora Csolakov <dora.csolakov@instructure.com>
Product-Review: Tamás Balogh <tamas.balogh@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
The main idea is the following: instead of simply calling
check_accounts_right? on the merged_into_user recursively, which might
run into an infinite recursion due to cyclic reference, let's collect
the merged_into_users chain in an iterative manner and select the first
user in the chain with associated_accounts.
fixes FOO-4789
flag=none
Test plan:
- Create two users through site admin: A and B
- Open user profile pages from site admin
- Merge A into B from rails console: UserMerge.from(a).into(b)
- Merge B into A from rails console: UserMerge.from(b).into(a)
- Set `workflow_state = 'deleted'` on related pseudonyms
- refresh the previously opened user profile pages
- CHECK:
- User A should show user's profile (because it has deleted pseudonyms)
- User B should return Access Denied (because it doesn't have any
pseudonym after the merge)
Change-Id: Id1cc16563a9c935bdd8a30dc73fbbd1bbe385c44
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/358412
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Imre Foldes <imre.foldes@instructure.com>
closes RCX-2591
flag=block_editor
test plan:
- click on +Page
> expect a blank page template, followed by any other
global page templates that exist (currently just 1)
- click on New Blank Page
> expect a blank page with a ColumnsSection having 1 column
> expect to be able to add blocks to the column, to
change column count, etc. Basically, it's a well behaved
page.
- start over and hover over the other template
> expect the "Customize" button to appear
- click it
> expect a page of stuff
Change-Id: Ib67db145a42c5e85c5ab8856743e69e55d7cbe0b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360987
Reviewed-by: Luis Oliveira <luis.oliveira@instructure.com>
QA-Review: Luis Oliveira <luis.oliveira@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
This reverts commit 56f14beb7e.
Reason for revert: This cause issues with some assignments in prod.
Change-Id: Ic2fa1359547e89c88d20d4a2e48f3492ea9a9672
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360560
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Sarah Gerard <sarah.gerard@instructure.com>
QA-Review: Sarah Gerard <sarah.gerard@instructure.com>
Product-Review: Sarah Gerard <sarah.gerard@instructure.com>
closes RCX-2444
flag=block_editor
Test plan:
- Create a page and check the editor choice modal
is opened up.
- Select the RCE and check the flow behaves normally
- Create a new page and select the block editor and
check the block editor flow works like it should
- Create a page via module and edit it later, check
the editor choice pops up, check both paths.
- Edit a page already with some content and check the
editor choice does not popup.
- Try the page creation a couple times and check th
remember my choice checkbox
- Check the modal no longer show up
- Clear the user preference that controls editor choice
- Try again and check the modal shows up like before
Change-Id: Ief8f5716ecca5e3f7d56a631c42cb3a284002ab5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360710
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Luis Oliveira <luis.oliveira@instructure.com>
This variable was resolved to assignment.due_at, which
does not handle differentiated due dates. Especially
the case when a due date is set for a specific section
and no other due date is set for anybody else.
The new logic gets the due dates from submissions
and returns the latest due date set for any student.
note: this commit was reverted and redone, with an index
on submissions to make this query performant on large clusters
refs INTEROP-8870
closes INTEROP-8911
flag=none
test plan:
- install LTI 1.3 test tool
- setup custom variable for $Canvas.assignment.dueAt.iso8601
- create a course
- create a section in the course
- enroll at least 2 students in the course
You need to activate them as well: log in and accept the enrollment
- create a section in the course with 1 of the enrolled students
- create an assignment in a Course
- set the due date to a future date, but only for the section
- do not set the 'Everyone else' due date
- launch the tool
- check if the LTI variable is expanded to the due date
- remove the due date from the assignment
- check if the LTI variable is not expanded
it's value should be: $Canvas.assignment.dueAt.iso8601
Change-Id: Ib1f685fe5e0b02087a942131912a48f59991f666
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360974
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Tucker Mcknight <tmcknight@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Reviewed-by: Ryan Hawkins <ryan.hawkins@instructure.com>
Migration-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Product-Review: Xander Moffatt <xmoffatt@instructure.com>
eportfolio categories and entries have a "slug" generated by
stripping non-alphanumeric characters from the name. names in
non-Latin scripts end up resulting in completely empty slugs,
breaking edit links
(rant: https://gerrit.instructure.com/c/canvas-lms/+/68422
did the wrong thing about this problem; clearly I18n was
not considered nine years ago)
for this change, use the `to_url` helper used by wiki pages
(which transliterates non-Latin characters) instead of
a naive regex, which will prevent empty slugs going forward.
fall back on a randomly-generated slug if `.to_url` returns
an empty string.
also, do not regenerate the slug on every save; only do this
if the slug is blank or the name changes. this will prevent
content updates from breaking external links to eportfolio
pages.
finally, apply a datafixup to generate missing slugs
test plan:
- before applying the database migration,
- create ePortfolio sections with no alphanumeric characters
in the name
- create ePortfolio pages with no alphanumeric characters
in the name
- confirm that some of these cannot be edited
(the `href` value in the `edit_page_link` is blank)
- apply the database migration and verify the pages
can be edited again
- confirm that it is no longer possible to reproduce the bug
flag=none
closes FOO-4862
Change-Id: I69fa58adde4786420bf410e768b8d80ea9d55867
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360251
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
Migration-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes RCX-2556
flag=rce_linked_file_urls
Test plan
- Ensure the authenticated_iframe_content
feature flag shows is on
- Set up a video in a new quiz question
- Copy the quiz question to an item bank
- In a different course, add that item
into a new quiz
- As a person who only has access to
the second course, ensure they can
access the video file
Change-Id: Ieb1dbee6d2ec52a6f6387a6e84011ec0b0867a84
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360475
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jorge Andres <jorge.andres@instructure.com>
Product-Review: Jorge Andres <jorge.andres@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Griffin Zody <griffin.zody@instructure.com>
closes RCX-2585
flag=block_editor
test plan:
- create 2 columns
- make one column tall (add a slew of icons?)
- add an image to the other column
- set size to percent and drag to make 100% tall
> expect the image to fill the column
- change among auto, pixel, and percent
- resize the image
> expect it to behave
- look at the preview
> expect it to behave
Change-Id: I9107dc07aea4de83cdb9c2f8b2a04b6e00b5a684
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360874
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
closes RCX-2588
flag=block_editor
test plan:
- create a page
- put some stuff in a column
- change horizontal alignment
> expect the content to align correctly
- change layout direction from column to row
- change the vertical alignment
> expect the contents to be correctly aligned
- add a group block
- put some stuff in it
- resize it so it's larger than its contents
- repeat the above exercise with the group
Change-Id: Ia6b23d70d174f85500b77d30e1e84365af705afc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360954
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
test plan:
- undo this fix locally:
https://gerrit.instructure.com/c/canvas-lms/+/358062/6/app/models/conversation.rb
- attempt to send a conversation message
- the graphql call should result in a 500 error and the invalid SQL
should show up in /error_reports and not the browser console
flag=none
closes FOO-4874
Change-Id: I78686a28ce3c99d2137f35423dbd81fe5e833658
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360950
Reviewed-by: Keith Garner <kgarner@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
This adds caching to queries that are commonly used to determine
visibilty, somtimes multiple times in the same call. For now, we'll
cache up to a minute to give the database some breathing room.
This also removes unused functions from the visibility services and
replaces a function with one provided by rails.
flag=none
test plan:
- specs pass
- determine if the queries are being cached by looking at the logs
Change-Id: I30cc97ea614a6fc9578582dc3d97be45e8427365
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360794
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Sarah Gerard <sarah.gerard@instructure.com>
QA-Review: Sarah Gerard <sarah.gerard@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
fixes EGG-256
flag=differentiated_tags
test plan:
- new specs must pass
- you can make the REST api requests
yourself if you want, keep in mind
it won't be that much different from
the specs
Change-Id: I527829430239701928cf17df81303cbdd9034d60
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360868
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jason Gillett <jason.gillett@instructure.com>
Reviewed-by: Martin Yosifov <martin.yosifov@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
fixes EGG-92
flag=discussion_checkpoints
flag=react_speedgrader
Test Plan:
0. Have a graded checkpoints discussion.
1. Open it in speedgrader:
- without url param entry_id and it will highlight an entry.
2. If entry_id is set that will be chosen over the default entry.
3. If you change to a new student it will default to an entry
(regardless if the entry_id is incorrect).
Change-Id: Icd4bd27b66f1aa777a292e0b1d23ed7c00f0af4e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360329
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Jason Gillett <jason.gillett@instructure.com>
Product-Review: Sam Garza <sam.garza@instructure.com>
closes RCX-2570
flag=block_editor
flag=block_template_editor
test plan:
- create a block page
- save a template
- from the Block Toolbox, click the 'x' in your template
- change from published to unpublished or visa versa
> expect its state in the toolbox to update accordingly
(unpublished templates have a red border)
Change-Id: I665157802fcfa20a9e7948aae42e2d2dcb3bb3fb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360817
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
closes EGG-270
flag=discussion_checkpoints
Test plan:
- Enable discussion checkpoints feature flag
- Go to Calendar and open devtools->network
- Select only your own calendar and reload the page
- Verify that the requests for calendar_events with
type assignment and sub_assignment return 200 OK
- Alternatively, paste in browser the URLs below and
verify that they succeed without errors
{local canvas}/api/v1/calendar_events?type=assignment
{local canvas}/api/v1/calendar_events?type=sub_assignment
Change-Id: I998c02ed40228ed5f414ff34d25bc74eff091422
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360905
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Jason Gillett <jason.gillett@instructure.com>
Product-Review: Sam Garza <sam.garza@instructure.com>
fetchMock throws error to console, causing test to fail. No
straightforward fix, so skip for the time being.
refs FOO-4877
flag=none
test-plan:
- tests pass
Change-Id: I7e042476beb07401224490d8e1dea5813c8352e0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360949
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Maya Tyner <maya.tyner@instructure.com>
Product-Review: Maya Tyner <maya.tyner@instructure.com>
This reverts commit 3a25dc44cf.
Reason for revert: on some clusters, this query does not perform well
Change-Id: I0579a51ec1718d235ba312234c08cea7b7375279
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360558
Reviewed-by: Evan Battaglia <ebattaglia@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Evan Battaglia <ebattaglia@instructure.com>
Product-Review: Evan Battaglia <ebattaglia@instructure.com>
Rails now provides a function that does the same thing as empty_id_hash,
so let's move over to using that.
flag=none
test plan:
- specs pass
Change-Id: I6b624f81c47092997b51c95a7bb6a854bd897363
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360888
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Keith Garner <kgarner@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
https://gerrit.instructure.com/c/canvas-lms/+/359689/ introduced a bug
This fix should resolve the 422 while trying to create a reply
flags=none
test plan
- Create a discussion
- Try to reply
- everything should work
- play with the sort order button
- refresh
- order should be preserved
Change-Id: I24ab6b05582fc93cd390cc399d03f187a8fbf905
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360917
Reviewed-by: Mario Hegyi <mario.hegyi@instructure.com>
QA-Review: Dora Csolakov <dora.csolakov@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Tamás Balogh <tamas.balogh@instructure.com>
refs VICE-4747
flag = instui_nav
Test plan:
- Navigate to the collaboration page
- Check the adding button in desktop and tablet view
- Button should be unter the title in tablet view
- Check with instui_nav feature flag as well
Change-Id: Iaef5c3ac492e0ddd4c7656f94be0dd15e34ed168
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360523
Reviewed-by: Daniel Matyas Vincze <daniel.vincze@instructure.com>
QA-Review: Dora Csolakov <dora.csolakov@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Tamás Balogh <tamas.balogh@instructure.com>
refs VICE-4738
flag = none
Test plan:
- Navigate to BigBlue button page (need to set)
- Check the add button
- The button label should be Add Conference
- Navigate to collaboration page
- Check the add button
- The button label should be Add Collaboration
Change-Id: I6e9919056159966aef769f8578761944c6ec333d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360513
Reviewed-by: Theo Sorriaux <theo.sorriaux@instructure.com>
QA-Review: Dora Csolakov <dora.csolakov@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Tamás Balogh <tamas.balogh@instructure.com>
closes RCX-2461
flag=block_editor
Test plan:
- Create a new page with the block editor
- Wait for the new full modal to appear with
the option for a blank page and the templates.
- Check all the templates showed up.
- Choose to start from scratch and save.
- Check everything worked out fine with the new page.
- Create a new page and this time choose a template
- Check that the correct template got loaded on
to the editor.
- Edit it and save and check the new page worked
out fine.
- Ensure the createFromTemplate modal does not show
up for block editor pages already created, even if they
are empty.
- Ensure the above flows can be completed keyboard only
Change-Id: I7d849520bfcd5d470ef2d8bcaf02144ffad29c6b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360485
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Ed Schiebel <eschiebel@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Luis Oliveira <luis.oliveira@instructure.com>
Lti tools can use postMessages to interact
with platform. There was a
toggleCourseNavigationMenu getting deprecated now,
and replaced with a showNavigationMenu
and a hideNavigationMenu to explicitly show
or hide the navigation menu in course, account or group page.
closes INTEROP-8809
flag=none
test plan:
- Open a course or account or group page
- Launch lti 1.3 test tool
- Send postmessage in test tool to hide course NavigationMenu
with message {"subject":"hideNavigationMenu"}
- Verify course navigation menu is hidden
- Send postmessage in test tool to show course NavigationMenu
with message {"subject":"showNavigationMenu"}
- Verify course navigation menu is shown
Change-Id: I2d84e48b0dc193f9bfe63e70683d445e0a3c95ca
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360518
Reviewed-by: Csaba Csuzdi <csaba.csuzdi@instructure.com>
QA-Review: Csaba Csuzdi <csaba.csuzdi@instructure.com>
Product-Review: Alexis Nast <alexis.nast@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Add a better description for the different types of workflow_state
refs VICE-4603
flag=none
Test plan:
- Read the description
- It should be understandable
Change-Id: I5f82cd6948f8a8303a0d6a47f080edea8b15a23b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360707
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Daniel Matyas Vincze <daniel.vincze@instructure.com>
QA-Review: Daniel Matyas Vincze <daniel.vincze@instructure.com>
Product-Review: Tamás Balogh <tamas.balogh@instructure.com>
refs VICE-4755
flag = instui_nav
Test plan:
- Ensure that the instui_nav feasture flag is enabled
- Navigate to the announcements page
- Select an announcements
- Check the breadcrumb in the loaded page
- Try it in the edit page as well
Change-Id: Ie04f94fb7c985de01bbe4384db9b27bf88ae6697
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360614
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Theo Sorriaux <theo.sorriaux@instructure.com>
QA-Review: Dora Csolakov <dora.csolakov@instructure.com>
Product-Review: Tamás Balogh <tamas.balogh@instructure.com>
refs VICE-4739
flag = none
Test plan:
- Navigate to Discussion list page
- Check the settings button
- Button has to be contains a settings label
Change-Id: Ic6372e2a5b26002ceb1c61ed8a3e5ff255c59171
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360516
Reviewed-by: Daniel Matyas Vincze <daniel.vincze@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Theo Sorriaux <theo.sorriaux@instructure.com>
Product-Review: Tamás Balogh <tamas.balogh@instructure.com>
flag=platform_notification_service
refs INTEROP-8895
Test plan:
- ensure the platform_notification_service FF is on for your root
account
- start creating or editing an LTI developer key for the root account
- make sure the scope
(https://purl.imsglobal.org/spec/lti/scope/noticehandlers) shows up in
the form
- save the Dev Key with the scope added
- check the DB and make sure the scope is added to the DeveloperKey and
the Lti::ToolConfiguration
- start a Dyn Reg flow and make sure the scope is listed in the
scopes_supported send back to the tool
- finish the Dyn Reg flow including the scope. check the DB and make
sure the scope is added to the DeveloperKey and
the Lti::ToolConfiguration
- turn the platform_notification_service FF off
- start creating or editing an LTI developer key and make sure the scope
doesn't show up in the manual form
- start a Dyn Reg flow and make sure the scope is _not_ listed in the
scopes_supported send back to the tool
Change-Id: I719360763b8c02a9bbd2f6685e834fe68d5ddc1e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360395
Product-Review: Alexis Nast <alexis.nast@instructure.com>
Product-Review: Paul Gray <paul.gray@instructure.com>
Reviewed-by: Paul Gray <paul.gray@instructure.com>
QA-Review: Paul Gray <paul.gray@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
The index method is the only one where we need to filter
out specific group categories based on permissions
The rest of the actions will just have an updated
permissions handler
refs EGG-254
flag=none
Test Plan
1. create a non_collaborative group category
2. Go to peoples page as a teacher
3. Verify that the category appears
4. as a student view the people page
5. Verify that the categories do not appear
6. turn off collaborative permissions for teacher
7. As a teacher view people page
8. Verify that the hidden group does not appear
Change-Id: Iabe83fd73e608c3af9c844cf9c1430cf13f211f8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360855
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Chrystal Langston <chrystal.langston@instructure.com>
Product-Review: Jason Gillett <jason.gillett@instructure.com>
This implements the part of the 1Edtech Platform Notification Service
specification, namely, platforms that support PNS should advertise the
supported notification types in LTI launches.
flag=platform_notification_service
closes INTEROP-8879
Test plan:
- Have an LTI tool whose developer key includes the scope
https://purl.imsglobal.org/spec/lti/scope/noticehandlers
- turn the platform_notification_service FF on (`canvas-ffs flip` to get
flag from checked out HEAD)
- launch the tool
- check that the
https://purl.imsglobal.org/spec/lti/claim/platformnotificationservice
claim is present in the JWT, and matches as described in the platform
notification spec
- flip the FF off
- launch the tool check that the claim is not present
- flip the FF on and remove the scope from the key
- launch the tool check that the claim is not present
Change-Id: Ibd2e2d19263e86557fb8269188143892c2c2211e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360075
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Alexis Nast <alexis.nast@instructure.com>
Reviewed-by: Paul Gray <paul.gray@instructure.com>
QA-Review: Paul Gray <paul.gray@instructure.com>
this commit allows the FindDialog to take a new optional parameter to
specify a custom zIndex. without this change, the FindDialog modal would
be hidden behind the instui modal. this change should have limited
impacts because the default zIndex is set to 1000 if not specified,
which is the same as today.
closes EVAL-4774
flag=enhanced_rubric_assignments
flag=enhanced_rubrics
test plan:
- navigate to an assignment and click on the Create rubric button
- click on the "Create from Outcome" button
- verify that you can see and interact with the outcomes dialog
Change-Id: Ide11a4da1cf31597a784f6217af0aeea0d13b458
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/360873
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Chris Soto <christopher.soto@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
balazs.buri