closes RCX-2537
flag=files_a11y_rewrite
test plan:
- Navigate to course files page.
- Select a file and click 'Copy To...'
menu item.
> Verify that the tray looks like the
designs.
- Search and select a course.
- Search and select a module.
- Select a place.
> Verify that if you select 'Before...'
or 'After...' places, the assignments
selector will appear.
- If wanted select an assignment.
- Click Copy button.
> Verify that flash alerts appear.
> Verify that the file was copied in
the correct place.
ALSO VERIFY...:
> That when clicking Cancel button
nothing happens.
> That the warning message can be
closed.
> That when the user tries to copy
without selecting a course, an error
message will appear and the input will
be focused.
Change-Id: I690636a660b964d27d6a3e819298af1c5866f1c8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/370502
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Juan Chavez <juan.chavez@instructure.com>
via api/v1/accounts/:id/logins/:id
closes AE-1620
flag=none
test plan:
*primary concern
-make some api requests to the endpoint attempting
to change your own password
-confirm you must have an old_password param
-confirm the old_password param must be valid
-confirm you can change your password when both of those
conditions are met
*secondary concern
-make another request but force a failure, e.g. include
a `raise` in the controller method
-check the error report and confirm the values of the
sensitive params are redacted
Change-Id: I4d9321da50e00fff5512609ebe7e039b9c0a0ad5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/370023
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jeremy Perkins <jperkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jake Oeding <jake.oeding@instructure.com>
refs CLAB-1025
flag=instui_for_import_page
Test plan:
- enable ff
- go to course -> setting -> import content
- Select any content type with "Adjust events and due dates"
- Select "Adjust events and due dates"
- The "to" label has nice paddings
Change-Id: I7351f5c86593025e7d486cc6881c4558c2e716dd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/370633
Reviewed-by: Peipei Zhou <peipei.zhou@instructure.com>
QA-Review: Peipei Zhou <peipei.zhou@instructure.com>
Product-Review: Kata Virag Keri <kata.keri@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
this commit updates our tinymce version, so be sure to yarn install
and yarn build:packages to test
closes RCX-3013
flag=none
test plan:
- use kb shortcuts to change formatting (e.g. cmd-b to toggle bold)
see https://www.tiny.cloud/docs/tinymce/latest/keyboard-shortcuts/
- this is only implemented for formatting change shortcuts (bold,
italic, underline, h1-6, etc.)
> expect the screenreader to tell you what just happened.
Change-Id: Iefab2745552eda5cd3b0f585af0cb7802694a11d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/370202
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Kata Virag Keri <kata.keri@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs EVAL-4982
flag=none
Test Plan:
- Create a course, and publish it
- Add one student to the course
- Create another section, and add the student to the second section as
well
- In one section the student should be active, and in the other section
the student should be inactive
- Create an assignment, and assign it only to the section where the
student is inactive
- In SpeedGrader, note that the student is only present, if “show
inactive enrollments” is selected in the gradebook
Change-Id: I3385d1f9c44494eeb8efc800c8700e85338b1778
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/370572
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Spencer Olson <solson@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
If the `RCE Lite in SpeedGrader comments` feature flag is enabled, users
create comments using HTML syntax. When the feature flag is turned off or
the input used for editing does not support RCE, the HTML syntax is
exposed to the user.
This commit ensures that teachers can edit their comments in the gradebook
with RCE if the feature flag is enabled. Additionally, if a comment
contains HTML syntax and the feature flag is disabled, HTML tags will be
stripped to provide a clean display.
flags=none
closes EVAL-4638
Test plan:
1. Ensure that the RCE Lite in SpeedGrader Comments feature flag is
enabled.
2. Create a course with an assignment and enroll at least one student.
3. Navigate to SpeedGrader and submit a comment for the student.
4. Open the Gradebook, select the student, and access the sidebar for the
graded assignment. Edit the comment.
5. Verify that the same Rich Content Editor (RCE) used in SpeedGrader is
available for editing the comment.
6. Disable the RCE Lite in SpeedGrader Comments feature flag.
7. Refresh the page and attempt to edit the comment using the previous
(non-RCE) editor. Confirm that HTML syntax is not exposed to the user.
Change-Id: I23e0a0f6673ec47d892a72c97792eded110ac383
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/369986
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Daniel Kis-Pal <daniel.kispal@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
- Remove @ts-expect-errors by defining proper types
- Add unit tests to cover additional edge cases
refs EVAL-4638
flag=none
Test plan:
1. Create a course, an assignment, and invite a student
2. Submit the assignment
3. Create a submission comment
4. Update a submission comment
Change-Id: I6a337155a8854ecdcc3e33a59fb8a0da5907a40c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/370473
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
QA-Review: Daniel Kis-Pal <daniel.kispal@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
This commit adds a feature flag for the LTI Usage Data tab. This tab
will be hidden by default.
test plan:
1. Go to Settings -> Feature Options and search for LTI Apps - Usage
2. Verify that the feature flag works
closes INTEROP-9112
flag=lti_registrations_usage_data
Change-Id: I801136e15d2f495b26e822e1f60af839bc14980f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/369586
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ryan Hawkins <ryan.hawkins@instructure.com>
QA-Review: Ryan Hawkins <ryan.hawkins@instructure.com>
Product-Review: Paul Gray <paul.gray@instructure.com>
This commit fixes the registrations controller to use the `api_find`
method when resolving the `account_id` param. This is necessary to
ensure that the account is properly resolved when the account id is
passed as the string `self`.
The code was previously naivley passing the `account_id` param to the
`find` method, which would result in no registrations being found for
the local account. The only registrations being shown were from the
site admin account.
Test plan:
1. Navigate to the Lti Apps Page Manage screen
2. Look at the list of installed tools.
3. Change the account id parameter to `self` and verify that the
local account registrations are still shown.
fixes INTEROP-9078
flag=lti_registrations_page
Change-Id: I61ea1bb818fc6813da2914bfb4fa69dc7a2aef5e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/369677
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ryan Hawkins <ryan.hawkins@instructure.com>
QA-Review: Ryan Hawkins <ryan.hawkins@instructure.com>
Product-Review: Paul Gray <paul.gray@instructure.com>
test plan:
- update your notification preferences to receive mention notifications
on a daily/weekly cadence
- be mentioned in a discussion
- that notification should show up in the summary
fixes VICE-4107
flag=none
Change-Id: Iba7ee2468e71c47c60cf016978dc3f5dc5d9d035
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/369875
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Roland Beres <roland.beres@instructure.com>
QA-Review: Roland Beres <roland.beres@instructure.com>
Product-Review: Balint Kartyas <balint.kartyas@instructure.com>
refs CLAB-1019
flag=instui_for_import_page
Test plan:
- enable ff
- go to course -> setting -> import content
- Select any content type with "Adjust events and due dates"
- Select "Adjust events and due dates"
- The "change to" label is vertically aligned
Change-Id: I781c633f0164279765a17bcb28e6f2544dc9d9ea
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/370514
Reviewed-by: Ferenc Marcsó <ferenc.marcso@instructure.com>
QA-Review: Ferenc Marcsó <ferenc.marcso@instructure.com>
Product-Review: Kata Virag Keri <kata.keri@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs CLAB-960
flag=instui_for_import_page
test-plan:
-go to Import Page
do this test with:
-Copy a Canvas Course (do it with a teacher + an admin)
-LTI 1.3 Test Tool
-Unzip .zip file into folder
-Choose the migrator
-Submit the form without inputting anything
-Focus should move to the error field
-Repeat with VoiceOver turned on
-Voiceover should say the validation error
Change-Id: Ib1771bcff8744f151771515b1bc4e289a63696f1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/370269
Reviewed-by: Ferenc Marcsó <ferenc.marcso@instructure.com>
QA-Review: Ferenc Marcsó <ferenc.marcso@instructure.com>
Product-Review: Kata Virag Keri <kata.keri@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Removes validation that disallows assigning diff tags to
group assignments.
closes EGG-599
closes EGG-601
flag=assign_to_differentiation_tags
flag=differentiation_tags
Test plan:
- Tests are sufficient and Jenkins passes
- Manual test plan:
- Turn on feature flags at the account level
- In a course that is in an account with
allow_assign_to_differentiation_tags setting enabled
- Add a differentiation tag set and 2 groups
- Add a collaborative tag set and group
- Add multiple learning objects to the course
- Discussion Topic
- Assignment
- Quiz
- Wiki Page
- Add 2 group learning objects to the course and
associate the collaborative tag set as the Group
Category and select the group in the assign to
component
- Group Discussion Topic
- Group Assignment
- Using the Assignment fly out, assign a differentiation
tag to each learning object.
- Assert this saves without any issue.
- Assert the first diff tag group can be assigned to the
group learning objects
- Add all learning object assignments to a module
- Add the second diff tag group to the module
- Click on each individual learning object assign to
in the module and verify the second diff tag group
is assigned via the module and the other assignees
are in tact.
Change-Id: I14f946dfbea4104735d639246a9819022efa8175
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/370318
Reviewed-by: Jason Gillett <jason.gillett@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jason Anderson <jason.anderson@instructure.com>
Product-Review: Kyle Rosenbaum <krosenbaum@instructure.com>
Changes of note:
- updated forms to show all error states on submit
(rather than linearly) to conform with 5vpat rules
- replaced desktop layout with tablet layout
- simplified layout custom styles
- moved auth provider sso buttons to below the login
form
- simplified sso button logic (they now just stack with
no responsive)
- removed loginLogoText from loginLogo and simplified
layout
- lower cased custom login label where appropriate
- updated verbiage
- left aligned reCAPTCHA
- removed close button from the login alert
closes AE-1710
closes AE-1553
flag=login_registration_ui_identity
[skip-crystalball]
test plan:
- log in to canvas as an admin
- go to /accounts/<account_id>/settings#tab-features
- enable "new login/registration ui for identity"
- navigate to /login/canvas
- expect to see SSO buttons below the login form
- expect tablet layout to persist on desktop viewports
- expect to not see login logo text under login logo
- expect login, frogot password and registration to work
- follow testing steps in manual QA document linked in jira
this would involve checking verbiage changes and other views
as many places in app were touched
- all unit tests pass
Change-Id: I75ca801ee4bd21f4e7922bfa4cab2196ecae7ee8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/370156
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Hargiss <mhargiss@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
QA-Review: Michael Hulse <michael.hulse@instructure.com>
Product-Review: Michael Hulse <michael.hulse@instructure.com>
closes CLAB-1023
flag=instui_for_import_page
Test plan:
- go to course -> settings -> import content
- select Copy a Canvas Course
- check Search for a course in desktop, table, mobile view
- there should not be a scrollbar for the input
Change-Id: I3aef317c2217f38edd628a69de7f7873d37bcb9b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/370526
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ferenc Marcsó <ferenc.marcso@instructure.com>
QA-Review: Dániel Török <daniel.torok@instructure.com>
Product-Review: Rajmund Csehil <rajmund.csehil@instructure.com>
Change-Id: I4c3f1f5f3ab23e721dcf1ff651d6d80cff28955b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/369402
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Attila Sedon <attila.sedon@instructure.com>
We will now show Mastery Paths UX elements when viewing a section.
Test Plan:
- Enable Mastery Paths
- Create a few module items that will have Mastery Paths conditional rules
- If you go to the course assignments, you will see the Link to
Mastery Paths and pills for the point ranges
- If you go to course pacing, after it syncs you should see the same MP UX
elements for these assignments that you see in the assignments page
Change-Id: I1ed144a7eb428dc90205e43dcba20722f23999c8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/370462
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Test Plan:
1. Edit a published course pace
2. Observe the "Save as Draft" button is gone, not just disabled
Change-Id: Ied06e0c8fc7987640eb5d2af70ec1c786d737114
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/370576
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
why:
- Due to the way Dyn Reg works, if a user clicks install on the
tool-side but then clicks the X in the registration modal on the new
Apps page, an Lti::Registration exists on the backend.
- This was confusing to users, as they feel the X should cancel the
whole process.
- Make reality match expectation.
fixes INTEROP-9079
flag=lti_registrations_page
test-plan:
- Go through the Dynamic Registration flow using yaltt.
- Click install in yaltt. Once you see the permission confirmation
screen, click the X in the Modal Header.
- Refresh the registrations page. The list should remain the same.
Change-Id: If57d502560139d86ee38268d68e4157fe4185afe
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/369920
Reviewed-by: Paul Gray <paul.gray@instructure.com>
QA-Review: Paul Gray <paul.gray@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Ryan Hawkins <ryan.hawkins@instructure.com>
Test Plan:
1. Download an individual student context course pace
2. Observe there is a field indicating the student is on or off pace
flag: course_pace_download_document
Change-Id: Id0d386fb9923a532577911d9c16d4ae90c19b389
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/370460
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Test Plan:
1. Turn on root account feature flag course_pace_pacing_with_mastery_paths
2. Turn on both course pacing and mastery paths for a course
3. Edit an assignment in that course
* Observe the "mastery path" toggle is present and controls
presence of "mastery path" assignment override
4. View an assignment in that course and open "assign to" tray
* Observe the "mastery path" toggle is present and controls
presence of "mastery path" assignment override
flag: course_pace_pacing_with_mastery_paths
Change-Id: I0bd2b54cf6f2225fbaa7e12771c74328fa23dc6c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/370048
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
refs EVAL-4416
flag=speedgrader_studio_media_capture
Previously, a VideoCaptionServiceError would be raised if a media object
did not have any media_sources after checking 10 times. Now, we log the
error but don't create a sentry report.
Test Plan:
- specs pass
Change-Id: I2dd65ed985130c54e7e5bfe3aff3c75c5df33830
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/370034
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Spencer Olson <solson@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
Juan Chavez