use same brandable_css manifest across deploys
fixes: CNVS-23783 also closes: CNVS-23841 all the real changes are here: https://github.com/ryankshaw/brandable_css/compare/2cf4ad3...master review those too while you are reviewing this. (sidenote: I was going to get this all set up to host that npm package all official from the instructure github account but, apparently we are going to get our own private npm so I didn't want to go through all of that fuss just to change it again when that gets figured out) https://gerrit.instructure.com/64465 should be submitted along with this test plan: * bundle exec rake RAILS_ENV=production \ UNIQUE_KEY_FOR_BRANDABLE_CSS_MANIFEST=some_unique_key \ brand_configs:generate_and_upload_all * it should generate all your css from scratch * run that again, it should say "no sass changes" * bundle exec rake RAILS_ENV=production \ UNIQUE_KEY_FOR_BRANDABLE_CSS_MANIFEST=other_key \ brand_configs:generate_and_upload_all * should generate everything from scratch * https://dev-canvascdn1-com.s3.amazonaws.com/dist/brandable_css/brand able_css_bundles_with_deps.jsonnestedother_key should exist to also test CNVS-23841: * with node 0.11.x installed * try to run `bundle exec canvas:compile_assets` * it should fail fast and tell you it failed because you don't have a new enough node * it should not ambiguously fail with an error like cannot find method 'parse' of undefined Change-Id: I7a90560b8ef3c5ca173c4b5bc06e0681848c0099 Reviewed-on: https://gerrit.instructure.com/64473 Tested-by: Jenkins QA-Review: August Thornton <august@instructure.com> Reviewed-by: Mike Nomitch <mnomitch@instructure.com> Product-Review: Ryan Shaw <ryan@instructure.com>
This commit is contained in:
parent
60d3834e9d
commit
fde44bd840
|
@ -6,7 +6,7 @@
|
|||
"node": ">=0.12.5"
|
||||
},
|
||||
"dependencies": {
|
||||
"brandable_css": "0.0.46"
|
||||
"brandable_css": "0.0.52"
|
||||
},
|
||||
"devDependencies": {
|
||||
"babel": "^5.6.23",
|
||||
|
|
Loading…
Reference in New Issue