ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

turn add module item link to a button 

fixes #CNVS-13548

When adding a module item the + link should have been a button with a
label. It now is a button with a label and works in JAWs and voice over.

Test Plan ------------
As a user that can create a module item
Given I'm using jaws and/or voice over
When I navigate to the modules page
I should be able to click on the add module items button
And it should be a button
And it should have a label
And it should work in Jaws
And it should work in voice over

Change-Id: I617dc3e37a9aeb2e54ee17a273f8284dbc7787f4
Reviewed-on: https://gerrit.instructure.com/36203
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
This commit is contained in:
Sterling Cobb 2014-06-10 14:08:36 -06:00
parent cdba3f2f09
commit fb9769bfb0
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/helpers/context_modules_helper.rb
View File

@ -19,7 +19,7 @@
module ContextModulesHelper
def cache_if_module(context_module, editable, draft_state, &block)
if context_module
cache(['context_module_render_10_', context_module.cache_key, editable, draft_state].join('/'), nil, &block)
cache(['context_module_render_11_', context_module.cache_key, editable, draft_state].join('/'), nil, &block)
else
yield
end

9
app/views/context_modules/_context_module_next.html.erb
View File

@ -73,12 +73,13 @@
<i class="icon-<%= published_status %>"></i>
</span>
<a href="#"
<button
aria-label="<%= t('aria_labels.add_item', %{Add Content}) %>"
rel="<%= context_url(@context, :context_url) %>/modules/<%= context_module ? context_module.id : "{{ id }}" %>/items"
class="add_module_item_link btn"><i class="icon-plus"></i><span class="screenreader-only"><%= t('links.add_item', %{Add Content}) %></span></a>
<a href="#" class="btn al-trigger" aria-label="<%= t("manager_module", "Manage module") %>">
class="add_module_item_link btn"><i class="icon-plus"></i><span class="screenreader-only"><%= t('links.add_item', %{Add Content}) %></span></button>
<button class="btn al-trigger" aria-label="<%= t("manager_module", "Manage module") %>">
<i class="icon-settings"></i><i class="icon-mini-arrow-down"></i>
</a>
</button>
<ul class="al-options">
<li>
<a