ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

don't allow resize of textarea fixes #8458 

also gave a few elements target="_blank" so you aren't
taken out of canvas when you click on the Jing or
Canvas Guides links

test plan:
  1. login and click on the help button
  2. click on "Report a Problem"
  3. notice you can't resize the text area anymore
  4. also notice the Jing and Canvas Guides links
     open in a new tab

Change-Id: Iac8a95115fad2ca94f40c84f950288f15f38ce49
Reviewed-on: https://gerrit.instructure.com/10549
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
This commit is contained in:
Jake Sorce 2012-05-04 10:10:37 -06:00
parent 2b5cbcb73f
commit f69a8c16dc
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/stylesheets/helpDialog.sass
View File

@ -56,6 +56,7 @@
textarea
width: 100%
height: 100px
resize: none
input
width: 100%
font-size: 13px
@ -85,6 +86,7 @@
position: absolute
left: 10px
top: 10px
.ui-dialog-header-backlink
display: block
float: left

4
app/views/jst/helpDialog.handlebars
View File

@ -33,7 +33,7 @@
<div class="ui-state-highlight">
<span class="ui-icon ui-icon-info"></span>
<strong>{{#t "for_an_instant_answer"}}For an instant answer:{{/t}}</strong>
<div>{{#t "see_if_your_issue_is_addressed_in_the_canvas_guides"}}See if your issue is addressed in the <a href="http://guides.instructure.com/">Canvas Guides</a>.{{/t}}</div>
<div>{{#t "see_if_your_issue_is_addressed_in_the_canvas_guides"}}See if your issue is addressed in the <a target="_blank" href="http://guides.instructure.com/">Canvas Guides</a>.{{/t}}</div>
</div>
{{/if}}
<div>
@ -43,7 +43,7 @@
<div>
<label for="error-comments">
{{#t "description"}}Description{{/t}}
<small>{{#t "include_a_link_to_a_screencast_or_screenshot_using_something_like_jing"}}Include a link to a screencast/screenshot using something like <a href="http://www.techsmith.com/download/jing">Jing</a>.{{/t}}</small>
<small>{{#t "include_a_link_to_a_screencast_or_screenshot_using_something_like_jing"}}Include a link to a screencast/screenshot using something like <a target="_blank" href="http://www.techsmith.com/download/jing">Jing</a>.{{/t}}</small>
</label>
<textarea id="error-comments" name="error[comments]"></textarea>
</div>