spec: remove some specs for smoke

Change-Id: Ifa529fe9c6246c6e13bee1409613a4407ca19e13
Reviewed-on: https://gerrit.instructure.com/186178
Tested-by: Jenkins
Reviewed-by: Robert Lamb <rlamb@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>

spec/selenium/admin/permissions_index_page_v2_spec.rb

@@ -43,7 +43,7 @@ describe "permissions index" do
       PermissionsIndex.visit(@account)
     end
 
-    it "updates the role to the new name after editing", :xbrowser do
+    it "updates the role to the new name after editing" do
       PermissionsIndex.edit_role(@custom_student_role, "A Better Kitty")
       expect{PermissionsIndex.role_name(@custom_student_role).text}.to become("A Better Kitty")
       expect{PermissionsIndex.edit_tray_header.text}.to become("Edit A Better Kitty")
@@ -92,7 +92,7 @@ describe "permissions index" do
       user_session(@admin)
     end
 
-    it "permissions enables on grid", :xbrowser do
+    it "permissions enables on grid" do
       PermissionsIndex.visit(@account)
       permission_name = "manage_outcomes"
       PermissionsIndex.change_permission(permission_name, ta_role.id, "enable")
@@ -103,7 +103,7 @@ describe "permissions index" do
       expect(r.locked).to eq(false)
     end
 
-    it "permissions disables on grid", :xbrowser do
+    it "permissions disables on grid" do
       PermissionsIndex.visit(@account)
       permission_name = "read_announcements"
       PermissionsIndex.change_permission(permission_name, student_role.id, "disable")
@@ -136,7 +136,7 @@ describe "permissions index" do
       expect(r.locked).to eq(true)
     end
 
-    it "permissions default on grid works", :xbrowser do
+    it "permissions default on grid works" do
       permission_name = "read_announcements"
       create_role_override(permission_name, student_role, @account,
         :enabled => false, :locked => false)

spec/selenium/assignments/assignments_spec.rb

@@ -48,7 +48,7 @@ describe "assignments" do
         get "/courses/#{@course.id}/assignments/#{@assignment.id}/edit"
       end
 
-      it "can save and publish an assignment", :xbrowser, priority: "1", test_id: 193784 do
+      it "can save and publish an assignment", priority: "1", test_id: 193784 do
         create_assignment false
 
         expect(f("#assignment-draft-state")).to be_displayed
@@ -122,7 +122,7 @@ describe "assignments" do
       expect(f('#assignment_description')).to have_value('<p>Testing HTML- RCE Toggle</p>')
     end
 
-    it "should edit an assignment", :xbrowser, priority: "1", test_id: 56012 do
+    it "should edit an assignment", priority: "1", test_id: 56012 do
       assignment_name = 'first test assignment'
       due_date = Time.now.utc + 2.days
       group = @course.assignment_groups.create!(:name => "default")

spec/selenium/assignments/assignments_submissions_student_spec.rb

@@ -105,7 +105,7 @@ describe "submissions" do
       driver.switch_to.alert.accept
     end
 
-    it "should allow you to submit a file", :xbrowser, priority: "1", test_id: 237022 do
+    it "should allow you to submit a file", priority: "1", test_id: 237022 do
       @assignment.submission_types = 'online_upload'
       @assignment.save!
       filename, fullpath, data = get_file("testfile1.txt")
@@ -355,7 +355,7 @@ describe "submissions" do
         driver.execute_script("$('.folder_item').addClass('folder_item_hover')")
       end
 
-      it "should allow uploaded files to be used for submission", :xbrowser, priority: "1", test_id: 237030 do
+      it "should allow uploaded files to be used for submission", priority: "1", test_id: 237030 do
         local_storage!
 
         add_file(fixture_file_upload('files/html-editing-test.html', 'text/html'),

spec/selenium/calendar/calendar2_agenda_spec.rb

@@ -354,7 +354,7 @@ describe "calendar2" do
       expect(f("#content")).not_to contain_css('.event-details .delete_event_link')
     end
 
-    it "should display agenda events", :xbrowser do
+    it "should display agenda events" do
       load_agenda_view
       expect(fj('.agenda-wrapper:visible')).to be_present
     end

spec/selenium/calendar/calendar2_month_spec.rb

@@ -482,7 +482,7 @@ describe "calendar2" do
       course_with_student_logged_in
     end
 
-    it "should navigate to month view when month button is clicked", :xbrowser do
+    it "should navigate to month view when month button is clicked" do
       load_week_view
       f('#month').click
       wait_for_ajaximations

spec/selenium/calendar/calendar2_week_spec.rb

@@ -346,7 +346,7 @@ describe "calendar2" do
       course_with_student_logged_in
     end
 
-    it "should navigate to week view when week button is clicked", :xbrowser do
+    it "should navigate to week view when week button is clicked" do
       load_week_view
       expect(fj('.fc-agendaWeek-view:visible')).to be_present
     end

spec/selenium/context_modules_teacher_spec.rb

@@ -53,7 +53,7 @@ describe "context modules" do
       wait_for_ajaximations
     end
 
-    it "should show all module items", :xbrowser, priority: "1", test_id: 126743 do
+    it "should show all module items", priority: "1", test_id: 126743 do
       module_with_two_items
       f(".expand_module_link").click
       wait_for_animations

spec/selenium/conversations/conversations_message_sending_spec.rb

@@ -41,7 +41,7 @@ describe "conversations new" do
       expect(errors[1].text).to include('Required field')
     end
 
-    it "should start a group conversation when there is only one recipient", :xbrowser, priority: "2", test_id: 201499 do
+    it "should start a group conversation when there is only one recipient", priority: "2", test_id: 201499 do
       skip_if_chrome('fragile in chrome')
       conversations
       compose course: @course, to: [@s1], subject: 'single recipient', body: 'hallo!'
@@ -50,7 +50,7 @@ describe "conversations new" do
       expect(c.private?).to be_falsey
     end
 
-    it "should start a group conversation when there is more than one recipient", :xbrowser, priority: "2", test_id: 201500 do
+    it "should start a group conversation when there is more than one recipient", priority: "2", test_id: 201500 do
       skip_if_chrome('fragile in chrome')
       conversations
       compose course: @course, to: [@s1, @s2], subject: 'multiple recipients', body: 'hallo!'

spec/selenium/conversations/conversations_replying_spec.rb

@@ -55,7 +55,7 @@ describe "conversations new" do
       expect(f('.message_subject_ro').text).to eq @convo.subject
     end
 
-    it "should add new messages to the conversation", :xbrowser, priority: "1", test_id: 197537 do
+    it "should add new messages to the conversation", priority: "1", test_id: 197537 do
       initial_message_count = @convo.conversation_messages.length
       go_to_inbox_and_select_message
       f('#reply-btn').click

spec/selenium/course_settings_spec.rb

@@ -181,7 +181,7 @@ describe "course settings" do
       expect(admin_cog('#nav_edit_tab_id_0')).to be_falsey
     end
 
-    it "should change course details", :xbrowser do
+    it "should change course details" do
       course_name = 'new course name'
       course_code = 'new course-101'
       locale_text = 'English (US)'

spec/selenium/dashboard/recent_activity/dashboard_spec.rb

@@ -118,7 +118,7 @@ describe "dashboard" do
       get "/courses/#{@course.id}"
     end
 
-    it "displays notification on course home page feed and todolist sidebar", :xbrowser do
+    it "displays notification on course home page feed and todolist sidebar" do
       # announcement icon is displayed
       expect(todosidebar_item_list).to contain_css(".ToDoSidebarItem [name='IconAnnouncement']")
       # announcement title link is displyed

spec/selenium/discussions/discussions_new_page_spec.rb

@@ -48,7 +48,7 @@ describe "discussions" do
         user_session(teacher)
       end
 
-      it "should add an attachment to a new topic", :xbrowser, priority: "1", test_id: 150466 do
+      it "should add an attachment to a new topic", priority: "1", test_id: 150466 do
         skip_if_firefox('known issue with firefox https://bugzilla.mozilla.org/show_bug.cgi?id=1335085')
         topic_title = 'new topic with file'
         get url
@@ -183,7 +183,7 @@ describe "discussions" do
         expect(f('.discussion-availability').text).to include("Not available until #{unlock_text_index_page}")
       end
 
-      it "should allow a student to create a discussion", :xbrowser, priority: "1", test_id: 150471 do
+      it "should allow a student to create a discussion", priority: "1", test_id: 150471 do
         skip_if_firefox('known issue with firefox https://bugzilla.mozilla.org/show_bug.cgi?id=1335085')
         get url
         wait_for_tiny(f('textarea[name=message]'))

spec/selenium/discussions/discussions_threaded_spec.rb

@@ -38,7 +38,7 @@ describe "threaded discussions" do
     expect(f('.discussion-title').text).to eq @topic_title
   end
 
-  it "should reply to the threaded discussion", :xbrowser, priority: "2", test_id: 222519 do
+  it "should reply to the threaded discussion", priority: "2", test_id: 222519 do
     entry_text = 'new entry'
     get "/courses/#{@course.id}/discussion_topics/#{@topic.id}"
 

spec/selenium/grades/gradezilla/gradebook_grade_detail_spec.rb

@@ -76,7 +76,7 @@ describe 'Grade Detail Tray:' do
       expect(late_policy_status).to eq 'none'
     end
 
-    it 'grade input is saved', :xbrowser, priority: "1", test_id: 3369723 do
+    it 'grade input is saved', priority: "1", test_id: 3369723 do
       Gradezilla::Cells.open_tray(@course.students.second, @a3)
       Gradezilla::GradeDetailTray.edit_grade(7)
 

spec/selenium/grades/gradezilla/gradebook_grade_edit_spec.rb

@@ -40,7 +40,7 @@ describe "Gradezilla editing grades" do
     clear_local_storage
   end
 
-  it "updates a graded quiz and have the points carry over to the quiz attempts page", :xbrowser, priority: "1", test_id: 220310 do
+  it "updates a graded quiz and have the points carry over to the quiz attempts page", priority: "1", test_id: 220310 do
     points = 50
     q = factory_with_protected_attributes(@course.quizzes, title: "new quiz", points_possible: points, quiz_type: 'assignment', workflow_state: 'available')
     q.save!

spec/selenium/groups_pages_student_spec.rb

@@ -332,7 +332,7 @@ describe "groups" do
     describe "pages page" do
       it_behaves_like 'pages_page', :student
 
-      it "should allow group members to create a page", :xbrowser, priority: "1", test_id: 273611 do
+      it "should allow group members to create a page", priority: "1", test_id: 273611 do
         skip_if_firefox('known issue with firefox https://bugzilla.mozilla.org/show_bug.cgi?id=1335085')
         get pages_page
         manually_create_wiki_page('yo','this be a page')

spec/selenium/groups_pages_teacher_spec.rb

@@ -253,7 +253,7 @@ describe "groups" do
     describe "pages page" do
       it_behaves_like 'pages_page', :teacher
 
-      it "should allow teachers to create a page", :xbrowser, priority: "1", test_id: 289993 do
+      it "should allow teachers to create a page", priority: "1", test_id: 289993 do
         skip_if_firefox('known issue with firefox https://bugzilla.mozilla.org/show_bug.cgi?id=1335085')
         get pages_page
         manually_create_wiki_page('stuff','it happens')

spec/selenium/helpers/basic/settings_specs.rb

@@ -75,7 +75,7 @@ shared_examples_for "settings basic tests" do |account_type|
       get account_settings_url
     end
 
-    it "should change the account name", :xbrowser, priority: "1", test_id: pick_test_id(account_type, sub_account: 249782, root_account: 251032) do
+    it "should change the account name", priority: "1", test_id: pick_test_id(account_type, sub_account: 249782, root_account: 251032) do
       new_account_name = 'new default account name'
       replace_content(f("#account_name"), new_account_name)
       click_submit

spec/selenium/login_logout_spec.rb

@@ -40,7 +40,7 @@ describe "login logout test" do
     expect(f('[aria-label="Profile tray"] h2').text).to eq @user.primary_pseudonym.unique_id
   end
 
-  it "should show error message if wrong credentials are used", :xbrowser, priority: "2" do
+  it "should show error message if wrong credentials are used", priority: "2" do
     get "/login"
     fill_in_login_form("fake@user.com", "fakepass")
     assert_flash_error_message("Invalid username")

spec/selenium/new_files_folders_spec.rb

@@ -41,7 +41,7 @@ describe "better_file_browsing, folders" do
       expect(fj("a:contains('new test folder')")).to be_present
     end
 
-    it "should display all cog icon options", :xbrowser, priority: "1", test_id: 133124 do
+    it "should display all cog icon options", priority: "1", test_id: 133124 do
       # locators were changed from fln in this test due to an issue with edgedriver
       # We can not use fln here
       create_new_folder
@@ -135,7 +135,7 @@ describe "better_file_browsing, folders" do
        expect(new_folder.text).to match(/New Folder/)
      end
 
-     it "should handle duplicate folder names", :xbrowser, priority: "1", test_id: 133130 do
+     it "should handle duplicate folder names", priority: "1", test_id: 133130 do
        create_new_folder
        add_folder("New Folder")
        expect(all_files_folders.last.text).to match(/New Folder 2/)

spec/selenium/new_files_spec.rb

@@ -35,13 +35,13 @@ describe "better_file_browsing" do
       user_session @teacher
     end
 
-    it "should display new files UI", :xbrowser, priority: "1", test_id: 133092 do
+    it "should display new files UI", priority: "1", test_id: 133092 do
       get "/courses/#{@course.id}/files"
       expect(f('.btn-upload')).to be_displayed
       expect(all_files_folders.count).to eq 1
     end
 
-    it "should load correct column values on uploaded file", :xbrowser, priority: "1", test_id: 133129 do
+    it "should load correct column values on uploaded file", priority: "1", test_id: 133129 do
       get "/courses/#{@course.id}/files"
       time_current = @course.attachments.first.updated_at.strftime("%l:%M%P").strip
       expect(ff('.ef-name-col__text')[0]).to include_text 'example.pdf'
@@ -186,7 +186,7 @@ describe "better_file_browsing" do
       get "/courses/#{@course.id}/files"
     end
 
-    it "should search for a file", :xbrowser, priority: "2", test_id: 220355 do
+    it "should search for a file", priority: "2", test_id: 220355 do
       expect(all_files_folders).to have_size 3
       f("input[type='search']").send_keys "b_fi", :return
       expect(all_files_folders).to have_size 1

spec/selenium/new_files_student_spec.rb

@@ -44,7 +44,7 @@ describe "better_file_browsing" do
         end
       end
 
-      it "should search for a file", :xbrowser, priority: "1", test_id: 220355 do
+      it "should search for a file", priority: "1", test_id: 220355 do
         get "/courses/#{@course.id}/files"
         f("input[type='search']").send_keys "b_fi", :return
         expect(all_files_folders).to have_size 1

spec/selenium/profile_communications_spec.rb

@@ -43,7 +43,7 @@ describe "profile communication settings" do
     fj("td.comm-event-option[data-category='#{category}'][data-channelid=#{channel_id}]")
   end
 
-  it "should render", :xbrowser do
+  it "should render" do
     get "/profile/communication"
     # Page title should match expected
     expect(driver.execute_script("return document.title")).to eq 'Notification Preferences'
@@ -53,7 +53,7 @@ describe "profile communication settings" do
     expect(f('#content > h1').text).to eq 'Notification Preferences'
   end
 
-  it "should display the users email address as channel", :xbrowser do
+  it "should display the users email address as channel" do
     get "/profile/communication"
     wait_for_ajaximations
     expect(fj('th.comm-channel:first')).to include_text('Email Address')
@@ -101,7 +101,7 @@ describe "profile communication settings" do
     expect(buttons[1]).to have_attribute('value', 'never')
   end
 
-  it "should load the initial state of a user-pref checkbox", :xbrowser do
+  it "should load the initial state of a user-pref checkbox" do
     # set the user's initial user preference and verify checked or unchecked
     @user.preferences[:send_scores_in_emails] = false
     @user.save!
@@ -110,7 +110,7 @@ describe "profile communication settings" do
     expect(is_checked('.user-pref-check[name=send_scores_in_emails]')).to be_falsey
   end
 
-  it "should save a user-pref checkbox change", :xbrowser do
+  it "should save a user-pref checkbox change" do
     # Enable the setting to be changed first...
     Account.default.settings[:allow_sending_scores_in_emails] = true
     Account.default.save!

spec/selenium/profile_spec.rb

@@ -109,7 +109,7 @@ describe "profile" do
       f('#right-side .add_email_link').click
     end
 
-    it "should add a new email address on profile settings page", :xbrowser do
+    it "should add a new email address on profile settings page" do
       @user.account.enable_feature!(:international_sms)
       notification_model(:category => 'Grading')
       notification_policy_model(:notification_id => @notification.id)

spec/selenium/quizzes/quizzes_create_quiz_teacher_spec.rb

@@ -41,7 +41,7 @@ describe 'creating a quiz' do
         open_quiz_edit_form
       end
 
-      it 'sets availability dates and due dates for each section', :xbrowser, priority: 1, test_id: 140670 do
+      it 'sets availability dates and due dates for each section', priority: 1, test_id: 140670 do
         assign_quiz_to_no_one
 
         # assign to default section
@@ -119,7 +119,7 @@ describe 'creating a quiz' do
         end
       end
 
-      it 'creates a quiz directly from the index page', :xbrowser, priority: "1", test_id: 210055 do
+      it 'creates a quiz directly from the index page', priority: "1", test_id: 210055 do
         expect do
           create_new_quiz
         end.to change{ Quizzes::Quiz.count }.by(1)

spec/selenium/syllabus_teacher_spec.rb

@@ -50,13 +50,13 @@ describe "course syllabus" do
       wait_for_ajaximations
     end
 
-    it "should confirm existing assignments and dates are correct", :xbrowser, priority:"1", test_id: 237016 do
+    it "should confirm existing assignments and dates are correct", priority:"1", test_id: 237016 do
       assignment_details = ff('td.name')
       expect(assignment_details[0].text.strip).to eq @assignment_1.title
       expect(assignment_details[1].text.strip).to eq @assignment_2.title
     end
 
-    it "should edit the description", :xbrowser, priority:"1", test_id: 237017 do
+    it "should edit the description", priority:"1", test_id: 237017 do
       skip_if_firefox('known issue with firefox https://bugzilla.mozilla.org/show_bug.cgi?id=1335085')
       new_description = "new syllabus description"
       wait_for_new_page_load { f('.edit_syllabus_link').click }