ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Accessibility: Enclose discussion titles in h3s 

Fixes CNVS-14659

Test plan:
- Visit the list of discussion topics for a course.
- Verify that the discussion titles are recognized as level three headings by
  screen readers.
- Verify that the visual appearance of the page has not been effected.

Change-Id: Ideddc504730cd0e8cdc91a8f34174922acafed76
Reviewed-on: https://gerrit.instructure.com/38886
Reviewed-by: Jayce Higgins <jhiggins@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Matthew Wheeler <mwheeler@instructure.com>
This commit is contained in:
Aaron Cannon 2014-08-07 12:36:05 -05:00
parent ba50a1c112
commit f1bdc8f7e4
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/stylesheets/pages/discussions_list.scss
View File

@ -66,6 +66,11 @@
} }
} }
.discussion-title-block {
margin: 0;
line-height: 1.5em;
}
.item-box { .item-box {
background: #e0e5ea; background: #e0e5ea;
border: 1px solid #c1c7cf; border: 1px solid #c1c7cf;

4
app/views/jst/DiscussionTopics/discussion.handlebars
View File

@ -16,12 +16,12 @@
</div> </div>
<div class="discussion-title"> <div class="discussion-title">
<div role="heading" aria-level="3"> <h3 class="inline-block discussion-title-block">
{{#if assignment}} {{#if assignment}}
<span class="screenreader-only">{{#t "graded_discussion"}}Graded discussion: {{/t}}</span> <span class="screenreader-only">{{#t "graded_discussion"}}Graded discussion: {{/t}}</span>
{{/if}} {{/if}}
<a href="{{html_url}}" class="title">{{title}}</a> <a href="{{html_url}}" class="title">{{title}}</a>
</div> </h3>
<small {{ contextSensitiveDatetimeTitle last_reply_at }}>{{#t "last_post_date"}}Last post {{display_last_reply_at}}{{/t}}</small> <small {{ contextSensitiveDatetimeTitle last_reply_at }}>{{#t "last_post_date"}}Last post {{display_last_reply_at}}{{/t}}</small>
</div> </div>