ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reduce test console output noise 

Test plan:
 - All tests pass

flag=none

Change-Id: I1522fc4b2f3cca0ee0cb291291d3f18b454dbf45
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277805
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
This commit is contained in:
Aaron Shafovaloff 2021-11-09 20:58:36 -06:00
parent 4ff10e0e7c
commit efa6d419f0
8 changed files with 21 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
spec/javascripts/jsx/gradebook/GradebookSpec.js
View File

@ -2820,7 +2820,7 @@ test('removes the filter when the "view section filter" option is turned off', f
QUnit.module('Gradebook#updateCurrentSection', {
setup() {
this.server = sinon.createFakeServer({respondImmediately: true})
this.server = sinon.fakeServer.create({respondImmediately: true})
this.server.respondWith([200, {}, ''])
this.gradebook = createGradebook({settings_update_url: '/settingUrl'})
@ -3810,7 +3810,13 @@ QUnit.module('Gradebook#filterAssignments', {
{id: '1', name: 'Algebra', position: 1},
{id: '2', name: 'English', position: 2}
]
this.gradebook.gradingPeriodSet = {id: '1501', gradingPeriods: [{id: '1401'}, {id: '1402'}]}
this.gradebook.gradingPeriodSet = {
id: '1501',
gradingPeriods: [
{id: '1401', title: 'Grading Period #1'},
{id: '1402', title: 'Grading Period #2'}
]
}
this.gradebook.gridDisplaySettings.showUnpublishedAssignments = true
this.gradebook.show_attendance = true
}
@ -5584,7 +5590,7 @@ QUnit.module('Gradebook#arrangeColumnsBy', hooks => {
QUnit.module('Gradebook#updateCurrentGradingPeriod', {
setup() {
this.server = sinon.createFakeServer({respondImmediately: true})
this.server = sinon.fakeServer.create({respondImmediately: true})
this.server.respondWith([200, {}, ''])
setFixtureHtml($fixtures)
@ -5592,7 +5598,10 @@ QUnit.module('Gradebook#updateCurrentGradingPeriod', {
this.gradebook = createGradebook({
grading_period_set: {
id: '1501',
grading_periods: [{id: '1401'}, {id: '1402'}]
grading_periods: [
{id: '1401', title: 'Grading Period #1'},
{id: '1402', title: 'Grading Period #2'}
]
},
settings: {
filter_columns_by: {
@ -5682,7 +5691,7 @@ test('renders the action menu', function () {
QUnit.module('Gradebook#updateCurrentModule', {
setup() {
this.server = sinon.createFakeServer({respondImmediately: true})
this.server = sinon.fakeServer.create({respondImmediately: true})
this.server.respondWith([200, {}, ''])
setFixtureHtml($fixtures)
@ -5779,7 +5788,7 @@ test('has no effect when the module has not changed', function () {
QUnit.module('Gradebook#updateCurrentAssignmentGroup', {
setup() {
this.server = sinon.createFakeServer({respondImmediately: true})
this.server = sinon.fakeServer.create({respondImmediately: true})
this.server.respondWith([200, {}, ''])
setFixtureHtml($fixtures)

4
spec/javascripts/webpack_spec_index.js
View File

@ -116,10 +116,6 @@ if (process.env.JSPEC_PATH) {
if (isFile) {
// eslint-disable-next-line import/no-dynamic-require
require(`../../${process.env.JSPEC_PATH}`)
} else {
requireAll(
require.context(`../../${process.env.JSPEC_PATH}`, process.env.JSPEC_RECURSE !== '0', /\.js$/)
)
}
} else {
requireAll(

2
ui/features/gradebook/react/default_gradebook/GradebookGrid/editors/AssignmentGradeInput/GradingSchemeGradeInput.js
View File

@ -112,7 +112,7 @@ export default class GradingSchemeInput extends Component {
}
}
componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
if (this.textInput !== document.activeElement) {
const {assignment, gradingScheme, pendingGradeInfo, submission} = nextProps
const value = formatGrade(submission, assignment, gradingScheme, pendingGradeInfo)

2
ui/features/gradebook/react/default_gradebook/GradebookGrid/editors/AssignmentGradeInput/TextGradeInput.js
View File

@ -104,7 +104,7 @@ export default class TextGradeInput extends Component {
}
}
componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
if (!this.isFocused()) {
const {assignment, enterGradesAs, gradingScheme, pendingGradeInfo, submission} = nextProps

2
ui/features/gradebook/react/default_gradebook/GradebookGrid/editors/GradeInput/TextGradeInput.js
View File

@ -52,7 +52,7 @@ export default class TextGradeInput extends PureComponent {
}
}
componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
if (this.textInput !== document.activeElement) {
const nextInfo = nextProps.pendingGradeInfo || nextProps.gradeInfo

2
ui/features/gradebook/react/default_gradebook/components/ActionMenu.js
View File

@ -100,7 +100,7 @@ class ActionMenu extends React.Component {
this.launchPostGrades = this.launchPostGrades.bind(this)
}
componentWillMount() {
UNSAFE_componentWillMount() {
const existingExport = this.getExistingExport()
this.exportManager = new GradebookExportManager(

2
ui/features/gradebook/react/default_gradebook/components/GradeInput.js
View File

@ -164,7 +164,7 @@ export default class GradeInput extends Component {
this.state = stateFromProps(props)
}
componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
const submissionChanged = this.props.submission.id !== nextProps.submission.id
const submissionUpdated = this.props.submissionUpdating && !nextProps.submissionUpdating

2
ui/features/gradebook/react/default_gradebook/components/SubmissionTrayRadioInputGroup.js
View File

@ -41,7 +41,7 @@ function checkedValue(submission, assignment) {
export default class SubmissionTrayRadioInputGroup extends React.Component {
state = {pendingUpdateData: null}
componentWillReceiveProps(nextProps) {
UNSAFE_componentWillReceiveProps(nextProps) {
if (
this.props.submissionUpdating &&
!nextProps.submissionUpdating &&