ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix screenReaderLabel is marked as required 

flag=none

Test Plan:
 - specs pass

Change-Id: Iec9cfcd9ead0a2fd72a6d2fdab92237aa912657d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277496
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
This commit is contained in:
Drake Harper 2021-11-04 15:38:05 -06:00
parent e99a0003be
commit e7d7990b91
2 changed files with 24 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
jest/jest-setup.js
View File

@ -90,7 +90,6 @@ const ignoredErrors = [
/The prop `rcsProps.canUploadFiles` is marked as required in `ForwardRef`/,
/The prop `renderLabel` is marked as required in `(FileDrop|NumberInput|Select)`/,
/The prop `rootId` is marked as required in `GroupSelectionDrillDown`/,
/The prop `screenReaderLabel` is marked as required in `IconButton`/,
/Unexpected keys "searchPermissions", "filterRoles", "tabChanged", "setAndOpenAddTray" found in preloadedState argument passed to createStore/,
/Use the `defaultValue` or `value` props on <select> instead of setting `selected` on <option>/,
/validateDOMNesting\(...\): %s cannot appear as a child of <%s>/,

28
ui/shared/integrations/react/accounts/microsoft_sync/MicrosoftSyncAccountSettings.js
View File

@ -94,7 +94,12 @@ export default function MicrosoftSyncAccountSettings() {
tip={I18n.t('Your Azure Active Directory Tenant Name')}
on={['hover', 'focus']}
>
<IconButton renderIcon={IconInfoLine} withBackground={false} withBorder={false} />
<IconButton
screenReaderLabel="Tenant Name"
renderIcon={IconInfoLine}
withBackground={false}
withBorder={false}
/>
</Tooltip>
</Table.RowHeader>
@ -122,7 +127,12 @@ export default function MicrosoftSyncAccountSettings() {
placement="top"
on={['hover', 'focus']}
>
<IconButton renderIcon={IconInfoLine} withBackground={false} withBorder={false} />
<IconButton
screenReaderLabel="Login Attribute"
renderIcon={IconInfoLine}
withBackground={false}
withBorder={false}
/>
</Tooltip>
</Table.RowHeader>
@ -147,7 +157,12 @@ export default function MicrosoftSyncAccountSettings() {
)}
on={['hover', 'focus']}
>
<IconButton renderIcon={IconInfoLine} withBackground={false} withBorder={false} />
<IconButton
screenReaderLabel="Suffix"
renderIcon={IconInfoLine}
withBackground={false}
withBorder={false}
/>
</Tooltip>
</Table.RowHeader>
<Table.Cell>
@ -172,7 +187,12 @@ export default function MicrosoftSyncAccountSettings() {
)}
on={['hover', 'focus']}
>
<IconButton renderIcon={IconInfoLine} withBackground={false} withBorder={false} />
<IconButton
screenReaderLabel="Active Directory Lookup Attribute"
renderIcon={IconInfoLine}
withBackground={false}
withBorder={false}
/>
</Tooltip>
</Table.RowHeader>