From e32e17f024071c06c5976cf966f4128d3b8de8b3 Mon Sep 17 00:00:00 2001 From: Jeremy Stanley Date: Mon, 29 Jan 2018 13:09:08 -0700 Subject: [PATCH] add comment about hashSalt in baseWebpackConfig.js to make it clear why it's there and under what conditions it should be changed refs CORE-933 Change-Id: I449eaaa54baddc3ab6667f2a16d97570bb61f21b Reviewed-on: https://gerrit.instructure.com/139438 Tested-by: Jenkins Reviewed-by: Brent Burgoyne Product-Review: Jeremy Stanley QA-Review: Jeremy Stanley --- frontend_build/baseWebpackConfig.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/frontend_build/baseWebpackConfig.js b/frontend_build/baseWebpackConfig.js index a05b7a6c65f..48b55f13ac1 100644 --- a/frontend_build/baseWebpackConfig.js +++ b/frontend_build/baseWebpackConfig.js @@ -83,6 +83,10 @@ module.exports = { }, bundleEntries, momentLocaleBundles), output: { + // NOTE: hashSalt was added when HashedModuleIdsPlugin was installed, since + // chunkhashes are insensitive to moduleid changes. It should be changed again + // if this plugin is reconfigured or removed, or if there is another reason to + // prevent previously cached assets from being mixed with those from the new build hashSalt: '2018-01-29', path: path.join(__dirname, '../public', webpackPublicPath),