From e1719b299e1daddd0832dbff51e1e64efe910c45 Mon Sep 17 00:00:00 2001 From: Anju Reddy Date: Tue, 25 Apr 2017 17:18:56 -0600 Subject: [PATCH] spec: Adding a fix for chrome failure (click nto working first time) Change-Id: I10bf8f39e33ae334b9d3989f73cc171573b5e752 Reviewed-on: https://gerrit.instructure.com/109763 Tested-by: Jenkins Reviewed-by: KC Naegle Product-Review: Gentry Beckmann Tested-by: Gentry Beckmann QA-Review: Gentry Beckmann --- spec/selenium/grades/page_objects/student_grades_page.rb | 4 ++++ .../grades/student_grades_page/gradebook_student_spec.rb | 8 ++++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/spec/selenium/grades/page_objects/student_grades_page.rb b/spec/selenium/grades/page_objects/student_grades_page.rb index fb655e4a633..53cc8229e50 100644 --- a/spec/selenium/grades/page_objects/student_grades_page.rb +++ b/spec/selenium/grades/page_objects/student_grades_page.rb @@ -40,4 +40,8 @@ class StudentGradesPage def assignment_row(assignment) f("#submission_#{assignment.id}") end + + def toggle_comment_module + fj('.toggle_comments_link .icon-discussion:first').click + end end diff --git a/spec/selenium/grades/student_grades_page/gradebook_student_spec.rb b/spec/selenium/grades/student_grades_page/gradebook_student_spec.rb index 341b6eba84f..59b150f05ee 100644 --- a/spec/selenium/grades/student_grades_page/gradebook_student_spec.rb +++ b/spec/selenium/grades/student_grades_page/gradebook_student_spec.rb @@ -203,9 +203,13 @@ describe 'Student Gradebook' do it 'should display comments from a teacher on student grades page', priority: "1", test_id: 537621 do user_session(student) - get "/courses/#{published_course.id}/grades" - fj('.toggle_comments_link .icon-discussion:first').click + + student_grades_page.toggle_comment_module + unless f('.score_details_table').displayed? + # 1st click seems to fail on chrome 1 out of 5 times so adding a second click + student_grades_page.toggle_comment_module + end expect(fj('.score_details_table span:first')).to include_text('good job') end