ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

spec: remove redundant discussion tests 

upon looking at the selenium tests, there are no
setting toggles or feature flag toggles triggerred
before any of the discussion new edit tests run,
this means that discussion edit and discussion new
edit are both testing the same default edit page

Change-Id: If1081ad00b91b354fd665692b13d72e1dd9c4787
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330668
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
This commit is contained in:
Caleb Guanzon 2023-10-18 10:59:48 -06:00
parent ff939066d8
commit de38af148a
2 changed files with 0 additions and 178 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

99
spec/selenium/discussions/discussions_edit_page_v2_spec.rb
View File

@ -1,99 +0,0 @@
# frozen_string_literal: true
#
# Copyright (C) 2014 - present Instructure, Inc.
#
# This file is part of Canvas.
#
# Canvas is free software: you can redistribute it and/or modify it under
# the terms of the GNU Affero General Public License as published by the Free
# Software Foundation, version 3 of the License.
#
# Canvas is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE. See the GNU Affero General Public License for more
# details.
#
# You should have received a copy of the GNU Affero General Public License along
# with this program. If not, see <http://www.gnu.org/licenses/>.
require_relative "pages/discussions_new_edit_page"
describe "discussions index" do
include_context "in-process server selenium tests"
context "as a teacher" do
discussion1_title = "Meaning of life"
discussion2_title = "Meaning of the universe"
before :once do
@teacher = user_with_pseudonym(active_user: true)
@student = user_with_pseudonym(active_user: true)
@account = Account.create(name: "New Account", default_time_zone: "UTC")
@course = course_factory(course_name: "Desks 101",
account: @account,
active_course: true)
@course.enroll_student(@student, { active_all: true })
@course.enroll_teacher(@teacher, { active_all: true })
# Discussion attributes: title, message, delayed_post_at, user
@discussion1 = @course.discussion_topics.create!(
title: discussion1_title,
message: "Is it really 42?",
user: @teacher,
pinned: false
)
@discussion2 = @course.discussion_topics.create!(
title: discussion2_title,
message: "Could it be 43?",
delayed_post_at: 1.day.from_now,
user: @teacher,
locked: true,
pinned: false
)
@discussion1.discussion_entries.create!(user: @student, message: "I think I read that somewhere...")
@discussion1.discussion_entries.create!(user: @student, message: ":eyeroll:")
end
def login_and_visit_edit_course(teacher, course)
user_session(teacher)
DiscussionNewEdit.visit(course)
end
def create_course_and_discussion(opts)
opts.reverse_merge!({ locked: false, pinned: false })
course = course_factory(active_all: true)
discussion = course.discussion_topics.create!(
title: opts[:title],
message: opts[:message],
user: @teacher,
locked: opts[:locked],
pinned: opts[:pinned]
)
[course, discussion]
end
it "creating discussion with section gives no error" do
@course.course_sections.create!(name: "Section 1")
@course.course_sections.create!(name: "Section 2")
login_and_visit_edit_course(@teacher, @course)
DiscussionNewEdit.select_a_section("Section")
DiscussionNewEdit.add_message("Discussion Body")
DiscussionNewEdit.add_title("Discussion Title")
expect_new_page_load { DiscussionNewEdit.submit_discussion_form }
end
it "no sections will give an error" do
login_and_visit_edit_course(@teacher, @course)
DiscussionNewEdit.select_a_section("")
expect(DiscussionNewEdit.section_error).to include("A section is required")
end
it "graded sections will not show SectionsAutocomplete" do
login_and_visit_edit_course(@teacher, @course)
DiscussionNewEdit.graded_checkbox.click
expect(DiscussionNewEdit.section_disabled_item).to be_truthy
end
end
end

79
spec/selenium/discussions/pages/discussions_new_edit_page.rb
View File

@ -1,79 +0,0 @@
# frozen_string_literal: true
#
# Copyright (C) 2017 - present Instructure, Inc.
#
# This file is part of Canvas.
#
# Canvas is free software: you can redistribute it and/or modify it under
# the terms of the GNU Affero General Public License as published by the Free
# Software Foundation, version 3 of the License.
#
# Canvas is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE. See the GNU Affero General Public License for more
# details.
#
# You should have received a copy of the GNU Affero General Public License along
# with this program. If not, see <http://www.gnu.org/licenses/>.
require_relative "../../common"
class DiscussionNewEdit
class << self
include SeleniumDependencies
# ---------------------- Page ----------------------
def visit(course)
get("/courses/#{course.id}/discussion_topics/new")
end
def new_discussion_url
"/discussion_topics/new"
end
def individual_discussion_url(discussion)
"/discussion_topics/#{discussion.id}"
end
# ---------------------- Controls ----------------------
def section_autocomplete_css
"#sections_autocomplete_root input[type='text']"
end
def submit_discussion_form
submit_form(".form-actions")
end
def add_message(message)
type_in_tiny("textarea[name=message]", message)
end
def add_title(title)
replace_content(f("input[name=title]"), title)
end
def section_error
f("#sections_autocomplete_root").text
end
def section_disabled_item
f("#disabled_sections_autocomplete")
end
def graded_checkbox
f("#use_for_grading")
end
def select_a_section(section_name)
fj(section_autocomplete_css).click
if section_name.empty?
driver.action.send_keys(:backspace).perform
else
set_value(fj(section_autocomplete_css), section_name)
driver.action.send_keys(:enter).perform
end
wait_for_ajax_requests
end
end
end