ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

replace string "x" with icon-x for recent activity 

Fixes: UIDEV-126

test plan:
- as a user, navigate to the dashboard
- from the cog dropdwon select "recent activity"
- click the "show more" and the line items should have an "X" at
  the end of each row (this is now using "icon-x" vs a typed "x")
  example:  https://screencast.com/t/vJAilWeWdwpY

Change-Id: I2b24a154e6544de3a9bf9d672d98d582f6eba9db
Reviewed-on: https://gerrit.instructure.com/133835
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
This commit is contained in:
Pam Hiett 2017-11-27 11:10:36 -07:00 committed by Pam Hiett
parent 87d6286d16
commit dbf96c78a3
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/views/shared/_recent_activity_item.html.erb
View File

@ -36,6 +36,8 @@
</td>
<td class="remove">
<% translated_close = t 'Ignore' %>
<a class="close ignore-item" href="#" data-url="<%= dashboard_ignore_stream_item_url(item.stream_item_id) %>" data-remove='tr' title="<%= translated_close %>" aria-label="<%= translated_close %>" role="button">×</a>
<a class="close ignore-item" href="#" data-url="<%= dashboard_ignore_stream_item_url(item.stream_item_id) %>" data-remove='tr' title="<%= translated_close %>" aria-label="<%= translated_close %>" role="button">
<i class="icon-x" aria-hidden="true"></i>
</a>
</td>
</tr>