ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

spec: fix flaky spec in groups_teacher_spec.rb:157 

closes: KNO-184

Another case where bug fixes have taken care of previous
flakiness. Unskipping.

Change-Id: I42594bc127f8ad51bbe739b1841b30e9ebea6c0f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/226442
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
This commit is contained in:
sshepherd 2020-02-12 11:51:14 -07:00 committed by Steve Shepherd
parent 4e23471df4
commit dbec4a49f9
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
spec/selenium/groups_teacher_spec.rb
View File

@ -155,7 +155,6 @@ describe "new groups" do
end end
it "should allow teachers to message unassigned students" do it "should allow teachers to message unassigned students" do
skip('KNO-184')
group_test_setup group_test_setup
get "/courses/#{@course.id}/groups" get "/courses/#{@course.id}/groups"
@ -941,7 +940,7 @@ describe "new groups" do
ff('.edit-group-assignment').last.click ff('.edit-group-assignment').last.click
wait_for_ajaximations wait_for_ajaximations
click_option('.move-select .move-select__group select', "#{@testgroup.first.name}") click_option('.move-select .move-select__group select', "#{@testgroup.first.name}")
sleep 0.3 # have to wait for instUI animations sleep 0.3 # have to wait for instUI animations
ff('.move-select button[type="submit"]').last.click ff('.move-select button[type="submit"]').last.click