Remove rce_lti_favorites feature flag

fixes LS-1988
flag=none

test plan:
- RCE LTI Favorites feature should be enabled and working normally

Change-Id: I0e0d6d7beb7c9c07c167eac8798576cb7aa2bf6f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/261871
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Nate Armstrong <narmstrong@instructure.com>
QA-Review: Nate Armstrong <narmstrong@instructure.com>
Product-Review: Eric Saupe <eric.saupe@instructure.com>

app/controllers/application_controller.rb

@@ -222,7 +222,7 @@ class ApplicationController < ActionController::Base
   # put feature checks on Account.site_admin and @domain_root_account that we're loading for every page in here
   # so altogether we can get them faster the vast majority of the time
   JS_ENV_SITE_ADMIN_FEATURES = [
-    :cc_in_rce_video_tray, :featured_help_links, :rce_lti_favorites, :rce_pretty_html_editor, :rce_better_file_downloading, :rce_better_file_previewing
+    :cc_in_rce_video_tray, :featured_help_links, :rce_pretty_html_editor, :rce_better_file_downloading, :rce_better_file_previewing
   ].freeze
   JS_ENV_ROOT_ACCOUNT_FEATURES = [
     :responsive_awareness, :responsive_misc, :product_tours, :module_dnd, :files_dnd, :unpublished_courses,

app/jsx/external_apps/components/ExternalToolsTable.js

@@ -111,7 +111,6 @@ export default class ExternalToolsTable extends React.Component {
     const show_lti_favorite_toggles =
       /^account_/.test(ENV.context_asset_string) &&
       !ENV.ACCOUNT?.site_admin &&
-      ENV.FEATURES?.rce_lti_favorites &&
       this.props.canAddEdit
 
     return (

app/jsx/external_apps/components/__tests__/ExternalToolsTable.test.js

@@ -26,9 +26,7 @@ function renderTable(canAddEdit) {
     ACCOUNT: {
       site_admin: false
     },
-    FEATURES: {
-      rce_lti_favorites: true
-    }
+    FEATURES: {}
   }
 
   const setFocusAbove = jest.fn()
@@ -36,7 +34,7 @@ function renderTable(canAddEdit) {
 }
 
 describe('ExternalToolsTable', () => {
-  describe('rce favorites toggle', function() {
+  describe('rce favorites toggle', function () {
     it('shows if admin has permission', () => {
       const {queryByText} = renderTable(true)
       expect(queryByText('Name')).toBeInTheDocument()

config/feature_flags/learning_activities_rce.yml

@@ -11,11 +11,6 @@ cc_in_rce_video_tray:
   display_name: RCE Edit Closed Captions
   description: Edit closed captions/subtitles to videos from the video options tray in the RCE
   applies_to: SiteAdmin
-rce_lti_favorites:
-  state: hidden
-  display_name: Support favorite LTI tools in the RCE
-  description: Let the site administrator select up to 2 LTI apps as favorites, which will then be displayed in the RCE's toolbar
-  applies_to: SiteAdmin
 rce_pretty_html_editor:
   state: hidden
   display_name: RCE Pretty HTML Editor

spec/controllers/application_controller_spec.rb

@@ -319,18 +319,6 @@ RSpec.describe ApplicationController do
           expect(controller.js_env[:FEATURES][:unpublished_courses]).to be_truthy
         end
       end
-
-      context "rce_lti_favorites" do
-        it 'is false if the feature flag is off' do
-          Account.site_admin.disable_feature!(:rce_lti_favorites)
-          expect(controller.js_env[:FEATURES][:rce_lti_favorites]).to be_falsey
-        end
-
-        it 'is true if the feature flag is on' do
-          Account.site_admin.enable_feature!(:rce_lti_favorites)
-          expect(controller.js_env[:FEATURES][:rce_lti_favorites]).to be_truthy
-        end
-      end
     end
 
     it 'sets LTI_LAUNCH_FRAME_ALLOWANCES' do