ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix peer review title 

Peer review displayed "'not" instead of "not yet submitted".

flag=none
fixes EVAL-3317

Test plan
- As a teacher go to the peer review page
- Hover over a student name who has not submitted
- Should say "not yet submitted"
- Hover over a student name who has submitted
- Should say "submitted"

Change-Id: I02d3b80248c476d5c07c1ca0222492a9de812dd7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325599
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Reviewed-by: Christopher Soto <christopher.soto@instructure.com>
QA-Review: Spencer Olson <solson@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
This commit is contained in:
Cameron Ray 2023-08-18 12:25:39 -04:00
parent 3f0c22188f
commit d8ddc6e31c
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app/views/assignments/peer_reviews.html.erb
View File

@ -59,19 +59,22 @@
<% @students.each do |student| %>
<% submission = @submissions.to_a.find{|s| s.user_id == student.id} %>
<li style="font-size: 1.2em; margin-bottom: 10px;" class="student_reviews">
<a <%= submission && submission.has_submission? ? "class='icon-warning person' title='#{h(t(:submitted, "submitted"))}'" : "class='person_gray' title='#{h(t(:not_yet_submitted, "not yet submitted"))}'" %> href="<%= context_url(@context, :context_assignment_submission_url, @assignment.id, student.id) %>">
<a
title="<%= submission&.has_submission? ? h(t(:submitted, "submitted")) : h(t(:not_yet_submitted, "not yet submitted")) %>"
href="<%= context_url(@context, :context_assignment_submission_url, @assignment.id, student.id) %>"
>
<span class="assessor_name"><%= student.last_name_first %> <% if student.pronouns %><i>(<%= student.pronouns %>)</i><% end %></span>
<span class="user_id student_review_id" style="display: none;"><%= student.id %></span>
</a>
<ul class="unstyled_list peer_reviews" style="padding-<%= direction('left') %>: 21px; font-size: 0.8em; width: 50%;">
<li class="peer_review no_requests_message" style="<%= hidden unless !submission || submission.assigned_assessments.for_active_users(@context).empty? %>"><%= t :none_assigned, "None Assigned" %></li>
<% if submission %>
<% Canvas::ICU.collate_by(submission.assigned_assessments.for_active_users(@context)) {|r| r.asset.user.sortable_name }.each do |request| %>
<% if (request && request.asset && request.asset.user) %>
<%= render :partial => 'peer_review_assignment', :locals => {:request => request} %>
<% Canvas::ICU.collate_by(submission.assigned_assessments.for_active_users(@context)) {|r| r.asset.user.sortable_name }.each do |request| %>
<% if (request && request.asset && request.asset.user) %>
<%= render :partial => 'peer_review_assignment', :locals => {:request => request} %>
<% end %>
<% end %>
<% end %>
<% end %>
</ul>
<div style="margin-<%= direction('left') %>: 25px; font-size: 0.7em;" class="assign_box">
<a href="#" class="assign_peer_review_link"><%= t 'links.assign_peer_review', "Give %{student} another submission to assess", :student => student.name %>