remove question id from data on clone, fixes #4684

Change-Id: I1ba23dfe1e20b33503b40711098ea7d329a5aba6
Reviewed-on: https://gerrit.instructure.com/3880
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>

app/models/quiz_question.rb

@@ -93,6 +93,7 @@ class QuizQuestion < ActiveRecord::Base
       dup.send("#{key}=", val)
     end
     data = self.question_data || {}
+    data.delete(:id)
     if options[:old_context] && options[:new_context]
       data = QuizQuestion.migrate_question_hash(data, options)
     end

db/migrate/20110526154853_remove_quiz_data_ids.rb

@@ -0,0 +1,19 @@
+# some cloned quiz questions mistakenly have the old question id saved to the data hash, causing issues when trying to edit.
+class RemoveQuizDataIds < ActiveRecord::Migration
+  class QuizQuestion < ActiveRecord::Base;
+    serialize :question_data
+  end
+
+  def self.up
+    QuizQuestion.find_each do |qq|
+      data = qq.question_data
+      if data.is_a?(Hash) && data[:id].present? && data[:id] != qq.id
+        data[:id] = qq.id
+        qq.save
+      end
+    end
+  end
+
+  def self.down
+  end
+end

spec/models/quiz_spec.rb

@@ -389,6 +389,8 @@ describe Quiz do
       new_q.title.should eql(q.title)
       new_q.quiz_groups.length.should eql(q.quiz_groups.length)
       new_q.quiz_questions.length.should eql(q.quiz_questions.length)
+      new_q.quiz_questions.first.question_data[:id].should be_nil
+      new_q.quiz_questions.first.data[:id].should == new_q.quiz_questions.first.id
     end
     
     it "should set the related assignment's group correctly" do