spec: identify and tag existing smoke specs

Change-Id: I4d344521e2488b899a8b4450fca8deb4aab61a04
Reviewed-on: https://gerrit.instructure.com/181459
Reviewed-by: KC Naegle <knaegle@instructure.com>
Tested-by: Jenkins
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
This commit is contained in:
James Butters 2019-02-11 08:32:51 -07:00
parent fc74e61d9b
commit cd53947a79
25 changed files with 47 additions and 47 deletions

View File

@ -43,7 +43,7 @@ describe "permissions index" do
PermissionsIndex.visit(@account)
end
it "updates the role to the new name after editing" do
it "updates the role to the new name after editing", :xbrowser do
PermissionsIndex.edit_role(@custom_student_role, "A Better Kitty")
expect{PermissionsIndex.role_name(@custom_student_role).text}.to become("A Better Kitty")
expect{PermissionsIndex.edit_tray_header.text}.to become("Edit A Better Kitty")
@ -92,7 +92,7 @@ describe "permissions index" do
user_session(@admin)
end
it "permissions enables on grid" do
it "permissions enables on grid", :xbrowser do
PermissionsIndex.visit(@account)
permission_name = "manage_outcomes"
PermissionsIndex.change_permission(permission_name, ta_role.id, "enable")
@ -103,7 +103,7 @@ describe "permissions index" do
expect(r.locked).to eq(false)
end
it "permissions disables on grid" do
it "permissions disables on grid", :xbrowser do
PermissionsIndex.visit(@account)
permission_name = "read_announcements"
PermissionsIndex.change_permission(permission_name, student_role.id, "disable")
@ -136,7 +136,7 @@ describe "permissions index" do
expect(r.locked).to eq(true)
end
it "permissions default on grid works" do
it "permissions default on grid works", :xbrowser do
permission_name = "read_announcements"
create_role_override(permission_name, student_role, @account,
:enabled => false, :locked => false)

View File

@ -48,7 +48,7 @@ describe "assignments" do
get "/courses/#{@course.id}/assignments/#{@assignment.id}/edit"
end
it "can save and publish an assignment", priority: "1", test_id: 193784 do
it "can save and publish an assignment", :xbrowser, priority: "1", test_id: 193784 do
create_assignment false
expect(f("#assignment-draft-state")).to be_displayed
@ -122,7 +122,7 @@ describe "assignments" do
expect(f('#assignment_description')).to have_value('<p>Testing HTML- RCE Toggle</p>')
end
it "should edit an assignment", priority: "1", test_id: 56012 do
it "should edit an assignment", :xbrowser, priority: "1", test_id: 56012 do
assignment_name = 'first test assignment'
due_date = Time.now.utc + 2.days
group = @course.assignment_groups.create!(:name => "default")
@ -168,7 +168,7 @@ describe "assignments" do
expect(driver.title).to include(assignment_name + ' edit')
end
it "should create an assignment using main add button", priority: "1", test_id: 132582 do
it "should create an assignment using main add button", :xbrowser, priority: "1", test_id: 132582 do
assignment_name = 'first assignment'
# freeze for a certain time, so we don't get unexpected ui complications
time = DateTime.new(Time.now.year,1,7,2,13)

View File

@ -41,7 +41,7 @@ describe "submissions" do
user_session(@student)
end
it "should let a student submit a text entry", priority: "1", test_id: 56015 do
it "should let a student submit a text entry", :xbrowser, priority: "1", test_id: 56015 do
@assignment.update_attributes(submission_types: "online_text_entry")
get "/courses/#{@course.id}/assignments/#{@assignment.id}"
@ -104,7 +104,7 @@ describe "submissions" do
driver.switch_to.alert.accept
end
it "should allow you to submit a file", priority: "1", test_id: 237022 do
it "should allow you to submit a file", :xbrowser, priority: "1", test_id: 237022 do
@assignment.submission_types = 'online_upload'
@assignment.save!
filename, fullpath, data = get_file("testfile1.txt")
@ -354,7 +354,7 @@ describe "submissions" do
driver.execute_script("$('.folder_item').addClass('folder_item_hover')")
end
it "should allow uploaded files to be used for submission", priority: "1", test_id: 237030 do
it "should allow uploaded files to be used for submission", :xbrowser, priority: "1", test_id: 237030 do
local_storage!
add_file(fixture_file_upload('files/html-editing-test.html', 'text/html'),

View File

@ -57,7 +57,7 @@ describe "calendar2" do
expect(all_agenda_items.length).to eq 1
end
it "should display agenda events" do
it "should display agenda events", :xbrowser do
load_agenda_view
expect(fj('.agenda-wrapper:visible')).to be_present
end

View File

@ -37,7 +37,7 @@ describe "calendar2" do
context "week view" do
it "should navigate to week view when week button is clicked", priority: "2", test_id: 766945 do
it "should navigate to week view when week button is clicked", :xbrowser, priority: "2", test_id: 766945 do
load_week_view
expect(fj('.fc-agendaWeek-view:visible')).to be_present
end

View File

@ -53,7 +53,7 @@ describe "context modules" do
wait_for_ajaximations
end
it "should show all module items", priority: "1", test_id: 126743 do
it "should show all module items", :xbrowser, priority: "1", test_id: 126743 do
module_with_two_items
f(".expand_module_link").click
wait_for_animations
@ -326,7 +326,7 @@ describe "context modules" do
expect(page.reload).to be_published
end
it "publishes a newly created item" do
it "publishes a newly created item", :xbrowser do
@course.context_modules.create!(name: "Content Page")
get "/courses/#{@course.id}/modules"
add_new_module_item('#wiki_pages_select', 'Page', '[ New Page ]', 'New Page Title')

View File

@ -41,7 +41,7 @@ describe "conversations new" do
expect(errors[1].text).to include('Required field')
end
it "should start a group conversation when there is only one recipient", priority: "2", test_id: 201499 do
it "should start a group conversation when there is only one recipient", :xbrowser, priority: "2", test_id: 201499 do
skip_if_chrome('fragile in chrome')
conversations
compose course: @course, to: [@s1], subject: 'single recipient', body: 'hallo!'
@ -50,7 +50,7 @@ describe "conversations new" do
expect(c.private?).to be_falsey
end
it "should start a group conversation when there is more than one recipient", priority: "2", test_id: 201500 do
it "should start a group conversation when there is more than one recipient", :xbrowser, priority: "2", test_id: 201500 do
skip_if_chrome('fragile in chrome')
conversations
compose course: @course, to: [@s1, @s2], subject: 'multiple recipients', body: 'hallo!'

View File

@ -55,7 +55,7 @@ describe "conversations new" do
expect(f('.message_subject_ro').text).to eq @convo.subject
end
it "should add new messages to the conversation", priority: "1", test_id: 197537 do
it "should add new messages to the conversation", :xbrowser, priority: "1", test_id: 197537 do
initial_message_count = @convo.conversation_messages.length
go_to_inbox_and_select_message
f('#reply-btn').click

View File

@ -155,7 +155,7 @@ describe "course settings" do
expect(admin_cog('#nav_edit_tab_id_0')).to be_falsey
end
it "should change course details" do
it "should change course details", :xbrowser do
course_name = 'new course name'
course_code = 'new course-101'
locale_text = 'English (US)'

View File

@ -51,7 +51,7 @@ describe "dashboard" do
get '/'
end
it "displays notification on todo list sidebar and course dashcard" do
it "displays notification on todo list sidebar and course dashcard", :xbrowser do
# announcement icon is displayed
expect(todosidebar_item_list).to contain_css(".ToDoSidebarItem [name='IconAnnouncement']")
# announcement title link is displyed
@ -118,7 +118,7 @@ describe "dashboard" do
get "/courses/#{@course.id}"
end
it "displays notification on course home page feed and todolist sidebar" do
it "displays notification on course home page feed and todolist sidebar", :xbrowser do
# announcement icon is displayed
expect(todosidebar_item_list).to contain_css(".ToDoSidebarItem [name='IconAnnouncement']")
# announcement title link is displyed

View File

@ -48,7 +48,7 @@ describe "discussions" do
user_session(teacher)
end
it "should add an attachment to a new topic", priority: "1", test_id: 150466 do
it "should add an attachment to a new topic", :xbrowser, priority: "1", test_id: 150466 do
topic_title = 'new topic with file'
get url
wait_for_tiny(f('textarea[name=message]'))
@ -182,7 +182,7 @@ describe "discussions" do
expect(f('.discussion-availability').text).to include("Not available until #{unlock_text_index_page}")
end
it "should allow a student to create a discussion", priority: "1", test_id: 150471 do
it "should allow a student to create a discussion", :xbrowser, priority: "1", test_id: 150471 do
get url
wait_for_tiny(f('textarea[name=message]'))
replace_content(f('input[name=title]'), "Student Discussion")

View File

@ -38,7 +38,7 @@ describe "threaded discussions" do
expect(f('.discussion-title').text).to eq @topic_title
end
it "should reply to the threaded discussion", priority: "2", test_id: 222519 do
it "should reply to the threaded discussion", :xbrowser, priority: "2", test_id: 222519 do
entry_text = 'new entry'
get "/courses/#{@course.id}/discussion_topics/#{@topic.id}"

View File

@ -76,7 +76,7 @@ describe 'Grade Detail Tray:' do
expect(late_policy_status).to eq 'none'
end
it 'grade input is saved', priority: "1", test_id: 3369723 do
it 'grade input is saved', :xbrowser, priority: "1", test_id: 3369723 do
Gradezilla::Cells.open_tray(@course.students.second, @a3)
Gradezilla::GradeDetailTray.edit_grade(7)

View File

@ -40,7 +40,7 @@ describe "Gradezilla editing grades" do
clear_local_storage
end
it "updates a graded quiz and have the points carry over to the quiz attempts page", priority: "1", test_id: 220310 do
it "updates a graded quiz and have the points carry over to the quiz attempts page", :xbrowser, priority: "1", test_id: 220310 do
points = 50
q = factory_with_protected_attributes(@course.quizzes, title: "new quiz", points_possible: points, quiz_type: 'assignment', workflow_state: 'available')
q.save!
@ -63,7 +63,7 @@ describe "Gradezilla editing grades" do
expect(final_score_for_row(1)).to eq @student_2_total_ignoring_ungraded
end
it "changes grades and validate course total is correct", priority: "1", test_id: 220312 do
it "changes grades and validate course total is correct", :xbrowser, priority: "1", test_id: 220312 do
expected_edited_total = "33.33%"
Gradezilla.visit(@course)

View File

@ -332,7 +332,7 @@ describe "groups" do
describe "pages page" do
it_behaves_like 'pages_page', :student
it "should allow group members to create a page", priority: "1", test_id: 273611 do
it "should allow group members to create a page", :xbrowser, priority: "1", test_id: 273611 do
get pages_page
manually_create_wiki_page('yo','this be a page')
end

View File

@ -253,7 +253,7 @@ describe "groups" do
describe "pages page" do
it_behaves_like 'pages_page', :teacher
it "should allow teachers to create a page", priority: "1", test_id: 289993 do
it "should allow teachers to create a page", :xbrowser, priority: "1", test_id: 289993 do
get pages_page
manually_create_wiki_page('stuff','it happens')
end

View File

@ -76,7 +76,7 @@ shared_examples_for "settings basic tests" do |account_type|
get account_settings_url
end
it "should change the account name", priority: "1", test_id: pick_test_id(account_type, sub_account: 249782, root_account: 251032) do
it "should change the account name", :xbrowser, priority: "1", test_id: pick_test_id(account_type, sub_account: 249782, root_account: 251032) do
new_account_name = 'new default account name'
replace_content(f("#account_name"), new_account_name)
click_submit

View File

@ -35,11 +35,11 @@ describe "better_file_browsing, folders" do
expect(f("form.ef-edit-name-form")).to be_displayed
end
it "should create a new folder", priority: "1", test_id: 133121 do
it "should create a new folder", :xbrowser, priority: "1", test_id: 133121 do
expect(fln("new test folder")).to be_present
end
it "should display all cog icon options", priority: "1", test_id: 133124 do
it "should display all cog icon options", :xbrowser, priority: "1", test_id: 133124 do
create_new_folder
ff('.al-trigger')[0].click
expect(fln("Download")).to be_displayed
@ -129,7 +129,7 @@ describe "better_file_browsing, folders" do
expect(new_folder.text).to match(/New Folder/)
end
it "should handle duplicate folder names", priority: "1", test_id: 133130 do
it "should handle duplicate folder names", :xbrowser, priority: "1", test_id: 133130 do
create_new_folder
add_folder("New Folder")
expect(all_files_folders.last.text).to match(/New Folder 2/)

View File

@ -35,13 +35,13 @@ describe "better_file_browsing" do
user_session @teacher
end
it "should display new files UI", priority: "1", test_id: 133092 do
it "should display new files UI", :xbrowser, priority: "1", test_id: 133092 do
get "/courses/#{@course.id}/files"
expect(f('.btn-upload')).to be_displayed
expect(all_files_folders.count).to eq 1
end
it "should load correct column values on uploaded file", priority: "1", test_id: 133129 do
it "should load correct column values on uploaded file", :xbrowser, priority: "1", test_id: 133129 do
get "/courses/#{@course.id}/files"
time_current = @course.attachments.first.updated_at.strftime("%l:%M%P").strip
expect(ff('.ef-name-col__text')[0]).to include_text 'example.pdf'
@ -186,7 +186,7 @@ describe "better_file_browsing" do
get "/courses/#{@course.id}/files"
end
it "should search for a file", priority: "2", test_id: 220355 do
it "should search for a file", :xbrowser, priority: "2", test_id: 220355 do
expect(all_files_folders).to have_size 3
f("input[type='search']").send_keys "b_fi", :return
expect(all_files_folders).to have_size 1

View File

@ -44,7 +44,7 @@ describe "better_file_browsing" do
end
end
it "should search for a file", priority: "1", test_id: 220355 do
it "should search for a file", :xbrowser, priority: "1", test_id: 220355 do
get "/courses/#{@course.id}/files"
f("input[type='search']").send_keys "b_fi", :return
expect(all_files_folders).to have_size 1

View File

@ -43,7 +43,7 @@ describe "profile communication settings" do
fj("td.comm-event-option[data-category='#{category}'][data-channelid=#{channel_id}]")
end
it "should render" do
it "should render", :xbrowser do
get "/profile/communication"
# Page title should match expected
expect(driver.execute_script("return document.title")).to eq 'Notification Preferences'
@ -53,7 +53,7 @@ describe "profile communication settings" do
expect(f('#content > h1').text).to eq 'Notification Preferences'
end
it "should display the users email address as channel" do
it "should display the users email address as channel", :xbrowser do
get "/profile/communication"
wait_for_ajaximations
expect(fj('th.comm-channel:first')).to include_text('Email Address')
@ -101,7 +101,7 @@ describe "profile communication settings" do
expect(buttons[1]).to have_attribute('value', 'never')
end
it "should load the initial state of a user-pref checkbox" do
it "should load the initial state of a user-pref checkbox", :xbrowser do
# set the user's initial user preference and verify checked or unchecked
@user.preferences[:send_scores_in_emails] = false
@user.save!
@ -110,7 +110,7 @@ describe "profile communication settings" do
expect(is_checked('.user-pref-check[name=send_scores_in_emails]')).to be_falsey
end
it "should save a user-pref checkbox change" do
it "should save a user-pref checkbox change", :xbrowser do
# Enable the setting to be changed first...
Account.default.settings[:allow_sending_scores_in_emails] = true
Account.default.save!

View File

@ -109,7 +109,7 @@ describe "profile" do
f('#right-side .add_email_link').click
end
it "should add a new email address on profile settings page" do
it "should add a new email address on profile settings page", :xbrowser do
@user.account.enable_feature!(:international_sms)
notification_model(:category => 'Grading')
notification_policy_model(:notification_id => @notification.id)

View File

@ -41,7 +41,7 @@ describe 'creating a quiz' do
open_quiz_edit_form
end
it 'sets availability dates and due dates for each section', priority: 1, test_id: 140670 do
it 'sets availability dates and due dates for each section', :xbrowser, priority: 1, test_id: 140670 do
assign_quiz_to_no_one
# assign to default section
@ -94,7 +94,7 @@ describe 'creating a quiz' do
'must have a student or section selected'
end
it 'saves and publishes a new quiz', priority: "1", test_id: 193785 do
it 'saves and publishes a new quiz', :xbrowser, priority: "1", test_id: 193785 do
@quiz = course_quiz
open_quiz_edit_form
@ -119,7 +119,7 @@ describe 'creating a quiz' do
end
end
it 'creates a quiz directly from the index page', priority: "1", test_id: 210055 do
it 'creates a quiz directly from the index page', :xbrowser, priority: "1", test_id: 210055 do
expect do
create_new_quiz
end.to change{ Quizzes::Quiz.count }.by(1)

View File

@ -60,7 +60,7 @@ describe "quiz taking" do
expect(links[2]).to be_displayed
end
it "should allow to take the quiz as long as there are attempts left", priority: "1", test_id: 140606 do
it "should allow to take the quiz as long as there are attempts left", :xbrowser, priority: "1", test_id: 140606 do
@quiz.allowed_attempts = 2
@quiz.save!
get "/courses/#{@course.id}/quizzes/#{@quiz.id}"

View File

@ -50,13 +50,13 @@ describe "course syllabus" do
wait_for_ajaximations
end
it "should confirm existing assignments and dates are correct", priority:"1", test_id: 237016 do
it "should confirm existing assignments and dates are correct", :xbrowser, priority:"1", test_id: 237016 do
assignment_details = ff('td.name')
expect(assignment_details[0].text).to eq @assignment_1.title
expect(assignment_details[1].text).to eq @assignment_2.title
end
it "should edit the description", priority:"1", test_id: 237017 do
it "should edit the description", :xbrowser, priority:"1", test_id: 237017 do
new_description = "new syllabus description"
f('.edit_syllabus_link').click
# check that the wiki sidebar is visible