ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add helpful gergich suggestion about ERB warning 

Change-Id: Id158bac164b3fdb989ed27faef085f4600ccabf6
Reviewed-on: https://gerrit.instructure.com/88425
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
QA-Review: Landon Wilkins <lwilkins@instructure.com>
Tested-by: Jenkins
This commit is contained in:
Ryan Shaw 2016-08-22 14:03:32 -06:00
parent 876a5158b1
commit cd03c7f8b6
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
script/tatl_tael
View File

@ -51,7 +51,14 @@ errors = []
linter.ban_new_erb do
errors << "Your commit includes new ERB files,"\
" which has been a no-no in Canvas since 2011."\
" All new UI should be built in React on top of documented APIs"
" All new UI should be built in React on top of documented APIs.\n"\
"Maybe try doing something like this in your controller instead:\n\n"\
" @page_title = t('Your Page Title')\n"\
" @body_classes << 'whatever-classes you-want-to-add-to-body'\n"\
" js_bundle :your_js_bundle\n"\
" css_bundle :any_css_bundles_you_want\n"\
" js_env({whatever: 'you need to put in window.ENV'})\n"\
" render :text => "".html_safe, :layout => true"\
end
linter.ensure_public_js_specs do