ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix issue on SVGWithTextPlaceholder.test.js 

flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I072a65e2e94a6f84a9b3bfff969831c9188a643b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277198
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
This commit is contained in:
Omar Gerardo Soto-Fortuño 2021-11-02 13:31:53 -04:00 committed by Omar Soto-Fortuño
parent fc439c30bf
commit cb8f2da2d2
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
jest/jest-setup.js
View File

@ -110,7 +110,6 @@ const ignoredErrors = [
/The prop `rootId` is marked as required in `GroupSelectionDrillDown`/,
/The prop `rubric.id` is marked as required in `RubricTab`/,
/The prop `screenReaderLabel` is marked as required in `IconButton`/,
/The prop `text` is marked as required in `(SVGWithTextPlaceholder|TextPlaceholder)`/,
/The prop `value` is marked as required in `CanvasSelectOption`/,
/Unexpected keys "searchPermissions", "filterRoles", "tabChanged", "setAndOpenAddTray" found in preloadedState argument passed to createStore/,
/Use the `defaultValue` or `value` props on <select> instead of setting `selected` on <option>/,

4
ui/features/assignments_show_student/react/__tests__/SVGWithTextPlaceholder.test.js
View File

@ -46,9 +46,9 @@ describe('SVGWithTextPlaceholder', () => {
expect(imgContainer).toHaveLength(1)
})
it('renders if null is provided to the text prop', () => {
it('renders if empty is provided to the text prop', () => {
ReactDOM.render(
<SVGWithTextPlaceholder url="www.test.com" />,
<SVGWithTextPlaceholder url="www.test.com" text="" />,
document.getElementById('fixtures')
)
const imgContainer = $("img[src$='www.test.com']")