ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

provide correct allSubmissions prop types 

flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: I96e6ca637f78baf5e54bede3bb11541074fdac39
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274436
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
This commit is contained in:
Davis Hyer 2021-09-24 15:42:19 -06:00
parent d289fdb87a
commit c8f3e1ce0f
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
jest/jest-setup.js
View File

@ -78,7 +78,6 @@ const ignoredErrors = [
/The 'screenReaderOnly' prop must be used in conjunction with 'liveRegion'/,
/The above error occurred in the <.*> component/,
/The prop `activeMailbox` is marked as required in `MailboxSelectionDropdown`/,
/The prop `allSubmissions\[0\]._id` is marked as required in `Header`/,
/The prop `app.courses\[0\].id` is marked as required in `K5AppLink`/,
/The prop `apps\[0\].courses\[0\].id` is marked as required in `AppsList`/,
/The prop `avatarName` is marked as required in `UserLink`/,

6
ui/features/assignments_show_student/react/components/__tests__/Header.test.js
View File

@ -302,7 +302,7 @@ it('renders the attempt select', async () => {
it('does not render the attempt select if there is no submission', async () => {
const props = await mockAssignmentAndSubmission({Submission: null})
props.allSubmissions = [{id: 1}]
props.allSubmissions = [{id: '1', _id: '1'}]
const {queryByTestId} = render(<Header {...props} />)
expect(queryByTestId('attemptSelect')).not.toBeInTheDocument()
})
@ -333,7 +333,7 @@ describe('submission workflow tracker', () => {
it('is not rendered when no submission object is present', async () => {
const props = await mockAssignmentAndSubmission({Submission: null})
props.allSubmissions = [{id: 1}]
props.allSubmissions = [{id: '1', _id: '1'}]
const {queryByTestId} = render(<Header {...props} />)
expect(queryByTestId('submission-workflow-tracker')).not.toBeInTheDocument()
})
@ -433,7 +433,7 @@ describe('Add Comment/View Feedback button', () => {
it('does not render when no submission is present', async () => {
const props = await mockAssignmentAndSubmission({Submission: null})
props.allSubmissions = [{id: 1}]
props.allSubmissions = [{id: '1', _id: '1'}]
const {queryByText} = render(<Header {...props} />)
expect(queryByText('View Feedback')).not.toBeInTheDocument()
expect(queryByText('Add Comment')).not.toBeInTheDocument()