diff --git a/gems/plugins/qti_exporter/lib/qti/assessment_item_converter.rb b/gems/plugins/qti_exporter/lib/qti/assessment_item_converter.rb index 9c3d454adec..23a838dff18 100644 --- a/gems/plugins/qti_exporter/lib/qti/assessment_item_converter.rb +++ b/gems/plugins/qti_exporter/lib/qti/assessment_item_converter.rb @@ -143,6 +143,7 @@ class AssessmentItemConverter elsif !%w(text_only_question file_upload_question).include?(@migration_type) self.parse_question_data else + self.get_feedback if @migration_type == 'file_upload_question' @question[:question_type] ||= @migration_type end rescue => e diff --git a/gems/plugins/qti_exporter/spec_canvas/lib/qti/angel_propietery_questions_spec.rb b/gems/plugins/qti_exporter/spec_canvas/lib/qti/angel_propietery_questions_spec.rb index 02f38390ff1..d9d41700175 100644 --- a/gems/plugins/qti_exporter/spec_canvas/lib/qti/angel_propietery_questions_spec.rb +++ b/gems/plugins/qti_exporter/spec_canvas/lib/qti/angel_propietery_questions_spec.rb @@ -255,7 +255,7 @@ module AngelPropExpected :answers=>[], :correct_comments=>"", :question_name=>"offline item?", - :incorrect_comments=>"", + :incorrect_comments=>"asdf", :migration_id=>nil, :points_possible=>1, :question_type=>"file_upload_question", diff --git a/lib/cc/qti/qti_items.rb b/lib/cc/qti/qti_items.rb index 9b0fd91d495..f355a2f5580 100644 --- a/lib/cc/qti/qti_items.rb +++ b/lib/cc/qti/qti_items.rb @@ -129,7 +129,7 @@ module CC presentation_options(pres_node, question) end # presentation - unless ['text_only_question', 'file_upload_question'].include?(question['question_type']) + if question['question_type'] != 'text_only_question' item_node.resprocessing do |res_node| res_node.outcomes do |out_node| out_node.decvar( diff --git a/spec/models/content_migration/course_copy_quizzes_spec.rb b/spec/models/content_migration/course_copy_quizzes_spec.rb index 6282e7714c5..81472dd86ba 100644 --- a/spec/models/content_migration/course_copy_quizzes_spec.rb +++ b/spec/models/content_migration/course_copy_quizzes_spec.rb @@ -1107,6 +1107,19 @@ equation: "q") + data = {"question_type" => "file_upload_question", 'name' => 'test question', "neutral_comments_html" => "comment", "neutral_comments" => "comment"} + qq = q.quiz_questions.create!(:question_data => data) + + run_course_copy + + q2 = @copy_to.quizzes.first + qq2 = q2.quiz_questions.first + expect(qq2.question_data['neutral_comments_html']).to eq data['neutral_comments_html'] + expect(qq2.question_data['neutral_comments']).to eq data['neutral_comments'] + end + describe "assignment overrides" do before :once do @quiz_plain = @copy_from.quizzes.create!(title: 'my quiz')