remove developer_key_support_includes feature flag

refs INTEROP-8917
flag=developer_key_support_includes

test plan:
- specs pass

Change-Id: Ib2c9a9a554b6d088a1088424acd73f64ad4afcbe
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/361558
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Alexis Nast <alexis.nast@instructure.com>

app/controllers/developer_keys_controller.rb

@@ -39,8 +39,7 @@ class DeveloperKeysController < ApplicationController
               TokenScopes::LTI_SCOPES.except(TokenScopes::LTI_PNS_SCOPE)
             end
           ),
-          validLtiPlacements: Lti::ResourcePlacement.public_placements(@domain_root_account),
-          includesFeatureFlagEnabled: Account.site_admin.feature_enabled?(:developer_key_support_includes)
+          validLtiPlacements: Lti::ResourcePlacement.public_placements(@domain_root_account)
         )
 
         render :index

config/feature_flags/interop_release_flags.yml

@@ -59,11 +59,6 @@ deep_linking_use_window_parent:
       state: allowed_on
     ci:
       state: on
-developer_key_support_includes:
-  state: hidden
-  display_name: Developer Key Include Parameter Support
-  description: Provides a flag on the Developer Key to support Include Parameters on API requests
-  applies_to: SiteAdmin
 disable_graphql_authentication:
   state: hidden
   display_name: Disable authentication for GraphQL

spec/controllers/developer_keys_controller_spec.rb

@@ -105,11 +105,6 @@ describe DeveloperKeysController do
           expect(assigns.dig(:js_env, :validLtiPlacements)).to match_array Lti::ResourcePlacement.public_placements(Account.site_admin)
         end
 
-        it 'includes the "includes parameter" release flag' do
-          get "index", params: { account_id: Account.site_admin.id }
-          expect(assigns.dig(:js_env, :includesFeatureFlagEnabled)).to be false
-        end
-
         describe "js bundles" do
           render_views
 

ui/features/developer_keys_v2/react/Scopes.jsx

@@ -131,7 +131,7 @@ export default class Scopes extends React.Component {
             </Grid.Col>
           ) : null}
         </Grid.Row>
-        {this.props.requireScopes && ENV.includesFeatureFlagEnabled && (
+        {this.props.requireScopes && (
           <Grid.Row>
             <Grid.Col>
               <Checkbox

ui/features/developer_keys_v2/react/__tests__/Scopes.test.jsx

@@ -72,10 +72,6 @@ describe('Scopes', () => {
     let wrapper
 
     beforeEach(() => {
-      window.ENV = {
-        includesFeatureFlagEnabled: true,
-      }
-
       const {wrapper: innerWrapper} = renderScopes()
 
       wrapper = innerWrapper

ui/shared/global/env/EnvDeveloperKeys.d.ts

@@ -25,5 +25,4 @@ export interface EnvDeveloperKeys {
 
   accountEndpoint: string
   enableTestClusterChecks: boolean
-  includesFeatureFlagEnabled: boolean
 }