ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

provide correct options prop type 

flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: Ieefcedb7203d7d3dd291b69be43e1d1ec1a11656
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274051
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
This commit is contained in:
Davis Hyer 2021-09-21 14:10:11 -06:00
parent 5ebdf0a79d
commit b7086d4ce6
2 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
jest/jest-setup.js
View File

@ -75,7 +75,6 @@ const ignoredErrors = [
/Invalid prop `id` of type `number` supplied to `Option`/,
/Invalid prop `label` of type `function` supplied to `StepItem`/,
/Invalid prop `open` of type `number` supplied to `(Modal|ModalSpinner)`/,
/Invalid prop `options.favoriteCourses\[0\]._id` of type `number` supplied to `CourseSelect`/,
/Invalid prop `outcomeContextId` of type `number` supplied to `ManageOutcomeItem`/,
/Invalid prop `outcomesGroup.contextId` of type `number` supplied to `FindOutcomesView`, expected `string`/,
/Invalid prop `returnFocusTo` of type `DeprecatedComponent` supplied to `(CourseHomeDialog|HomePagePromptContainer)`/,

22
ui/features/inbox/react/components/CourseSelect/__tests__/CourseSelect.test.js
View File

@ -26,23 +26,23 @@ const createProps = overrides => {
mainPage: true,
options: {
favoriteCourses: [
{_id: 1, contextName: 'Charms', assetString: 'course_1'},
{_id: 2, contextName: 'Transfiguration', assetString: 'course_2'}
{_id: '1', contextName: 'Charms', assetString: 'course_1'},
{_id: '2', contextName: 'Transfiguration', assetString: 'course_2'}
],
moreCourses: [
{_id: 3, contextName: 'Potions', assetString: 'course_3'},
{_id: 4, contextName: 'History of Magic', assetString: 'course_4'},
{_id: 5, contextName: 'Herbology', assetString: 'course_5'},
{_id: 6, contextName: 'Defense Against the Dark Arts', assetString: 'course_6'}
{_id: '3', contextName: 'Potions', assetString: 'course_3'},
{_id: '4', contextName: 'History of Magic', assetString: 'course_4'},
{_id: '5', contextName: 'Herbology', assetString: 'course_5'},
{_id: '6', contextName: 'Defense Against the Dark Arts', assetString: 'course_6'}
],
concludedCourses: [
{_id: 7, contextName: 'Muggle Studies', assetString: 'course_7'},
{_id: 8, contextName: 'Astronomy', assetString: 'course_8'}
{_id: '7', contextName: 'Muggle Studies', assetString: 'course_7'},
{_id: '8', contextName: 'Astronomy', assetString: 'course_8'}
],
groups: [
{_id: 1, contextName: 'Gryffindor Bros', assetString: 'group_1'},
{_id: 2, contextName: 'Quidditch', assetString: 'group_2'},
{_id: 3, contextName: "Dumbledore's Army", assetString: 'group_3'}
{_id: '1', contextName: 'Gryffindor Bros', assetString: 'group_1'},
{_id: '2', contextName: 'Quidditch', assetString: 'group_2'},
{_id: '3', contextName: "Dumbledore's Army", assetString: 'group_3'}
]
},
onCourseFilterSelect: () => {},