RCE: Enable noImplicitAny for typescript

- Matches recent changes to canvas core tsconfig - Enable noImplicitAny in packages/canvas-rce/package.json - Remove canvas-rce pre-commit hook - Add @ts-nocheck to files that have errors due to noImplicitAny test plan: - existing tests pass flag=none Change-Id: I6540a42ba5089deaab851f113e5f665dcff2851e Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317214 Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com> QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com> Product-Review: Yona Appletree <yona.appletree@instructure.com> Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2023-04-27 16:32:04 -07:00 · 2023-04-27 16:32:04 -07:00 · ac34b669e1
parent ce864bb5ff
commit ac34b669e1
33 changed files with 32 additions and 45 deletions
--- a/hooks/pre-commit
+++ b/hooks/pre-commit
@ -25,21 +25,6 @@ if [ $(pwd -P) = $CANVAS ]; then
      echo "You should run yarn locally or check to make sure docker is running."
  fi

-  # per-package pre-commit hooks
-  git diff --cached --name-only | grep -E -o '^(packages/[^/]+)' | sort | uniq | while read -r PACKAGE; do
-    # check if CHANGED_PACKAGES/pre-commit-hook.sh exists and run it
-    if [ -f "$PACKAGE/pre-commit-hook.sh" ]; then
-      echo "Running pre-commit hook for $PACKAGE"
-
-      (cd "$PACKAGE" && "./pre-commit-hook.sh")
-
-      if [ $? -ne 0 ]; then
-        echo "Pre-commit hook for $PACKAGE failed, aborting commit"
-        exit 1
-      fi
-    fi
-  done || exit 1
-
  if git diff --cached --name-only | grep -q Gemfile.lock; then
    echo "Checking lockfiles..."
    script/sync_lockfiles.rb
--- a/packages/canvas-rce/.eslintrc
+++ b/packages/canvas-rce/.eslintrc
@ -38,7 +38,7 @@

        // Prefer @typescript-eslint/no-empty-function over no-empty-function
        "no-empty-function": "off",
-        "@typescript-eslint/no-empty-function": "error"
+        "@typescript-eslint/no-empty-function": "warn"
      }
    }
  ]
--- a/packages/canvas-rce/pre-commit-hook.sh
+++ b/packages/canvas-rce/pre-commit-hook.sh
@ -1,26 +0,0 @@
-#!/usr/bin/env bash
-
-#
-# This file is executed automatically by /hooks/pre-commit if package files are changed
-#
-
-cd "$(dirname "$0")" || exit 1
-PACKAGE_DIR=$(git rev-parse --show-prefix)
-
-# Check typescript
-if git diff --cached --name-only . | grep -qE '\.(ts|tsx)$'; then
-  if [ -f node_modules/.bin/tsc ]; then
-    echo "Checking $PACKAGE_DIR TypeScript..."
-    node_modules/.bin/tsc
-  else
-    echo 'Trying to run tsc inside Docker. If you want things quicker yarn install locally.'
-    docker-compose run --rm web node_modules/.bin/tsc
-  fi
-
-  if [ $? -ne 0 ]; then
-    echo "TypeScript checking failed in $PACKAGE_DIR, aborting commit"
-    exit 1
-  fi
-fi
-
-# Note that eslint is handled by the root hook, so we don't need to do that here
--- a/packages/canvas-rce/src/rce/tests/userOS.test.ts
+++ b/packages/canvas-rce/src/rce/tests/userOS.test.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2022 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure-ui-icons/plugin.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure-ui-icons/plugin.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2019 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_condensed_buttons/ui/list-button.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_condensed_buttons/ui/list-button.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2019 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_equation/plugin.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_equation/plugin.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2018 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_external_tools/plugin.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_external_tools/plugin.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2018 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_fullscreen/plugin.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_fullscreen/plugin.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2022 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_icon_maker/plugin.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_icon_maker/plugin.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2021 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_icon_maker/utils/IconMakerClose.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_icon_maker/utils/IconMakerClose.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2022 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_icon_maker/utils/tests/IconMakerFormHasChanges.test.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_icon_maker/utils/tests/IconMakerFormHasChanges.test.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2022 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_icon_maker/utils/tests/addIconMakerAttributes.test.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_icon_maker/utils/tests/addIconMakerAttributes.test.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2022 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_icon_maker/utils/addIconMakerAttributes.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_icon_maker/utils/addIconMakerAttributes.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2022 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_image/plugin.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_image/plugin.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2018 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_links/plugin.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_links/plugin.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2019 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_paste/plugin.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_paste/plugin.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2022 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/ExternalToolsEnv.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/ExternalToolsEnv.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2023 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/RceToolWrapper.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/RceToolWrapper.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2023 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/tests/RceToolWrapper.test.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/tests/RceToolWrapper.test.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2021 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/components/ExternalToolDialog/ExternalToolDialogModal.tsx
+++ b/packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/components/ExternalToolDialog/ExternalToolDialogModal.tsx
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2019 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/components/ExternalToolSelectionDialog/ExternalToolSelectionDialog.tsx
+++ b/packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/components/ExternalToolSelectionDialog/ExternalToolSelectionDialog.tsx
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2019 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/components/tests/ExternalToolDialog.test.tsx
+++ b/packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/components/tests/ExternalToolDialog.test.tsx
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2019 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/jquery/jquery.dropdownList.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/jquery/jquery.dropdownList.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2011 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/lti13-content-items/RceLti13ContentItem.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/lti13-content-items/RceLti13ContentItem.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2018 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/lti13-content-items/processEditorContentItems.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/lti13-content-items/processEditorContentItems.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2018 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_record/plugin.ts
+++ b/packages/canvas-rce/src/rce/plugins/instructure_record/plugin.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2018 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/instructure_wordcount/components/WordCountModal.tsx
+++ b/packages/canvas-rce/src/rce/plugins/instructure_wordcount/components/WordCountModal.tsx
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2022 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/rce/plugins/shared/Upload/UploadFile.tsx
+++ b/packages/canvas-rce/src/rce/plugins/shared/Upload/UploadFile.tsx
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2019 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/util/tests/deepMockProxy.test.ts
+++ b/packages/canvas-rce/src/util/tests/deepMockProxy.test.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2023 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/src/util/tests/deepMockProxy.ts
+++ b/packages/canvas-rce/src/util/tests/deepMockProxy.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2023 - present Instructure, Inc.
 *
@ -165,5 +166,4 @@ export type DeepMocked<T> = {
    : T[P] extends object | null | undefined
    ? DeepMocked<T[P]>
    : T[P]
-} &
-  T & {mockClear(): void}
+} & T & {mockClear(): void}
--- a/packages/canvas-rce/src/util/instui-icon-helper.ts
+++ b/packages/canvas-rce/src/util/instui-icon-helper.ts
@ -1,3 +1,4 @@
+// @ts-nocheck
 /*
 * Copyright (C) 2023 - present Instructure, Inc.
 *
--- a/packages/canvas-rce/tsconfig.json
+++ b/packages/canvas-rce/tsconfig.json
@ -13,7 +13,7 @@
    "skipLibCheck": true, // don't do type-checking on dependencies' internal types for improved performance
    "strict": true, // enables a bunch of strict mode family options. See https://www.typescriptlang.org/tsconfig#strict
    "target": "ES2020", // support the most modern JS features (let babel handle transpilation)
-    "noImplicitAny": false, // temporarily allows un-typed variables (and imports) to be automatically defined as "any"
+    "noImplicitAny": true,
    "experimentalDecorators": true,
    "outDir": "es"
  },