ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

optimize object allocation in RoleOverride 

RoleOverride.permission_for was accounting for 25% of all objects
allocated when loading my dashboard, this small tweaks drops it to 4%

Change-Id: Id837e0243c5450c7e3b206b70375df2c97e742e3
Reviewed-on: https://gerrit.instructure.com/2652
Reviewed-by: Zach Wily <zach@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
This commit is contained in:
Brian Palmer 2011-03-15 10:06:50 -06:00
parent 204d916a4e
commit ac2c7ef686
1 changed files with 21 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
app/models/role_override.rb
View File

@ -34,17 +34,19 @@ class RoleOverride < ActiveRecord::Base
res
end
def self.enrollment_types
ENROLLMENT_TYPES =
[
{:name => 'StudentEnrollment', :label => 'Student'},
{:name => 'TaEnrollment', :label => 'TA'},
{:name => 'TeacherEnrollment', :label => 'Teacher'},
{:name => 'DesignerEnrollment', :label => 'Course Designer'},
{:name => 'ObserverEnrollment', :label => 'Observer'}
]
].freeze
def self.enrollment_types
ENROLLMENT_TYPES
end
def self.known_role_types
KNOWN_ROLE_TYPES =
[
'TeacherEnrollment',
'TaEnrollment',
@ -53,10 +55,12 @@ class RoleOverride < ActiveRecord::Base
'ObserverEnrollment',
'TeacherlessStudentEnrollment',
'AccountAdmin'
]
].freeze
def self.known_role_types
KNOWN_ROLE_TYPES
end
def self.permissions
PERMISSIONS =
{
:manage_wiki => {
:label => "Manage Wiki (add / edit / delete pages)",
@ -479,7 +483,9 @@ class RoleOverride < ActiveRecord::Base
:true_for => %w(AccountAdmin),
:available_to => %w(AccountAdmin AccountMembership),
},
}
}.freeze
def self.permissions
PERMISSIONS
end
def self.css_class_for(context, permission, enrollment_type)
@ -524,7 +530,7 @@ class RoleOverride < ActiveRecord::Base
end
def self.teacherless_permissions
@teacherless_permissions ||= permissions.to_a.select{|p, data| data[:available_to].include?('TeacherlessStudentEnrollment') }.map{|p, data| p }
@teacherless_permissions ||= permissions.select{|p, data| data[:available_to].include?('TeacherlessStudentEnrollment') }.map{|p, data| p }
end
def self.clear_cached_contexts