From a418b6f9eafb41e2e4e99f3c66413f7bd873f710 Mon Sep 17 00:00:00 2001 From: Davis Hyer Date: Mon, 28 Feb 2022 09:12:50 -0700 Subject: [PATCH] replace deprecated toBeEmpty with toBeEmptyDOMElement MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit flag=none test plan: - tests pass qa risk: low Change-Id: I71810f19ccc4590b7c4ca70a92c86ebdb14c4043 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286038 Tested-by: Service Cloud Jenkins Reviewed-by: Omar Soto-Fortuño QA-Review: Omar Soto-Fortuño Product-Review: Omar Soto-Fortuño --- jest/jest-setup.js | 1 - .../pace_plans/react/components/__tests__/errors.test.tsx | 2 +- ui/shared/k5/react/__tests__/StaffContactInfoLayout.test.js | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/jest/jest-setup.js b/jest/jest-setup.js index 1ef7e984b13..60a3fd3368f 100644 --- a/jest/jest-setup.js +++ b/jest/jest-setup.js @@ -105,7 +105,6 @@ const ignoredWarnings = [ /Missing field moduleItem in/, /Please update the following components: %s/, /shared_brand_configs.* not called/, - /toBeEmpty has been deprecated/, /Translation for .* is missing/, /value provided is not in a recognized RFC2822 or ISO format/ ] diff --git a/ui/features/pace_plans/react/components/__tests__/errors.test.tsx b/ui/features/pace_plans/react/components/__tests__/errors.test.tsx index 4ea5866317c..0e2ff8185b4 100644 --- a/ui/features/pace_plans/react/components/__tests__/errors.test.tsx +++ b/ui/features/pace_plans/react/components/__tests__/errors.test.tsx @@ -38,7 +38,7 @@ describe('Errors', () => { it('renders nothing when there are no errors', () => { const {container} = render() - expect(container.firstChild).toBeEmpty() + expect(container.firstChild).toBeEmptyDOMElement() }) it('displays custom error messages for pre-defined categories, and generic error messages for unknown categories', () => { diff --git a/ui/shared/k5/react/__tests__/StaffContactInfoLayout.test.js b/ui/shared/k5/react/__tests__/StaffContactInfoLayout.test.js index 36814903b60..cf81632d897 100644 --- a/ui/shared/k5/react/__tests__/StaffContactInfoLayout.test.js +++ b/ui/shared/k5/react/__tests__/StaffContactInfoLayout.test.js @@ -70,7 +70,7 @@ describe('StaffContactInfoLayout', () => { it('renders nothing at all if staff is empty', () => { const {container} = render() - expect(container.firstChild).toBeEmpty() + expect(container.firstChild).toBeEmptyDOMElement() }) it('renders 3 loading skeletons if isLoading set', () => {